[Koha-bugs] [Bug 30790] Add REST API route to list biblios

2022-05-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30790 --- Comment #13 from Marcel de Rooy --- Seeing this too: # Failed test 'No tests run for subtest "get() tests"' # at t/db_dependent/api/v1/biblios/list.t line 89. DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception:

[Koha-bugs] [Bug 30788] Argument "" isn't numeric in multiplication (*) at /usr/share/koha/lib/C4/Overdues.pm

2022-05-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30788 Katrin Fischer changed: What|Removed |Added Version|20.11 |master

[Koha-bugs] [Bug 30788] Argument "" isn't numeric in multiplication (*) at /usr/share/koha/lib/C4/Overdues.pm

2022-05-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30788 --- Comment #5 from Katrin Fischer --- Created attachment 135226 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135226=edit Bug 30788: Unit test Run: prove t/db_dependent/Circulation/CalcFine.t -- You are

[Koha-bugs] [Bug 30788] Argument "" isn't numeric in multiplication (*) at /usr/share/koha/lib/C4/Overdues.pm

2022-05-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30788 --- Comment #4 from Katrin Fischer --- Created attachment 135225 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135225=edit Bug 30788: Fix warning in Overdues.pm when fine is empty in circ rules Argument "" isn't

[Koha-bugs] [Bug 30788] Argument "" isn't numeric in multiplication (*) at /usr/share/koha/lib/C4/Overdues.pm

2022-05-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30788 Katrin Fischer changed: What|Removed |Added Status|NEW |Needs Signoff -- You are

[Koha-bugs] [Bug 30790] Add REST API route to list biblios

2022-05-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30790 --- Comment #12 from Marcel de Rooy --- Just trying to get a bit more grip on what could be done with the query string: objects.search my $args = $c->validation->output; [..] my ( $filtered_params,

[Koha-bugs] [Bug 30790] Add REST API route to list biblios

2022-05-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30790 --- Comment #11 from Marcel de Rooy --- (In reply to Julian Maurice from comment #10) > (In reply to Marcel de Rooy from comment #8) > > +$schema->resultset('Biblio')->delete(); > What is wrong with this ? It's in the tests,

[Koha-bugs] [Bug 30790] Add REST API route to list biblios

2022-05-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30790 Julian Maurice changed: What|Removed |Added Status|Signed Off |ASSIGNED --- Comment #10

[Koha-bugs] [Bug 30755] too_soon should not be counted as an error in autorenewals

2022-05-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30755 --- Comment #10 from Martin Renvoize --- That very much brings us back around to bug 30278. I'll take a look at working on that :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for

[Koha-bugs] [Bug 30755] too_soon should not be counted as an error in autorenewals

2022-05-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30755 --- Comment #9 from Martin Renvoize --- In fact.. I do wonder about how much we pass in our calls to GetPreparedLetter sometimes. In this case, I wonder if we aught to just send 'patron' and have sane accessors in the Patron object

[Koha-bugs] [Bug 30755] too_soon should not be counted as an error in autorenewals

2022-05-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30755 --- Comment #8 from Martin Renvoize --- Code speaks... though I'm not 100% about it vs the $updated flag. Our libraries only want the notices to include actual auto-renewals or auto-renewal-failures and their patrons don't count

[Koha-bugs] [Bug 30790] Add REST API route to list biblios

2022-05-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30790 --- Comment #9 from Marcel de Rooy --- my $biblios_rs = Koha::Biblios->new->search(undef, { join => 'biblioitem' }); Not a normal pattern to use new here -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 30755] too_soon should not be counted as an error in autorenewals

2022-05-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30755 --- Comment #7 from Martin Renvoize --- Created attachment 135224 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135224=edit Bug 30755: Remove auto_too_soon from error count This patch prevents auto_too_soon

[Koha-bugs] [Bug 21366] add plack reload

2022-05-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21366 Michal Denar changed: What|Removed |Added CC||blac...@gmail.com -- You

[Koha-bugs] [Bug 30790] Add REST API route to list biblios

2022-05-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30790 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl

[Koha-bugs] [Bug 25790] [OMNIBUS] warnings removal

2022-05-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25790 Katrin Fischer changed: What|Removed |Added Depends on||30816 Referenced Bugs:

[Koha-bugs] [Bug 30816] New: Use of uninitialized value in numeric ge (>=) at /usr/share/koha/lib/C4/Serials.pm

2022-05-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30816 Bug ID: 30816 Summary: Use of uninitialized value in numeric ge (>=) at /usr/share/koha/lib/C4/Serials.pm Change sponsored?: --- Product: Koha Version: 20.11

[Koha-bugs] [Bug 30751] Print autorenewal notice to console when running in verbose.

2022-05-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30751 --- Comment #4 from Martin Renvoize --- Hmm, I think I see what you're saying.. but I don't think the suggested change will work either. Notices always fetch the data from the database for themselves, so splitting out the change

[Koha-bugs] [Bug 30612] Add accountlines method to Koha::Checkout and Koha::Old::Checkout

2022-05-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30612 Marcel de Rooy changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl

[Koha-bugs] [Bug 30612] Add accountlines method to Koha::Checkout and Koha::Old::Checkout

2022-05-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30612 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Failed QA

[Koha-bugs] [Bug 29260] UNIMARC 210a is reported to Author (meeting/conference) when upgrading an authority through Z3950

2022-05-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29260 Marcel de Rooy changed: What|Removed |Added Attachment #135172|0 |1 is obsolete|

[Koha-bugs] [Bug 29260] UNIMARC 210a is reported to Author (meeting/conference) when upgrading an authority through Z3950

2022-05-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29260 Marcel de Rooy changed: What|Removed |Added Status|BLOCKED |Passed QA Patch

[Koha-bugs] [Bug 25798] Copyright year to Holds to pull report

2022-05-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25798 Katrin Fischer changed: What|Removed |Added Depends on||30815 Referenced Bugs:

[Koha-bugs] [Bug 30815] New: Use of uninitialized value $charge in numeric gt (>) at /usr/share/koha/lib/C4/Circulation.pm

2022-05-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30815 Bug ID: 30815 Summary: Use of uninitialized value $charge in numeric gt (>) at /usr/share/koha/lib/C4/Circulation.pm Change sponsored?: --- Product: Koha Version:

[Koha-bugs] [Bug 29260] UNIMARC 210a is reported to Author (meeting/conference) when upgrading an authority through Z3950

2022-05-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29260 --- Comment #5 from Marcel de Rooy --- if ( C4::Context->preference('marcflavour') eq 'MARC21' ){ return { '100a' => 'authorpersonal', '110a' => 'authorcorp', '111a' =>

[Koha-bugs] [Bug 29260] UNIMARC 210a is reported to Author (meeting/conference) when upgrading an authority through Z3950

2022-05-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29260 Marcel de Rooy changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl

[Koha-bugs] [Bug 29260] UNIMARC 210a is reported to Author (meeting/conference) when upgrading an authority through Z3950

2022-05-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29260 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl

[Koha-bugs] [Bug 30507] Value builder for UNIMARC field 183

2022-05-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30507 Marcel de Rooy changed: What|Removed |Added Severity|minor |enhancement -- You are

[Koha-bugs] [Bug 30506] Value builder for UNIMARC field 182

2022-05-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30506 Marcel de Rooy changed: What|Removed |Added Severity|minor |enhancement -- You are

[Koha-bugs] [Bug 30504] Value builder for UNIMARC field 181

2022-05-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30504 Marcel de Rooy changed: What|Removed |Added Severity|minor |enhancement -- You are

[Koha-bugs] [Bug 30799] Add REST API route to update biblio metadata

2022-05-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30799 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl

[Koha-bugs] [Bug 30781] Use of uninitialized value $val in substitution iterator at /usr/share/koha/lib/C4/Letters.pm line 665.

2022-05-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30781 --- Comment #13 from Marcel de Rooy --- I wanted to add this remark: We could have a theoretical debate if you should allow the substitution if you pass an undefined value. What we do now, is formalize what already happened but

[Koha-bugs] [Bug 22490] Some strings in JavaScript files are untranslatable

2022-05-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22490 Josef Moravec changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #12

[Koha-bugs] [Bug 30781] Use of uninitialized value $val in substitution iterator at /usr/share/koha/lib/C4/Letters.pm line 665.

2022-05-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30781 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Passed QA -- You are

[Koha-bugs] [Bug 30781] Use of uninitialized value $val in substitution iterator at /usr/share/koha/lib/C4/Letters.pm line 665.

2022-05-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30781 --- Comment #12 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #11) > QAing. Not for this release Too late -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 30781] Use of uninitialized value $val in substitution iterator at /usr/share/koha/lib/C4/Letters.pm line 665.

2022-05-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30781 Marcel de Rooy changed: What|Removed |Added Keywords||rel_22_11_candidate

[Koha-bugs] [Bug 30808] Release team 22.11

2022-05-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30808 --- Comment #3 from Fridolin Somers --- Thanks a lot. "To infinity and beyond ..." -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list

[Koha-bugs] [Bug 30781] Use of uninitialized value $val in substitution iterator at /usr/share/koha/lib/C4/Letters.pm line 665.

2022-05-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30781 Katrin Fischer changed: What|Removed |Added Attachment #135220|0 |1 is obsolete|

[Koha-bugs] [Bug 30781] Use of uninitialized value $val in substitution iterator at /usr/share/koha/lib/C4/Letters.pm line 665.

2022-05-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30781 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are

[Koha-bugs] [Bug 29860] Useless warnings in regressions.t

2022-05-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29860 Marcel de Rooy changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl

[Koha-bugs] [Bug 29860] Useless warnings in regressions.t

2022-05-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29860 Marcel de Rooy changed: What|Removed |Added Attachment #135218|0 |1 is obsolete|

[Koha-bugs] [Bug 29860] Useless warnings in regressions.t

2022-05-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29860 Marcel de Rooy changed: What|Removed |Added Patch complexity|--- |Trivial patch

<    1   2