[Koha-bugs] [Bug 33791] $hold->fill does not set itemnumber when checking out without confirming hold

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33791 --- Comment #9 from Martin Renvoize --- Looks like Kyle and I both PQA'd on this one simultaneously.. lol.. it's certainly PQA anyways. -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 33791] $hold->fill does not set itemnumber when checking out without confirming hold

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33791 Martin Renvoize changed: What|Removed |Added CC|

[Koha-bugs] [Bug 33791] $hold->fill does not set itemnumber when checking out without confirming hold

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33791 --- Comment #8 from Kyle M Hall --- Created attachment 151527 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151527=edit Bug 33791: Pass itemnumber to $hold->fill Test plan: Without this patch: Place next

[Koha-bugs] [Bug 33791] $hold->fill does not set itemnumber when checking out without confirming hold

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33791 Kyle M Hall changed: What|Removed |Added Attachment #151524|0 |1 is obsolete|

[Koha-bugs] [Bug 33791] $hold->fill does not set itemnumber when checking out without confirming hold

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33791 Kyle M Hall changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are

[Koha-bugs] [Bug 33791] $hold->fill does not set itemnumber when checking out without confirming hold

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33791 Martin Renvoize changed: What|Removed |Added Attachment #151509|0 |1 is obsolete|

[Koha-bugs] [Bug 33791] $hold->fill does not set itemnumber when checking out without confirming hold

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33791 Martin Renvoize changed: What|Removed |Added Attachment #151508|0 |1 is obsolete|

[Koha-bugs] [Bug 33573] Holds cancellation for waiting holds via the API don't generate a cancellation request

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33573 Emily Lamancusa changed: What|Removed |Added CC|

[Koha-bugs] [Bug 30719] ILL should provide the ability to create batch requests

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 Pedro Amorim changed: What|Removed |Added Attachment #151517|0 |1 is obsolete|

[Koha-bugs] [Bug 30719] ILL should provide the ability to create batch requests

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 Pedro Amorim changed: What|Removed |Added Attachment #151516|0 |1 is obsolete|

[Koha-bugs] [Bug 30719] ILL should provide the ability to create batch requests

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 Pedro Amorim changed: What|Removed |Added Attachment #151515|0 |1 is obsolete|

[Koha-bugs] [Bug 30719] ILL should provide the ability to create batch requests

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 Pedro Amorim changed: What|Removed |Added Attachment #151514|0 |1 is obsolete|

[Koha-bugs] [Bug 30719] ILL should provide the ability to create batch requests

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 Pedro Amorim changed: What|Removed |Added Attachment #151513|0 |1 is obsolete|

[Koha-bugs] [Bug 32677] Spanish language not displaying on the staff or opac interface

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32677 Jonathan Druart changed: What|Removed |Added CC|

[Koha-bugs] [Bug 23059] reserves_stats.pl: Simplify reserve status handling

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23059 Marcel de Rooy changed: What|Removed |Added Status|NEW |ASSIGNED -- You are

[Koha-bugs] [Bug 23059] reserves_stats.pl: Simplify reserve status handling

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23059 Marcel de Rooy changed: What|Removed |Added Summary|reserves_stats.pl needs |reserves_stats.pl:

[Koha-bugs] [Bug 23059] reserves_stats.pl needs overhaul

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23059 --- Comment #4 from Marcel de Rooy --- (In reply to Andrew Fuerste-Henry from comment #0) > > - The wizard splits holds into 5 statuses (Placed, Processed, Pending, > Satisfied, and Cancelled) that aren't used anywhere else in

[Koha-bugs] [Bug 23059] reserves_stats.pl needs overhaul

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23059 --- Comment #3 from Marcel de Rooy --- (In reply to Andrew Fuerste-Henry from comment #0) > Two big issues: > - By default, the wizard sets a value for items.homebranch and > items.holdingbranch. That means it unexpectedly cuts out

[Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #12 from Jonathan Druart --- (In reply to Michaela Sieber from comment #11) > (In reply to Jonathan Druart from comment #8) > > Remote branch rebased and a couple of fixes added. > > > > Setting status to Needs Signoff,

[Koha-bugs] [Bug 33792] reserves_stats.pl ignores filled holds without itemnumber

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33792 Marcel de Rooy changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |m.de.r...@rijksmuseum.nl

[Koha-bugs] [Bug 33792] reserves_stats.pl ignores filled holds without itemnumber

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33792 --- Comment #3 from Marcel de Rooy --- Created attachment 151518 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151518=edit Bug 33792: reserves_stats: Undo homebranch and holdingbranch preselect This preselect

[Koha-bugs] [Bug 33792] reserves_stats.pl ignores filled holds without itemnumber

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33792 Marcel de Rooy changed: What|Removed |Added Status|NEW |Needs Signoff Patch

[Koha-bugs] [Bug 33792] reserves_stats.pl ignores filled holds without itemnumber

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33792 --- Comment #2 from Marcel de Rooy --- And as mentioned on bug 23059, you can deselect that filter. But it does not work very intuitive. -- You are receiving this mail because: You are watching all bug changes. You are the

[Koha-bugs] [Bug 33792] reserves_stats.pl ignores filled holds without itemnumber

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33792 --- Comment #1 from Marcel de Rooy --- Actually, it is caused by looking at homebranch/holdingbranch in the where: items.homebranch LIKE ? AND items.holdingbranch LIKE ? And since there is no item, there is no branch.. -- You

[Koha-bugs] [Bug 30719] ILL should provide the ability to create batch requests

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 Pedro Amorim changed: What|Removed |Added Attachment #151312|0 |1 is obsolete|

[Koha-bugs] [Bug 30719] ILL should provide the ability to create batch requests

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 Pedro Amorim changed: What|Removed |Added Attachment #151311|0 |1 is obsolete|

[Koha-bugs] [Bug 30719] ILL should provide the ability to create batch requests

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 Pedro Amorim changed: What|Removed |Added Attachment #151310|0 |1 is obsolete|

[Koha-bugs] [Bug 30719] ILL should provide the ability to create batch requests

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 Pedro Amorim changed: What|Removed |Added Attachment #151309|0 |1 is obsolete|

[Koha-bugs] [Bug 30719] ILL should provide the ability to create batch requests

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 Pedro Amorim changed: What|Removed |Added Attachment #151308|0 |1 is obsolete|

[Koha-bugs] [Bug 33786] ILL requests table pagination in borrower history is transposing for different borrowers

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33786 Pedro Amorim changed: What|Removed |Added Blocks||30719 Referenced Bugs:

[Koha-bugs] [Bug 30719] ILL should provide the ability to create batch requests

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30719 Pedro Amorim changed: What|Removed |Added Depends on||33786 Referenced Bugs:

[Koha-bugs] [Bug 23059] reserves_stats.pl needs overhaul

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23059 --- Comment #2 from Marcel de Rooy --- When you do not confirm a hold, Koha stored it without itemnumber in old holds when directly checking out to same patron. These filled holds are not taken into consideration in statistics. See

[Koha-bugs] [Bug 33792] reserves_stats.pl ignores filled holds without itemnumber

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33792 Marcel de Rooy changed: What|Removed |Added See Also|

[Koha-bugs] [Bug 23059] reserves_stats.pl needs overhaul

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23059 Marcel de Rooy changed: What|Removed |Added See Also|

[Koha-bugs] [Bug 23059] reserves_stats.pl needs overhaul

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23059 Marcel de Rooy changed: What|Removed |Added Version|18.11 |master

[Koha-bugs] [Bug 33791] $hold->fill does not set itemnumber when checking out without confirming hold

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33791 Marcel de Rooy changed: What|Removed |Added See Also|

[Koha-bugs] [Bug 33792] reserves_stats.pl ignores filled holds without itemnumber

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33792 Marcel de Rooy changed: What|Removed |Added See Also|

[Koha-bugs] [Bug 33792] New: reserves_stats.pl ignores filled holds without itemnumber

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33792 Bug ID: 33792 Summary: reserves_stats.pl ignores filled holds without itemnumber Change sponsored?: --- Product: Koha Version: unspecified Hardware: All

[Koha-bugs] [Bug 33787] Remove option to archive system debit types

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33787 Marcel de Rooy changed: What|Removed |Added Attachment #151505|0 |1 is obsolete|

[Koha-bugs] [Bug 33787] Remove option to archive system debit types

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33787 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Passed QA -- You are

[Koha-bugs] [Bug 33786] ILL requests table pagination in borrower history is transposing for different borrowers

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33786 Pedro Amorim changed: What|Removed |Added Attachment #151506|0 |1 is obsolete|

[Koha-bugs] [Bug 33404] Authorities imported from Z39.50 in encodings other than UTF-8 are corrupted

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33404 --- Comment #1 from Nick Clemens --- Created attachment 151510 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151510=edit Bug 33404: (bug 19436 follow-up) Save the original encoded record This patch restores

[Koha-bugs] [Bug 33404] Authorities imported from Z39.50 in encodings other than UTF-8 are corrupted

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33404 Nick Clemens changed: What|Removed |Added Status|NEW |Needs Signoff -- You are

[Koha-bugs] [Bug 33791] $hold->fill does not set itemnumber when checking out without confirming hold

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33791 Marcel de Rooy changed: What|Removed |Added Attachment #151507|0 |1 is obsolete|

[Koha-bugs] [Bug 33791] $hold->fill does not set itemnumber when checking out without confirming hold

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33791 --- Comment #3 from Marcel de Rooy --- Created attachment 151508 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151508=edit Bug 33791: Add unit test Test plan: Run t/db_dependent/Koha/Hold.t NOTE: This test

[Koha-bugs] [Bug 33791] $hold->fill does not set itemnumber when checking out without confirming hold

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33791 Marcel de Rooy changed: What|Removed |Added Patch complexity|--- |Trivial patch

[Koha-bugs] [Bug 33791] $hold->fill does not set itemnumber when checking out without confirming hold

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33791 Marcel de Rooy changed: What|Removed |Added Status|NEW |ASSIGNED -- You are

[Koha-bugs] [Bug 33791] $hold->fill does not set itemnumber when checking out without confirming hold

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33791 Marcel de Rooy changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |m.de.r...@rijksmuseum.nl

[Koha-bugs] [Bug 33791] $hold->fill does not set itemnumber when checking out without confirming hold

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33791 --- Comment #2 from Marcel de Rooy --- Created attachment 151507 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151507=edit Bug 33791: Pass itemnumber to $hold->fill Test plan: Without this patch: Place next

[Koha-bugs] [Bug 33791] $hold->fill does not set itemnumber when checking out without confirming hold

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33791 --- Comment #1 from Marcel de Rooy --- Interestingly, CheckReserves puts the given itemnumber (from the checkout) into its highest reserve of the result: $highest->{'itemnumber'} = $item->itemnumber; But MoveReserves does ignore it

[Koha-bugs] [Bug 33786] ILL requests table pagination in borrower history is transposing for different borrowers

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33786 --- Comment #3 from Pedro Amorim --- I'm happy with this patch, extra eyes on it are welcome. Thank you Tomas for your suggestion re making the requests table id unique, it does fix the issue and we can keep the stateSave: true this

[Koha-bugs] [Bug 33786] ILL requests table pagination in borrower history is transposing for different borrowers

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33786 Pedro Amorim changed: What|Removed |Added Attachment #151487|0 |1 is obsolete|

[Koha-bugs] [Bug 33791] New: $hold->fill does not set itemnumber when checking out without confirming hold

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33791 Bug ID: 33791 Summary: $hold->fill does not set itemnumber when checking out without confirming hold Change sponsored?: --- Product: Koha Version: unspecified

[Koha-bugs] [Bug 33787] Remove option to archive system debit types

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33787 Martin Renvoize changed: What|Removed |Added Patch complexity|--- |Trivial patch -- You

[Koha-bugs] [Bug 33787] Remove option to archive system debit types

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33787 Martin Renvoize changed: What|Removed |Added Keywords||rel_23_05_candidate --

[Koha-bugs] [Bug 33787] Remove option to archive system debit types

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33787 Martin Renvoize changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun

[Koha-bugs] [Bug 33787] Remove option to archive system debit types

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33787 Martin Renvoize changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are

[Koha-bugs] [Bug 33787] Remove option to archive system debit types

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33787 Martin Renvoize changed: What|Removed |Added Status|NEW |Needs Signoff ---

[Koha-bugs] [Bug 33787] Remove option to archive system debit types

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33787 --- Comment #2 from Martin Renvoize --- Created attachment 151505 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151505=edit Bug 33787: Fix for regression caused by bug 32450 This patch fixes the regression

[Koha-bugs] [Bug 33716] ILL - Allow for a disclaimer stage per request type

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33716 Jonathan Field changed: What|Removed |Added CC|

[Koha-bugs] [Bug 33766] Accessibility: Fix ambiguous form-field in opac-auth.tt

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33766 claire.hernan...@biblibre.com changed: What|Removed |Added CC|

<    1   2