https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21330
--- Comment #35 from Fridolin Somers ---
Great :D thanks to all
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-c
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33967
--- Comment #5 from David Cook ---
If you want to verify the unit test works, you can either run it before
applying the first patch, or you can compromise Koha/Middleware/SetEnv.pm by
adding the following:
$env = {};
right before t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33904
Jonathan Druart changed:
What|Removed |Added
Attachment #152220|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33967
David Cook changed:
What|Removed |Added
Attachment #152229|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33967
--- Comment #3 from David Cook ---
Created attachment 152229
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152229&action=edit
Bug 33967: Add unit test to ensure SetEnv doesn't compromise $env
This patch includes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31744
--- Comment #3 from David Cook ---
(In reply to David Cook from comment #2)
> That's my interpretation at a glance. There might be other scenarios to take
> into account...
Looks like there can be other results like "Barcode not fou
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31744
--- Comment #2 from David Cook ---
This one seems a bit intimidating because there are different modes for the
inventory and no one uses the inventory tool that much I think.
When you provide barcodes, I think that you end up with a
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31744
David Cook changed:
What|Removed |Added
CC||dc...@prosentient.com.au
--- C
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33967
David Nind changed:
What|Removed |Added
Attachment #152227|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33967
David Nind changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--
You are receivi
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33556
David Cook changed:
What|Removed |Added
CC||dc...@prosentient.com.au
--
Y
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30013
--- Comment #13 from David Cook ---
(In reply to David Cook from comment #12)
> (In reply to Kyle M Hall from comment #11)
> > I think we need to implement
> > https://metacpan.org/pod/Email::Sender::Transport::SMTP::Persistent and k
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33964
--- Comment #3 from David Cook ---
Is this still in progress or should it be needs signoff?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33964
David Cook changed:
What|Removed |Added
CC||dc...@prosentient.com.au
--
Y
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33967
--- Comment #1 from David Cook ---
Created attachment 152227
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152227&action=edit
Bug 33967: Fix SetEnv middleware to preserve $env integrity
This patch fixes the Koha:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33967
David Cook changed:
What|Removed |Added
Status|NEW |Needs Signoff
--
You are rece
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33967
David Cook changed:
What|Removed |Added
Severity|enhancement |normal
--
You are receiving t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23068
--- Comment #55 from David Cook ---
Boy that was crazy-making but feels good to figure out a tough problem 😅
--
You are receiving this mail because:
You are watching all bug changes.
___
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30002
--- Comment #34 from Mason James ---
(In reply to Jonathan Druart from comment #23)
> (In reply to Julian Maurice from comment #21)
> > Also, since it's a developer-only tool, do we need to restrict ourselves to
> > an old version ?
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33967
David Cook changed:
What|Removed |Added
Assignee|koha-b...@lists.koha-commun |dc...@prosentient.com.au
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23068
David Cook changed:
What|Removed |Added
Blocks||33967
Referenced Bugs:
https
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33967
David Cook changed:
What|Removed |Added
Depends on||23068
Referenced Bugs:
https
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33967
Bug ID: 33967
Summary: REMOTE_ADDR incorrect in plack.log when run behind a
proxy
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23068
--- Comment #54 from David Cook ---
The problem is Koha::Middleware::SetEnv. It's a fundamentally flawed
middleware.
The wrapping of middleware works by passing around a hash reference (ie $env),
and Koha::Middleware::SetEnv breaks
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23068
--- Comment #53 from David Cook ---
(In reply to David Cook from comment #52)
> I can get the client IP via $ENV{REMOTE_ADDR} in Koha as set by
> Koha::Middleware::RealIP, but plack.log is still using the proxy address as
> set by Pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23068
--- Comment #52 from David Cook ---
(In reply to David Cook from comment #50)
> Trying to remember why we needed this since in theory
> Plack::Middleware::ReverseProxy should've handled this...
Ahh I see now. Plack::Middleware::Reve
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33933
--- Comment #6 from David Cook ---
(In reply to Katrin Fischer from comment #5)
> Available can be on the shelf... usable in the library, not necessarily for
> loan.
Mmm that's true and I think that's how we've been using it for yea
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31427
--- Comment #6 from David Cook ---
(In reply to Ray Delahunty from comment #5)
> We are testing auto-renewals in 22.11 (preparing to ditch our auto-renewal
> workaround which avoided various bugs like 19014 in place since 17.11). We
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30013
--- Comment #12 from David Cook ---
(In reply to Kyle M Hall from comment #11)
> I think we need to implement
> https://metacpan.org/pod/Email::Sender::Transport::SMTP::Persistent and keep
> the instances of it in memory during each
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30002
--- Comment #33 from David Cook ---
Does anything need to be done for folk who code in koha-testing-docker using
vim?
--
You are receiving this mail because:
You are watching all bug changes.
___
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33937
Katrin Fischer changed:
What|Removed |Added
Status|Signed Off |Passed QA
--
You are rece
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33937
Katrin Fischer changed:
What|Removed |Added
Attachment #152095|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33937
Katrin Fischer changed:
What|Removed |Added
Patch complexity|--- |Trivial patch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33858
Katrin Fischer changed:
What|Removed |Added
Assignee|koha-b...@lists.koha-commun |jonathan.druart+koha@gmail.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33858
--- Comment #4 from Katrin Fischer ---
It works, but I updated it to use with_hours=1 to show the time, but we are
still losing the second. Should we worry about that?
--
You are receiving this mail because:
You are watching all bu
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33858
Katrin Fischer changed:
What|Removed |Added
Attachment #152079|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33858
Katrin Fischer changed:
What|Removed |Added
Patch complexity|--- |Trivial patch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24517
Katrin Fischer changed:
What|Removed |Added
Attachment #152072|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24517
Katrin Fischer changed:
What|Removed |Added
Attachment #152071|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24517
Katrin Fischer changed:
What|Removed |Added
Patch complexity|--- |Trivial patch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33929
Katrin Fischer changed:
What|Removed |Added
Severity|enhancement |normal
Hardware|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24622
Katrin Fischer changed:
What|Removed |Added
Summary|Restrict Circulation by |Restrict circulation by
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33966
Katrin Fischer changed:
What|Removed |Added
Depends on||23824
Referenced Bugs:
h
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23824
Katrin Fischer changed:
What|Removed |Added
Blocks||33966
--- Comment #18 from
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33966
Bug ID: 33966
Summary: "Update and run SQL" for non-English templates
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Statu
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33965
Bug ID: 33965
Summary: Hide patron accounts that are for admin use only
Change sponsored?: ---
Product: Koha
Version: unspecified
Hardware: All
OS: All
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21833
Katrin Fischer changed:
What|Removed |Added
CC||tomasco...@gmail.com
--
Y
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21833
--- Comment #13 from Katrin Fischer ---
Our own backend has quite a bit of code using the medium, but it might date
back to the type when it was still used. It would certainly need some work to
clean-up.
What could a deprecation pr
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33855
--- Comment #5 from Katrin Fischer ---
(In reply to David Nind from comment #3)
> A nice update!
Agreed :)
--
You are receiving this mail because:
You are watching all bug changes.
___
K
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33855
Katrin Fischer changed:
What|Removed |Added
Attachment #152021|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33855
Katrin Fischer changed:
What|Removed |Added
Status|Signed Off |Passed QA
--
You are rece
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33855
Katrin Fischer changed:
What|Removed |Added
QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33868
Katrin Fischer changed:
What|Removed |Added
Attachment #152020|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33868
Katrin Fischer changed:
What|Removed |Added
Status|Signed Off |Passed QA
--
You are rece
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33868
Katrin Fischer changed:
What|Removed |Added
QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33904
--- Comment #12 from Katrin Fischer ---
The perltidy patch does include a fair bit of whitespace changes. We might want
to leave it off as Jonathan suggested.
--
You are receiving this mail because:
You are watching all bug changes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33904
Katrin Fischer changed:
What|Removed |Added
Attachment #152198|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33904
Katrin Fischer changed:
What|Removed |Added
Attachment #152197|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33904
Katrin Fischer changed:
What|Removed |Added
Attachment #152196|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33904
Katrin Fischer changed:
What|Removed |Added
Patch complexity|--- |Small patch
St
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33904
Katrin Fischer changed:
What|Removed |Added
QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25901
Emily Lamancusa changed:
What|Removed |Added
CC||emily.lamancusa@montgomery
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33901
Katrin Fischer changed:
What|Removed |Added
Version|unspecified |master
Summary|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33901
--- Comment #7 from Katrin Fischer ---
Much better, thx Caroline for filing and Jonathan for the fix :)
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33901
Katrin Fischer changed:
What|Removed |Added
Attachment #152105|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33901
Katrin Fischer changed:
What|Removed |Added
Status|Signed Off |Passed QA
--
You are rece
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33411
George Williams (NEKLS) changed:
What|Removed |Added
CC||geo...@nekls.org
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33901
Katrin Fischer changed:
What|Removed |Added
QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33528
Katrin Fischer changed:
What|Removed |Added
Attachment #151984|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33528
Katrin Fischer changed:
What|Removed |Added
Status|Signed Off |Passed QA
--
You are rece
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33528
--- Comment #13 from Katrin Fischer ---
First time I noticed this: when doing actions on the tabs, the page reloads and
you lose your 'active' tab. Maybe we could take a look at this sometime. But
this is the same without the patch s
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33528
Katrin Fischer changed:
What|Removed |Added
QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33894
Katrin Fischer changed:
What|Removed |Added
Status|Signed Off |Patch doesn't apply
--- Co
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33897
Katrin Fischer changed:
What|Removed |Added
Status|Signed Off |Failed QA
--- Comment #4 f
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30002
--- Comment #32 from Katrin Fischer ---
(In reply to Tomás Cohen Arazi from comment #31)
> (In reply to Jonathan Druart from comment #30)
> > (In reply to Jonathan Druart from comment #24)
> > > Suggestion addition for the wiki at
>
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33594
Katrin Fischer changed:
What|Removed |Added
Severity|enhancement |normal
--- Comment #18 fro
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30002
--- Comment #31 from Tomás Cohen Arazi ---
(In reply to Jonathan Druart from comment #30)
> (In reply to Jonathan Druart from comment #24)
> > Suggestion addition for the wiki at
> > https://wiki.koha-community.org/wiki/Coding_Guidel
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33960
--- Comment #4 from Tomás Cohen Arazi ---
Created attachment 152215
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152215&action=edit
Bug 33960: (QA follow-up) ->delete doesn't send to deletedbiblio
Signed-off-by:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32256
--- Comment #3 from Dave ---
new line delimited list of barcodes
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33854
--- Comment #4 from Matt Blenkinsop ---
Nice work everyone!
Pushed to stable for 22.11.x
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing l
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33854
Matt Blenkinsop changed:
What|Removed |Added
Version(s)|23.05.00|23.05.00,22.11.07
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33838
--- Comment #11 from Matt Blenkinsop ---
Nice work everyone!
Pushed to stable for 22.11.x
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33838
Matt Blenkinsop changed:
What|Removed |Added
Version(s)|23.05.00|23.05.00,22.11.07
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33829
--- Comment #6 from Matt Blenkinsop ---
Nice work everyone!
Pushed to stable for 22.11.x
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing l
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33829
Matt Blenkinsop changed:
What|Removed |Added
Status|Pushed to master|Pushed to stable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33823
--- Comment #4 from Matt Blenkinsop ---
Nice work everyone!
Pushed to stable for 22.11.x
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing l
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33823
Matt Blenkinsop changed:
What|Removed |Added
Version(s)|23.05.00|23.05.00,22.11.07
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33821
--- Comment #8 from Matt Blenkinsop ---
Nice work everyone!
Pushed to stable for 22.11.x
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing l
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33821
Matt Blenkinsop changed:
What|Removed |Added
Version(s)|23.05.00|23.05.00,22.11.07
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33788
--- Comment #6 from Matt Blenkinsop ---
Nice work everyone!
Pushed to stable for 22.11.x
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33788
Matt Blenkinsop changed:
What|Removed |Added
Version(s)|23.05.00|23.05.00,22.11.07
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33867
Bug 33867 depends on bug 33864, which changed state.
Bug 33864 Summary: Problems in order receive modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33864
What|Removed |Added
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33863
Bug 33863 depends on bug 33864, which changed state.
Bug 33864 Summary: Problems in order receive modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33864
What|Removed |Added
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33864
Matt Blenkinsop changed:
What|Removed |Added
Resolution|--- |FIXED
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33783
Matt Blenkinsop changed:
What|Removed |Added
Resolution|--- |FIXED
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33834
--- Comment #4 from Matt Blenkinsop ---
Nice work everyone!
Pushed to stable for 22.11.x
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing l
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33834
Matt Blenkinsop changed:
What|Removed |Added
Status|Pushed to master|Pushed to stable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33815
--- Comment #19 from Matt Blenkinsop ---
Nice work everyone!
Pushed to stable for 22.11.x
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33815
Matt Blenkinsop changed:
What|Removed |Added
Version(s)|23.05.00|23.05.00,22.11.07
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33792
--- Comment #7 from Matt Blenkinsop ---
Nice work everyone!
Pushed to stable for 22.11.x
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing l
1 - 100 of 429 matches
Mail list logo