http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10277
Fridolin SOMERS changed:
What|Removed |Added
Status|Pushed to Master|Pushed to Stable
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10277
Jonathan Druart changed:
What|Removed |Added
Blocks||11587
--
You are receivin
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10277
Galen Charlton changed:
What|Removed |Added
Blocks||7002
--
You are receiving
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10277
Galen Charlton changed:
What|Removed |Added
Status|Passed QA |Pushed to Master
--- Commen
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10277
--- Comment #35 from Katrin Fischer ---
Hi Kyle, I found bug 7002 - it looks like there could be some more occurences
to fix.
--
You are receiving this mail because:
You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10277
Katrin Fischer changed:
What|Removed |Added
CC||katrin.fisc...@bsz-bw.de
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10277
Katrin Fischer changed:
What|Removed |Added
Attachment #23523|0 |1
is obsolete|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10277
Katrin Fischer changed:
What|Removed |Added
Status|Signed Off |Passed QA
Patch complexit
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10277
--- Comment #34 from Katrin Fischer ---
Created attachment 23861
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23861&action=edit
[PASSED QA] Bug 10277: Add UT for C4::Context::IsSuperLibrarian
Note that I modify th
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10277
--- Comment #32 from Kyle M Hall ---
Great work! Thanks! I had attempted a UT using MockModule, but I must have been
setting it up incorrectly.
(In reply to Jonathan Druart from comment #30)
> (In reply to Kyle M Hall from comment #
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10277
Kyle M Hall changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--
You are receivi
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10277
Kyle M Hall changed:
What|Removed |Added
Attachment #23634|0 |1
is obsolete|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10277
--- Comment #30 from Jonathan Druart ---
(In reply to Kyle M Hall from comment #26)
> I have been unable to find a good way to UT this sub. MockModule doesn't
> seem to work in this context, since we are trying to mock a subroutine
>
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10277
Jonathan Druart changed:
What|Removed |Added
Status|Signed Off |Needs Signoff
--
You are
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10277
--- Comment #29 from Jonathan Druart ---
Created attachment 23634
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23634&action=edit
Bug 10277: Add UT for C4::Context::IsSuperLibrarian
Note that I modify the return va
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10277
--- Comment #28 from sandbo...@biblibre.com ---
Created attachment 23523
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23523&action=edit
Bug 10277 - Add C4::Context->IsSuperLibrarian()
The method of checking the lo
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10277
sandbo...@biblibre.com changed:
What|Removed |Added
Attachment #23518|0 |1
is obsolet
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10277
sandbo...@biblibre.com changed:
What|Removed |Added
CC||sandbo...@biblibre.c
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10277
Joel Sasse changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--
You are receivin
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10277
Kyle M Hall changed:
What|Removed |Added
Attachment #23518|Squashed the two patches|Bug 10277 - Add
descrip
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10277
Kyle M Hall changed:
What|Removed |Added
CC||k...@bywatersolutions.com
---
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10277
Kyle M Hall changed:
What|Removed |Added
Attachment #23480|0 |1
is obsolete|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10277
Jonathan Druart changed:
What|Removed |Added
CC||jonathan.dru...@biblibre.co
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10277
Kyle M Hall changed:
What|Removed |Added
Blocks|10502 |
--
You are receiving this ma
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10277
Kyle M Hall changed:
What|Removed |Added
Blocks|10278 |
--
You are receiving this ma
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10277
Kyle M Hall changed:
What|Removed |Added
Blocks|10263 |
--
You are receiving this ma
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10277
Kyle M Hall changed:
What|Removed |Added
Blocks||10502
--
You are receiving th
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10277
Kyle M Hall changed:
What|Removed |Added
Attachment #23481|0 |1
is obsolete|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10277
--- Comment #22 from Kyle M Hall ---
Created attachment 23481
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23481&action=edit
Bug 10277 [Followup] - Replace all remaining userenv checks with
IsSuperLibrarian()
--
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10277
Kyle M Hall changed:
What|Removed |Added
Attachment #23479|0 |1
is obsolete|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10277
Kyle M Hall changed:
What|Removed |Added
Status|Failed QA |Needs Signoff
--
You are rece
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10277
Kyle M Hall changed:
What|Removed |Added
Attachment #21144|0 |1
is obsolete|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10277
Joel Sasse changed:
What|Removed |Added
CC||jsa...@plumcreeklibrary.net
--
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10277
Julian Maurice changed:
What|Removed |Added
Status|Needs Signoff |Failed QA
--- Comment #19 f
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10277
Julian Maurice changed:
What|Removed |Added
CC||julian.maur...@biblibre.com
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10277
--- Comment #17 from Srdjan Jankovic ---
Kyle, did you check C4/Circulation.pm please?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10277
Kyle M Hall changed:
What|Removed |Added
Attachment #20776|0 |1
is obsolete|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10277
--- Comment #15 from Srdjan Jankovic ---
I could be wrong with those, so please double check: C4/Circulation.pm - if
should become unless ?
--
You are receiving this mail because:
You are watching all bug changes.
__
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10277
Kyle M Hall changed:
What|Removed |Added
Attachment #19229|0 |1
is obsolete|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10277
Kyle M Hall changed:
What|Removed |Added
Attachment #18518|0 |1
is obsolete|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10277
--- Comment #12 from Srdjan Jankovic ---
> Does it? Did you mean
>
> my $userenv = C4::Context->userenv or carp(...);
> return $userenv->{flags} % 2 == 1;
Sure, sorry, not enough coffee I guess...
--
You are receiving this mail
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10277
--- Comment #11 from Galen Charlton ---
(In reply to comment #10)
> my $userenv = C4::Context->userenv or carp(...);
> return C4::Context->userenv->{flags} % 2 == 1;
>
> It saves one C4::Context->userenv call.
Does it? Did you mean
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10277
Srdjan Jankovic changed:
What|Removed |Added
CC||srd...@catalyst.net.nz
---
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10277
Kyle M Hall changed:
What|Removed |Added
Attachment #18427|0 |1
is obsolete|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10277
Kyle M Hall changed:
What|Removed |Added
Blocks||10276
--
You are receiving th
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10277
Kyle M Hall changed:
What|Removed |Added
Blocks||10263
--
You are receiving th
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10277
Kyle M Hall changed:
What|Removed |Added
Attachment #18427|Squashed both patches |Bug 10277 - Add
descrip
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10277
Kyle M Hall changed:
What|Removed |Added
Attachment #18422|0 |1
is obsolete|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10277
--- Comment #7 from Kyle M Hall ---
Test Plan:
1) Apply these patches
2) Verify superlibrarian behavior remains unchanged
--
You are receiving this mail because:
You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10277
--- Comment #6 from Kyle M Hall ---
> - I'm pretty sure terminating (via confess) is not the right thing to do if
> the userenv isn't set up yet; in particular, this has the potential to break
> command-line scripts for no good reason
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10277
Kyle M Hall changed:
What|Removed |Added
Status|Failed QA |Needs Signoff
--
You are rece
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10277
--- Comment #5 from Kyle M Hall ---
Created attachment 18425
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18425&action=edit
Bug 10277 - Add C4::Context->IsSuperLibrarian() - Followup - Use
IsSuperLibrarian()
--
Y
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10277
Kyle M Hall changed:
What|Removed |Added
Attachment #18421|0 |1
is obsolete|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10277
Kyle M Hall changed:
What|Removed |Added
Attachment #18206|0 |1
is obsolete|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10277
Galen Charlton changed:
What|Removed |Added
Status|Needs Signoff |Failed QA
C
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10277
Kyle M Hall changed:
What|Removed |Added
Assignee|gmcha...@gmail.com |kyle.m.h...@gmail.com
--
You
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10277
Kyle M Hall changed:
What|Removed |Added
Blocks||10278
--
You are receiving th
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10277
Kyle M Hall changed:
What|Removed |Added
Status|NEW |Needs Signoff
--
You are rece
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10277
--- Comment #1 from Kyle M Hall ---
Created attachment 18206
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18206&action=edit
Bug 10277 - Add C4::Context->IsSuperLibrarian()
The method of checking the logged in user
59 matches
Mail list logo
