[Koha-bugs] [Bug 10332] UT: CourseReserves.t needs to create its own data

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10332 Galen Charlton changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Commen

[Koha-bugs] [Bug 10332] UT: CourseReserves.t needs to create its own data

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10332 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #30

[Koha-bugs] [Bug 10332] UT: CourseReserves.t needs to create its own data

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10332 Jonathan Druart changed: What|Removed |Added Attachment #19129|0 |1 is obsolete|

[Koha-bugs] [Bug 10332] UT: CourseReserves.t needs to create its own data

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10332 --- Comment #29 from Galen Charlton --- (In reply to comment #25) > Yes maybe. But as I said in my mail (see comment 15), the first step is that > all unit tests pass on any instance. > They could be improved later. No, they can be i

[Koha-bugs] [Bug 10332] UT: CourseReserves.t needs to create its own data

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10332 --- Comment #28 from Galen Charlton --- Created attachment 19129 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19129&action=edit Bug 10332: further improvements to course reserves tests - Wrap tests in a database t

[Koha-bugs] [Bug 10332] UT: CourseReserves.t needs to create its own data

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10332 Galen Charlton changed: What|Removed |Added Status|Passed QA |Signed Off -- You are rece

[Koha-bugs] [Bug 10332] UT: CourseReserves.t needs to create its own data

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10332 Galen Charlton changed: What|Removed |Added Attachment #19077|0 |1 is obsolete|

[Koha-bugs] [Bug 10332] UT: CourseReserves.t needs to create its own data

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10332 --- Comment #27 from Galen Charlton --- Created attachment 19128 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19128&action=edit Bug 10332: Data could exist in the courses table. Signed-off-by: Kyle M Hall Signed-

[Koha-bugs] [Bug 10332] UT: CourseReserves.t needs to create its own data

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10332 --- Comment #25 from Jonathan Druart --- (In reply to comment #24) > I think this is the way to go. Perhaps we could use MyTAP > (http://theory.github.io/mytap/) as a framework for this. Hi Galen, Yes maybe. But as I said in my mail

[Koha-bugs] [Bug 10332] UT: CourseReserves.t needs to create its own data

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10332 Galen Charlton changed: What|Removed |Added CC||gmcha...@gmail.com --- Comm

[Koha-bugs] [Bug 10332] UT: CourseReserves.t needs to create its own data

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10332 Kyle M Hall changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receivi

[Koha-bugs] [Bug 10332] UT: CourseReserves.t needs to create its own data

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10332 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receivin

[Koha-bugs] [Bug 10332] UT: CourseReserves.t needs to create its own data

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10332 --- Comment #23 from Kyle M Hall --- Created attachment 19078 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19078&action=edit Bug 10332: Data could exist in the courses table. Signed-off-by: Kyle M Hall -- You a

[Koha-bugs] [Bug 10332] UT: CourseReserves.t needs to create its own data

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10332 Kyle M Hall changed: What|Removed |Added Attachment #18645|0 |1 is obsolete|

[Koha-bugs] [Bug 10332] UT: CourseReserves.t needs to create its own data

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10332 M. de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl --- Co

[Koha-bugs] [Bug 10332] UT: CourseReserves.t needs to create its own data

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10332 --- Comment #20 from Kyle M Hall --- I bet you're right. Thanks! Kyle (In reply to comment #19) > (In reply to comment #18) > > Thanks for the followup Jonathan! Everything looks, except koha-qa.pl fail > > because there is no use s

[Koha-bugs] [Bug 10332] UT: CourseReserves.t needs to create its own data

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10332 --- Comment #19 from Jonathan Druart --- (In reply to comment #18) > Thanks for the followup Jonathan! Everything looks, except koha-qa.pl fail > because there is no use strict ( or use Modern::Perl ). Could you amend your > followup

[Koha-bugs] [Bug 10332] UT: CourseReserves.t needs to create its own data

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10332 --- Comment #18 from Kyle M Hall --- Thanks for the followup Jonathan! Everything looks, except koha-qa.pl fail because there is no use strict ( or use Modern::Perl ). Could you amend your followup to include one of those. After that

[Koha-bugs] [Bug 10332] UT: CourseReserves.t needs to create its own data

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10332 Jonathan Druart changed: What|Removed |Added Attachment #19058|0 |1 is obsolete|

[Koha-bugs] [Bug 10332] UT: CourseReserves.t needs to create its own data

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10332 --- Comment #16 from Jonathan Druart --- Created attachment 19058 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19058&action=edit Bug 10332: Data could exist in the courses table. -- You are receiving this mail be

[Koha-bugs] [Bug 10332] UT: CourseReserves.t needs to create its own data

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10332 Jonathan Druart changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are

[Koha-bugs] [Bug 10332] UT: CourseReserves.t needs to create its own data

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10332 --- Comment #15 from Jonathan Druart --- (In reply to comment #13) > Test 10 at the least may fail if there is any data already in the courses > table. This patch removes the truncations that ensure the tables are empty. Yes, good ca

[Koha-bugs] [Bug 10332] UT: CourseReserves.t needs to create its own data

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10332 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --

[Koha-bugs] [Bug 10332] UT: CourseReserves.t needs to create its own data

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10332 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Failed QA CC|

[Koha-bugs] [Bug 10332] UT: CourseReserves.t needs to create its own data

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10332 --- Comment #12 from Srdjan Jankovic --- > Yes we should look deeper into this way. The t/db_dependent/HoldsQueue.t > already use a roolback. No wonder, I wrote it :) -- You are receiving this mail because: You are watching all bug

[Koha-bugs] [Bug 10332] UT: CourseReserves.t needs to create its own data

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10332 --- Comment #11 from Jonathan Druart --- (In reply to comment #9) > When I do this kind of testing, I do it within a transaction, and rollback > at the end. That way I do not need to think about a proper cleanup. Has > there been any

[Koha-bugs] [Bug 10332] UT: CourseReserves.t needs to create its own data

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10332 --- Comment #10 from Jared Camins-Esakov --- (In reply to comment #9) > I know this is not the right forum to raise the topic, but I've done worse > things in my life: > > When I do this kind of testing, I do it within a transaction,

[Koha-bugs] [Bug 10332] UT: CourseReserves.t needs to create its own data

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10332 --- Comment #9 from Srdjan Jankovic --- I know this is not the right forum to raise the topic, but I've done worse things in my life: When I do this kind of testing, I do it within a transaction, and rollback at the end. That way I d

[Koha-bugs] [Bug 10332] UT: CourseReserves.t needs to create its own data

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10332 Jared Camins-Esakov changed: What|Removed |Added Attachment #18638|0 |1 is obsolete|

[Koha-bugs] [Bug 10332] UT: CourseReserves.t needs to create its own data

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10332 Jared Camins-Esakov changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are

[Koha-bugs] [Bug 10332] UT: CourseReserves.t needs to create its own data

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10332 Jonathan Druart changed: What|Removed |Added Attachment #18382|0 |1 is obsolete|

[Koha-bugs] [Bug 10332] UT: CourseReserves.t needs to create its own data

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10332 --- Comment #6 from Jonathan Druart --- (In reply to comment #5) > Do I need to do some prep first, or some special config? No, it is the goal of this patch :) Since the course course are removed at the end of the test file, I think

[Koha-bugs] [Bug 10332] UT: CourseReserves.t needs to create its own data

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10332 Srdjan Jankovic changed: What|Removed |Added CC||srd...@catalyst.net.nz ---

[Koha-bugs] [Bug 10332] UT: CourseReserves.t needs to create its own data

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10332 --- Comment #4 from Jonathan Druart --- (In reply to comment #2) > Hi Jonathan > > I get this > > DBD::mysql::db do failed: Cannot truncate a table referenced in a foreign > key constraint (`koha_persona`.`course_instructors`, CONS

[Koha-bugs] [Bug 10332] UT: CourseReserves.t needs to create its own data

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10332 --- Comment #3 from Chris Cormack --- (In reply to comment #2) > Hi Jonathan > > I get this > > DBD::mysql::db do failed: Cannot truncate a table referenced in a foreign > key constraint (`koha_persona`.`course_instructors`, CONSTR

[Koha-bugs] [Bug 10332] UT: CourseReserves.t needs to create its own data

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10332 Chris Cormack changed: What|Removed |Added CC||ch...@bigballofwax.co.nz ---

[Koha-bugs] [Bug 10332] UT: CourseReserves.t needs to create its own data

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10332 Jonathan Druart changed: What|Removed |Added Blocks||10273 Depends on|1

[Koha-bugs] [Bug 10332] UT: CourseReserves.t needs to create its own data

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10332 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are

[Koha-bugs] [Bug 10332] UT: CourseReserves.t needs to create its own data

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10332 --- Comment #1 from Jonathan Druart --- Created attachment 18382 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18382&action=edit Bug 10332: CourseReserves.t needs to create its own data prove t/db_dependent/CourseR

[Koha-bugs] [Bug 10332] UT: CourseReserves.t needs to create its own data

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10332 Jonathan Druart changed: What|Removed |Added Depends on||10273 -- You are receivin

[Koha-bugs] [Bug 10332] UT: CourseReserves.t needs to create its own data

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10332 Jonathan Druart changed: What|Removed |Added Status|NEW |ASSIGNED Assigne