https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382
Katrin Fischer changed:
What|Removed |Added
Keywords||release-notes-needed
Text
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382
Martin Renvoize changed:
What|Removed |Added
Resolution|--- |FIXED
Status|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382
Fridolin SOMERS changed:
What|Removed |Added
CC||fridolin.som...@biblibre.c
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382
--- Comment #81 from Katrin Fischer ---
Does this fix location and collection and should the bug title be adjusted
accordingly?
--
You are receiving this mail because:
You are watching all bug changes.
_
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382
Martin Renvoize changed:
What|Removed |Added
Status|Pushed to Master|Pushed to Stable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382
Nick Clemens changed:
What|Removed |Added
Status|Passed QA |Pushed to Master
--- Comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382
--- Comment #78 from Marcel de Rooy ---
RM: Your decision now. I said enough..
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bu
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382
--- Comment #77 from Christopher Brannon ---
(In reply to Marcel de Rooy from comment #76)
> (In reply to Christopher Brannon from comment #74)
> > It should be returned to the exact state it was originally. It should not
> > be mod
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382
--- Comment #76 from Marcel de Rooy ---
(In reply to Christopher Brannon from comment #74)
> It should be returned to the exact state it was originally. It should not
> be modified in any way by this module when inactive. If it was
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382
--- Comment #75 from Marcel de Rooy ---
(In reply to Nick Clemens from comment #72)
> (In reply to Marcel de Rooy from comment #70)
> > @RM:
> >
> > Passed QA but a bit 'reluctant or restrained'?
> > This patch set improves things b
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382
--- Comment #74 from Christopher Brannon ---
It should be returned to the exact state it was originally. It should not be
modified in any way by this module when inactive. If it was null before, is
should be returned to null. If i
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382
--- Comment #73 from Katrin Fischer ---
I don't think we should have empty entries in collections in locations. They
will appear doubled up in lots of places.
--
You are receiving this mail because:
You are watching all bug change
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382
--- Comment #72 from Nick Clemens ---
(In reply to Marcel de Rooy from comment #70)
> @RM:
>
> Passed QA but a bit 'reluctant or restrained'?
> This patch set improves things but imo this area needs more attention.
> See comment58 a
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382
--- Comment #71 from Christopher Brannon ---
(In reply to Marcel de Rooy from comment #58)
> I am requesting another signoff here.
> The third patch has no signoff line yet.
> And additionally please tell me explicitly what you teste
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382
--- Comment #70 from Marcel de Rooy ---
@RM:
Passed QA but a bit 'reluctant or restrained'?
This patch set improves things but imo this area needs more attention.
See comment58 and the earlier comments/discussion.
--
You are recei
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382
Marcel de Rooy changed:
What|Removed |Added
Attachment #79724|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382
Marcel de Rooy changed:
What|Removed |Added
Attachment #79723|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382
Marcel de Rooy changed:
What|Removed |Added
Status|Signed Off |Passed QA
--
You are rece
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382
Marcel de Rooy changed:
What|Removed |Added
Attachment #79722|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382
--- Comment #66 from Kyle M Hall ---
Created attachment 79724
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79724&action=edit
Bug 10382: Course reserves: handle empty values
Test Plan:
1) Create an item, do not s
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382
--- Comment #65 from Kyle M Hall ---
Created attachment 79723
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79723&action=edit
Bug 10382: Add unit tests for course items
Signed-off-by: Josef Moravec
Signed-off-b
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382
Kyle M Hall changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--
You are receiv
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382
Kyle M Hall changed:
What|Removed |Added
Attachment #79207|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382
Kyle M Hall changed:
What|Removed |Added
Status|Failed QA |Needs Signoff
--- Comment #63
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382
--- Comment #62 from Caroline Cyr La Rose ---
I get the same error message in a sandbox (tried with BibLibre sandbox 5 and
PTFS Europe sandbox 0)
Software error:
Undefined subroutine &C4::Items::ModZebra called at /home/koha/src/C4
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382
--- Comment #61 from Caroline Cyr La Rose ---
Created another course, added items (changed collection code), tried disabling
the course
Software error:
Undefined subroutine &C4::Items::ModZebra called at
/inlibro/git/koha-master-de
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382
Christopher Brannon changed:
What|Removed |Added
CC||cbran...@cdalibrary.or
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382
--- Comment #60 from Katrin Fischer ---
Hi Caroline,
I can't reproduce the error - can you try again with another course reserve?
--
You are receiving this mail because:
You are watching all bug changes.
___
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382
M. Tompsett changed:
What|Removed |Added
CC|mtomp...@hotmail.com|
--
You are receiving this m
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382
Caroline Cyr La Rose changed:
What|Removed |Added
Status|Needs Signoff |Failed QA
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382
Marcel de Rooy changed:
What|Removed |Added
Status|Signed Off |Needs Signoff
--- Comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382
Koha Team Lyon 3 changed:
What|Removed |Added
CC||k...@univ-lyon3.fr
--
Y
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382
--- Comment #57 from Marcel de Rooy ---
(In reply to Alex Arnaud from comment #56)
> But i don't understand why puting your code at line #113 should be a problem
> if the test still pass.
This is probably the clue. You should ;) My
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382
--- Comment #56 from Alex Arnaud ---
(In reply to Marcel de Rooy from comment #55)
> (In reply to Alex Arnaud from comment #54)
> > If you put this at the line #113, this is just after the ccode test. So why
> > would it change anyth
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382
--- Comment #55 from Marcel de Rooy ---
(In reply to Alex Arnaud from comment #54)
> If you put this at the line #113, this is just after the ccode test. So why
> would it change anything ?
It should be after that test. But its purpo
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382
--- Comment #54 from Alex Arnaud ---
(In reply to Marcel de Rooy from comment #53)
> Alex,
> Thx for your prompt corrections.
> If I add this as line 113 in your test:
> $item->ccode(undef)->store;
> the test still passes, which mean
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382
--- Comment #53 from Marcel de Rooy ---
Alex,
Thx for your prompt corrections.
If I add this as line 113 in your test:
$item->ccode(undef)->store;
the test still passes, which means that an original NULL is converted to empty
string
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382
Kyle M Hall changed:
What|Removed |Added
CC||k...@bywatersolutions.com
---
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382
Alex Arnaud changed:
What|Removed |Added
Status|Failed QA |Signed Off
--
You are receiv
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382
Alex Arnaud changed:
What|Removed |Added
Attachment #79116|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382
Alex Arnaud changed:
What|Removed |Added
Attachment #79115|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382
Alex Arnaud changed:
What|Removed |Added
Attachment #79114|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382
Marcel de Rooy changed:
What|Removed |Added
Status|BLOCKED |Failed QA
--- Comment #48
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382
Marcel de Rooy changed:
What|Removed |Added
QA Contact||m.de.r...@rijksmuseum.nl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382
--- Comment #46 from Marcel de Rooy ---
create_dependent_objets();
French spelling :) Better use objects
--
You are receiving this mail because:
You are watching all bug changes.
___
Koh
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382
--- Comment #45 from Marcel de Rooy ---
* Commit title does not start with 'Bug X: ' - 22c50da
* Commit title does not start with 'Bug X: ' - a9c2f43
* Commit title does not start with 'Bug X: ' -
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382
--- Comment #44 from Theodoros Theodoropoulos ---
I have tested the patch with biblibre Sandboxes (MARC21 flavor) and works fine.
Apart from handling collection code properly (as described in test plan), it
also handles properly chan
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382
M. Tompsett changed:
What|Removed |Added
CC||mtomp...@hotmail.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382
ByWater Sandboxes changed:
What|Removed |Added
Attachment #79032|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382
ByWater Sandboxes changed:
What|Removed |Added
Attachment #79031|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382
ByWater Sandboxes changed:
What|Removed |Added
Attachment #79030|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382
Alex Arnaud changed:
What|Removed |Added
Status|Failed QA |Needs Signoff
--
You are rec
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382
Alex Arnaud changed:
What|Removed |Added
Attachment #72022|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382
Alex Arnaud changed:
What|Removed |Added
Attachment #61815|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382
Alex Arnaud changed:
What|Removed |Added
Attachment #61814|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382
--- Comment #36 from Katrin Fischer ---
This is such a long standing bug... anyone willing to have another go?
--
You are receiving this mail because:
You are watching all bug changes.
__
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382
Josef Moravec changed:
What|Removed |Added
CC||josef.mora...@gmail.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382
Alex Arnaud changed:
What|Removed |Added
Status|In Discussion |Needs Signoff
--
You are rec
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382
Alex Arnaud changed:
What|Removed |Added
Attachment #63531|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382
Kyle M Hall changed:
What|Removed |Added
CC||th...@lib.auth.gr
--- Comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382
Patrick Robitaille changed:
What|Removed |Added
CC||patrick.robitai...@ccsr
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382
Marcel de Rooy changed:
What|Removed |Added
Status|Signed Off |In Discussion
--- Comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382
Marcel de Rooy changed:
What|Removed |Added
CC||m.de.r...@rijksmuseum.nl
-
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382
--- Comment #30 from Jonathan Druart
---
I do not like the way this bug is fixed (especially the drop of the FK).
I will not oppose to a push as I do not have anything else to suggest.
I let the QA step to someone else.
--
You ar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382
Alex Arnaud changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--
You are receiv
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382
Alex Arnaud changed:
What|Removed |Added
Status|Failed QA |Needs Signoff
--
You are rec
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382
Alex Arnaud changed:
What|Removed |Added
Attachment #61816|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382
Jonathan Druart changed:
What|Removed |Added
Status|Signed Off |Failed QA
--- Comment #28
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382
Alex Sassmannshausen changed:
What|Removed |Added
CC||alex.sassmannshausen@
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382
Nick Clemens changed:
What|Removed |Added
CC||n...@bywatersolutions.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382
--- Comment #26 from Katrin Fischer ---
Hm, so is the problem that we save 'unchanged' instead of the original value,
no matter if it was changed or not? And 'null' would be confusing, as it could
mean 'unchanged' as well as 'was emp
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382
--- Comment #25 from Alex Arnaud ---
(In reply to Jonathan Druart from comment #24)
> This stuff smells like a very bad codding pattern.
> Could not we use empty string and undef/NULL to handle empty values?
Hello Jonathan,
I don'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382
Jonathan Druart changed:
What|Removed |Added
CC||jonathan.dru...@bugs.koha-
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382
--- Comment #22 from Josef Moravec ---
Created attachment 61815
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61815&action=edit
[SIGNED-OFF] Bug 10382 - Add unit tests for course items
Signed-off-by: Josef Morave
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382
Josef Moravec changed:
What|Removed |Added
Attachment #60947|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382
--- Comment #21 from Josef Moravec ---
Created attachment 61814
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61814&action=edit
[SIGNED-OFF] Bug 10382 - collection not returning to null when removed from
course re
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382
Josef Moravec changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--
You are rece
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382
--- Comment #20 from Alex Arnaud ---
> Why drop the foreign key completely? Shouldn't the key be recreated?
With this patch, the value '' is inserted in the column
course_items.holdingbranch if no change is requested. This is why i
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382
--- Comment #19 from M. Tompsett ---
Comment on attachment 60979
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60979
Bug 10382 - Course reserves: handle empty values
Review of attachment 60979:
-->
(https://bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382
Alex Arnaud changed:
What|Removed |Added
Status|Failed QA |Needs Signoff
--
You are rec
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382
--- Comment #18 from Alex Arnaud ---
Created attachment 60979
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60979&action=edit
Bug 10382 - Course reserves: handle empty values
--
You are receiving this mail becau
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382
Alex Arnaud changed:
What|Removed |Added
CC||alex.arn...@biblibre.com
---
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382
Alex Arnaud changed:
What|Removed |Added
Attachment #19611|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382
--- Comment #16 from Alex Arnaud ---
Created attachment 60948
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60948&action=edit
Bug 10382 - Add unit tests for course items
--
You are receiving this mail because:
Y
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382
--- Comment #14 from Kyle M Hall ---
(In reply to Katrin Fischer from comment #13)
> Hi Kyle, I think this could be related to the new bug 15876 for locations -
> sounds like the same or at least a very similar issue
Yes, I expect t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382
Katrin Fischer changed:
What|Removed |Added
See Also||https://bugs.koha-community
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382
--- Comment #12 from Kyle M Hall ---
If someone would be willing to write some unit tests to demonstrate the issues
I'd be more than happy to continue work on this bug. I think the issue is
triggered by removing an item from course re
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382
Marc Véron changed:
What|Removed |Added
CC||ve...@veron.ch
--- Comment #11
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382
Derryn changed:
What|Removed |Added
CC||derr...@gmail.com
--
You are recei
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382
Tom Misilo changed:
What|Removed |Added
CC||misi...@fit.edu
--
You are rec
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382
--- Comment #10 from Katrin Fischer ---
Kyle, could you take another look at this? I think it's almost a blocker, as
your items will not be reset to the correct state if the fields has been empty
(which is kind of a data loss)
--
Yo
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382
Marjorie Barry-Vila changed:
What|Removed |Added
CC||marjorie.barry-v...@ccs
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382
Katrin Fischer changed:
What|Removed |Added
CC||katrin.fisc...@bsz-bw.de
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382
Francois Charbonnier changed:
What|Removed |Added
CC||francois.charbonnier@i
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382
Owen Leonard changed:
What|Removed |Added
Status|Needs Signoff |Failed QA
--- Comment #8 from
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382
Kyle M Hall changed:
What|Removed |Added
Attachment #18674|0 |1
is obsolete|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382
Kyle M Hall changed:
What|Removed |Added
Status|Failed QA |Needs Signoff
--
You are rece
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382
Owen Leonard changed:
What|Removed |Added
Status|Needs Signoff |Failed QA
--- Comment #6 from
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382
Kyle M Hall changed:
What|Removed |Added
Status|Failed QA |Needs Signoff
--- Comment #5 f
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382
Jared Camins-Esakov changed:
What|Removed |Added
Status|Needs Signoff |Failed QA
--- Comment
1 - 100 of 104 matches
Mail list logo
