[Koha-bugs] [Bug 10454] Duplicate card numbers may be generated

2023-07-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10454 Katrin Fischer changed: What|Removed |Added Status|In Discussion |RESOLVED Resolutio

[Koha-bugs] [Bug 10454] Duplicate card numbers may be generated

2015-10-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10454 Marc VĂ©ron changed: What|Removed |Added See Also||http://bugs.koha-community.

[Koha-bugs] [Bug 10454] Duplicate card numbers may be generated

2015-09-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10454 Josef Moravec changed: What|Removed |Added CC||josef.mora...@gmail.com --

[Koha-bugs] [Bug 10454] Duplicate card numbers may be generated

2015-08-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10454 Jonathan Druart changed: What|Removed |Added Severity|major |normal CC|

[Koha-bugs] [Bug 10454] Duplicate card numbers may be generated

2013-09-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10454 --- Comment #23 from M. Tompsett --- I'm not sure there is a way to $dbh->last_insert_id() query a value, increment it, and update it in a way that is consistent in a multi-user scenario. $dbh doesn't let us "SQL;SQL;SQL" as far as I

[Koha-bugs] [Bug 10454] Duplicate card numbers may be generated

2013-09-29 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10454 Zeno Tajoli changed: What|Removed |Added Status|Failed QA |In Discussion

[Koha-bugs] [Bug 10454] Duplicate card numbers may be generated

2013-09-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10454 --- Comment #21 from M. Tompsett --- SUBSTR can be fixed. YAY! SUBSTRING is ANSI-1992. The UNSIGNED, from CAST( ... AS UNSIGNED), can be worked around using BIGINT and adding a >0 constraint on the value. Not sure I like that, but it

[Koha-bugs] [Bug 10454] Duplicate card numbers may be generated

2013-09-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10454 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #20 from

[Koha-bugs] [Bug 10454] Duplicate card numbers may be generated

2013-09-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10454 Kyle M Hall changed: What|Removed |Added CC||k...@bywatersolutions.com

[Koha-bugs] [Bug 10454] Duplicate card numbers may be generated

2013-09-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10454 Paola Rossi changed: What|Removed |Added CC|paola.ro...@cineca.it | -- You are receiving this ma

[Koha-bugs] [Bug 10454] Duplicate card numbers may be generated

2013-09-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10454 Paola Rossi changed: What|Removed |Added Status|Needs Signoff |Signed Off CC|

[Koha-bugs] [Bug 10454] Duplicate card numbers may be generated

2013-09-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10454 Paola Rossi changed: What|Removed |Added Attachment #19265|0 |1 is obsolete|

[Koha-bugs] [Bug 10454] Duplicate card numbers may be generated

2013-06-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10454 M. Tompsett changed: What|Removed |Added See Also||http://bugs.koha-community.

[Koha-bugs] [Bug 10454] Duplicate card numbers may be generated

2013-06-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10454 M. Tompsett changed: What|Removed |Added Status|In Discussion |Needs Signoff --- Comment #18

[Koha-bugs] [Bug 10454] Duplicate card numbers may be generated

2013-06-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10454 M. Tompsett changed: What|Removed |Added Attachment #19264|0 |1 is obsolete|

[Koha-bugs] [Bug 10454] Duplicate card numbers may be generated

2013-06-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10454 M. Tompsett changed: What|Removed |Added Attachment #19196|0 |1 is obsolete|

[Koha-bugs] [Bug 10454] Duplicate card numbers may be generated

2013-06-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10454 --- Comment #15 from M. de Rooy --- (In reply to M. Tompsett from comment #11) > I suppose we could disable or not display them if they are auto-generated, > but if there is no auto-generation, we need to field visible and able to be

[Koha-bugs] [Bug 10454] Duplicate card numbers may be generated

2013-06-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10454 --- Comment #14 from Galen Charlton --- As a point of information, I also tried using DBIx::Sequence. Pros of using DBIx::Sequence: - It works, in the sense that using a bunch of concurrent processes to fetch sequence values will

[Koha-bugs] [Bug 10454] Duplicate card numbers may be generated

2013-06-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10454 --- Comment #13 from Galen Charlton --- Here's a version that shows that one can store multiple sequences in a single table and add new ones at will: ___BEGIN #!/usr/bin/perl use Modern::Perl; use C4::Context; my $dbh = C4::Con

[Koha-bugs] [Bug 10454] Duplicate card numbers may be generated

2013-06-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10454 --- Comment #12 from Galen Charlton --- (In reply to M. Tompsett from comment #11) > > From a glance through code, I feel that this routine fixup_cardnumber is > > still quite confusing and complicated. Should it really be done this w

[Koha-bugs] [Bug 10454] Duplicate card numbers may be generated

2013-06-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10454 --- Comment #11 from M. Tompsett --- (In reply to M. de Rooy from comment #10) Apologies for the reordering of your commentary. :) > With compliments for your hard work, but is it true that we spend so much > effort on this only be

[Koha-bugs] [Bug 10454] Duplicate card numbers may be generated

2013-06-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10454 M. de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl --- Co

[Koha-bugs] [Bug 10454] Duplicate card numbers may be generated

2013-06-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10454 --- Comment #9 from M. Tompsett --- Test Plan = TEST updatedatabase.pl & kohaversion.pl === 1) Apply patch. 2) Back up koha database. -- Necessary to test empty borrowers case. 3) Upgrade t

[Koha-bugs] [Bug 10454] Duplicate card numbers may be generated

2013-06-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10454 --- Comment #8 from Galen Charlton --- Comment on attachment 19196 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19196 Bug 10454 - Duplicate card numbers may be generated Review of attachment 19196: --> (http://b

[Koha-bugs] [Bug 10454] Duplicate card numbers may be generated

2013-06-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10454 --- Comment #7 from M. Tompsett --- Created attachment 19196 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19196&action=edit Bug 10454 - Duplicate card numbers may be generated Previously, there was a gap in time b

[Koha-bugs] [Bug 10454] Duplicate card numbers may be generated

2013-06-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10454 --- Comment #6 from M. Tompsett --- Adding another dependency is undesirable. This is why my random string is based on String::Random, which is already a dependency. I use Time::HiRes for the microsecond time, which is already a depen

[Koha-bugs] [Bug 10454] Duplicate card numbers may be generated

2013-06-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10454 --- Comment #5 from M. de Rooy --- (In reply to comment #4) > Others have suggested last_insert_id. Is last_insert_id a good option? The > DBI page has scary things like: "Given all the caveats above, it's clear > that this method mus

[Koha-bugs] [Bug 10454] Duplicate card numbers may be generated

2013-06-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10454 M. de Rooy changed: What|Removed |Added See Also||http://bugs.koha-community.

[Koha-bugs] [Bug 10454] Duplicate card numbers may be generated

2013-06-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10454 M. Tompsett changed: What|Removed |Added Status|NEW |In Discussion --- Comment #4 f

[Koha-bugs] [Bug 10454] Duplicate card numbers may be generated

2013-06-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10454 M. Tompsett changed: What|Removed |Added Summary|Lack of critical section|Duplicate card numbers may