[Koha-bugs] [Bug 10589] Override OpacHiddenItems based on Patron Category

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589 M. Tompsett changed: What|Removed |Added Depends on|10895 |14385 Referenced Bugs: http

[Koha-bugs] [Bug 10589] Override OpacHiddenItems based on Patron Category

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589 M. Tompsett changed: What|Removed |Added Attachment #30806|0 |1 is obsolete|

[Koha-bugs] [Bug 10589] Override OpacHiddenItems based on Patron Category

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589 --- Comment #42 from M. Tompsett --- (In reply to M. Tompsett from comment #39) > Oops. Missed C4::Search::searchResults. That comment is right about it being > messy. On a positive note, that is dealt with in bug 14385. This furthe

[Koha-bugs] [Bug 10589] Override OpacHiddenItems based on Patron Category

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589 M. Tompsett changed: What|Removed |Added Resolution|DUPLICATE |--- Status|RESOLV

[Koha-bugs] [Bug 10589] Override OpacHiddenItems based on Patron Category

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589 M. Tompsett changed: What|Removed |Added Resolution|--- |DUPLICATE Status|

[Koha-bugs] [Bug 10589] Override OpacHiddenItems based on Patron Category

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589 --- Comment #39 from M. Tompsett --- Oops. Missed C4::Search::searchResults. That comment is right about it being messy. -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 10589] Override OpacHiddenItems based on Patron Category

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589 M. Tompsett changed: What|Removed |Added Depends on||11592 Referenced Bugs: http

[Koha-bugs] [Bug 10589] Override OpacHiddenItems based on Patron Category

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589 --- Comment #38 from M. Tompsett --- Okay... thoughts on a rework include: GetHiddenItems in C4::Items would be removed. This would lead to a refactor EmbedItemsInMarcBiblio to NOT have an fourth parameter $opac as all the filtering

[Koha-bugs] [Bug 10589] Override OpacHiddenItems based on Patron Category

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589 M. Tompsett changed: What|Removed |Added See Also||https://bugs.koha-community

[Koha-bugs] [Bug 10589] Override OpacHiddenItems based on Patron Category

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589 --- Comment #37 from M. Tompsett --- (In reply to Marc Véron from comment #36) > Still valid? This patch is not the correct way to proceed. I'm working on a rewrite with filters now. -- You are receiving this mail because: You are

[Koha-bugs] [Bug 10589] Override OpacHiddenItems based on Patron Category

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589 M. Tompsett changed: What|Removed |Added Depends on||15777 Referenced Bugs: http

[Koha-bugs] [Bug 10589] Override OpacHiddenItems based on Patron Category

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589 Marc Véron changed: What|Removed |Added See Also||http://bugs.koha-community.

[Koha-bugs] [Bug 10589] Override OpacHiddenItems based on Patron Category

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589 --- Comment #36 from Marc Véron --- Still valid? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org htt

[Koha-bugs] [Bug 10589] Override OpacHiddenItems based on Patron Category

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589 M. Tompsett changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #35 from

[Koha-bugs] [Bug 10589] Override OpacHiddenItems based on Patron Category

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589 M. Tompsett changed: What|Removed |Added Depends on||10895 -- You are receiving th

[Koha-bugs] [Bug 10589] Override OpacHiddenItems based on Patron Category

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589 M. Tompsett changed: What|Removed |Added Blocks|10895 | Depends on|10900

[Koha-bugs] [Bug 10589] Override OpacHiddenItems based on Patron Category

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589 M. Tompsett changed: What|Removed |Added Depends on|10895 |10900 -- You are receiving th

[Koha-bugs] [Bug 10589] Override OpacHiddenItems based on Patron Category

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589 --- Comment #34 from M. Tompsett --- Okay, this patch needs to be AFTER 10900, and the test cases are in 10895, but those depend on 10900 as well. Bug 10589 is an ENHANCEMENT. It was signed off rather quickly, but at the time I didn'

[Koha-bugs] [Bug 10589] Override OpacHiddenItems based on Patron Category

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589 M. Tompsett changed: What|Removed |Added Depends on||10900 -- You are receiving th

[Koha-bugs] [Bug 10589] Override OpacHiddenItems based on Patron Category

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589 --- Comment #33 from Jonathan Druart --- (In reply to M. Tompsett from comment #32) > See Bugs 10900 and 10895. They kind of all go together. The unit tests are > on another bug report. 10895 is in discussion, because Galen punted it

[Koha-bugs] [Bug 10589] Override OpacHiddenItems based on Patron Category

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589 --- Comment #32 from M. Tompsett --- See Bugs 10900 and 10895. They kind of all go together. The unit tests are on another bug report. 10895 is in discussion, because Galen punted it to the next release. -- You are receiving this ma

[Koha-bugs] [Bug 10589] Override OpacHiddenItems based on Patron Category

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@biblibre.co

[Koha-bugs] [Bug 10589] Override OpacHiddenItems based on Patron Category

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589 Srdjan Jankovic changed: What|Removed |Added Attachment #30796|0 |1 is obsolete|

[Koha-bugs] [Bug 10589] Override OpacHiddenItems based on Patron Category

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589 Srdjan Jankovic changed: What|Removed |Added Status|In Discussion |Signed Off -- You are rec

[Koha-bugs] [Bug 10589] Override OpacHiddenItems based on Patron Category

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589 Marc Véron changed: What|Removed |Added Attachment #22629|0 |1 is obsolete|

[Koha-bugs] [Bug 10589] Override OpacHiddenItems based on Patron Category

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589 Marc Véron changed: What|Removed |Added CC||ve...@veron.ch -- You are rece

[Koha-bugs] [Bug 10589] Override OpacHiddenItems based on Patron Category

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589 jkpatti...@gmail.com changed: What|Removed |Added CC||jkpatti...@gmail.com -

[Koha-bugs] [Bug 10589] Override OpacHiddenItems based on Patron Category

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589 Manny Tamayao changed: What|Removed |Added CC||manueltama...@gmail.com ---

[Koha-bugs] [Bug 10589] Override OpacHiddenItems based on Patron Category

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589 Galen Charlton changed: What|Removed |Added Status|Passed QA |In Discussion -- You are r

[Koha-bugs] [Bug 10589] Override OpacHiddenItems based on Patron Category

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589 Galen Charlton changed: What|Removed |Added Keywords|rel_3_16_candidate | CC|

[Koha-bugs] [Bug 10589] Override OpacHiddenItems based on Patron Category

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589 Galen Charlton changed: What|Removed |Added Keywords||rel_3_16_candidate -- You

[Koha-bugs] [Bug 10589] Override OpacHiddenItems based on Patron Category

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589 Chris Cormack changed: What|Removed |Added CC||ch...@bigballofwax.co.nz ---

[Koha-bugs] [Bug 10589] Override OpacHiddenItems based on Patron Category

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589 --- Comment #24 from M. de Rooy --- (In reply to M. de Rooy from comment #23) > 1) No unit tests. Adding these makes the chance of a push considerably > larger :) Reading back, I happen to notice that there seem to be tests under ano

[Koha-bugs] [Bug 10589] Override OpacHiddenItems based on Patron Category

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589 M. de Rooy changed: What|Removed |Added Patch complexity|--- |Small patch QA Contact|

[Koha-bugs] [Bug 10589] Override OpacHiddenItems based on Patron Category

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589 M. de Rooy changed: What|Removed |Added Status|Signed Off |Passed QA CC|

[Koha-bugs] [Bug 10589] Override OpacHiddenItems based on Patron Category

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589 M. de Rooy changed: What|Removed |Added Attachment #22587|0 |1 is obsolete|

[Koha-bugs] [Bug 10589] Override OpacHiddenItems based on Patron Category

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589 M. Tompsett changed: What|Removed |Added Blocks||10895 -- You are receiving th

[Koha-bugs] [Bug 10589] Override OpacHiddenItems based on Patron Category

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589 M. Tompsett changed: What|Removed |Added Attachment #21620|0 |1 is obsolete|

[Koha-bugs] [Bug 10589] Override OpacHiddenItems based on Patron Category

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589 --- Comment #21 from M. Tompsett --- Rebased again. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org

[Koha-bugs] [Bug 10589] Override OpacHiddenItems based on Patron Category

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589 Srdjan Jankovic changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are rec

[Koha-bugs] [Bug 10589] Override OpacHiddenItems based on Patron Category

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589 Srdjan Jankovic changed: What|Removed |Added Attachment #21256|0 |1 is obsolete|

[Koha-bugs] [Bug 10589] Override OpacHiddenItems based on Patron Category

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589 --- Comment #18 from M. Tompsett --- I put the tests into a separate bug, because at the time, this was signed off. Sadly, I had to rebase. See bug 10895 for a test file, which depends on bug 10900. -- You are receiving this mail be

[Koha-bugs] [Bug 10589] Override OpacHiddenItems based on Patron Category

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589 I'm just a bot changed: What|Removed |Added CC||git...@bugs.koha-community.

[Koha-bugs] [Bug 10589] Override OpacHiddenItems based on Patron Category

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589 M. Tompsett changed: What|Removed |Added Status|Signed Off |Needs Signoff -- You are rece

[Koha-bugs] [Bug 10589] Override OpacHiddenItems based on Patron Category

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589 M. Tompsett changed: What|Removed |Added Attachment #21066|0 |1 is obsolete|

[Koha-bugs] [Bug 10589] Override OpacHiddenItems based on Patron Category

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589 M. Tompsett changed: What|Removed |Added See Also||http://bugs.koha-community.

[Koha-bugs] [Bug 10589] Override OpacHiddenItems based on Patron Category

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589 Srdjan Jankovic changed: What|Removed |Added Attachment #21063|0 |1 is obsolete|

[Koha-bugs] [Bug 10589] Override OpacHiddenItems based on Patron Category

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589 Srdjan Jankovic changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are rec

[Koha-bugs] [Bug 10589] Override OpacHiddenItems based on Patron Category

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589 --- Comment #13 from M. Tompsett --- Created attachment 21063 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21063&action=edit Bug 10589 - Override OpacHiddenItems based on Patron Category Two system preferences, Pa

[Koha-bugs] [Bug 10589] Override OpacHiddenItems based on Patron Category

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589 M. Tompsett changed: What|Removed |Added Attachment #19954|0 |1 is obsolete|

[Koha-bugs] [Bug 10589] Override OpacHiddenItems based on Patron Category

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589 M. Tompsett changed: What|Removed |Added Status|Signed Off |Needs Signoff -- You are rece

[Koha-bugs] [Bug 10589] Override OpacHiddenItems based on Patron Category

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589 Nicole C. Engard changed: What|Removed |Added CC||neng...@gmail.com -- You

[Koha-bugs] [Bug 10589] Override OpacHiddenItems based on Patron Category

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589 M. Tompsett changed: What|Removed |Added Attachment #19949|0 |1 is obsolete|

[Koha-bugs] [Bug 10589] Override OpacHiddenItems based on Patron Category

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589 --- Comment #11 from Srdjan Jankovic --- Created attachment 19954 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19954&action=edit [SIGNED-OFF] Bug 10589 - Override OpacHiddenItems based on Patron Category Two syste

[Koha-bugs] [Bug 10589] Override OpacHiddenItems based on Patron Category

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589 Srdjan Jankovic changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are rec

[Koha-bugs] [Bug 10589] Override OpacHiddenItems based on Patron Category

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589 --- Comment #10 from Srdjan Jankovic --- IT works and I will sign it of, however I need to raise two things (should have done earlier, but occurred to me when testing): 1. Not sure if it is appropriate to put default values for those

[Koha-bugs] [Bug 10589] Override OpacHiddenItems based on Patron Category

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589 M. Tompsett changed: What|Removed |Added Status|In Discussion |Needs Signoff -- You are rece

[Koha-bugs] [Bug 10589] Override OpacHiddenItems based on Patron Category

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589 M. Tompsett changed: What|Removed |Added Attachment #19933|0 |1 is obsolete|

[Koha-bugs] [Bug 10589] Override OpacHiddenItems based on Patron Category

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589 --- Comment #8 from Srdjan Jankovic --- Sorry, now another one: grep( /^$categorycode$/, @SingleBranchCodes ) should be replaced with any() (and @EveryBranchCodes too) -- You are receiving this mail because: You are watching all bug

[Koha-bugs] [Bug 10589] Override OpacHiddenItems based on Patron Category

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589 M. Tompsett changed: What|Removed |Added Attachment #19932|0 |1 is obsolete|

[Koha-bugs] [Bug 10589] Override OpacHiddenItems based on Patron Category

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589 M. Tompsett changed: What|Removed |Added Attachment #19931|0 |1 is obsolete|

[Koha-bugs] [Bug 10589] Override OpacHiddenItems based on Patron Category

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589 M. Tompsett changed: What|Removed |Added Status|Needs Signoff |In Discussion --- Comment #5 f

[Koha-bugs] [Bug 10589] Override OpacHiddenItems based on Patron Category

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589 Srdjan Jankovic changed: What|Removed |Added CC||srd...@catalyst.net.nz ---

[Koha-bugs] [Bug 10589] Override OpacHiddenItems based on Patron Category

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589 M. Tompsett changed: What|Removed |Added Attachment #19708|0 |1 is obsolete|

[Koha-bugs] [Bug 10589] Override OpacHiddenItems based on Patron Category

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589 M. Tompsett changed: What|Removed |Added Attachment #19647|0 |1 is obsolete|

[Koha-bugs] [Bug 10589] Override OpacHiddenItems based on Patron Category

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589 M. Tompsett changed: What|Removed |Added Status|NEW |Needs Signoff Assign