https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11077
Jonathan Druart changed:
What|Removed |Added
Blocks||18275
--
You are receivi
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11077
M. Tompsett changed:
What|Removed |Added
CC||katrin.fisc...@bsz-bw.de
--- C
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11077
--- Comment #54 from Tomás Cohen Arazi ---
This patch has been pushed to 3.12.x, will be in 3.12.8.
Thanks Srdjan and Mark!
--
You are receiving this mail because:
You are watching all bug changes.
_
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11077
Fridolin SOMERS changed:
What|Removed |Added
Blocks|8817|
--
You are receiving thi
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11077
Fridolin SOMERS changed:
What|Removed |Added
Blocks||8817
--
You are receiving
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11077
Fridolin SOMERS changed:
What|Removed |Added
Status|Pushed to Master|Pushed to Stable
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11077
Galen Charlton changed:
What|Removed |Added
Status|Passed QA |Pushed to Master
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11077
M. de Rooy changed:
What|Removed |Added
Status|Signed Off |Passed QA
--- Comment #51 from
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11077
M. de Rooy changed:
What|Removed |Added
Attachment #23268|0 |1
is obsolete|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11077
--- Comment #49 from M. Tompsett ---
Re-tested.
- staff client: click login with nothing entered
- click login with just a valid username entered
- click login with proper credentials entered
- log out
- deleted system preference
- c
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11077
M. Tompsett changed:
What|Removed |Added
Attachment #23240|0 |1
is obsolete|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11077
--- Comment #48 from M. Tompsett ---
Created attachment 23268
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23268&action=edit
[SIGNED OFF] Bug 11077 - Correct silent warnings in C4/Auth.pm
This gets rid of some mor
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11077
M. de Rooy changed:
What|Removed |Added
QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11077
--- Comment #47 from M. de Rooy ---
Thanks, Srdjan.
Mark, could you please add your signoff too?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mai
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11077
Srdjan Jankovic changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--
You are rec
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11077
Srdjan Jankovic changed:
What|Removed |Added
Attachment #23219|0 |1
is obsolete|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11077
--- Comment #45 from M. de Rooy ---
Thanks, Mark.
Since the patch still is on the name of Srdjan, I would like to ask him to test
the patch again. After that please add your signoff, Mark. Since this looks
good to me, QA will not take
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11077
M. Tompsett changed:
What|Removed |Added
Status|Failed QA |Needs Signoff
--- Comment #44
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11077
M. Tompsett changed:
What|Removed |Added
Attachment #23198|0 |1
is obsolete|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11077
M. Tompsett changed:
What|Removed |Added
Attachment #23218|0 |1
is obsolete|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11077
--- Comment #42 from M. Tompsett ---
(In reply to M. Tompsett from comment #41)
> - Delete the AllowPKIAuth System Preference
Oops... and click the login button.
--
You are receiving this mail because:
You are watching all bug chan
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11077
--- Comment #41 from M. Tompsett ---
Test Plan:
- Go to staff client
- Click the login button without typing anything
- Type just a username without a password and click the login button
- Backup DB
- Delete the AllowPKIAuth System Pr
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11077
M. Tompsett changed:
What|Removed |Added
Attachment #23215|0 |1
is obsolete|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11077
M. Tompsett changed:
What|Removed |Added
Attachment #23214|0 |1
is obsolete|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11077
M. Tompsett changed:
What|Removed |Added
Attachment #23217|0 |1
is obsolete|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11077
--- Comment #39 from M. Tompsett ---
Yes, my patch does change it back. I did as you suggested and looked at the
code again. If we set the variable to 'None', it bypasses the if completely. If
we set the variable to '', it goes throug
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11077
--- Comment #38 from M. Tompsett ---
Created attachment 23217
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23217&action=edit
Bug 11077 - Fix indents to trace code more easily
--
You are receiving this mail becaus
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11077
--- Comment #37 from M. de Rooy ---
(In reply to M. Tompsett from comment #36)
> > Correct me if I am wrong but if PKIAuth is None or undef, the if statement
> > should not be run (so we should make the expr be false).
> > Do you agre
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11077
--- Comment #36 from M. Tompsett ---
(In reply to M. de Rooy from comment #35)
> Maybe we have some misunderstanding?
We may have some cross-talk.
> Correct me if I am wrong but if PKIAuth is None or undef, the if statement
> shoul
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11077
--- Comment #35 from M. de Rooy ---
(In reply to M. Tompsett from comment #34)
> Created attachment 23215 [details]
> Confirmation of what I said regarding undef ne 'None'
>
> I believe this clarifies the problem even better, and thi
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11077
--- Comment #34 from M. Tompsett ---
Created attachment 23215
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23215&action=edit
Confirmation of what I said regarding undef ne 'None'
I believe this clarifies the probl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11077
M. Tompsett changed:
What|Removed |Added
Attachment #23199|0 |1
is obsolete|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11077
--- Comment #32 from M. de Rooy ---
(In reply to M. Tompsett from comment #30)
> Also, my patch depends on his, so should I squash our patches together, and
> get a single sign off? Should I correct mine after he corrects his? This is
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11077
--- Comment #31 from M. de Rooy ---
Hi Mark,
I did not look at the third patch obviously :)
Will have a look soon.
Thanks.
--
You are receiving this mail because:
You are watching all bug changes.
___
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11077
--- Comment #30 from M. Tompsett ---
My patch corrects the problem for which you failed Srdjan Jankovic's patch. You
will notice that I changed:
elsif ( $lasttime && ($lasttime < time() - $timeout) ) {
into
elsif ( !$las
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11077
M. de Rooy changed:
What|Removed |Added
Status|Signed Off |Failed QA
--
You are receiving
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11077
M. de Rooy changed:
What|Removed |Added
Attachment #22854|0 |1
is obsolete|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11077
M. de Rooy changed:
What|Removed |Added
Attachment #22805|0 |1
is obsolete|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11077
M. de Rooy changed:
What|Removed |Added
Attachment #22805|bug_11077: get rid of some |[FAILED_QA] Bug 11077: get
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11077
M. de Rooy changed:
What|Removed |Added
Attachment #23197|Bug 11077: Uninitialized|[PASSED_QA] Bug 11077:
d
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11077
M. de Rooy changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--
You are receivin
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11077
M. de Rooy changed:
What|Removed |Added
Attachment #22125|0 |1
is obsolete|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11077
M. Tompsett changed:
What|Removed |Added
Attachment #22844|0 |1
is obsolete|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11077
--- Comment #23 from Tomás Cohen Arazi ---
(In reply to Srdjan Jankovic from comment #22)
> No worries mate :)
+1, I thought my signed-by-Petter patch was enough :-D, I welcome anything that
makes this warnings away. I'm already focu
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11077
--- Comment #22 from Srdjan Jankovic ---
No worries mate :)
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-commun
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11077
M. Tompsett changed:
What|Removed |Added
Status|ASSIGNED|Needs Signoff
--- Comment #21
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11077
M. Tompsett changed:
What|Removed |Added
Attachment #22806|0 |1
is obsolete|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11077
M. Tompsett changed:
What|Removed |Added
Attachment #22831|0 |1
is obsolete|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11077
--- Comment #19 from M. Tompsett ---
Created attachment 22831
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22831&action=edit
Sample Test Program to confirm behaviour of busted vs current patch vs
suggestion
--
Yo
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11077
M. Tompsett changed:
What|Removed |Added
Status|Needs Signoff |ASSIGNED
--- Comment #18 from
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11077
Srdjan Jankovic changed:
What|Removed |Added
Attachment #22667|0 |1
is obsolete|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11077
Srdjan Jankovic changed:
What|Removed |Added
Attachment #22665|0 |1
is obsolete|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11077
M. Tompsett changed:
What|Removed |Added
Status|ASSIGNED|Needs Signoff
--
You are rece
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11077
--- Comment #15 from M. Tompsett ---
Created attachment 22667
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22667&action=edit
Bug 11077 - Correct silent warnings in C4/Auth.pm
This patch corrects a noisy ne conditi
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11077
Srdjan Jankovic changed:
What|Removed |Added
CC||srd...@catalyst.net.nz
---
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11077
--- Comment #13 from Srdjan Jankovic ---
Created attachment 22665
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22665&action=edit
bug_11077: get rid of some warnings
--
You are receiving this mail because:
You are
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11077
M. Tompsett changed:
What|Removed |Added
Status|Signed Off |ASSIGNED
--- Comment #12 from
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11077
Jonathan Druart changed:
What|Removed |Added
CC||jonathan.dru...@biblibre.co
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11077
--- Comment #10 from M. Tompsett ---
(In reply to Jonathan Druart from comment #9)
> I am not sure it is a good idea to suppress the warning caused by an
> undefined syspref. This syspref should exist in the DB, else something wrong
>
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11077
--- Comment #9 from Jonathan Druart ---
Comment on attachment 22125
--> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22125
Bug 11077: Uninitialized value $pki_field warning
Review of attachment 22125:
-->
(http://bu
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11077
M. Tompsett changed:
What|Removed |Added
Attachment #22120|0 |1
is obsolete|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11077
--- Comment #7 from Petter Goksøyr Åsen ---
Created attachment 22125
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22125&action=edit
Bug 11077: Uninitialized value $pki_field warning
During login at the Staff inter
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11077
Petter Goksøyr Åsen changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
Patch com
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11077
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #22043|0 |1
is obsolete|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11077
--- Comment #5 from M. Tompsett ---
Test case to check, which makes a difference whether '' or 'None' is used.
Apply patch.
Make sure you aren't doing cas authentication (not normally configured)
DELETE AllowPKIAuth system preference
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11077
M. Tompsett changed:
What|Removed |Added
Summary|Uninitialized value |Correct silent warnings in
66 matches
Mail list logo
