https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700
Marcel de Rooy changed:
What|Removed |Added
Status|RESOLVED
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700
Marcel de Rooy changed:
What|Removed |Added
Resolution|---
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700
Marcel de Rooy changed:
What|Removed |Added
Blocks|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700
Jonathan Druart changed:
What|Removed |Added
Status|Signed Off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700
--- Comment #70 from Martin Renvoize ---
I often tidy the file for my own sanity and commit just that tidy.. then I
commit the actual fixes in the next commit(s) and backport them to the untidy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700
--- Comment #69 from Jonathan Druart
---
(In reply to Jacek Ablewicz from comment #68)
> (In reply to Jonathan Druart from comment #66)
> > All the indentation changes make this patchset
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700
--- Comment #68 from Jacek Ablewicz ---
(In reply to Jonathan Druart from comment #66)
> All the indentation changes make this patchset really hard to read, but
> basically it seems that there are only 2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700
--- Comment #67 from Jacek Ablewicz ---
(In reply to Jonathan Druart from comment #66)
> 1/
> Add
> +$MARCfrom ||= GetAuthority($mergefrom);
$MARCfrom (and @record_from) are currently not used in this
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700
--- Comment #66 from Jonathan Druart
---
All the indentation changes make this patchset really hard to read, but
basically it seems that there are only 2 changes:
1/
Add
+$MARCfrom
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700
Julian Maurice changed:
What|Removed |Added
Status|Patch doesn't apply
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700
Julian Maurice changed:
What|Removed |Added
Attachment #46402|0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700
--- Comment #61 from Julian Maurice ---
Created attachment 56470
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56470=edit
Bug 11700: C4::AuthoritiesMarc::merge enhancements/fixes
-
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700
Julian Maurice changed:
What|Removed |Added
Attachment #46401|0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700
Julian Maurice changed:
What|Removed |Added
Attachment #46400|0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700
Julian Maurice changed:
What|Removed |Added
Attachment #46397|0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700
Julian Maurice changed:
What|Removed |Added
Attachment #46399|0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700
Fridolin SOMERS changed:
What|Removed |Added
Status|BLOCKED
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700
Fridolin SOMERS changed:
What|Removed |Added
Depends on|13762
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700
Bug 11700 depends on bug 13762, which changed state.
Bug 13762 Summary: biblionumber field and subfield can be called once in
authorities merge
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13762
What
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700
Jacek Ablewicz changed:
What|Removed |Added
See Also|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700
Jacek Ablewicz changed:
What|Removed |Added
CC|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700
Katrin Fischer changed:
What|Removed |Added
Status|Signed Off
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700
Julian Maurice changed:
What|Removed |Added
Attachment #45053|0
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700
--- Comment #52 from Julian Maurice ---
Created attachment 46398
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46398=edit
Bug 11700: C4::AuthoritiesMarc::merge enhancements/fixes
-
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700
Julian Maurice changed:
What|Removed |Added
Attachment #45050|0
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700
Kyle M Hall changed:
What|Removed |Added
CC|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700
--- Comment #50 from Katrin Fischer ---
Merging authorities is broken currently - see bug 15358
--
You are receiving this mail because:
You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700
--- Comment #42 from Katrin Fischer ---
This is a bit of a mixed bag of things - can you please add test plans to the
2nd and 3rd patch?
--
You are receiving this mail because:
You are watching all bug
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700
Kyle M Hall changed:
What|Removed |Added
Attachment #45048|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700
Kyle M Hall changed:
What|Removed |Added
Status|Signed Off
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700
Kyle M Hall changed:
What|Removed |Added
Attachment #40968|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700
--- Comment #45 from Kyle M Hall ---
Created attachment 45050
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45050=edit
Bug 11700: Avoid to try to delete the authority twice
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700
--- Comment #48 from Kyle M Hall ---
Created attachment 45053
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45053=edit
Bug 11700 [QA Followup] - Tidy merge a bit, fix warning triggered
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700
--- Comment #46 from Kyle M Hall ---
Created attachment 45051
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45051=edit
Bug 11700: Add unit tests for C4::AuthoritiesMarc::merge
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700
--- Comment #47 from Kyle M Hall ---
Created attachment 45052
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45052=edit
Bug 11700: Add description to unit tests
Signed-off-by: Kyle M Hall
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700
--- Comment #40 from Julian Maurice julian.maur...@biblibre.com ---
Created attachment 40972
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40972action=edit
Bug 11700: Add description to unit tests
--
You are
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700
Julian Maurice julian.maur...@biblibre.com changed:
What|Removed |Added
Attachment #39268|0
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700
Julian Maurice julian.maur...@biblibre.com changed:
What|Removed |Added
Status|Failed QA
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700
Julian Maurice julian.maur...@biblibre.com changed:
What|Removed |Added
Attachment #39264|0
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700
Julian Maurice julian.maur...@biblibre.com changed:
What|Removed |Added
Attachment #39265|0
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700
Julian Maurice julian.maur...@biblibre.com changed:
What|Removed |Added
Attachment #39266|0
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700
Katrin Fischer katrin.fisc...@bsz-bw.de changed:
What|Removed |Added
Status|Signed Off
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700
Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed:
What|Removed |Added
Attachment #27970|0
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700
Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed:
What|Removed |Added
Attachment #27971|0
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700
Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed:
What|Removed |Added
Attachment #27973|0
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700
Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed:
What|Removed |Added
Attachment #27972|0
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700
Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed:
What|Removed |Added
Attachment #28177|0
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700
Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed:
What|Removed |Added
Attachment #35107|0
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700
Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed:
What|Removed |Added
Status|Needs Signoff
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700
Fridolin SOMERS fridolyn.som...@biblibre.com changed:
What|Removed |Added
See Also|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700
Fridolin SOMERS fridolyn.som...@biblibre.com changed:
What|Removed |Added
CC|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700
Fridolin SOMERS fridolyn.som...@biblibre.com changed:
What|Removed |Added
See Also|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700
Julian Maurice julian.maur...@biblibre.com changed:
What|Removed |Added
Blocks|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700
M. de Rooy m.de.r...@rijksmuseum.nl changed:
What|Removed |Added
Status|Needs Signoff |Failed
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700
--- Comment #23 from Jonathan Druart jonathan.dru...@biblibre.com ---
(In reply to M. de Rooy from comment #21)
Hm. I cannot find any reference to field 109 in unimarc too?
Julian has certainly chosen 109 arbitrarily.
The tests pass
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700
--- Comment #22 from M. de Rooy m.de.r...@rijksmuseum.nl ---
OK. I had a closer look. But we are not there yet:
I added some debug prints to the unit test:
warn L251a; my @biblios = C4::AuthoritiesMarc::merge($authid2, undef,
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700
--- Comment #24 from M. de Rooy m.de.r...@rijksmuseum.nl ---
(In reply to Jonathan Druart from comment #23)
(In reply to M. de Rooy from comment #21)
Hm. I cannot find any reference to field 109 in unimarc too?
Julian has
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700
--- Comment #21 from M. de Rooy m.de.r...@rijksmuseum.nl ---
Hm. I cannot find any reference to field 109 in unimarc too?
--
You are receiving this mail because:
You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700
--- Comment #26 from Julian Maurice julian.maur...@biblibre.com ---
Jonathan reproduced the bug on one of the sandbox, so no need to do this on
your side.
I think I've found the problem and will submit a patch.
--
You are receiving
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700
--- Comment #27 from Julian Maurice julian.maur...@biblibre.com ---
Created attachment 35107
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35107action=edit
Bug 11700: Fix unit test when index mode is not defined
Use
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700
Julian Maurice julian.maur...@biblibre.com changed:
What|Removed |Added
Status|Failed QA
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700
--- Comment #25 from Julian Maurice julian.maur...@biblibre.com ---
Hi Marcel,
Unfortunately I am not able to reproduce your problem.
Could you add some debug prints in the mock of ZOOM::Record::raw (line 242 of
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700
Jonathan Druart jonathan.dru...@biblibre.com changed:
What|Removed |Added
CC|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700
--- Comment #17 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 28176
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28176action=edit
Bug 11700: Avoid to try to delete the authority twice
--
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700
Jonathan Druart jonathan.dru...@biblibre.com changed:
What|Removed |Added
Status|Failed QA
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700
--- Comment #18 from Jonathan Druart jonathan.dru...@biblibre.com ---
(In reply to Jonathan Druart from comment #17)
Created attachment 28176 [details] [review]
Bug 11700: Avoid to try to delete the authority twice
Not sure dying
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700
Jonathan Druart jonathan.dru...@biblibre.com changed:
What|Removed |Added
Attachment #28176|0
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700
Martin Renvoize martin.renvo...@ptfs-europe.com changed:
What|Removed |Added
CC|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700
Galen Charlton gmcha...@gmail.com changed:
What|Removed |Added
Status|Needs Signoff |Failed QA
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700
Julian Maurice julian.maur...@biblibre.com changed:
What|Removed |Added
Attachment #25426|0
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700
Julian Maurice julian.maur...@biblibre.com changed:
What|Removed |Added
Attachment #25413|0
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700
--- Comment #12 from Julian Maurice julian.maur...@biblibre.com ---
Created attachment 27973
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27973action=edit
Bug 11700: Fix unit tests when index mode is 'dom'
--
You
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700
Julian Maurice julian.maur...@biblibre.com changed:
What|Removed |Added
Attachment #25414|0
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700
Julian Maurice julian.maur...@biblibre.com changed:
What|Removed |Added
Status|Patch doesn't apply
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700
Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed:
What|Removed |Added
Status|Needs Signoff
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700
Julian Maurice julian.maur...@biblibre.com changed:
What|Removed |Added
Attachment #25086|0
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700
--- Comment #5 from Julian Maurice julian.maur...@biblibre.com ---
Created attachment 25414
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25414action=edit
Bug 11700: C4::AuthoritiesMarc::merge enhancements/fixes
-
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700
--- Comment #6 from Julian Maurice julian.maur...@biblibre.com ---
I split patch in two parts: 1) whitespace fixes 2) real changes
I'll try to write unit tests asap
--
You are receiving this mail because:
You are watching all bug
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700
--- Comment #7 from Julian Maurice julian.maur...@biblibre.com ---
Created attachment 25426
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25426action=edit
Bug 11700: Add unit tests for C4::AuthoritiesMarc::merge
--
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700
M. Tompsett mtomp...@hotmail.com changed:
What|Removed |Added
CC|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700
--- Comment #3 from M. Tompsett mtomp...@hotmail.com ---
Please also note:
http://wiki.koha-community.org/wiki/Coding_Guidelines#PERL6:_Indentation
If you want to reindent large amounts of existing code in connection with a
bugfix or
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700
Julian Maurice julian.maur...@biblibre.com changed:
What|Removed |Added
Status|ASSIGNED
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700
--- Comment #1 from Julian Maurice julian.maur...@biblibre.com ---
Created attachment 25086
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25086action=edit
Bug 11700: C4::AuthoritiesMarc::merge enhancements/fixes
-
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700
Julian Maurice julian.maur...@biblibre.com changed:
What|Removed |Added
Blocks|
84 matches
Mail list logo