[Koha-bugs] [Bug 11744] cancel receipt doesn't work for one item

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11744 --- Comment #31 from Jonathan Druart --- (In reply to Jonathan Druart from comment #28) > (In reply to Katrin Fischer from comment #27) > > I lost track of this a bit, should we have a new bug report for comment > > 18-20? > > Bug 12

[Koha-bugs] [Bug 11744] cancel receipt doesn't work for one item

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11744 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to Master

[Koha-bugs] [Bug 11744] cancel receipt doesn't work for one item

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11744 --- Comment #29 from Katrin Fischer --- Ah! Thx! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org htt

[Koha-bugs] [Bug 11744] cancel receipt doesn't work for one item

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11744 --- Comment #28 from Jonathan Druart --- (In reply to Katrin Fischer from comment #27) > I lost track of this a bit, should we have a new bug report for comment > 18-20? Bug 12555 already opened and linked ;) -- You are receiving t

[Koha-bugs] [Bug 11744] cancel receipt doesn't work for one item

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11744 --- Comment #27 from Katrin Fischer --- I lost track of this a bit, should we have a new bug report for comment 18-20? -- You are receiving this mail because: You are watching all bug changes. ___

[Koha-bugs] [Bug 11744] cancel receipt doesn't work for one item

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11744 --- Comment #25 from Kyle M Hall --- Created attachment 29627 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29627&action=edit [PASSED QA] Bug 11744: A receipt should not be cancelled if holds exist Test plan: 1/ Se

[Koha-bugs] [Bug 11744] cancel receipt doesn't work for one item

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11744 --- Comment #26 from Kyle M Hall --- Created attachment 29628 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29628&action=edit [PASSED QA] Bug 11744: Add regression tests Before the patch: prove t/db_dependent/Acqu

[Koha-bugs] [Bug 11744] cancel receipt doesn't work for one item

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11744 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receivin

[Koha-bugs] [Bug 11744] cancel receipt doesn't work for one item

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11744 Kyle M Hall changed: What|Removed |Added Attachment #25683|0 |1 is obsolete|

[Koha-bugs] [Bug 11744] cancel receipt doesn't work for one item

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11744 --- Comment #23 from Jonathan Druart --- The UT patch is rebased (conflict with commit Bug 11699: ModReceiveOrder should take a hashref in parameter), -- You are receiving this mail because: You are watching all bug changes. ___

[Koha-bugs] [Bug 11744] cancel receipt doesn't work for one item

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11744 Jonathan Druart changed: What|Removed |Added Attachment #25682|0 |1 is obsolete|

[Koha-bugs] [Bug 11744] cancel receipt doesn't work for one item

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11744 Jonathan Druart changed: What|Removed |Added Blocks||12555 -- You are receivin

[Koha-bugs] [Bug 11744] cancel receipt doesn't work for one item

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11744 Jonathan Druart changed: What|Removed |Added Status|Failed QA |Signed Off --- Comment #21

[Koha-bugs] [Bug 11744] cancel receipt doesn't work for one item

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11744 --- Comment #20 from Jonathan Druart --- (In reply to Kyle M Hall from comment #18) > This patch set does not appear to update zebra on deletion. Also, I wonder > if it would be best to call DelItem from the item deletion to take care

[Koha-bugs] [Bug 11744] cancel receipt doesn't work for one item

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11744 --- Comment #19 from Katrin Fischer --- Hi Kyle, thx for taking a look at this - I won't be able to do much QA before the beginning of next week. Woudl DelItem also help with the hold issues? -- You are receiving this mail because:

[Koha-bugs] [Bug 11744] cancel receipt doesn't work for one item

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11744 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Failed QA CC|

[Koha-bugs] [Bug 11744] cancel receipt doesn't work for one item

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11744 --- Comment #17 from Marjorie Barry-Vila --- (In reply to Katrin Fischer from comment #15) > Hi Jonathan, > > I have tested this again and it works as described. But I am a bit worried > still - before the patch you could undo a rec

[Koha-bugs] [Bug 11744] cancel receipt doesn't work for one item

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11744 --- Comment #16 from Jonathan Druart --- (In reply to Katrin Fischer from comment #15) > Could showing an alert: 'There is at least 1 hold on this record, please > delete items manually' be an option? Did you see I added a 'title' on

[Koha-bugs] [Bug 11744] cancel receipt doesn't work for one item

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11744 --- Comment #15 from Katrin Fischer --- Hi Jonathan, I have tested this again and it works as described. But I am a bit worried still - before the patch you could undo a receipt any time, being aware that the items would not be dele

[Koha-bugs] [Bug 11744] cancel receipt doesn't work for one item

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11744 Jonathan Druart changed: What|Removed |Added Status|Failed QA |Signed Off -- You are rec

[Koha-bugs] [Bug 11744] cancel receipt doesn't work for one item

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11744 --- Comment #14 from Jonathan Druart --- Created attachment 26447 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26447&action=edit Bug 11744: A receipt should not be cancelled if holds exist Test plan: 1/ Set acqCre

[Koha-bugs] [Bug 11744] cancel receipt doesn't work for one item

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11744 --- Comment #13 from Katrin Fischer --- The problem I see here is that right now the feature is not there, but no damage is done. The item is not deleted and you can do it manually, the data will remain consistent. With the patch, you

[Koha-bugs] [Bug 11744] cancel receipt doesn't work for one item

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11744 --- Comment #12 from Jonathan Druart --- (In reply to Katrin Fischer from comment #11) Katrin, I agree that some tests are missing but in my opinion it is outside the scope of this bug. Don't you think? -- You are receiving this mai

[Koha-bugs] [Bug 11744] cancel receipt doesn't work for one item

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11744 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #11 f

[Koha-bugs] [Bug 11744] cancel receipt doesn't work for one item

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11744 --- Comment #9 from sandbo...@biblibre.com --- Created attachment 25682 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25682&action=edit Bug 11744: Add regression tests Before the patch: prove t/db_dependent/Acquis

[Koha-bugs] [Bug 11744] cancel receipt doesn't work for one item

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11744 --- Comment #10 from sandbo...@biblibre.com --- Created attachment 25683 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25683&action=edit Bug 11744: Cancel a receipt does not delete items created on receiving If ite

[Koha-bugs] [Bug 11744] cancel receipt doesn't work for one item

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11744 sandbo...@biblibre.com changed: What|Removed |Added Attachment #25445|0 |1 is obsolet

[Koha-bugs] [Bug 11744] cancel receipt doesn't work for one item

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11744 sandbo...@biblibre.com changed: What|Removed |Added Attachment #25444|0 |1 is obsolet

[Koha-bugs] [Bug 11744] cancel receipt doesn't work for one item

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11744 sandbo...@biblibre.com changed: What|Removed |Added CC||sandbo...@biblibre.c

[Koha-bugs] [Bug 11744] cancel receipt doesn't work for one item

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11744 Marjorie Barry-Vila changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment

[Koha-bugs] [Bug 11744] cancel receipt doesn't work for one item

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11744 --- Comment #6 from Jonathan Druart --- (In reply to Marjorie Barry-Vila from comment #5) Hi Marjorie, Could you test this patch against the master branch using a sandbox? -- You are receiving this mail because: You are watching all

[Koha-bugs] [Bug 11744] cancel receipt doesn't work for one item

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11744 --- Comment #5 from Marjorie Barry-Vila --- Hi, I tested the patch on 3.12.7 and it works fine. Regards, Marjorie -- You are receiving this mail because: You are watching all bug changes. __

[Koha-bugs] [Bug 11744] cancel receipt doesn't work for one item

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11744 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de