https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999
--- Comment #137 from Fridolin Somers ---
FYI here is our patch for 22.11
https://git.biblibre.com/biblibre/kohac/commit/2fd63a2a5916e3e19ba9b0aad90caca0225a1212
--
You are receiving this mail because:
You are watching all bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999
--- Comment #136 from Arthur Suzuki ---
(In reply to David Cook from comment #134)
> Checking hold limits has been driving me crazy lately.
>
> It seems to me that these functions should check all the different hold
> limits and
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999
Fridolin Somers changed:
What|Removed |Added
Status|Needs Signoff |Patch doesn't apply
---
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999
David Cook changed:
What|Removed |Added
CC||dc...@prosentient.com.au
---
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999
--- Comment #133 from David Nind ---
Created attachment 121612
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121612=edit
Test fails for holds - 2021-06-04
I've attached the test results for prove -v
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999
--- Comment #132 from Arthur Suzuki ---
Hi David,
I've not reproduced the issue with t/db_dependent/Holds.t
number of tests in Reserves.t has been updated.
Kr,
--
You are receiving this mail because:
You are watching all bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999
Arthur Suzuki changed:
What|Removed |Added
Attachment #120780|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999
--- Comment #130 from David Nind ---
Test failed - if I change the number of tests to 68, everything works fine:
t/db_dependent/Reserves.t (Wstat: 65280 Tests: 68 Failed: 1)
Failed test: 68
Non-zero exit status: 255
Parse
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999
--- Comment #129 from Fridolin Somers ---
(In reply to Joonas Kylmälä from comment #123)
> I didn't realize the follow-ups here removed those git merge conflict
> resolution hints. It would still probably be better if the conflicts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999
Fridolin Somers changed:
What|Removed |Added
Attachment #120778|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999
Fridolin Somers changed:
What|Removed |Added
Attachment #120776|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999
Fridolin Somers changed:
What|Removed |Added
Attachment #112874|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999
Fridolin Somers changed:
What|Removed |Added
Attachment #112872|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999
Fridolin Somers changed:
What|Removed |Added
Attachment #112871|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999
Fridolin Somers changed:
What|Removed |Added
Status|Failed QA |Needs Signoff
--
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999
Fridolin Somers changed:
What|Removed |Added
Patch complexity|Medium patch|Small patch
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999
--- Comment #123 from Joonas Kylmälä ---
I didn't realize the follow-ups here removed those git merge conflict
resolution hints. It would still probably be better if the conflicts were
solved in the patches they happen. If I review
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999
Joonas Kylmälä changed:
What|Removed |Added
Status|Needs Signoff |Failed QA
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999
Arthur Suzuki changed:
What|Removed |Added
Attachment #112873|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999
--- Comment #120 from Arthur Suzuki ---
Thanks david :)
Patch did no longer apply because one of my other patch actually got into
master, hurray! \o/
Re-posted all patches.
--
You are receiving this mail because:
You are watching
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999
--- Comment #119 from Arthur Suzuki ---
Created attachment 112873
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112873=edit
Bug 11999: (QA follow-up)
--
You are receiving this mail because:
You are watching all
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999
--- Comment #118 from Arthur Suzuki ---
Created attachment 112872
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112872=edit
Bug 11999: Test improvements + check maxreserves
improve t/db_dependent/Reserves.t to
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999
Arthur Suzuki changed:
What|Removed |Added
Attachment #111687|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999
Arthur Suzuki changed:
What|Removed |Added
Status|Patch doesn't apply |Needs Signoff
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999
David Nind changed:
What|Removed |Added
Status|Failed QA |Patch doesn't apply
---
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999
--- Comment #115 from Arthur Suzuki ---
Huuum...
Hi David,
Sorry, can't reproduce, this is what I got.
Can you post verbose log? (in the meantime i'll try to clear those warnings)
root@kohadevbox:koha(bz11999)$ prove
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999
David Nind changed:
What|Removed |Added
Status|Needs Signoff |Failed QA
--- Comment #114
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999
--- Comment #113 from Arthur Suzuki ---
Attached new patches rebased on current master, just in time for KohaCon ;)
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999
--- Comment #111 from Arthur Suzuki ---
Created attachment 111688
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111688=edit
Bug 11999: Test improvements + check maxreserves
improve t/db_dependent/Reserves.t to
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999
--- Comment #112 from Arthur Suzuki ---
Created attachment 111689
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111689=edit
Bug 11999: (QA follow-up)
--
You are receiving this mail because:
You are watching all
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999
Arthur Suzuki changed:
What|Removed |Added
Attachment #99927|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999
Arthur Suzuki changed:
What|Removed |Added
Status|Patch doesn't apply |Needs Signoff
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999
David Nind changed:
What|Removed |Added
Status|Needs Signoff |Patch doesn't apply
---
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999
Nick Clemens changed:
What|Removed |Added
See Also||https://bugs.koha-community
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999
Marcel de Rooy changed:
What|Removed |Added
Status|Needs Signoff |Failed QA
--- Comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999
Arthur Suzuki changed:
What|Removed |Added
Status|Failed QA |Needs Signoff
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999
Arthur Suzuki changed:
What|Removed |Added
Attachment #99928|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999
Arthur Suzuki changed:
What|Removed |Added
Status|Failed QA |Needs Signoff
--- Comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999
--- Comment #107 from Arthur Suzuki ---
Created attachment 106494
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106494=edit
Bug 11999: QA follow-up
--
You are receiving this mail because:
You are watching all
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999
--- Comment #105 from Arthur Suzuki ---
Daag Marcel,
from your comment :
"And what about performance? If you come from CanBook, why would you test it
again and again in CanItem? This check is only needed for the first item?"
No
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999
--- Comment #103 from Arthur Suzuki ---
(In reply to Katrin Fischer from comment #102)
> I agree about the tests, but with all the API work - Doesn't it makes sense
> to centralize all the checks needed instead of repeating (and
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999
--- Comment #102 from Katrin Fischer ---
I agree about the tests, but with all the API work - Doesn't it makes sense to
centralize all the checks needed instead of repeating (and forgetting them) all
over the place? The general idea
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999
Marcel de Rooy changed:
What|Removed |Added
Status|BLOCKED |Failed QA
--- Comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999
Marcel de Rooy changed:
What|Removed |Added
Status|Signed Off |BLOCKED
--- Comment #100
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999
--- Comment #99 from David Nind ---
Hi Arthur. Have tested again, even though it is already signed off now.
Everything works fine, except for the DataTables/Ajax warning. Bug 24769
created for that.
--
You are receiving this mail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999
--- Comment #98 from Arthur Suzuki ---
(In reply to David Nind from comment #94)
> Similar to Bug 17229 you get an error on the patron's page when following
> the test plan (step 2 before patch), but before trying to apply the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999
Arthur Suzuki changed:
What|Removed |Added
Attachment #91593|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999
Arthur Suzuki changed:
What|Removed |Added
Status|Patch doesn't apply |Signed Off
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999
Arthur Suzuki changed:
What|Removed |Added
Attachment #91581|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999
--- Comment #95 from Arthur Suzuki ---
Just realized Age Restriction issue has been fixed in BZ13113.
Will re-post patches and change tests accordingly.
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999
--- Comment #94 from David Nind ---
Similar to Bug 17229 you get an error on the patron's page when following the
test plan (step 2 before patch), but before trying to apply the patch:
1) For the patron, the holds tab heading shows
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999
David Nind changed:
What|Removed |Added
Status|Needs Signoff |Patch doesn't apply
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999
Katrin Fischer changed:
What|Removed |Added
Blocks||11641
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999
Arthur Suzuki changed:
What|Removed |Added
Attachment #91580|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999
Arthur Suzuki changed:
What|Removed |Added
Status|Failed QA |Needs Signoff
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999
Arthur Suzuki changed:
What|Removed |Added
Attachment #91590|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999
--- Comment #90 from Arthur Suzuki ---
Created attachment 91591
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91591=edit
Bug 11999: Add maxreserves check in CanBookBeReserved and CanItemBeReserved
- Check if
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999
Arthur Suzuki changed:
What|Removed |Added
Attachment #91582|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999
--- Comment #88 from Arthur Suzuki ---
Created attachment 91582
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91582=edit
Bug 11999: Test improvements
improve t/db_dependent/Reserves.t to make tests pass on
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999
--- Comment #87 from Arthur Suzuki ---
Created attachment 91581
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91581=edit
Bug 11999: Check for age restriction in CanBookBeReserved
--
You are receiving this mail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999
Arthur Suzuki changed:
What|Removed |Added
Attachment #90143|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999
Nick Clemens changed:
What|Removed |Added
Status|Patch doesn't apply |Failed QA
--- Comment #85
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999
--- Comment #84 from Arthur Suzuki ---
(In reply to Nick Clemens from comment #82)
> I think you need to obsolete some of these, not sure why one followup is
> 18.11?
Indeed... that one was to prepare backporting to 18.11.
--
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999
Arthur Suzuki changed:
What|Removed |Added
Attachment #91481|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999
Nick Clemens changed:
What|Removed |Added
Status|Needs Signoff |Patch doesn't apply
---
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999
Arthur Suzuki changed:
What|Removed |Added
Attachment #91402|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999
Arthur Suzuki changed:
What|Removed |Added
Status|Failed QA |Needs Signoff
Patch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999
Arthur Suzuki changed:
What|Removed |Added
Attachment #90146|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999
--- Comment #79 from Fridolin SOMERS ---
I see test "alreadyReserved" on same biblio still exists inCanBookBeReserved.
It should be removed says "Remove 'alreadyReserved' check in
CanBookBeReserved".
--
You are receiving this
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999
--- Comment #78 from Arthur Suzuki ---
Created attachment 91403
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91403=edit
Bug 11999: QA follow-up [18.11]
--
You are receiving this mail because:
You are watching
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999
Arthur Suzuki changed:
What|Removed |Added
Attachment #91046|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999
--- Comment #76 from Fridolin SOMERS ---
Arg there are conflict signes in patches :
+<<< HEAD
CanItemBeReserved( $borrowernumbers[0], $itemnumber)->{status},
'tooManyReserves',
+===
+CanItemBeReserved(
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999
--- Comment #75 from Arthur Suzuki ---
Created attachment 91046
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91046=edit
Bug 11999: QA follow-up
--
You are receiving this mail because:
You are watching all bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999
Marcel de Rooy changed:
What|Removed |Added
Status|Signed Off |Failed QA
--- Comment #74
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999
Katrin Fischer changed:
What|Removed |Added
Status|Failed QA |Signed Off
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999
Katrin Fischer changed:
What|Removed |Added
Status|Pushed for QA |Failed QA
--- Comment #73
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999
Arthur Suzuki changed:
What|Removed |Added
Status|Failed QA |Pushed for QA
--- Comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999
Arthur Suzuki changed:
What|Removed |Added
Attachment #88303|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999
Arthur Suzuki changed:
What|Removed |Added
Attachment #88302|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999
Arthur Suzuki changed:
What|Removed |Added
Attachment #90142|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999
Arthur Suzuki changed:
What|Removed |Added
Attachment #88301|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999
Arthur Suzuki changed:
What|Removed |Added
Attachment #88300|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999
Magnus Enger changed:
What|Removed |Added
Status|Needs Signoff |Failed QA
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999
Michal Denar changed:
What|Removed |Added
CC||blac...@gmail.com
--
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999
Arthur Suzuki changed:
What|Removed |Added
Status|Failed QA |Needs Signoff
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999
Arthur Suzuki changed:
What|Removed |Added
Attachment #66270|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999
Arthur Suzuki changed:
What|Removed |Added
Attachment #66269|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999
Arthur Suzuki changed:
What|Removed |Added
Attachment #66268|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999
Arthur Suzuki changed:
What|Removed |Added
Attachment #66267|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999
Katrin Fischer changed:
What|Removed |Added
See Also|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999
Arthur Suzuki changed:
What|Removed |Added
CC||arthur.suz...@biblibre.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999
Fridolin SOMERS changed:
What|Removed |Added
See Also|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999
--- Comment #60 from Fridolin SOMERS ---
(In reply to Fridolin SOMERS from comment #59)
> Looks like CanBookBeReserved may be called with undef biblionumber : when at
> intranet clicking on holds tab of
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999
Fridolin SOMERS changed:
What|Removed |Added
Depends on|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999
--- Comment #59 from Fridolin SOMERS ---
Looks like CanBookBeReserved may be called with undef biblionumber : when at
intranet clicking on holds tab of a record.
This generates error :
Can't call
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999
Josef Moravec changed:
What|Removed |Added
Status|Needs Signoff
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999
Julian Maurice changed:
What|Removed |Added
Status|Failed QA
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999
--- Comment #56 from Julian Maurice ---
Created attachment 66270
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66270=edit
Bug 11999: Remove the "biblio already reserved" check in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999
Julian Maurice changed:
What|Removed |Added
Attachment #63595|0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999
Julian Maurice changed:
What|Removed |Added
Attachment #63594|0
1 - 100 of 179 matches
Mail list logo