https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532
Blou changed:
What|Removed |Added
Summary|Copy guarantee email to |Redirect guarantee email to
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532
Martin Renvoize changed:
What|Removed |Added
Status|Signed Off |Passed QA
--- Comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532
--- Comment #164 from Martin Renvoize ---
Created attachment 155946
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155946=edit
Bug 12532: (follow-up) Catch more cases in tests
This patch added lots more cases to
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532
Martin Renvoize changed:
What|Removed |Added
Attachment #155886|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532
Martin Renvoize changed:
What|Removed |Added
Attachment #155883|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532
Martin Renvoize changed:
What|Removed |Added
Attachment #155882|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532
Martin Renvoize changed:
What|Removed |Added
Attachment #155881|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532
Martin Renvoize changed:
What|Removed |Added
Attachment #155880|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532
Martin Renvoize changed:
What|Removed |Added
Attachment #155879|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532
Martin Renvoize changed:
What|Removed |Added
Attachment #155878|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532
Martin Renvoize changed:
What|Removed |Added
Attachment #155877|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532
Martin Renvoize changed:
What|Removed |Added
Attachment #155876|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532
Martin Renvoize changed:
What|Removed |Added
Attachment #155875|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532
Martin Renvoize changed:
What|Removed |Added
Attachment #155874|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532
Martin Renvoize changed:
What|Removed |Added
Attachment #155873|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532
--- Comment #151 from Martin Renvoize ---
Thanks for the follow-up Jonathan. Me being code blind it seems
--
You are receiving this mail because:
You are watching all bug changes.
___
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532
--- Comment #150 from Jonathan Druart ---
Created attachment 155886
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155886=edit
Bug 12532: Fix test
The mock was working. The problem was that the to_address of the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532
--- Comment #149 from Martin Renvoize ---
I think we're pretty much there now.. however I can't get that darn test to
pass.. for some reason the second mock of the new preference doesn't want to
take effect in this case so testing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532
Martin Renvoize changed:
What|Removed |Added
Attachment #155837|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532
Martin Renvoize changed:
What|Removed |Added
Attachment #155836|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532
--- Comment #146 from Martin Renvoize ---
Created attachment 155881
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155881=edit
Bug 12532: Expose CC address in patron notices display
Add the CC address into the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532
Martin Renvoize changed:
What|Removed |Added
Attachment #155835|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532
Martin Renvoize changed:
What|Removed |Added
Attachment #155834|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532
Martin Renvoize changed:
What|Removed |Added
Attachment #155833|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532
Martin Renvoize changed:
What|Removed |Added
Attachment #155832|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532
Martin Renvoize changed:
What|Removed |Added
Attachment #155831|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532
Martin Renvoize changed:
What|Removed |Added
Attachment #155830|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532
Martin Renvoize changed:
What|Removed |Added
Attachment #155829|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532
Martin Renvoize changed:
What|Removed |Added
Attachment #155828|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532
--- Comment #137 from Martin Renvoize ---
Still got a tiny bit to finnish up here to get over the qa line.. I'll continue
tommorow.
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532
--- Comment #136 from Martin Renvoize ---
Created attachment 155837
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155837=edit
Bug 12532: (QA follow-up) Fix issues highlighted by unit tests
* YesNo preferences
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532
--- Comment #135 from Martin Renvoize ---
Created attachment 155836
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155836=edit
Bug 12532: DBIC Schema
--
You are receiving this mail because:
You are watching all
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532
--- Comment #134 from Martin Renvoize ---
Created attachment 155835
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155835=edit
Bug 12532: (QA follow-up) Add cc_address to message_queue
Add the cc_address field to
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532
--- Comment #133 from Martin Renvoize ---
Created attachment 155834
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155834=edit
Bug 12532: (QA follow-up) Add tests for SendQueuedMessages
This patch adds unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532
--- Comment #132 from Martin Renvoize ---
Created attachment 155833
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155833=edit
Bug 12532: (QA follow-up) Remove defunkt test
Signed-off-by: Martin Renvoize
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532
--- Comment #131 from Martin Renvoize ---
Created attachment 155832
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155832=edit
Bug 12532: (QA follow-up) More cleanup
Minor QA cleanup, perltidy, remove
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532
Martin Renvoize changed:
What|Removed |Added
Attachment #154857|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532
Martin Renvoize changed:
What|Removed |Added
Attachment #154856|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532
Martin Renvoize changed:
What|Removed |Added
Attachment #154855|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532
Martin Renvoize changed:
What|Removed |Added
Attachment #154854|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532
Ilona R changed:
What|Removed |Added
CC||hatt...@gmail.com
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532
Hammat wele changed:
What|Removed |Added
Attachment #155037|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532
Hammat wele changed:
What|Removed |Added
Attachment #155036|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532
--- Comment #126 from Hammat wele ---
Created attachment 155037
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155037=edit
Bug 21272: Unit test
--
You are receiving this mail because:
You are watching all bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532
--- Comment #125 from Hammat wele ---
Created attachment 155036
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155036=edit
Bug 21272: MARC import should warn about mis-matched branch and item-type
fields in 952
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532
--- Comment #124 from Hammat wele ---
Created attachment 154857
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154857=edit
Bug 12532: (follow-up) Send email to guarantor using the CC field
In This patch the CC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532
Hammat wele changed:
What|Removed |Added
Attachment #151029|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532
Hammat wele changed:
What|Removed |Added
Attachment #151028|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532
Hammat wele changed:
What|Removed |Added
Attachment #150256|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532
--- Comment #120 from Hammat wele ---
(In reply to Martin Renvoize from comment #116)
> Sorry, I also meant to say I think the guarantor email should go in the cc
> field rather than to field (unless the to field is empty in which
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532
Bug 12532 depends on bug 33223, which changed state.
Bug 33223 Summary: Koha::Patron->notice_email_address isn't consistently used
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33223
What|Removed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532
Eric Bégin changed:
What|Removed |Added
CC|bouzid.ferg...@gmail.com, |
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532
--- Comment #119 from Blou ---
Hello Martin,
Thanks for the feedbacks AND the corrections. Now, as to your latest inquiry,
I'm not the one who will answer it. But I'll give perspective.
This has been coded about 10 years ago.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532
Martin Renvoize changed:
What|Removed |Added
See Also|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532
--- Comment #118 from Martin Renvoize ---
I agree Marcel.. It was late last night.
So.. In short, I'd like some explanations from the original author as to why
they picked the changes they did.. I still don't understand a number of
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532
--- Comment #117 from Marcel de Rooy ---
(In reply to Martin Renvoize from comment #115)
> I'm not so sure that we're hooking this into the right place.. I'm wondering
> if it may be better placed in Koha::Email->create..
I would
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532
--- Comment #116 from Martin Renvoize ---
Sorry, I also meant to say I think the guarantor email should go in the cc
field rather than to field (unless the to field is empty in which case just put
guarantor in to). This complicates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532
Martin Renvoize changed:
What|Removed |Added
Status|Failed QA |Signed Off
--- Comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532
--- Comment #114 from Martin Renvoize ---
Created attachment 151029
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151029=edit
Bug 12532: (QA follow-up) Clean up notice_email_address
Reduce some of the code
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532
--- Comment #113 from Martin Renvoize ---
Created attachment 151028
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151028=edit
Bug 12532: (QA follow-up) Undo changes to Koha::Email
The changes here aren't
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532
--- Comment #112 from Martin Renvoize ---
Working on fixes and will PQA with follow-ups.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532
--- Comment #111 from Martin Renvoize ---
Comment on attachment 150256
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150256
Bug 12532: Send email to guarantee and guarantor
Review of attachment 150256:
-->
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532
Martin Renvoize changed:
What|Removed |Added
Status|Signed Off |Failed QA
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532
--- Comment #110 from Martin Renvoize ---
Comment on attachment 150256
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150256
Bug 12532: Send email to guarantee and guarantor
Review of attachment 150256:
-->
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532
Martin Renvoize changed:
What|Removed |Added
Depends on||33223
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532
Martin Renvoize changed:
What|Removed |Added
QA Contact|testo...@bugs.koha-communit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532
--- Comment #109 from Martin Renvoize ---
Looking here..
I think it you want to make sure you're catching all locations you need to
depend on bug 33223 which systematically goes through the codebase making sure
we use
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532
Martin Renvoize changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532
Hammat wele changed:
What|Removed |Added
Assignee|charles.far...@inlibro.com |hammat.w...@inlibro.com
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532
--- Comment #108 from David Nind ---
(In reply to Hammat wele from comment #106)
> (In reply to David Nind from comment #104)
> > However, the tests fail (even though that wasn't included in the test plan)
> > - they passed before
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532
David Nind changed:
What|Removed |Added
Attachment #150240|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532
David Nind changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532
Hammat wele changed:
What|Removed |Added
Status|Failed QA |Needs Signoff
--- Comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532
--- Comment #105 from Hammat wele ---
Created attachment 150240
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150240=edit
Bug 12532: Send email to guarantee and guarantor
This patch allows guarantors to receive
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532
Hammat wele changed:
What|Removed |Added
Attachment #150217|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532
David Nind changed:
What|Removed |Added
Status|Needs Signoff |Failed QA
--- Comment #104
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532
Hammat wele changed:
What|Removed |Added
Status|Patch doesn't apply |Needs Signoff
--- Comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532
Hammat wele changed:
What|Removed |Added
Attachment #150208|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532
David Nind changed:
What|Removed |Added
Status|Needs Signoff |Patch doesn't apply
---
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532
Hammat wele changed:
What|Removed |Added
Status|Failed QA |Needs Signoff
--- Comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532
--- Comment #99 from Hammat wele ---
Created attachment 150208
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150208=edit
Bug 12532: Send email to guarantee and guarantor
This patch allows guarantors to receive
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532
Hammat wele changed:
What|Removed |Added
Attachment #150071|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532
Hammat wele changed:
What|Removed |Added
Attachment #131093|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532
Hammat wele changed:
What|Removed |Added
Attachment #131092|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532
Hammat wele changed:
What|Removed |Added
CC||hammat.w...@inlibro.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532
Marius changed:
What|Removed |Added
Attachment #149233|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532
Marius changed:
What|Removed |Added
Attachment #149233|1 |0
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532
Marius changed:
What|Removed |Added
CC||marius.mandre...@inlibro.co
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532
David Nind changed:
What|Removed |Added
Status|Signed Off |Failed QA
--- Comment #97
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532
Marius changed:
What|Removed |Added
Attachment #131094|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532
Marius changed:
What|Removed |Added
Status|Failed QA |Signed Off
--
You are receiving
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532
Laura Escamilla changed:
What|Removed |Added
Status|Needs Signoff |Failed QA
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532
The Minh Luong changed:
What|Removed |Added
Status|Patch doesn't apply |Needs Signoff
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532
The Minh Luong changed:
What|Removed |Added
CC||the-minh.lu...@inlibro.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532
--- Comment #94 from The Minh Luong ---
Created attachment 131094
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131094=edit
Bug 12532: Send email to guarantee and guarantor;
This patch allows guarantors to
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532
The Minh Luong changed:
What|Removed |Added
Attachment #114461|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532
The Minh Luong changed:
What|Removed |Added
Attachment #114459|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532
The Minh Luong changed:
What|Removed |Added
Attachment #114458|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532
David Nind changed:
What|Removed |Added
Status|Needs Signoff |Patch doesn't apply
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532
Alexis Ripetti changed:
What|Removed |Added
Attachment #114457|0 |1
is obsolete|
1 - 100 of 229 matches
Mail list logo
