[Koha-bugs] [Bug 12702] Suggestions still accessible in OPAC when deactivated

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12702 Chris Cormack changed: What|Removed |Added Keywords|Academy | -- You are receiving this

[Koha-bugs] [Bug 12702] Suggestions still accessible in OPAC when deactivated

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12702 Chris Cormack changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable --- Comment

[Koha-bugs] [Bug 12702] Suggestions still accessible in OPAC when deactivated

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12702 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com

[Koha-bugs] [Bug 12702] Suggestions still accessible in OPAC when deactivated

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12702 --- Comment #12 from Martin Renvoize --- Agreed, not a blocker here.. it's not your job to go cleaning the code up.. this was more just a comment trying to get anyone that sees it to think a bit more when implementing such code in the

[Koha-bugs] [Bug 12702] Suggestions still accessible in OPAC when deactivated

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12702 Katrin Fischer changed: What|Removed |Added Attachment #35175|0 |1 is obsolete|

[Koha-bugs] [Bug 12702] Suggestions still accessible in OPAC when deactivated

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12702 Katrin Fischer changed: What|Removed |Added Patch complexity|--- |Small patch Sta

[Koha-bugs] [Bug 12702] Suggestions still accessible in OPAC when deactivated

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12702 --- Comment #10 from Katrin Fischer --- I think not a blocker for your patch - just some thoughts about how we could handle things better. -- You are receiving this mail because: You are watching all bug changes. ___

[Koha-bugs] [Bug 12702] Suggestions still accessible in OPAC when deactivated

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12702 --- Comment #9 from Thomas Wright --- (In reply to Martin Renvoize from comment #8) > OK, I'm happy with the logic here. I had to go digging a little to prove to > mysefl that the assumption was valid. (Lines 530 -> 539 in commit >

[Koha-bugs] [Bug 12702] Suggestions still accessible in OPAC when deactivated

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12702 --- Comment #8 from Martin Renvoize --- OK, I'm happy with the logic here. I had to go digging a little to prove to mysefl that the assumption was valid. (Lines 530 -> 539 in commit http://git.koha-community.org/gitweb/?p=koha.git;a

[Koha-bugs] [Bug 12702] Suggestions still accessible in OPAC when deactivated

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12702 Martin Renvoize changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are rec

[Koha-bugs] [Bug 12702] Suggestions still accessible in OPAC when deactivated

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12702 Martin Renvoize changed: What|Removed |Added Attachment #35171|0 |1 is obsolete|

[Koha-bugs] [Bug 12702] Suggestions still accessible in OPAC when deactivated

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12702 Martin Renvoize changed: What|Removed |Added Attachment #35175|Bug 12702 - Suggestions |[SIGNED OFF] Bug 12702 -

[Koha-bugs] [Bug 12702] Suggestions still accessible in OPAC when deactivated

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12702 --- Comment #6 from Thomas Wright --- Test Plan: -Set preference 'suggestion' to 'Don't Allow'. Navigate to .../cgi-bin/koha/opac-suggestions.pl *You should be presented with a 404 error. This is the case even if 'AnonSuggestions' ar

[Koha-bugs] [Bug 12702] Suggestions still accessible in OPAC when deactivated

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12702 Thomas Wright changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are re

[Koha-bugs] [Bug 12702] Suggestions still accessible in OPAC when deactivated

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12702 --- Comment #5 from Thomas Wright --- Created attachment 35171 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35171&action=edit Bug 12702 - Suggestions still accessible in OPAC when deactivated Added check for sugge

[Koha-bugs] [Bug 12702] Suggestions still accessible in OPAC when deactivated

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12702 Thomas Wright changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receivi

[Koha-bugs] [Bug 12702] Suggestions still accessible in OPAC when deactivated

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12702 Justin Vos changed: What|Removed |Added CC||justin...@live.com

[Koha-bugs] [Bug 12702] Suggestions still accessible in OPAC when deactivated

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12702 Thomas Wright changed: What|Removed |Added Status|NEW |ASSIGNED CC|

[Koha-bugs] [Bug 12702] Suggestions still accessible in OPAC when deactivated

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12702 Chris Cormack changed: What|Removed |Added Keywords||Academy -- You are receivin

[Koha-bugs] [Bug 12702] Suggestions still accessible in OPAC when deactivated

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12702 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe

[Koha-bugs] [Bug 12702] Suggestions still accessible in OPAC when deactivated

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12702 Chris Cormack changed: What|Removed |Added CC||ch...@bigballofwax.co.nz --

[Koha-bugs] [Bug 12702] Suggestions still accessible in OPAC when deactivated

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12702 --- Comment #3 from Marc Véron --- Maybe something for the Catalyst Open Source Academy... (Starting today) -- You are receiving this mail because: You are watching all bug changes. ___ Ko

[Koha-bugs] [Bug 12702] Suggestions still accessible in OPAC when deactivated

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12702 --- Comment #2 from Marc Véron --- Pattern for solution in Bug 10595 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.ko

[Koha-bugs] [Bug 12702] Suggestions still accessible in OPAC when deactivated

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12702 --- Comment #1 from Marc Véron --- Confirmed. With both Sysprefs AnonSuggestions and suggestion turned off, I was redirected to the login page and after login the page "Your purchase suggestions" displayed. I could even put a suggest

[Koha-bugs] [Bug 12702] Suggestions still accessible in OPAC when deactivated

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12702 Marjorie Barry-Vila changed: What|Removed |Added CC||marjorie.barry-v...@ccs

[Koha-bugs] [Bug 12702] Suggestions still accessible in OPAC when deactivated

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12702 Marc Véron changed: What|Removed |Added CC||ve...@veron.ch -- You are rece