http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13215
Jonathan Druart changed:
What|Removed |Added
Status|NEW |ASSIGNED
Depends o
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13215
Jonathan Druart changed:
What|Removed |Added
Status|ASSIGNED|Needs Signoff
--
You are
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13215
--- Comment #1 from Jonathan Druart ---
Created attachment 33316
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33316&action=edit
Bug 13215: The same letter code can be used for several libraries
This patch fixes a
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13215
--- Comment #2 from Jonathan Druart ---
(In reply to Jonathan Druart from comment #1)
> The patches submitted on bug 11742 tried to fix an issue based on a
> (very) assertion: letter.code should be considered as a primary key and
> sh
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13215
Tomás Cohen Arazi changed:
What|Removed |Added
Keywords||rel_3_18_candidate
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13215
M. Tompsett changed:
What|Removed |Added
CC||mtomp...@hotmail.com
--- Comme
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13215
Katrin Fischer changed:
What|Removed |Added
CC||katrin.fisc...@bsz-bw.de
--
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13215
--- Comment #5 from M. Tompsett ---
(In reply to Katrin Fischer from comment #4)
> I am not sure how the discussion on bug 8753 relates to this patch - I think
> the point there was to not have SQL in the .pl files?
So, SQL in .pm fi
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13215
--- Comment #6 from Tomás Cohen Arazi ---
(In reply to M. Tompsett from comment #5)
> (In reply to Katrin Fischer from comment #4)
> > I am not sure how the discussion on bug 8753 relates to this patch - I think
> > the point there wa
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13215
--- Comment #7 from M. Tompsett ---
(In reply to Katrin Fischer from comment #4)
> This seems like a major
> improvement of the code in terms of coding guidelines.
It is. I'm not critiquing that. Frankly, the code is beautiful.
> A
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13215
--- Comment #8 from Jonathan Druart ---
This is a quite sensitive bug and need to be fixed before the release.
Since we don't have a clear and documented way to use DBIC in our Koha
namespace, I preferred to use the old-way: C4 and DB
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13215
--- Comment #9 from M. Tompsett ---
Comment on attachment 33316
--> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33316
Bug 13215: The same letter code can be used for several libraries
Review of attachment 33316:
-->
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13215
--- Comment #10 from Jonathan Druart ---
(In reply to M. Tompsett from comment #9)
> Comment on attachment 33316 [details] [review]
> Bug 13215: The same letter code can be used for several libraries
> Does SQL9 rule apply?
Not sure
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13215
Katrin Fischer changed:
What|Removed |Added
Severity|major |critical
--
You are receiv
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13215
Chris Cormack changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--
You are recei
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13215
Chris Cormack changed:
What|Removed |Added
Attachment #33316|0 |1
is obsolete|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13215
--- Comment #12 from Katrin Fischer ---
Only got as far as running all the tests this morning - they all pass. We need
this urgently, but it needs good testing. If someone has time, please help out.
--
You are receiving this mail be
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13215
--- Comment #13 from Jonathan Druart ---
(In reply to Katrin Fischer from comment #12)
> Only got as far as running all the tests this morning - they all pass. We
> need this urgently, but it needs good testing. If someone has time, p
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13215
Katrin Fischer changed:
What|Removed |Added
Status|Signed Off |Failed QA
--- Comment #14 f
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13215
--- Comment #16 from Jonathan Druart ---
Created attachment 33773
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33773&action=edit
Bug 13215: Fix notice deletion
This patch could have only been
-name => $val
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13215
Jonathan Druart changed:
What|Removed |Added
Status|Failed QA |Signed Off
--
You are rec
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13215
--- Comment #15 from Jonathan Druart ---
Created attachment 33772
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33772&action=edit
Bug 13215: Fix notice edition
C4::Letters::getletter does not set mtt in value ( i.e
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13215
Kyle M Hall changed:
What|Removed |Added
Status|Signed Off |Failed QA
CC|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13215
--- Comment #18 from Jonathan Druart ---
Created attachment 33788
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33788&action=edit
Bug 13215: (follow-up) Fix notice edition
--
You are receiving this mail because:
Y
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13215
Jonathan Druart changed:
What|Removed |Added
Status|Failed QA |Needs Signoff
--
You are
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13215
--- Comment #19 from Jonathan Druart ---
(In reply to Kyle M Hall from comment #17)
> * I can't copy a notice from default to a branch.
Should be fixed now.
> * As Katrin stated, code on a copy is not editable. Is this a bug?
No, i
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13215
--- Comment #20 from Katrin Fischer ---
I agree, first of all we need to fix the main problem.
2 thoughts about editing the code of a notice, though those should maybe go on
a separate bug report later:
- In master it's currently po
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13215
Marc Véron changed:
What|Removed |Added
CC||ve...@veron.ch
--- Comment #21
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13215
Jonathan Druart changed:
What|Removed |Added
Status|Needs Signoff |ASSIGNED
--
You are recei
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13215
Jonathan Druart changed:
What|Removed |Added
Status|ASSIGNED|Needs Signoff
--
You are
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13215
--- Comment #22 from Jonathan Druart ---
Created attachment 33909
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33909&action=edit
Bug 13215: Fix GetLetterTemplates should return default templates if branchcode
is no
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13215
--- Comment #23 from Jonathan Druart ---
(In reply to Marc Véron from comment #21)
> I have the following issue:
Thanks for testing Marc.
That should be fixed now.
--
You are receiving this mail because:
You are watching all bug ch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13215
Chris Cormack changed:
What|Removed |Added
Attachment #33637|0 |1
is obsolete|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13215
Chris Cormack changed:
What|Removed |Added
Attachment #33788|0 |1
is obsolete|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13215
Chris Cormack changed:
What|Removed |Added
Attachment #33773|0 |1
is obsolete|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13215
Chris Cormack changed:
What|Removed |Added
Attachment #33909|0 |1
is obsolete|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13215
Chris Cormack changed:
What|Removed |Added
Attachment #33772|0 |1
is obsolete|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13215
Chris Cormack changed:
What|Removed |Added
Attachment #33934|0 |1
is obsolete|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13215
Chris Cormack changed:
What|Removed |Added
Attachment #33931|0 |1
is obsolete|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13215
Chris Cormack changed:
What|Removed |Added
Attachment #33930|0 |1
is obsolete|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13215
Chris Cormack changed:
What|Removed |Added
Attachment #33933|0 |1
is obsolete|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13215
Chris Cormack changed:
What|Removed |Added
Attachment #33932|0 |1
is obsolete|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13215
Chris Cormack changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
C
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13215
--- Comment #34 from Katrin Fischer ---
I have started testing again, these seem to work alright for me:
- Copying a notice to another branch
Note: You can not copy to 'default' only to a real library.
This is the behaviour
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13215
--- Comment #35 from Katrin Fischer ---
Overdue notice triggers
- Default: shows only default notices
- Library: shows default and library specific notices.
If there are 2 notices with the same code, the library specific is shown.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13215
--- Comment #38 from Katrin Fischer ---
Created attachment 33973
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33973&action=edit
[PASSED QA] Bug 13215: Fix notice deletion
This patch could have only been
-n
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13215
--- Comment #37 from Katrin Fischer ---
Created attachment 33972
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33972&action=edit
[PASSED QA] Bug 13215: Fix notice edition
C4::Letters::getletter does not set mtt in
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13215
--- Comment #40 from Katrin Fischer ---
Created attachment 33975
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33975&action=edit
[PASSED QA] Bug 13215: Fix GetLetterTemplates should return default templates
if branc
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13215
--- Comment #36 from Katrin Fischer ---
Created attachment 33971
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33971&action=edit
[PASSED QA] Bug 13215: The same letter code can be used for several libraries
This pa
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13215
Katrin Fischer changed:
What|Removed |Added
Status|Signed Off |Passed QA
--
You are recei
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13215
--- Comment #39 from Katrin Fischer ---
Created attachment 33974
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33974&action=edit
[PASSED QA] Bug 13215: (follow-up) Fix notice edition
Signed-off-by: Chris Cormack
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13215
Katrin Fischer changed:
What|Removed |Added
Attachment #33937|0 |1
is obsolete|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13215
Katrin Fischer changed:
What|Removed |Added
Attachment #33939|0 |1
is obsolete|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13215
Katrin Fischer changed:
What|Removed |Added
Attachment #33938|0 |1
is obsolete|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13215
Katrin Fischer changed:
What|Removed |Added
Attachment #33935|0 |1
is obsolete|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13215
Katrin Fischer changed:
What|Removed |Added
Attachment #33936|0 |1
is obsolete|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13215
--- Comment #41 from Katrin Fischer ---
(In reply to Katrin Fischer from comment #35)
> Overdue notice triggers
> - Default: shows only default notices
> - Library: shows default and library specific notices.
> If there are 2 notice
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13215
--- Comment #42 from Jonathan Druart ---
(In reply to Katrin Fischer from comment #35)
> Acq and serial claims
> - Only shows default notice, if there are 2 of the same code. (ACQCLAIM)
> - Only shows branch specific if the code is u
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13215
Jonathan Druart changed:
What|Removed |Added
Attachment #33975|0 |1
is obsolete|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13215
--- Comment #44 from Jonathan Druart ---
(In reply to Jonathan Druart from comment #43)
> Created attachment 33995 [details] [review]
> Bug 13215: Fix GetLetterTemplates should return default templates if
> branchcode is not defined
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13215
Tomás Cohen Arazi changed:
What|Removed |Added
Status|Passed QA |Pushed to Master
--- Com
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13215
Katrin Fischer changed:
What|Removed |Added
See Also||http://bugs.koha-community.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13215
Barton Chittenden changed:
What|Removed |Added
See Also||http://bugs.koha-communit
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13215
Barton Chittenden changed:
What|Removed |Added
See Also||http://bugs.koha-communit
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13215
Barton Chittenden changed:
What|Removed |Added
See Also||http://bugs.koha-communit
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13215
Heather Braum changed:
What|Removed |Added
CC||hbr...@nekls.org
--
You are
66 matches
Mail list logo
