[Koha-bugs] [Bug 13600] XSLT: 8xx not showing if there is no 4xx

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13600 Phil Ringnalda changed: What|Removed |Added CC||1joynel...@gmail.com ---

[Koha-bugs] [Bug 13600] XSLT: 8xx not showing if there is no 4xx

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13600 --- Comment #49 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___

[Koha-bugs] [Bug 13600] XSLT: 8xx not showing if there is no 4xx

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13600 Tomás Cohen Arazi changed: What|Removed |Added Version(s)||22.11.00

[Koha-bugs] [Bug 13600] XSLT: 8xx not showing if there is no 4xx

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13600 --- Comment #48 from Tomás Cohen Arazi --- Created attachment 143568 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143568=edit Bug 13600: (follow-up) Add seperator on the OPAC Signed-off-by: Tomas Cohen Arazi

[Koha-bugs] [Bug 13600] XSLT: 8xx not showing if there is no 4xx

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13600 --- Comment #47 from Tomás Cohen Arazi --- Created attachment 143567 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143567=edit Bug 13600: (follow-up) Add separator between different series fields This patch

[Koha-bugs] [Bug 13600] XSLT: 8xx not showing if there is no 4xx

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13600 --- Comment #46 from Tomás Cohen Arazi --- Created attachment 143566 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143566=edit Bug 13600: XSLT - 8xx not showing if there is no 4xx This patch adjusts XSLT so that

[Koha-bugs] [Bug 13600] XSLT: 8xx not showing if there is no 4xx

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13600 Tomás Cohen Arazi changed: What|Removed |Added Attachment #143069|0 |1 is obsolete|

[Koha-bugs] [Bug 13600] XSLT: 8xx not showing if there is no 4xx

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13600 Tomás Cohen Arazi changed: What|Removed |Added Attachment #142589|0 |1 is obsolete|

[Koha-bugs] [Bug 13600] XSLT: 8xx not showing if there is no 4xx

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13600 Tomás Cohen Arazi changed: What|Removed |Added Attachment #142588|0 |1 is obsolete|

[Koha-bugs] [Bug 13600] XSLT: 8xx not showing if there is no 4xx

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13600 Tomás Cohen Arazi changed: What|Removed |Added Status|Signed Off |Passed QA -- You are

[Koha-bugs] [Bug 13600] XSLT: 8xx not showing if there is no 4xx

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13600 Tomás Cohen Arazi changed: What|Removed |Added Keywords||rel_22_11_candidate --

[Koha-bugs] [Bug 13600] XSLT: 8xx not showing if there is no 4xx

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13600 --- Comment #45 from Nick Clemens --- Created attachment 143069 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143069=edit Bug 13600: (follow-up) Add seperator on the OPAC -- You are receiving this mail because:

[Koha-bugs] [Bug 13600] XSLT: 8xx not showing if there is no 4xx

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13600 --- Comment #44 from Katrin Fischer --- Do we need the separator (last patch) for the OPAC too? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs

[Koha-bugs] [Bug 13600] XSLT: 8xx not showing if there is no 4xx

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13600 --- Comment #43 from David Nind --- Have signed off based on the follow-up, and that semicolons will be addressed in another bug. Thanks Heather for your great comments! -- You are receiving this mail because: You are watching

[Koha-bugs] [Bug 13600] XSLT: 8xx not showing if there is no 4xx

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13600 David Nind changed: What|Removed |Added Attachment #142530|0 |1 is obsolete|

[Koha-bugs] [Bug 13600] XSLT: 8xx not showing if there is no 4xx

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13600 David Nind changed: What|Removed |Added Attachment #140705|0 |1 is obsolete|

[Koha-bugs] [Bug 13600] XSLT: 8xx not showing if there is no 4xx

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13600 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are

[Koha-bugs] [Bug 13600] XSLT: 8xx not showing if there is no 4xx

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13600 --- Comment #40 from Nick Clemens --- I fixed the issue with separators by checking ahead for upcoming series tags The semicolons should be handled on a new bug as we supposedly strip punctuation, then add it back, but it doesn't

[Koha-bugs] [Bug 13600] XSLT: 8xx not showing if there is no 4xx

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13600 --- Comment #39 from Nick Clemens --- Created attachment 142530 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142530=edit Bug 13600: (follow-up) Add separator between different series fields This patch checks

[Koha-bugs] [Bug 13600] XSLT: 8xx not showing if there is no 4xx

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13600 --- Comment #38 from Heather --- Here's some Cataloger Opinions on Punctuation (in case it's helpful!): I looked at the sample records--lots of fields seem to be missing required indicators, but I guess that doesn't affect this?

[Koha-bugs] [Bug 13600] XSLT: 8xx not showing if there is no 4xx

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13600 --- Comment #37 from Katrin Fischer --- Tested with some of our records and no regressions found (display before and after the patch is applied are the same). It looks like there might be some punctuation issues unrelated to the

[Koha-bugs] [Bug 13600] XSLT: 8xx not showing if there is no 4xx

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13600 David Nind changed: What|Removed |Added CC||da...@davidnind.com ---

[Koha-bugs] [Bug 13600] XSLT: 8xx not showing if there is no 4xx

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13600 Nick Clemens changed: What|Removed |Added Assignee|wsale...@gmail.com |n...@bywatersolutions.com

[Koha-bugs] [Bug 13600] XSLT: 8xx not showing if there is no 4xx

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13600 --- Comment #35 from Nick Clemens --- Created attachment 140706 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140706=edit Different records with different series statments Import this file - search for 'this is

[Koha-bugs] [Bug 13600] XSLT: 8xx not showing if there is no 4xx

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13600 Nick Clemens changed: What|Removed |Added Attachment #40637|0 |1 is obsolete|

[Koha-bugs] [Bug 13600] XSLT: 8xx not showing if there is no 4xx

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13600 Nick Clemens changed: What|Removed |Added Status|Failed QA |Needs Signoff Patch

[Koha-bugs] [Bug 13600] XSLT: 8xx not showing if there is no 4xx

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13600 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au ---

[Koha-bugs] [Bug 13600] XSLT: 8xx not showing if there is no 4xx

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13600 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com

[Koha-bugs] [Bug 13600] XSLT: 8xx not showing if there is no 4xx

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13600 Nicole C. Engard changed: What|Removed |Added CC|

[Koha-bugs] [Bug 13600] XSLT: 8xx not showing if there is no 4xx

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13600 Nicole C. Engard neng...@gmail.com changed: What|Removed |Added CC|

[Koha-bugs] [Bug 13600] XSLT: 8xx not showing if there is no 4xx

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13600 Nick Clemens n...@quecheelibrary.org changed: What|Removed |Added Status|Needs Signoff |Failed

[Koha-bugs] [Bug 13600] XSLT: 8xx not showing if there is no 4xx

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13600 Winona Salesky wsale...@gmail.com changed: What|Removed |Added Attachment #40636|0 |1

[Koha-bugs] [Bug 13600] XSLT: 8xx not showing if there is no 4xx

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13600 Winona Salesky wsale...@gmail.com changed: What|Removed |Added Attachment #40207|0 |1

[Koha-bugs] [Bug 13600] XSLT: 8xx not showing if there is no 4xx

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13600 --- Comment #31 from Winona Salesky wsale...@gmail.com --- Sorry about that, the original patch did not include a fix for the staff client. -Winona -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 13600] XSLT: 8xx not showing if there is no 4xx

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13600 Winona Salesky wsale...@gmail.com changed: What|Removed |Added Status|Failed QA |Needs

[Koha-bugs] [Bug 13600] XSLT: 8xx not showing if there is no 4xx

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13600 Nick Clemens n...@quecheelibrary.org changed: What|Removed |Added Assignee|oleon...@myacpl.org

[Koha-bugs] [Bug 13600] XSLT: 8xx not showing if there is no 4xx

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13600 --- Comment #23 from Winona Salesky wsale...@gmail.com --- I also like the ':' (currently it is ':' should it be ';'?) between title and volumne, a solution would be to make it conditional, so it only appears if a $v is present. I

[Koha-bugs] [Bug 13600] XSLT: 8xx not showing if there is no 4xx

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13600 --- Comment #25 from Katrin Fischer katrin.fisc...@bsz-bw.de --- I also like the ':' (currently it is ':' should it be ';'?) between title and volumne, a solution would be to make it conditional, so it only appears if a $v is

[Koha-bugs] [Bug 13600] XSLT: 8xx not showing if there is no 4xx

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13600 --- Comment #26 from Heather heather_hernan...@nps.gov --- (In reply to Katrin Fischer from comment #25) I also like the ':' (currently it is ':' should it be ';'?) between title and volumne, a solution would be to make it

[Koha-bugs] [Bug 13600] XSLT: 8xx not showing if there is no 4xx

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13600 --- Comment #24 from Heather heather_hernan...@nps.gov --- (In reply to Winona Salesky from comment #23) I also like the ':' (currently it is ':' should it be ';'?) between title and volumne, a solution would be to make it

[Koha-bugs] [Bug 13600] XSLT: 8xx not showing if there is no 4xx

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13600 Winona Salesky wsale...@gmail.com changed: What|Removed |Added Attachment #40107|0 |1

[Koha-bugs] [Bug 13600] XSLT: 8xx not showing if there is no 4xx

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13600 Winona Salesky wsale...@gmail.com changed: What|Removed |Added Status|Signed Off |Needs

[Koha-bugs] [Bug 13600] XSLT: 8xx not showing if there is no 4xx

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13600 --- Comment #22 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Hm, not sure about generally removing the separator between the title and the volumne - some 'volumes' might be more textual. It might be more clear with something in

[Koha-bugs] [Bug 13600] XSLT: 8xx not showing if there is no 4xx

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13600 --- Comment #12 from Winona Salesky wsale...@gmail.com --- These are all simple additions and can be added. I will have an amended patch up by tonight. Thanks for the feedback! -Winona (In reply to Nick Clemens from comment #11)

[Koha-bugs] [Bug 13600] XSLT: 8xx not showing if there is no 4xx

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13600 --- Comment #13 from Heather heather_hernan...@nps.gov --- (In reply to Winona Salesky from comment #12) These are all simple additions and can be added. I will have an amended patch up by tonight. Thanks for the feedback! -Winona

[Koha-bugs] [Bug 13600] XSLT: 8xx not showing if there is no 4xx

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13600 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added CC|

[Koha-bugs] [Bug 13600] XSLT: 8xx not showing if there is no 4xx

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13600 --- Comment #17 from Katrin Fischer katrin.fisc...@bsz-bw.de --- I won't, because I like it :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs

[Koha-bugs] [Bug 13600] XSLT: 8xx not showing if there is no 4xx

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13600 --- Comment #18 from Heather heather_hernan...@nps.gov --- (In reply to Katrin Fischer from comment #17) I won't, because I like it :) It is our secret!:) -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 13600] XSLT: 8xx not showing if there is no 4xx

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13600 --- Comment #16 from Heather heather_hernan...@nps.gov --- (In reply to Heather from comment #15) Yes--multiple series do happen! I like the idea of a pipe between series entries. Maybe it would look cleaner without a period/full

[Koha-bugs] [Bug 13600] XSLT: 8xx not showing if there is no 4xx

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13600 --- Comment #15 from Heather heather_hernan...@nps.gov --- Yes--multiple series do happen! I like the idea of a pipe between series entries. Maybe it would look cleaner without a period/full stop at the end: Series: Hines, Jim C.

[Koha-bugs] [Bug 13600] XSLT: 8xx not showing if there is no 4xx

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13600 --- Comment #19 from Nick Clemens n...@quecheelibrary.org --- (In reply to Heather from comment #16) ETA: I forgot to mention re. Also, 8xx fields seems to be ending in ':' regardless of field ending in record, that this looks OK to

[Koha-bugs] [Bug 13600] XSLT: 8xx not showing if there is no 4xx

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13600 --- Comment #21 from Heather heather_hernan...@nps.gov --- Just removing the : may look great. Traditionally the ; precedes the numbering in the $v if it is present. If there was no 8XX $v, then there was no punctuation at the end

[Koha-bugs] [Bug 13600] XSLT: 8xx not showing if there is no 4xx

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13600 --- Comment #20 from Katrin Fischer katrin.fisc...@bsz-bw.de --- I think removing the : if there is no number/volume would make sense to me. -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 13600] XSLT: 8xx not showing if there is no 4xx

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13600 Nick Clemens n...@quecheelibrary.org changed: What|Removed |Added Attachment #40097|0 |1

[Koha-bugs] [Bug 13600] XSLT: 8xx not showing if there is no 4xx

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13600 Nick Clemens n...@quecheelibrary.org changed: What|Removed |Added Attachment #40106|0 |1

[Koha-bugs] [Bug 13600] XSLT: 8xx not showing if there is no 4xx

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13600 Nick Clemens n...@quecheelibrary.org changed: What|Removed |Added CC|

[Koha-bugs] [Bug 13600] XSLT: 8xx not showing if there is no 4xx

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13600 --- Comment #9 from Nick Clemens n...@quecheelibrary.org --- Created attachment 40106 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40106action=edit Bug 14280: Add branches fields to discharges letters Currently,

[Koha-bugs] [Bug 13600] XSLT: 8xx not showing if there is no 4xx

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13600 Nick Clemens n...@quecheelibrary.org changed: What|Removed |Added Status|Needs Signoff |Signed

[Koha-bugs] [Bug 13600] XSLT: 8xx not showing if there is no 4xx

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13600 --- Comment #8 from Winona Salesky wsale...@gmail.com --- Created attachment 40097 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40097action=edit Bug 13600 - XSLT: 8xx not showing if there is no 4xx Removes

[Koha-bugs] [Bug 13600] XSLT: 8xx not showing if there is no 4xx

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13600 Winona Salesky wsale...@gmail.com changed: What|Removed |Added Status|NEW |Needs

[Koha-bugs] [Bug 13600] XSLT: 8xx not showing if there is no 4xx

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13600 --- Comment #7 from Heather heather_hernan...@nps.gov --- (In reply to Winona Salesky from comment #6) I can do that. What should happen where 490 ind1 is blank? In the example below if 490 ind1 is blank the field will be

[Koha-bugs] [Bug 13600] XSLT: 8xx not showing if there is no 4xx

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13600 --- Comment #6 from Winona Salesky wsale...@gmail.com --- I can do that. What should happen where 490 ind1 is blank? In the example below if 490 ind1 is blank the field will be suppressed. It might make more sense to show the field as

[Koha-bugs] [Bug 13600] XSLT: 8xx not showing if there is no 4xx

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13600 --- Comment #5 from Heather heather_hernan...@nps.gov --- (In reply to Winona Salesky from comment #4) Thanks Heather. That is very helpful. So to translate that into code, I could say, always display 8xx, but only display 490

[Koha-bugs] [Bug 13600] XSLT: 8xx not showing if there is no 4xx

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13600 --- Comment #2 from Nicole C. Engard neng...@gmail.com --- (In reply to Winona Salesky from comment #1) How about if there is 490$0 or 490$# ? Should the 8xx display in that case as well? You know .. I don't know. The examples on

[Koha-bugs] [Bug 13600] XSLT: 8xx not showing if there is no 4xx

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13600 Heather heather_hernan...@nps.gov changed: What|Removed |Added CC|

[Koha-bugs] [Bug 13600] XSLT: 8xx not showing if there is no 4xx

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13600 --- Comment #4 from Winona Salesky wsale...@gmail.com --- Thanks Heather. That is very helpful. So to translate that into code, I could say, always display 8xx, but only display 490 where ind1 is NOT 1 (not traced). Is that

[Koha-bugs] [Bug 13600] XSLT: 8xx not showing if there is no 4xx

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13600 Winona Salesky wsale...@gmail.com changed: What|Removed |Added CC|