https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669
--- Comment #72 from Marcel de Rooy ---
IN the period between this push and the the push of bug 26947, the /*! version
dependent lines at the start of kohastructure appear to have been silently
ignored by DBIx::RunSQL.
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669
Marcel de Rooy changed:
What|Removed |Added
See Also|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669
Martin Renvoize changed:
What|Removed |Added
Target Milestone|Oldversions |---
Marcel de Rooy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669
Mason James changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669
Jonathan Druart changed:
What|Removed |Added
Blocks|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669
--- Comment #70 from Tomás Cohen Arazi ---
(In reply to Julian Maurice from comment #69)
> I forgot the last followup in 3.22.7, it will be in 3.22.8
Julian, have the PM add it on packaging!
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669
--- Comment #69 from Julian Maurice ---
I forgot the last followup in 3.22.7, it will be in 3.22.8
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669
--- Comment #68 from Kyle M Hall ---
Excellent! Followup pushed to master! Thanks Bernardo!
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669
Julian Maurice changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669
Jacek Ablewicz changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669
Bernardo Gonzalez Kriegel changed:
What|Removed |Added
Blocks|16554
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669
Bernardo Gonzalez Kriegel changed:
What|Removed |Added
Blocks|16572
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669
Bernardo Gonzalez Kriegel changed:
What|Removed |Added
Attachment #51738|0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669
Marc Véron changed:
What|Removed |Added
Attachment #51736|0 |1
is
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669
--- Comment #64 from Bernardo Gonzalez Kriegel ---
Created attachment 51736
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51736=edit
Bug 13669: followup to add DBIx::RunSQL dependency
Just
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669
--- Comment #63 from Tomás Cohen Arazi ---
Just a followup!
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669
--- Comment #62 from Bernardo Gonzalez Kriegel ---
(In reply to Kyle M Hall from comment #61)
>
> Thanks! If you write it I'm sure we can find some testers!
Will do!
Do you need another bug to add
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669
--- Comment #61 from Kyle M Hall ---
(In reply to Bernardo Gonzalez Kriegel from comment #60)
> (In reply to Kyle M Hall from comment #59)
> > So, with the release so close, how should we deal with this?
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669
--- Comment #60 from Bernardo Gonzalez Kriegel ---
(In reply to Kyle M Hall from comment #59)
> So, with the release so close, how should we deal with this? Revert? Push
> forward with Bug 16572 and Bug 16573?
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669
--- Comment #59 from Kyle M Hall ---
So, with the release so close, how should we deal with this? Revert? Push
forward with Bug 16572 and Bug 16573? Or do we have other options?
--
You are receiving this
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669
--- Comment #58 from Kyle M Hall ---
(In reply to Katrin Fischer from comment #57)
> Yes it is related - and I think it needs to be packaged, I couldn't find it
> in latest Ubuntu and installed from CPAN
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669
--- Comment #57 from Katrin Fischer ---
Yes it is related - and I think it needs to be packaged, I couldn't find it in
latest Ubuntu and installed from CPAN for testing.
--
You are receiving this mail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669
Marc Véron changed:
What|Removed |Added
CC||ve...@veron.ch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669
--- Comment #55 from Katrin Fischer ---
Thx all for working on this! I have Ubuntu 16.04 and MySQL 5.7 - so I can test
this tomorrow again at the hackfest if stil needed.
--
You are receiving this mail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669
--- Comment #54 from Bernardo Gonzalez Kriegel ---
(In reply to Bernardo Gonzalez Kriegel from comment #52)
> (In reply to Jonathan Druart from comment #50)
> > Yes, on another bug report.
> > Now you have
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669
Bernardo Gonzalez Kriegel changed:
What|Removed |Added
Blocks|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669
--- Comment #53 from Bernardo Gonzalez Kriegel ---
Mmm, we have a problem :(
RunSQL prints loads of 'warnings', they are catched and treated as
errors because they go to stderr.
RunSQL have this line
261
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669
--- Comment #52 from Bernardo Gonzalez Kriegel ---
(In reply to Jonathan Druart from comment #50)
> Yes, on another bug report.
> Now you have Ubuntu 16.04, could you please submit a patch? :)
Will do :)
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669
Kyle M Hall changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669
--- Comment #50 from Jonathan Druart
---
(In reply to Bernardo Gonzalez Kriegel from comment #49)
> Errors are not in the procedeure, I tested extensively but on msyql < 5.6,
> so this is
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669
--- Comment #49 from Bernardo Gonzalez Kriegel ---
Errors are not in the procedeure, I tested extensively but on msyql < 5.6, so
this is specific to ver 5.6+ treatment of SQL, or 5.7 more specifically
1) table:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669
--- Comment #48 from Bernardo Gonzalez Kriegel ---
(In reply to Katrin Fischer from comment #47)
> I have installed the dependency from CPAN, made sure that the database was
> empty, applied the patches and ran
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669
--- Comment #47 from Katrin Fischer ---
I have installed the dependency from CPAN, made sure that the database was
empty, applied the patches and ran the web installer in English. But I still
get errors,
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669
--- Comment #46 from Jonathan Druart
---
Created attachment 51685
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51685=edit
Bug 13669: Catch the errors to have them to the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669
Jonathan Druart changed:
What|Removed |Added
Status|Signed Off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669
--- Comment #45 from Jonathan Druart
---
Created attachment 51684
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51684=edit
Bug 13669: Re-adds error handling to load_sql
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669
Jonathan Druart changed:
What|Removed |Added
Attachment #51600|0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669
--- Comment #44 from Jonathan Druart
---
Created attachment 51683
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51683=edit
Bug 13669: (alternative) use DBIx::RunSQL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669
--- Comment #43 from Jonathan Druart
---
Created attachment 51682
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51682=edit
Bug 13669: (followup) Fix kohastructure.sql so
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669
Jonathan Druart changed:
What|Removed |Added
Status|Needs Signoff
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669
--- Comment #41 from Bernardo Gonzalez Kriegel ---
>
> Sorry, forgot to apply the last patch locally.
Forgot to sing also :)
I've signed yours, can't sign mine.
--
You are receiving this mail because:
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669
Bernardo Gonzalez Kriegel changed:
What|Removed |Added
Attachment #51672|0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669
--- Comment #39 from Jonathan Druart
---
Created attachment 51672
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51672=edit
Bug 13669: Catch the errors to have them to the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669
Jonathan Druart changed:
What|Removed |Added
Status|Failed QA
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669
Jonathan Druart changed:
What|Removed |Added
Status|Needs Signoff
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669
--- Comment #36 from Bernardo Gonzalez Kriegel ---
(In reply to Tomás Cohen Arazi from comment #35)
> (In reply to Jonathan Druart from comment #34)
> > I don't know if we should fail or continue actually, hard
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669
--- Comment #35 from Tomás Cohen Arazi ---
(In reply to Jonathan Druart from comment #34)
> I don't know if we should fail or continue actually, hard to say.
> I would say we should block anything if an error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669
--- Comment #34 from Jonathan Druart
---
I don't know if we should fail or continue actually, hard to say.
I would say we should block anything if an error occurs (and so do not execute
next
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669
Bernardo Gonzalez Kriegel changed:
What|Removed |Added
Status|Failed QA
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669
--- Comment #32 from Bernardo Gonzalez Kriegel ---
Created attachment 51671
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51671=edit
Bug 13669: Re-adds error handling to load_sql
This patch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669
Jonathan Druart changed:
What|Removed |Added
Status|Signed Off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669
Bernardo Gonzalez Kriegel changed:
What|Removed |Added
Blocks|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669
Bernardo Gonzalez Kriegel changed:
What|Removed |Added
Status|Needs Signoff
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669
Bernardo Gonzalez Kriegel changed:
What|Removed |Added
Attachment #51612|0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669
Bernardo Gonzalez Kriegel changed:
What|Removed |Added
Attachment #51611|0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669
--- Comment #29 from Bernardo Gonzalez Kriegel ---
Hi Jonathan,
(In reply to Jonathan Druart from comment #27)
> Bernardo, how did you generate new sample files?
Mmmm, sorry but can't understand exactly...
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669
--- Comment #28 from Jonathan Druart
---
What's the expected behavior if an error occurs,
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669
--- Comment #27 from Jonathan Druart
---
Bernardo, how did you generate new sample files?
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669
Bernardo Gonzalez Kriegel changed:
What|Removed |Added
Attachment #51610|0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669
Bernardo Gonzalez Kriegel changed:
What|Removed |Added
Status|Signed Off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669
--- Comment #24 from Bernardo Gonzalez Kriegel ---
Created attachment 51611
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51611=edit
Bug 13669: (followup) fix fr-FR files
Rewrite
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669
--- Comment #23 from Bernardo Gonzalez Kriegel ---
Created attachment 51610
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51610=edit
Bug 13669: (followup) fix I18N files
This patch fix web
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669
Tomás Cohen Arazi changed:
What|Removed |Added
Keywords|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669
--- Comment #22 from Tomás Cohen Arazi ---
(In reply to Chris Cormack from comment #20)
> It works, but a new dependency eh? We need to update that too.
>
> I've attached it as a signed off patch, but will let
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669
Chris Cormack changed:
What|Removed |Added
Attachment #51607|0 |1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669
Chris Cormack changed:
What|Removed |Added
Status|Needs Signoff
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669
--- Comment #20 from Chris Cormack ---
It works, but a new dependency eh? We need to update that too.
I've attached it as a signed off patch, but will let the RM and others decide
if they want to add the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669
Chris Cormack changed:
What|Removed |Added
Status|Signed Off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669
--- Comment #18 from Bernardo Gonzalez Kriegel ---
Created attachment 51607
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51607=edit
Bug 13669: (alternative) use DBIx::RunSQL
Alternative POC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669
--- Comment #17 from Chris Cormack ---
This works, but it is slow, I think that is ok though, as you only run the web
installer once :)
--
You are receiving this mail because:
You are watching all bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669
Chris Cormack changed:
What|Removed |Added
Attachment #51599|0 |1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669
Chris Cormack changed:
What|Removed |Added
Attachment #51598|0 |1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669
--- Comment #14 from Tomás Cohen Arazi ---
Created attachment 51599
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51599=edit
Bug 13669: (followup) Fix kohastructure.sql so FK dependencies
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #51597|0 |1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #51596|0 |1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669
--- Comment #11 from Tomás Cohen Arazi ---
Created attachment 51596
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51596=edit
Bug 13669: Use perl to load SQL statements from sample data
This
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669
Tomás Cohen Arazi changed:
What|Removed |Added
Status|NEW
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669
--- Comment #10 from Jonathan Druart
---
It seems that using MySQL v5.7, the web installer fails on step 3 with "using a
password on command line interface can be insecure".
I don't think we
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669
Tomás Cohen Arazi changed:
What|Removed |Added
Summary|Web installer fails on
79 matches
Mail list logo