[Koha-bugs] [Bug 13871] OverDrive message when user authentication fails

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871 Julian Maurice changed: What|Removed |Added Status|Pushed to Master

[Koha-bugs] [Bug 13871] OverDrive message when user authentication fails

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871 --- Comment #66 from Nick Clemens --- *** Bug 16479 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 13871] OverDrive message when user authentication fails

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871 Kyle M Hall changed: What|Removed |Added Status|Passed QA

[Koha-bugs] [Bug 13871] OverDrive message when user authentication fails

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871 Marcel de Rooy changed: What|Removed |Added Attachment #51421|0

[Koha-bugs] [Bug 13871] OverDrive message when user authentication fails

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871 --- Comment #63 from Katrin Fischer --- I agree - fixing it is better. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs

[Koha-bugs] [Bug 13871] OverDrive message when user authentication fails

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871 --- Comment #62 from Marcel de Rooy --- @RM: Handled as QA follow-up. Please check last patch and push that one only. -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 13871] OverDrive message when user authentication fails

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871 Marcel de Rooy changed: What|Removed |Added Status|Signed Off

[Koha-bugs] [Bug 13871] OverDrive message when user authentication fails

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871 Marcel de Rooy changed: What|Removed |Added Status|Pushed to Stable

[Koha-bugs] [Bug 13871] OverDrive message when user authentication fails

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871 Marcel de Rooy changed: What|Removed |Added Status|ASSIGNED

[Koha-bugs] [Bug 13871] OverDrive message when user authentication fails

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871 Marcel de Rooy changed: What|Removed |Added Status|Needs Signoff

[Koha-bugs] [Bug 13871] OverDrive message when user authentication fails

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871 --- Comment #60 from Marcel de Rooy --- Created attachment 51421 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51421=edit Bug 13871: [QA Follow-up] Fix small regression on AF with

[Koha-bugs] [Bug 13871] OverDrive message when user authentication fails

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871 --- Comment #59 from Katrin Fischer --- The problem I see here is that it's already in a stable release. So a revert is not as easy as just getting it out of master. -- You are receiving this mail

[Koha-bugs] [Bug 13871] OverDrive message when user authentication fails

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871 --- Comment #58 from Marcel de Rooy --- (In reply to Kyle M Hall from comment #56) > This is > definitely a regression and needs to be fixed or we may have to revert this > bug in master before the release.

[Koha-bugs] [Bug 13871] OverDrive message when user authentication fails

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871 --- Comment #57 from Marcel de Rooy --- (In reply to Kyle M Hall from comment #56) > Yes, SIP2 can have multiple AF fields. In that case that is the best route. -- You are receiving this mail because:

[Koha-bugs] [Bug 13871] OverDrive message when user authentication fails

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871 --- Comment #56 from Kyle M Hall --- > Hi Nick, > Your problem should not be that hard to resolve. > I think we should not rely on the fact that AF only includes the patron > branch code. It is just a

[Koha-bugs] [Bug 13871] OverDrive message when user authentication fails

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871 --- Comment #55 from Marcel de Rooy --- (In reply to Nick Clemens from comment #52) > This patch has altered the way that the patron branch is sent. Previously > it was in a separate AF field, now the

[Koha-bugs] [Bug 13871] OverDrive message when user authentication fails

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871 --- Comment #54 from Mason James --- (In reply to Nick Clemens from comment #52) > This patch has altered the way that the patron branch is sent. Previously > it was in a separate AF field, now the branch is

[Koha-bugs] [Bug 13871] OverDrive message when user authentication fails

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871 Nick Clemens changed: What|Removed |Added See Also|

[Koha-bugs] [Bug 13871] OverDrive message when user authentication fails

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871 --- Comment #53 from Katrin Fischer --- Hi Nick, can you please open a new bug linked to this one? -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 13871] OverDrive message when user authentication fails

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871 Nick Clemens changed: What|Removed |Added CC|

[Koha-bugs] [Bug 13871] OverDrive message when user authentication fails

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871 Julian Maurice changed: What|Removed |Added Status|Pushed to Master

[Koha-bugs] [Bug 13871] OverDrive message when user authentication fails

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871 Brendan Gallagher changed: What|Removed |Added Status|Passed QA

[Koha-bugs] [Bug 13871] OverDrive message when user authentication fails

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871 --- Comment #49 from Marcel de Rooy --- Created attachment 48672 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48672=edit Bug 13871: [QA Follow-up] Add $server for FID_SCREEN_MSG When

[Koha-bugs] [Bug 13871] OverDrive message when user authentication fails

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871 Marcel de Rooy changed: What|Removed |Added Patch complexity|---

[Koha-bugs] [Bug 13871] OverDrive message when user authentication fails

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871 Marcel de Rooy changed: What|Removed |Added Status|Signed Off

[Koha-bugs] [Bug 13871] OverDrive message when user authentication fails

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871 --- Comment #46 from Marcel de Rooy --- Created attachment 48670 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48670=edit Bug 13871: [QA Follow-up] Adjust Patron Status Request Conform

[Koha-bugs] [Bug 13871] OverDrive message when user authentication fails

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871 --- Comment #45 from Marcel de Rooy --- Created attachment 48669 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48669=edit Bug 13871 - OverDrive message when user authentication fails

[Koha-bugs] [Bug 13871] OverDrive message when user authentication fails

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871 --- Comment #47 from Marcel de Rooy --- Created attachment 48671 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48671=edit Bug 13871: [QA Follow-up] Adjust Patron Info Request Conform QA

[Koha-bugs] [Bug 13871] OverDrive message when user authentication fails

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871 --- Comment #44 from Marcel de Rooy --- Created attachment 48668 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48668=edit Bug 13871: [TITLE_AMENDED] Additional changes The original

[Koha-bugs] [Bug 13871] OverDrive message when user authentication fails

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871 Marcel de Rooy changed: What|Removed |Added Attachment #48386|0

[Koha-bugs] [Bug 13871] OverDrive message when user authentication fails

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871 Marcel de Rooy changed: What|Removed |Added See Also|

[Koha-bugs] [Bug 13871] OverDrive message when user authentication fails

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871 Marcel de Rooy changed: What|Removed |Added Blocks|

[Koha-bugs] [Bug 13871] OverDrive message when user authentication fails

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871 --- Comment #42 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #41) > Will continue QA session here later. Submitting some follow-ups to get this thru QA later this week. -- You are

[Koha-bugs] [Bug 13871] OverDrive message when user authentication fails

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871 --- Comment #41 from Marcel de Rooy --- Will continue QA session here later. -- You are receiving this mail because: You are watching all bug changes. ___

[Koha-bugs] [Bug 13871] OverDrive message when user authentication fails

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871 --- Comment #40 from Marcel de Rooy --- And some advanced wrestling with utf8 characters in the commit message (and the git version on Debian 7) -- You are receiving this mail because: You are watching

[Koha-bugs] [Bug 13871] OverDrive message when user authentication fails

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871 Marcel de Rooy changed: What|Removed |Added Attachment #48391|0

[Koha-bugs] [Bug 13871] OverDrive message when user authentication fails

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871 Marcel de Rooy changed: What|Removed |Added Attachment #48390|0

[Koha-bugs] [Bug 13871] OverDrive message when user authentication fails

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871 Marcel de Rooy changed: What|Removed |Added Attachment #48388|0

[Koha-bugs] [Bug 13871] OverDrive message when user authentication fails

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871 Marcel de Rooy changed: What|Removed |Added Attachment #48389|0

[Koha-bugs] [Bug 13871] OverDrive message when user authentication fails

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871 --- Comment #35 from Marcel de Rooy --- I rebased this patch set on the new perltidy. The second patch includes comments on the changes from Mason. This effectively obsoletes the last follow-up from Kyle to

[Koha-bugs] [Bug 13871] OverDrive message when user authentication fails

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871 --- Comment #34 from Marcel de Rooy --- Created attachment 48389 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48389=edit Bug 13871 [QA Followup] - Rename parameter to

[Koha-bugs] [Bug 13871] OverDrive message when user authentication fails

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871 --- Comment #33 from Marcel de Rooy --- Created attachment 48388 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48388=edit Bug 13871 - OverDrive message when user authentication fails

[Koha-bugs] [Bug 13871] OverDrive message when user authentication fails

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871 --- Comment #32 from Marcel de Rooy --- Created attachment 48387 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48387=edit Bug 13871: [TITLE_AMENDED] Additional changes The original

[Koha-bugs] [Bug 13871] OverDrive message when user authentication fails

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871 Marcel de Rooy changed: What|Removed |Added Attachment #45646|0

[Koha-bugs] [Bug 13871] OverDrive message when user authentication fails

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871 Marcel de Rooy changed: What|Removed |Added CC|

[Koha-bugs] [Bug 13871] OverDrive message when user authentication fails

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871 Kyle M Hall changed: What|Removed |Added Status|Failed QA

[Koha-bugs] [Bug 13871] OverDrive message when user authentication fails

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871 --- Comment #27 from Kyle M Hall --- Created attachment 45647 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45647=edit Bug 13871 - OverDrive message when user authentication fails NOTE:

[Koha-bugs] [Bug 13871] OverDrive message when user authentication fails

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871 --- Comment #28 from Kyle M Hall --- Created attachment 45648 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45648=edit Bug 13871 [QA Followup] - Rename parameter to

[Koha-bugs] [Bug 13871] OverDrive message when user authentication fails

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871 --- Comment #29 from Kyle M Hall --- Created attachment 45649 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45649=edit Bug 13871 [QA Followup] - Fix namespaces Signed-off-by: Kyle M Hall

[Koha-bugs] [Bug 13871] OverDrive message when user authentication fails

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871 Kyle M Hall changed: What|Removed |Added Attachment #38452|0 |1

[Koha-bugs] [Bug 13871] OverDrive message when user authentication fails

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871 Kyle M Hall changed: What|Removed |Added Status|Needs Signoff

[Koha-bugs] [Bug 13871] OverDrive message when user authentication fails

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871 Kyle M Hall changed: What|Removed |Added Attachment #45645|0 |1

[Koha-bugs] [Bug 13871] OverDrive message when user authentication fails

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871 --- Comment #23 from Mason James --- (In reply to Bob Birchall from comment #20) > Given Mason's comments, does this still need to be in Failed QA? any update Kyle? -- You are receiving this mail because: You

[Koha-bugs] [Bug 13871] OverDrive message when user authentication fails

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871 --- Comment #22 from Mason James --- (In reply to Kyle M Hall from comment #21) > (In reply to Mason James from comment #19) > > (In reply to Kyle M Hall from comment #11) > > > I see. I hadn't looked deeply

[Koha-bugs] [Bug 13871] OverDrive message when user authentication fails

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871 --- Comment #21 from Kyle M Hall --- (In reply to Mason James from comment #19) > (In reply to Kyle M Hall from comment #11) > > I see. I hadn't looked deeply enough to realize 1 was the card number. In > >

[Koha-bugs] [Bug 13871] OverDrive message when user authentication fails

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871 --- Comment #20 from Bob Birchall --- Given Mason's comments, does this still need to be in Failed QA? -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 13871] OverDrive message when user authentication fails

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871 --- Comment #19 from Mason James --- (In reply to Kyle M Hall from comment #11) > I see. I hadn't looked deeply enough to realize 1 was the card number. In > that case my solution won't work. > > (In reply to

[Koha-bugs] [Bug 13871] OverDrive message when user authentication fails

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871 --- Comment #18 from Mason James --- sorry, i missed some questions here... (In reply to Kyle M Hall from comment #8) > Pardon my being late to reply to this, but could this be solved with a a > screen message

[Koha-bugs] [Bug 13871] OverDrive message when user authentication fails

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|In Discussion

[Koha-bugs] [Bug 13871] OverDrive message when user authentication fails

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871 --- Comment #16 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 38455 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38455action=edit Bug 13871 [QA Followup] - Fix namespaces -- You are receiving

[Koha-bugs] [Bug 13871] OverDrive message when user authentication fails

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #38451|0 |1

[Koha-bugs] [Bug 13871] OverDrive message when user authentication fails

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #37539|0 |1

[Koha-bugs] [Bug 13871] OverDrive message when user authentication fails

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871 --- Comment #14 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 38453 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38453action=edit Bug 13871 - OverDrive message when user authentication fails

[Koha-bugs] [Bug 13871] OverDrive message when user authentication fails

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871 --- Comment #15 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 38454 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38454action=edit Bug 13871 [QA Followup] - Rename parameter to

[Koha-bugs] [Bug 13871] OverDrive message when user authentication fails

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|Failed QA

[Koha-bugs] [Bug 13871] OverDrive message when user authentication fails

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|Signed Off

[Koha-bugs] [Bug 13871] OverDrive message when user authentication fails

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added CC|

[Koha-bugs] [Bug 13871] OverDrive message when user authentication fails

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871 --- Comment #10 from Katrin Fischer katrin.fisc...@bsz-bw.de --- ... and 1 being the cardnumber. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs

[Koha-bugs] [Bug 13871] OverDrive message when user authentication fails

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871 --- Comment #9 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Hm, not sure this would work? 3/ enter a correct username and correct password in overdrive see overdrive display '(1) Greetings from Koha…' (good) 4/ enter a correct

[Koha-bugs] [Bug 13871] OverDrive message when user authentication fails

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871 --- Comment #7 from Mason James m...@kohaaloha.com --- (In reply to Katrin Fischer from comment #6) Hi Mason, can the first patch be obsoleted? hmm, no - it's a perltidy patch, that the feature depends on as you can see from the

[Koha-bugs] [Bug 13871] OverDrive message when user authentication fails

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Version|unspecified

[Koha-bugs] [Bug 13871] OverDrive message when user authentication fails

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added CC|

[Koha-bugs] [Bug 13871] OverDrive message when user authentication fails

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871 --- Comment #3 from Mason James m...@kohaaloha.com --- Created attachment 37539 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37539action=edit Bug 13871 - OverDrive message when user authentication fails perltidy

[Koha-bugs] [Bug 13871] OverDrive message when user authentication fails

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871 Mason James m...@kohaaloha.com changed: What|Removed |Added Attachment #37539|1 |0 is

[Koha-bugs] [Bug 13871] OverDrive message when user authentication fails

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871 Mason James m...@kohaaloha.com changed: What|Removed |Added Attachment #37539|0 |1 is

[Koha-bugs] [Bug 13871] OverDrive message when user authentication fails

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871 Bob Birchall b...@calyx.net.au changed: What|Removed |Added Status|Needs Signoff |Signed Off

[Koha-bugs] [Bug 13871] OverDrive message when user authentication fails

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871 Mason James m...@kohaaloha.com changed: What|Removed |Added Status|ASSIGNED|Needs

[Koha-bugs] [Bug 13871] OverDrive message when user authentication fails

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871 Bob Birchall b...@calyx.net.au changed: What|Removed |Added Status|NEW |ASSIGNED --

[Koha-bugs] [Bug 13871] OverDrive message when user authentication fails

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871 Bob Birchall b...@calyx.net.au changed: What|Removed |Added Assignee|oleon...@myacpl.org

[Koha-bugs] [Bug 13871] OverDrive message when user authentication fails

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871 Bob Birchall b...@calyx.net.au changed: What|Removed |Added Change sponsored?|--- |Sponsored

[Koha-bugs] [Bug 13871] OverDrive message when user authentication fails

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871 --- Comment #2 from Bob Birchall b...@calyx.net.au --- Colin Campbell wrote: I've had this reported recently but havent been able to look at it. I think there might be a change of behaviour I think screen message used to get a default