[Koha-bugs] [Bug 14101] auto renewal is tied to 'no renewal before'

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14101 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to Master

[Koha-bugs] [Bug 14101] auto renewal is tied to 'no renewal before'

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14101 --- Comment #32 from Kyle M Hall --- Created attachment 44991 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44991&action=edit [PASSED QA] Bug 14101: Unit tests This patch adds new test cases to check if CanBookBeRe

[Koha-bugs] [Bug 14101] auto renewal is tied to 'no renewal before'

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14101 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receivin

[Koha-bugs] [Bug 14101] auto renewal is tied to 'no renewal before'

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14101 Kyle M Hall changed: What|Removed |Added Attachment #44948|0 |1 is obsolete|

[Koha-bugs] [Bug 14101] auto renewal is tied to 'no renewal before'

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14101 --- Comment #30 from Holger Meißner --- Rebased on master. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-communi

[Koha-bugs] [Bug 14101] auto renewal is tied to 'no renewal before'

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14101 Holger Meißner changed: What|Removed |Added Attachment #43808|0 |1 is obsolete|

[Koha-bugs] [Bug 14101] auto renewal is tied to 'no renewal before'

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14101 Holger Meißner changed: What|Removed |Added Attachment #43809|0 |1 is obsolete|

[Koha-bugs] [Bug 14101] auto renewal is tied to 'no renewal before'

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14101 --- Comment #27 from Holger Meißner --- Hi Jonathan, thanks for QA! I think I fixed everything :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs ma

[Koha-bugs] [Bug 14101] auto renewal is tied to 'no renewal before'

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14101 Holger Meißner changed: What|Removed |Added Attachment #42773|0 |1 is obsolete|

[Koha-bugs] [Bug 14101] auto renewal is tied to 'no renewal before'

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14101 Holger Meißner changed: What|Removed |Added Attachment #39800|0 |1 is obsolete|

[Koha-bugs] [Bug 14101] auto renewal is tied to 'no renewal before'

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14101 --- Comment #24 from Jonathan Druart --- Comment on attachment 39800 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39800 Bug 14101: Automatic renewals exactly on due date Review of attachment 39800: --> (http://

[Koha-bugs] [Bug 14101] auto renewal is tied to 'no renewal before'

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14101 Holger Meißner changed: What|Removed |Added Status|Failed QA |Signed Off --- Comment #23

[Koha-bugs] [Bug 14101] auto renewal is tied to 'no renewal before'

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14101 --- Comment #22 from Holger Meißner --- Created attachment 42773 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42773&action=edit Bug 14101: Unit tests This patch adds new test cases to cover the changes introduced

[Koha-bugs] [Bug 14101] auto renewal is tied to 'no renewal before'

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14101 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Failed QA

[Koha-bugs] [Bug 14101] auto renewal is tied to 'no renewal before'

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14101 bondiurbano changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receivi

[Koha-bugs] [Bug 14101] auto renewal is tied to 'no renewal before'

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14101 --- Comment #20 from bondiurbano --- (In reply to Holger Meißner from comment #19) > Okay. I'll work on it. I think it should be sysprefed and in a separate > patch, depending on this one. See bug 14395. - Good idea Holge

[Koha-bugs] [Bug 14101] auto renewal is tied to 'no renewal before'

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14101 --- Comment #19 from Holger Meißner --- Okay. I'll work on it. I think it should be sysprefed and in a separate patch, depending on this one. See bug 14395. -- You are receiving this mail because: You are watching all bug changes. _

[Koha-bugs] [Bug 14101] auto renewal is tied to 'no renewal before'

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14101 Holger Meißner changed: What|Removed |Added Blocks||14395 -- You are receiving

[Koha-bugs] [Bug 14101] auto renewal is tied to 'no renewal before'

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14101 Indranil Das Gupta changed: What|Removed |Added CC||indr...@gmail.com -- Y

[Koha-bugs] [Bug 14101] auto renewal is tied to 'no renewal before'

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14101 --- Comment #18 from bondiurbano --- Hi Holger! Ah! I understand. In my opinion "no renewal before" has no sense in hours. But it's only my point of view. Not because it is not needed by me, but I can't imagine a situation like this

[Koha-bugs] [Bug 14101] auto renewal is tied to 'no renewal before'

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14101 --- Comment #17 from Holger Meißner --- Bondiurbano, the calculation uses the exact DateTime. When the unit for the loan period is days, as far as I know koha always sets the time for the due date to 23:59. So with due date 04/06/20

[Koha-bugs] [Bug 14101] auto renewal is tied to 'no renewal before'

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14101 --- Comment #16 from bondiurbano --- Created attachment 39829 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39829&action=edit Test 1 "no renewals before" -- You are receiving this mail because: You are watching al

[Koha-bugs] [Bug 14101] auto renewal is tied to 'no renewal before'

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14101 --- Comment #15 from bondiurbano --- Holger, I've upload a PDF with a case I'd like you to consider. I've made a test as you suggested: 1) Now is possible to set "no renewals before" to 0. It works fine. 2) Calculation of days to d

[Koha-bugs] [Bug 14101] auto renewal is tied to 'no renewal before'

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14101 Holger Meißner changed: What|Removed |Added Patch complexity|--- |Small patch Change sponsor

[Koha-bugs] [Bug 14101] auto renewal is tied to 'no renewal before'

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14101 Holger Meißner changed: What|Removed |Added CC||cost...@gmail.com --- Comme

[Koha-bugs] [Bug 14101] auto renewal is tied to 'no renewal before'

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14101 Holger Meißner changed: What|Removed |Added CC||fiona.borthwick@ptfs-europe

[Koha-bugs] [Bug 14101] auto renewal is tied to 'no renewal before'

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14101 Holger Meißner changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are r

[Koha-bugs] [Bug 14101] auto renewal is tied to 'no renewal before'

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14101 --- Comment #12 from Holger Meißner --- Created attachment 39802 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39802&action=edit Table to illustrate how automatic renewals should work. To make testing easier and fo

[Koha-bugs] [Bug 14101] auto renewal is tied to 'no renewal before'

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14101 --- Comment #11 from Holger Meißner --- Created attachment 39800 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39800&action=edit Bug 14101: Automatic renewals exactly on due date If no value for 'no renewal before'

[Koha-bugs] [Bug 14101] auto renewal is tied to 'no renewal before'

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14101 Katrin Fischer changed: What|Removed |Added See Also||http://bugs.koha-community.

[Koha-bugs] [Bug 14101] auto renewal is tied to 'no renewal before'

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14101 Holger Meißner changed: What|Removed |Added Status|NEW |ASSIGNED Assignee

[Koha-bugs] [Bug 14101] auto renewal is tied to 'no renewal before'

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14101 --- Comment #10 from Holger Meißner --- (In reply to Katrin Fischer from comment #4) > Maybe the feature could fall back to try a renewal on the due date if there > is nothing else specified in the circulation rules? I think that's a

[Koha-bugs] [Bug 14101] auto renewal is tied to 'no renewal before'

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14101 --- Comment #9 from Holger Meißner --- I am unable to reproduce this problem. We already use the feature in 3.18. Loan period: 30 days Renewal period: 20 days No renewal before: 11 days Renewals allowed (count): 16 I checked out som

[Koha-bugs] [Bug 14101] auto renewal is tied to 'no renewal before'

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14101 --- Comment #8 from Katrin Fischer --- Hi Kyle, what are the loan period and no renewal before values you tested with? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. _

[Koha-bugs] [Bug 14101] auto renewal is tied to 'no renewal before'

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14101 Kyle M Hall changed: What|Removed |Added CC||k...@bywatersolutions.com ---

[Koha-bugs] [Bug 14101] auto renewal is tied to 'no renewal before'

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14101 --- Comment #6 from Holger Meißner --- (In reply to Kyle M Hall from comment #3) > This seems to happen even if I set a no renewal before value. Hi Kyle, which values did you test? It should work with values equal to or greater than

[Koha-bugs] [Bug 14101] auto renewal is tied to 'no renewal before'

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14101 --- Comment #5 from Holger Meißner --- (In reply to Nicole C. Engard from comment #0) > It seems as though the autorenewal feature needs to have the column "no > renewal before" filled in or it will auto renew everyday after the dueda

[Koha-bugs] [Bug 14101] auto renewal is tied to 'no renewal before'

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14101 Katrin Fischer changed: What|Removed |Added See Also||http://bugs.koha-community.

[Koha-bugs] [Bug 14101] auto renewal is tied to 'no renewal before'

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14101 --- Comment #4 from Katrin Fischer --- I think it should take the 'no renewal before' into account - I am not sure why it wouldn't. I haven't tested this myself, but I have added the developer in CC. Maybe the feature could fall back

[Koha-bugs] [Bug 14101] auto renewal is tied to 'no renewal before'

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14101 --- Comment #3 from Kyle M Hall --- Maybe the documentation on this feature is wrong, but when I've tried to set up automatica renewals I have a serious issue. I enable the nightly cron and all my automatic renewals are renewed ever

[Koha-bugs] [Bug 14101] auto renewal is tied to 'no renewal before'

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14101 --- Comment #2 from Nicole C. Engard --- I'm a bit confused then on how it works if I check the auto renew box when I check out - in that scenario you're overriding the default and there is no way to set 'no renewal before' in that sc

[Koha-bugs] [Bug 14101] auto renewal is tied to 'no renewal before'

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14101 Katrin Fischer changed: What|Removed |Added CC||h.meissner...@web.de,