https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321
jmbroust changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321
--- Comment #96 from Mirko Tietgen ---
Tried to hide the spammer. Don't know if someone else can delete it. Account
should be banned.
--
You are receiving this mail because:
You are watching all bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321
OLLIE SCHWEIZER changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321
--- Comment #94 from David Cook ---
(In reply to Marcel de Rooy from comment #93)
> (In reply to David Cook from comment #92)
> > Just a FYI for people testing out permanent uploads.
> >
> > If you're
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321
David Cook changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321
--- Comment #93 from Marcel de Rooy ---
(In reply to David Cook from comment #92)
> Just a FYI for people testing out permanent uploads.
>
> If you're using "/tmp" as the "upload_path", you might want to
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321
--- Comment #89 from Mirko Tietgen ---
Now that this is in 3.22, I wonder how the nonpublic file upload is supposed to
work? There is no direct link to tools/upload.pl AFAICT and with the
cataloguing plugin,
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321
--- Comment #90 from Marcel de Rooy ---
(In reply to Mirko Tietgen from comment #89)
> Now that this is in 3.22, I wonder how the nonpublic file upload is supposed
> to work? There is no direct link to
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321
--- Comment #91 from Mirko Tietgen ---
Ah, thanks! I checked the blocks/depends on bugs, but managed to overlook the
see also ones.
--
You are receiving this mail because:
You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321
Marcel de Rooy changed:
What|Removed |Added
Blocks|14893 |
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321
Jonathan Druart changed:
What|Removed |Added
See Also|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321
--- Comment #87 from Marcel de Rooy ---
(In reply to Tomás Cohen Arazi from comment #86)
> This patches broke the search_utf8.t tests. Please take a look.
I fixed the warning from tt_valid.t. See bug 14904.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321
Jonathan Druart changed:
What|Removed |Added
Blocks|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321
Jonathan Druart changed:
What|Removed |Added
Blocks|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321
--- Comment #88 from Marcel de Rooy ---
(In reply to Marcel de Rooy from comment #87)
> Which tests exactly fail?
> If I am running this test now without the patches pushed yet, I also have
> some errors.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321
--- Comment #86 from Tomás Cohen Arazi ---
(In reply to Tomás Cohen Arazi from comment #85)
> Patches pushed to master.
>
> Thanks Marcel!
This patches broke the search_utf8.t tests. Please take a look.
--
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321
Tomás Cohen Arazi changed:
What|Removed |Added
Status|Passed QA
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321
--- Comment #84 from Tomás Cohen Arazi ---
Created attachment 42890
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42890=edit
Bug 14321: (QA followup) remove Test::CGI::Multipart dependency
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321
--- Comment #83 from Tomás Cohen Arazi ---
Created attachment 42889
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42889=edit
Bug 14321: (RM followup) DBIx update
Signed-off-by: Tomas Cohen
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321
Marcel de Rooy changed:
What|Removed |Added
Blocks|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321
--- Comment #82 from Marcel de Rooy ---
(In reply to Jonathan Druart from comment #73)
> (In reply to Marcel de Rooy from comment #71)
> > > c. public and permanent are tinyint(4) but actually are boolean,
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321
Jonathan Druart changed:
What|Removed |Added
Attachment #42660|0
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321
Jonathan Druart changed:
What|Removed |Added
Attachment #42662|0
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321
Jonathan Druart changed:
What|Removed |Added
Attachment #42664|0
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321
Jonathan Druart changed:
What|Removed |Added
Attachment #42663|0
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321
Jonathan Druart changed:
What|Removed |Added
Attachment #42661|0
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321
Jonathan Druart changed:
What|Removed |Added
Attachment #42707|0
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321
Jonathan Druart changed:
What|Removed |Added
Attachment #42665|0
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321
--- Comment #81 from Jonathan Druart
---
I have squashed
Bug 14321: Integrate Upload.pm into Koha
and
Bug 14321: [QA Follow-up] Perltidy upload.pl
--
You are receiving this mail
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321
Jonathan Druart changed:
What|Removed |Added
See Also|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321
Jonathan Druart changed:
What|Removed |Added
Attachment #42666|0
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321
Jonathan Druart changed:
What|Removed |Added
Status|Signed Off
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321
--- Comment #72 from Marcel de Rooy ---
Created attachment 42707
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42707=edit
Bug 14321: [QA Follow-up] Additional QA requests
This patch makes
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321
Marcel de Rooy changed:
What|Removed |Added
See Also|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321
--- Comment #71 from Marcel de Rooy ---
(In reply to Jonathan Druart from comment #69)
Thanks for looking further !
> 1/ DB structure:
> a. It would have been better not to choose "categorycode", already
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321
--- Comment #59 from Jonathan Druart
---
I have asked Julian to have a look, to confirm there is no regression on bug
6874.
--
You are receiving this mail because:
You are watching all bug
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321
--- Comment #70 from Jonathan Druart
---
(In reply to Jonathan Druart from comment #69)
> 1/ DB structure:
> a. It would have been better not to choose "categorycode", already used
>
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321
--- Comment #67 from Julian Maurice ---
(In reply to Jonathan Druart from comment #59)
> I have asked Julian to have a look, to confirm there is no regression on bug
> 6874.
Confirmed ;)
I also tested
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321
--- Comment #69 from Jonathan Druart
---
1/ DB structure:
a. It would have been better not to choose "categorycode", already used
everywhere into Koha for another use.
b. owner should be a
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321
--- Comment #68 from Marcel de Rooy ---
(In reply to Julian Maurice from comment #67)
> (In reply to Jonathan Druart from comment #59)
> > I have asked Julian to have a look, to confirm there is no
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321
Julian Maurice changed:
What|Removed |Added
Attachment #42559|0
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321
Julian Maurice changed:
What|Removed |Added
Attachment #42558|0
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321
Julian Maurice changed:
What|Removed |Added
Attachment #42590|0
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321
Julian Maurice changed:
What|Removed |Added
Attachment #42560|0
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321
Julian Maurice changed:
What|Removed |Added
Attachment #42591|0
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321
Julian Maurice changed:
What|Removed |Added
Attachment #42561|0
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321
Julian Maurice changed:
What|Removed |Added
Attachment #42587|0
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321
Jonathan Druart changed:
What|Removed |Added
CC|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321
--- Comment #49 from Jonathan Druart
---
Created attachment 42584
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42584=edit
Bug 14321: QA Fix
Remove QA errors (keys on
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321
--- Comment #50 from Marcel de Rooy ---
Jonathan: Thanks for looking into this one!
> +sub DESTROY {
> +}
> This is not really useful.
Agreed. Removing it.
> +# ** HELPER ROUTINES / CLASS
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321
--- Comment #51 from Marcel de Rooy ---
> ::: koha-tmpl/intranet-tmpl/prog/en/modules/tools/upload.tt
> I don't really like the structure of this file. You have to jump in the file
> to know what is next.
>
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321
Marcel de Rooy changed:
What|Removed |Added
Attachment #42588|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321
--- Comment #46 from Jonathan Druart
---
Comment on attachment 42559
--> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42559
Bug 14321: Introduce Koha::Upload
Review of
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321
Jonathan Druart changed:
What|Removed |Added
Depends on|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321
Marcel de Rooy changed:
What|Removed |Added
Attachment #42589|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321
--- Comment #47 from Jonathan Druart
---
Comment on attachment 42560
--> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42560
Bug 14321: Integrate Upload.pm into Koha
Review of
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321
--- Comment #56 from Marcel de Rooy ---
(In reply to Jonathan Druart from comment #52)
> (In reply to Marcel de Rooy from comment #50)
> > > +sub _lookup {
> > > +my ( $self, $params ) = @_;
> > > +
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321
Marcel de Rooy changed:
What|Removed |Added
Attachment #42584|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321
--- Comment #55 from Marcel de Rooy ---
Created attachment 42589
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42589=edit
Bug 14321: [QA Follow-up] Perltidy upload.pl
Run perltidy
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321
--- Comment #54 from Marcel de Rooy ---
Created attachment 42588
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42588=edit
Bug 14321: [QA Follow-up] Changes for Upload.pm and upload-file.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321
--- Comment #52 from Jonathan Druart
---
(In reply to Marcel de Rooy from comment #50)
> > +sub _lookup {
> > +my ( $self, $params ) = @_;
> > +my $dbh = C4::Context->dbh;
> > +my
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321
--- Comment #45 from Marcel de Rooy ---
(In reply to Mirko Tietgen from comment #44)
> Works for me. One thing I noticed is that in the cataloguing editor, having
> the plugin and add/remove field options
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321
Mirko Tietgen changed:
What|Removed |Added
Status|Needs Signoff
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321
Mirko Tietgen changed:
What|Removed |Added
Attachment #42411|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321
Mirko Tietgen changed:
What|Removed |Added
Attachment #42412|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321
Mirko Tietgen changed:
What|Removed |Added
Attachment #42413|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321
Mirko Tietgen changed:
What|Removed |Added
Attachment #42414|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321
--- Comment #44 from Mirko Tietgen ---
Works for me. One thing I noticed is that in the cataloguing editor, having the
plugin and add/remove field options next to each other looks a little off.
--
You are
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321
Marcel de Rooy changed:
What|Removed |Added
CC|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321
--- Comment #39 from Marcel de Rooy ---
Mirko: I rearranged the patches and as you will see, the test plan on the third
patch is the crux now (you will recognize it).
Apart from reorganizing, I added a
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321
Marcel de Rooy changed:
What|Removed |Added
CC|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321
Marcel de Rooy changed:
What|Removed |Added
Attachment #41874|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321
Marcel de Rooy changed:
What|Removed |Added
Attachment #41875|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321
Marcel de Rooy changed:
What|Removed |Added
Attachment #41877|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321
Marcel de Rooy changed:
What|Removed |Added
Attachment #41876|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321
Marcel de Rooy changed:
What|Removed |Added
Attachment #41878|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321
Marcel de Rooy changed:
What|Removed |Added
Attachment #41873|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321
Marcel de Rooy changed:
What|Removed |Added
Attachment #41880|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321
Marcel de Rooy changed:
What|Removed |Added
Attachment #41879|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321
--- Comment #38 from Marcel de Rooy ---
Created attachment 42414
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42414=edit
Bug 14321: Final cleanup, removing obsolete files
The new
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321
--- Comment #35 from Marcel de Rooy ---
Created attachment 42411
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42411=edit
Bug 14321: Add two columns to uploaded_files
This patch adds
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321
--- Comment #36 from Marcel de Rooy ---
Created attachment 42412
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42412=edit
Bug 14321: Introduce Koha::Upload
This patch introduces
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321
--- Comment #37 from Marcel de Rooy ---
Created attachment 42413
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42413=edit
Bug 14321: Integrate Upload.pm into Koha
This patch makes the
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321
Marcel de Rooy changed:
What|Removed |Added
Attachment #41881|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321
Marcel de Rooy changed:
What|Removed |Added
Status|ASSIGNED
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321
Marcel de Rooy changed:
What|Removed |Added
Status|Needs Signoff
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321
--- Comment #33 from Marcel de Rooy ---
CHECK: No results while files have been uploaded permanently? Test by drojf.
--
You are receiving this mail because:
You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321
Marcel de Rooy m.de.r...@rijksmuseum.nl changed:
What|Removed |Added
See Also|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321
Marcel de Rooy m.de.r...@rijksmuseum.nl changed:
What|Removed |Added
Depends on|14588, 14589|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321
--- Comment #32 from Marcel de Rooy m.de.r...@rijksmuseum.nl ---
Rebased, included small change from bug 14589 for upload-file and
upload-file-progress. No dependencies anymore.
--
You are receiving this mail because:
You are
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321
Marcel de Rooy m.de.r...@rijksmuseum.nl changed:
What|Removed |Added
Attachment #41555|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321
Marcel de Rooy m.de.r...@rijksmuseum.nl changed:
What|Removed |Added
Attachment #41556|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321
Marcel de Rooy m.de.r...@rijksmuseum.nl changed:
What|Removed |Added
Attachment #41668|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321
Marcel de Rooy m.de.r...@rijksmuseum.nl changed:
What|Removed |Added
Attachment #41665|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321
Marcel de Rooy m.de.r...@rijksmuseum.nl changed:
What|Removed |Added
Attachment #41558|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321
Marcel de Rooy m.de.r...@rijksmuseum.nl changed:
What|Removed |Added
Attachment #41666|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321
Marcel de Rooy m.de.r...@rijksmuseum.nl changed:
What|Removed |Added
Attachment #41677|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321
Marcel de Rooy m.de.r...@rijksmuseum.nl changed:
What|Removed |Added
Attachment #41557|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321
Marcel de Rooy m.de.r...@rijksmuseum.nl changed:
What|Removed |Added
Attachment #41667|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321
Marcel de Rooy m.de.r...@rijksmuseum.nl changed:
What|Removed |Added
Attachment #41562|0 |1
1 - 100 of 125 matches
Mail list logo