[Koha-bugs] [Bug 14337] AllowRenewalIfOtherItemsAvailable counts holdable not for loan items when checking renewability

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14337 Kyle M Hall changed: What|Removed |Added Attachment #50841|0 |1 is obsolete|

[Koha-bugs] [Bug 14337] AllowRenewalIfOtherItemsAvailable counts holdable not for loan items when checking renewability

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14337 Kyle M Hall changed: What|Removed |Added Attachment #50840|0 |1 is obsolete|

[Koha-bugs] [Bug 14337] AllowRenewalIfOtherItemsAvailable counts holdable not for loan items when checking renewability

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14337 --- Comment #26 from Kyle M Hall --- Created attachment 50840 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50840&action=edit Bug 14337 [QA Followup] - Fix conditional -- You are receiving this mail because: You

[Koha-bugs] [Bug 14337] AllowRenewalIfOtherItemsAvailable counts holdable not for loan items when checking renewability

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14337 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com

[Koha-bugs] [Bug 14337] AllowRenewalIfOtherItemsAvailable counts holdable not for loan items when checking renewability

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14337 --- Comment #24 from Kyle M Hall --- Thanks for the followups Jonathan! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists

[Koha-bugs] [Bug 14337] AllowRenewalIfOtherItemsAvailable counts holdable not for loan items when checking renewability

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14337 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA Depends

[Koha-bugs] [Bug 14337] AllowRenewalIfOtherItemsAvailable counts holdable not for loan items when checking renewability

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14337 Jonathan Druart changed: What|Removed |Added Attachment #41787|0 |1 is obsolete|

[Koha-bugs] [Bug 14337] AllowRenewalIfOtherItemsAvailable counts holdable not for loan items when checking renewability

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14337 --- Comment #22 from Jonathan Druart --- Created attachment 41906 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41906&action=edit Bug 14337: Fix conflict with bug 9809 The reserves.constrainttype does not exist an

[Koha-bugs] [Bug 14337] AllowRenewalIfOtherItemsAvailable counts holdable not for loan items when checking renewability

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14337 --- Comment #23 from Jonathan Druart --- Created attachment 41907 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41907&action=edit Bug 14337: Add 2 more tests to be complete Signed-off-by: Jonathan Druart -- You

[Koha-bugs] [Bug 14337] AllowRenewalIfOtherItemsAvailable counts holdable not for loan items when checking renewability

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14337 Jonathan Druart changed: What|Removed |Added Attachment #41788|0 |1 is obsolete|

[Koha-bugs] [Bug 14337] AllowRenewalIfOtherItemsAvailable counts holdable not for loan items when checking renewability

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14337 Kyle M Hall changed: What|Removed |Added Attachment #41708|0 |1 is obsolete|

[Koha-bugs] [Bug 14337] AllowRenewalIfOtherItemsAvailable counts holdable not for loan items when checking renewability

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14337 --- Comment #18 from Kyle M Hall --- Created attachment 41788 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41788&action=edit Bug 14337 - AllowRenewalIfOtherItemsAvailable counts holdable not for loan items when che

[Koha-bugs] [Bug 14337] AllowRenewalIfOtherItemsAvailable counts holdable not for loan items when checking renewability

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14337 --- Comment #19 from Kyle M Hall --- (In reply to Jonathan Druart from comment #14) > Comment on attachment 41708 [details] [review] > Bug 14337 - Add Unit Tests > > Review of attachment 41708 [details] [review]: > --

[Koha-bugs] [Bug 14337] AllowRenewalIfOtherItemsAvailable counts holdable not for loan items when checking renewability

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14337 Jonathan Druart changed: What|Removed |Added See Also|http://bugs.koha-community. |http://bugs.koha-community.

[Koha-bugs] [Bug 14337] AllowRenewalIfOtherItemsAvailable counts holdable not for loan items when checking renewability

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14337 Jonathan Druart changed: What|Removed |Added See Also||http://bugs.koha-community.

[Koha-bugs] [Bug 14337] AllowRenewalIfOtherItemsAvailable counts holdable not for loan items when checking renewability

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14337 --- Comment #14 from Jonathan Druart --- Comment on attachment 41708 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41708 Bug 14337 - Add Unit Tests Review of attachment 41708: --> (http://bugs.koha-community.org

[Koha-bugs] [Bug 14337] AllowRenewalIfOtherItemsAvailable counts holdable not for loan items when checking renewability

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14337 --- Comment #13 from Kyle M Hall --- (In reply to Jonathan Druart from comment #10) > (In reply to Kyle M Hall from comment #9) > > I just wanted to publicly observe that these unit tests are such a mess that > > I'm spending hours wr

[Koha-bugs] [Bug 14337] AllowRenewalIfOtherItemsAvailable counts holdable not for loan items when checking renewability

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14337 --- Comment #12 from Kyle M Hall --- Created attachment 41709 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41709&action=edit Bug 14337 - AllowRenewalIfOtherItemsAvailable counts holdable not for loan items when che

[Koha-bugs] [Bug 14337] AllowRenewalIfOtherItemsAvailable counts holdable not for loan items when checking renewability

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14337 Kyle M Hall changed: What|Removed |Added Attachment #41263|0 |1 is obsolete|

[Koha-bugs] [Bug 14337] AllowRenewalIfOtherItemsAvailable counts holdable not for loan items when checking renewability

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14337 Kyle M Hall changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receivi

[Koha-bugs] [Bug 14337] AllowRenewalIfOtherItemsAvailable counts holdable not for loan items when checking renewability

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14337 --- Comment #10 from Jonathan Druart --- (In reply to Kyle M Hall from comment #9) > I just wanted to publicly observe that these unit tests are such a mess that > I'm spending hours writing unit tests for a patch that took minutes t

[Koha-bugs] [Bug 14337] AllowRenewalIfOtherItemsAvailable counts holdable not for loan items when checking renewability

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14337 --- Comment #9 from Kyle M Hall --- I just wanted to publicly observe that these unit tests are such a mess that I'm spending hours writing unit tests for a patch that took minutes to complete. We really need to think about how to cle

[Koha-bugs] [Bug 14337] AllowRenewalIfOtherItemsAvailable counts holdable not for loan items when checking renewability

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14337 --- Comment #8 from Kyle M Hall --- (In reply to Jonathan Druart from comment #7) > Kyle, the test you have provided passes against master. > I would expect something to fail, and then to be fixed by your patch. > > Why is the versio

[Koha-bugs] [Bug 14337] AllowRenewalIfOtherItemsAvailable counts holdable not for loan items when checking renewability

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14337 Kyle M Hall changed: What|Removed |Added Version|3.18|master -- You are receiving t

[Koha-bugs] [Bug 14337] AllowRenewalIfOtherItemsAvailable counts holdable not for loan items when checking renewability

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14337 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #7 f

[Koha-bugs] [Bug 14337] AllowRenewalIfOtherItemsAvailable counts holdable not for loan items when checking renewability

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14337 --- Comment #6 from Kyle M Hall --- (In reply to Jonathan Druart from comment #4) > Kyle, please provide tests for this change. Done! -- You are receiving this mail because: You are watching all bug changes. ___

[Koha-bugs] [Bug 14337] AllowRenewalIfOtherItemsAvailable counts holdable not for loan items when checking renewability

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14337 Kyle M Hall changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receivi

[Koha-bugs] [Bug 14337] AllowRenewalIfOtherItemsAvailable counts holdable not for loan items when checking renewability

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14337 --- Comment #5 from Kyle M Hall --- Created attachment 41569 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41569&action=edit Bug 14337 [QA Followup] - Add unit test -- You are receiving this mail because: You are

[Koha-bugs] [Bug 14337] AllowRenewalIfOtherItemsAvailable counts holdable not for loan items when checking renewability

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14337 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Failed QA

[Koha-bugs] [Bug 14337] AllowRenewalIfOtherItemsAvailable counts holdable not for loan items when checking renewability

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14337 Amit Gupta changed: What|Removed |Added Attachment #39898|0 |1 is obsolete|

[Koha-bugs] [Bug 14337] AllowRenewalIfOtherItemsAvailable counts holdable not for loan items when checking renewability

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14337 Amit Gupta changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receivin

[Koha-bugs] [Bug 14337] AllowRenewalIfOtherItemsAvailable counts holdable not for loan items when checking renewability

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14337 --- Comment #2 from Amit Gupta --- Created attachment 41262 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41262&action=edit Bug 14337 - AllowRenewalIfOtherItemsAvailable counts holdable not for loan items when chec

[Koha-bugs] [Bug 14337] AllowRenewalIfOtherItemsAvailable counts holdable not for loan items when checking renewability

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14337 Amit Gupta changed: What|Removed |Added CC||amitddng...@gmail.com -- You a

[Koha-bugs] [Bug 14337] AllowRenewalIfOtherItemsAvailable counts holdable not for loan items when checking renewability

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14337 --- Comment #1 from Kyle M Hall --- Created attachment 39898 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39898&action=edit Bug 14337 - AllowRenewalIfOtherItemsAvailable counts holdable not for loan items when chec

[Koha-bugs] [Bug 14337] AllowRenewalIfOtherItemsAvailable counts holdable not for loan items when checking renewability

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14337 Kyle M Hall changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexi

[Koha-bugs] [Bug 14337] AllowRenewalIfOtherItemsAvailable counts holdable not for loan items when checking renewability

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14337 Kyle M Hall changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com