[Koha-bugs] [Bug 14395] Two different ways to calculate 'No renewal before' ( days or hours)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14395 --- Comment #51 from Claudio --- *** Bug 15666 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mail

[Koha-bugs] [Bug 14395] Two different ways to calculate 'No renewal before' (days or hours)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14395 --- Comment #50 from bondiurbano --- (In reply to Holger Meißner from comment #44) > Don't worry, bondiurbano. Everything is okay. We're just waiting to pass QA. > The QA team also has to check a lot of other bugs, so this may take s

[Koha-bugs] [Bug 14395] Two different ways to calculate 'No renewal before' (days or hours)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14395 Kyle M Hall changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment

[Koha-bugs] [Bug 14395] Two different ways to calculate 'No renewal before' (days or hours)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14395 Jesse Weaver changed: What|Removed |Added Attachment #44952|0 |1 is obsolete|

[Koha-bugs] [Bug 14395] Two different ways to calculate 'No renewal before' (days or hours)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14395 Jesse Weaver changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiv

[Koha-bugs] [Bug 14395] Two different ways to calculate 'No renewal before' (days or hours)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14395 Jesse Weaver changed: What|Removed |Added Attachment #44950|0 |1 is obsolete|

[Koha-bugs] [Bug 14395] Two different ways to calculate 'No renewal before' (days or hours)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14395 Jesse Weaver changed: What|Removed |Added Attachment #44951|0 |1 is obsolete|

[Koha-bugs] [Bug 14395] Two different ways to calculate 'No renewal before' (days or hours)

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14395 --- Comment #45 from bondiurbano --- (In reply to Holger Meißner from comment #44) > Don't worry, bondiurbano. Everything is okay. We're just waiting to pass QA. > The QA team also has to check a lot of other bugs, so this may take so

[Koha-bugs] [Bug 14395] Two different ways to calculate 'No renewal before' (days or hours)

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14395 --- Comment #44 from Holger Meißner --- Don't worry, bondiurbano. Everything is okay. We're just waiting to pass QA. The QA team also has to check a lot of other bugs, so this may take some time. That's all. -- You are receiving thi

[Koha-bugs] [Bug 14395] Two different ways to calculate 'No renewal before' (days or hours)

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14395 --- Comment #43 from bondiurbano --- (In reply to Holger Meißner from comment #42) > Rebased on master. Holger, I do not understand what is the status of this issue... -- You are receiving this mail because: You are watching all bu

[Koha-bugs] [Bug 14395] Two different ways to calculate 'No renewal before' (days or hours)

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14395 --- Comment #42 from Holger Meißner --- Rebased on master. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-communi

[Koha-bugs] [Bug 14395] Two different ways to calculate 'No renewal before' (days or hours)

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14395 Holger Meißner changed: What|Removed |Added Attachment #43812|0 |1 is obsolete|

[Koha-bugs] [Bug 14395] Two different ways to calculate 'No renewal before' (days or hours)

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14395 Holger Meißner changed: What|Removed |Added Attachment #43810|0 |1 is obsolete|

[Koha-bugs] [Bug 14395] Two different ways to calculate 'No renewal before' (days or hours)

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14395 Holger Meißner changed: What|Removed |Added Attachment #43811|0 |1 is obsolete|

[Koha-bugs] [Bug 14395] Two different ways to calculate 'No renewal before' (days or hours)

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14395 --- Comment #38 from bondiurbano --- (In reply to Holger Meißner from comment #36) > Here you go, bondiurbano. Have a nice weekend :) Holger, the next release is ahead and it seems we have no lucky... -- You are receiving this mail

[Koha-bugs] [Bug 14395] Two different ways to calculate 'No renewal before' (days or hours)

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14395 --- Comment #37 from bondiurbano --- (In reply to Holger Meißner from comment #36) > Here you go, bondiurbano. Have a nice weekend :) Thanks Holger! Impressive... -- You are receiving this mail because: You are watching all bug cha

[Koha-bugs] [Bug 14395] Two different ways to calculate 'No renewal before' (days or hours)

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14395 --- Comment #36 from Holger Meißner --- Here you go, bondiurbano. Have a nice weekend :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing lis

[Koha-bugs] [Bug 14395] Two different ways to calculate 'No renewal before' (days or hours)

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14395 Holger Meißner changed: What|Removed |Added Attachment #42785|0 |1 is obsolete|

[Koha-bugs] [Bug 14395] Two different ways to calculate 'No renewal before' (days or hours)

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14395 Holger Meißner changed: What|Removed |Added Attachment #41054|0 |1 is obsolete|

[Koha-bugs] [Bug 14395] Two different ways to calculate 'No renewal before' (days or hours)

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14395 Holger Meißner changed: What|Removed |Added Attachment #41053|0 |1 is obsolete|

[Koha-bugs] [Bug 14395] Two different ways to calculate 'No renewal before' (days or hours)

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14395 --- Comment #32 from bondiurbano --- (In reply to Holger Meißner from comment #31) > I apologize. We have a bit of staff shortage here. But don't worry, it's on > my to-do-list. I hope I'll get it done next week. Thank you Holger! Ni

[Koha-bugs] [Bug 14395] Two different ways to calculate 'No renewal before' (days or hours)

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14395 --- Comment #31 from Holger Meißner --- I apologize. We have a bit of staff shortage here. But don't worry, it's on my to-do-list. I hope I'll get it done next week. -- You are receiving this mail because: You are watching all bug c

[Koha-bugs] [Bug 14395] Two different ways to calculate 'No renewal before' (days or hours)

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14395 --- Comment #30 from bondiurbano --- (In reply to Holger Meißner from comment #27) > Sry it took so long, bondiurbano! > > Now bug 14101 and 14395 have their own unit tests. Setting back to signed > off. Holger! My friend! You did n

[Koha-bugs] [Bug 14395] Two different ways to calculate 'No renewal before' (days or hours)

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14395 --- Comment #29 from Jonathan Druart --- Comment on attachment 41054 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41054 Bug 14395: Code changes Review of attachment 41054: --> (http://bugs.koha-community.org/bu

[Koha-bugs] [Bug 14395] Two different ways to calculate 'No renewal before' (days or hours)

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14395 --- Comment #28 from bondiurbano --- (In reply to Holger Meißner from comment #27) > Sry it took so long, bondiurbano! > > Now bug 14101 and 14395 have their own unit tests. Setting back to signed > off. Great job Holger! Thank you

[Koha-bugs] [Bug 14395] Two different ways to calculate 'No renewal before' (days or hours)

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14395 Holger Meißner changed: What|Removed |Added Status|Patch doesn't apply |Signed Off --- Comment #27

[Koha-bugs] [Bug 14395] Two different ways to calculate 'No renewal before' (days or hours)

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14395 Holger Meißner changed: What|Removed |Added Attachment #41197|0 |1 is obsolete|

[Koha-bugs] [Bug 14395] Two different ways to calculate 'No renewal before' (days or hours)

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14395 --- Comment #25 from bondiurbano --- (In reply to Holger Meißner from comment #23) > Sorry, I forgot about the unit tests. Note that two test cases (related to > bug 11634) still fail and I think they are not affected by anything I di

[Koha-bugs] [Bug 14395] Two different ways to calculate 'No renewal before' (days or hours)

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14395 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Patch doesn't apply

[Koha-bugs] [Bug 14395] Two different ways to calculate 'No renewal before' (days or hours)

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14395 Holger Meißner changed: What|Removed |Added Status|Failed QA |Signed Off --- Comment #23

[Koha-bugs] [Bug 14395] Two different ways to calculate 'No renewal before' (days or hours)

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14395 --- Comment #22 from Holger Meißner --- Created attachment 41197 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41197&action=edit Bug 14395: Unit tests This patch fixes test cases that broke because of the changes i

[Koha-bugs] [Bug 14395] Two different ways to calculate 'No renewal before' (days or hours)

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14395 --- Comment #21 from bondiurbano --- Created attachment 41189 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41189&action=edit No renewal before TEST IN DAYS AND HOURS UNIT No renewal before TEST IN DAYS AND HOURS U

[Koha-bugs] [Bug 14395] Two different ways to calculate 'No renewal before' (days or hours)

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14395 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Failed QA CC|

[Koha-bugs] [Bug 14395] Two different ways to calculate 'No renewal before' (days or hours)

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14395 --- Comment #19 from bondiurbano --- Holger, Please sign off for me this time. Git or sandboxes are misteries for me for now, despite I know that I must to learn its use as a best practice. I beg your patient. -- You are receivin

[Koha-bugs] [Bug 14395] Two different ways to calculate 'No renewal before' (days or hours)

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14395 Holger Meißner changed: What|Removed |Added Patch complexity|--- |Small patch -- You are rec

[Koha-bugs] [Bug 14395] Two different ways to calculate 'No renewal before' (days or hours)

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14395 --- Comment #18 from Holger Meißner --- Thank you for testing, bondiurbano! :) Please sign off 14101 as well. Git bz is a really comfortable way to do this, once you have set it up. http://wiki.koha-community.org/wiki/Git_bz_configur

[Koha-bugs] [Bug 14395] Two different ways to calculate 'No renewal before' (days or hours)

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14395 --- Comment #17 from bondiurbano --- (In reply to Katrin Fischer from comment #16) > Don't panic, just trying to help :) We can add your sign-off manually for > these patches during the QA step. > > For adding your sign-off line you

[Koha-bugs] [Bug 14395] Two different ways to calculate 'No renewal before' (days or hours)

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14395 --- Comment #16 from Katrin Fischer --- Don't panic, just trying to help :) We can add your sign-off manually for these patches during the QA step. For adding your sign-off line you can use git-bz if you are using a git installation

[Koha-bugs] [Bug 14395] Two different ways to calculate 'No renewal before' (days or hours)

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14395 --- Comment #15 from bondiurbano --- Glup! I'm soo sorry. I wrote above that I tested this issue in a local virtual machine. I did not know about what you are informing me (I am realizing I'm not the best tester!!) I'm no a prog

[Koha-bugs] [Bug 14395] Two different ways to calculate 'No renewal before' (days or hours)

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14395 --- Comment #14 from Katrin Fischer --- One step closer :) But we miss your signature in the patches - do you know that you can use the sandboxes for adding your sign off lines? (http://wiki.koha-community.org/wiki/Sandboxes) -- You

[Koha-bugs] [Bug 14395] Two different ways to calculate 'No renewal before' (days or hours)

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14395 bondiurbano changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #13 fro

[Koha-bugs] [Bug 14395] Two different ways to calculate 'No renewal before' (days or hours)

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14395 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --

[Koha-bugs] [Bug 14395] Two different ways to calculate 'No renewal before' (days or hours)

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14395 --- Comment #11 from bondiurbano --- Holger! Great job! I have tested all cases in a local virtual machine under Debian Jessie and Koha 3.20.1. All seem to work perfectly! I have tested both 14101 bug and 14395 bug together. I thin

[Koha-bugs] [Bug 14395] Two different ways to calculate 'No renewal before' (days or hours)

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14395 --- Comment #10 from bondiurbano --- (In reply to Holger Meißner from comment #8) > Note: With 'date' setting both OPAC user account and staff client display > soonest possible renewal including time. With 'exact time' setting the sta

[Koha-bugs] [Bug 14395] Two different ways to calculate 'No renewal before' (days or hours)

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14395 --- Comment #9 from bondiurbano --- (In reply to Holger Meißner from comment #5) > On second thought, it's kind of pointless to have hourly loans with > date-based 'No renewal before'. I'll change it, so that the syspref is only > rel

[Koha-bugs] [Bug 14395] Two different ways to calculate 'No renewal before' (days or hours)

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14395 Holger Meißner changed: What|Removed |Added Status|ASSIGNED|Needs Signoff --- Comment #

[Koha-bugs] [Bug 14395] Two different ways to calculate 'No renewal before' (days or hours)

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14395 Holger Meißner changed: What|Removed |Added Attachment #41027|0 |1 is obsolete|

[Koha-bugs] [Bug 14395] Two different ways to calculate 'No renewal before' (days or hours)

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14395 Holger Meißner changed: What|Removed |Added Attachment #41029|0 |1 is obsolete|

[Koha-bugs] [Bug 14395] Two different ways to calculate 'No renewal before' (days or hours)

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14395 Holger Meißner changed: What|Removed |Added Status|Needs Signoff |ASSIGNED --- Comment #5 fro

[Koha-bugs] [Bug 14395] Two different ways to calculate 'No renewal before' (days or hours)

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14395 Holger Meißner changed: What|Removed |Added Attachment #41028|0 |1 is obsolete|

[Koha-bugs] [Bug 14395] Two different ways to calculate 'No renewal before' (days or hours)

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14395 Holger Meißner changed: What|Removed |Added Status|NEW |Needs Signoff -- You are r

[Koha-bugs] [Bug 14395] Two different ways to calculate 'No renewal before' (days or hours)

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14395 --- Comment #2 from Holger Meißner --- Created attachment 41027 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41027&action=edit Bug 14395: Add new syspref NoRenewalBeforePrecision Currently the 'NoRenwalBefore' set

[Koha-bugs] [Bug 14395] Two different ways to calculate 'No renewal before' (days or hours)

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14395 --- Comment #3 from Holger Meißner --- Created attachment 41028 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41028&action=edit Bug 14395: Code changes This patch updates the calculation of 'No renewal before' to i

[Koha-bugs] [Bug 14395] Two different ways to calculate 'No renewal before' (days or hours)

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14395 bondiurbano changed: What|Removed |Added CC||cost...@gmail.com --- Comment

[Koha-bugs] [Bug 14395] Two different ways to calculate 'No renewal before' (days or hours)

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14395 Holger Meißner changed: What|Removed |Added Priority|P5 - low|P3 Change sponsored?|---