https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407
--- Comment #40 from M. Tompsett ---
Created attachment 70475
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70475&action=edit
Bug 14407: Allow restricting SCO to IP or IP range
Converted this to actual applicable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407
--- Comment #41 from M. Tompsett ---
Created attachment 70476
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70476&action=edit
Bug 14407: Unit tests for in_ipset
TEST PLAN
-
1) apply all pathches
2) sudo k
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407
M. Tompsett changed:
What|Removed |Added
CC||mtomp...@hotmail.com
Attachm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407
--- Comment #43 from Nicholas van Oudtshoorn ---
Thanks for fixing that - my bad :-(
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
K
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407
--- Comment #44 from M. Tompsett ---
Comment on attachment 70476
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70476
Bug 14407: Unit tests for in_ipset
Review of attachment 70476:
-->
(https://bugs.koha-communi
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407
--- Comment #45 from M. Tompsett ---
Created attachment 73316
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73316&action=edit
Bug 14407: Follow up add missing atomic update
The patch only added the system prefere
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407
--- Comment #46 from M. Tompsett ---
Created attachment 73318
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73318&action=edit
Bug 14407: Follow up to add test case and clean noise
Comment #28 has a /36 which is i
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407
--- Comment #47 from M. Tompsett ---
kohadevbox is triggered from 192.168.50.1, so testing 192.168.0.0/16 worked
nicely. :)
--
You are receiving this mail because:
You are watching all bug changes.
_
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407
--- Comment #48 from M. Tompsett ---
(In reply to Marc Véron from comment #28)
> - Set SelfCheckAllowByIPRanges to 192.168.1.1 192.168.1.0/36
> as described for syspref SelfCheckAllowByIPRanges
> Internal Server Error
> Plack e
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407
M. Tompsett changed:
What|Removed |Added
Attachment #70476|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407
M. Tompsett changed:
What|Removed |Added
Attachment #70475|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407
M. Tompsett changed:
What|Removed |Added
Attachment #73316|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407
M. Tompsett changed:
What|Removed |Added
Attachment #73318|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407
--- Comment #53 from M. Tompsett ---
The question is does the in_ipset return the correct value for bad ranges?
Because currently, it assumes open when a bad range is provided.
--
You are receiving this mail because:
You are watchi
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407
Michal Denar changed:
What|Removed |Added
CC||blac...@gmail.com
--- Commen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407
Nicholas van Oudtshoorn changed:
What|Removed |Added
Attachment #56066|0 |1
is obsol
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407
Nicholas van Oudtshoorn changed:
What|Removed |Added
Status|Failed QA |Needs Signoff
---
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407
Nicholas van Oudtshoorn changed:
What|Removed |Added
Attachment #68834|0 |1
is obsol
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407
Nicholas van Oudtshoorn changed:
What|Removed |Added
Attachment #68835|0 |1
is obsol
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407
Katrin Fischer changed:
What|Removed |Added
Keywords||Academy
CC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407
--- Comment #55 from M. Tompsett ---
(In reply to Michal Denar from comment #54)
> Please, rebase on master.
Please remember to set to "Patch Does Not Apply" when you request a rebase. :)
--
You are receiving this mail because:
Yo
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407
M. Tompsett changed:
What|Removed |Added
Attachment #73339|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407
--- Comment #57 from M. Tompsett ---
Created attachment 80736
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80736&action=edit
Bug 14407: Unit tests for in_ipset
TEST PLAN
-
1) apply all pathches
2) sudo k
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407
--- Comment #58 from M. Tompsett ---
Created attachment 80737
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80737&action=edit
Bug 14407: Follow up add missing atomic update
The patch only added the system prefere
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407
--- Comment #59 from M. Tompsett ---
Created attachment 80738
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80738&action=edit
Bug 14407: Follow up to add test case and clean noise
Comment #28 has a /36 which is i
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407
Zeno Tajoli changed:
What|Removed |Added
Patch complexity|--- |Medium patch
--
You are recei
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407
Frédéric Demians changed:
What|Removed |Added
CC||frede...@tamil.fr
--- Com
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407
Marc Véron changed:
What|Removed |Added
Status|Needs Signoff |Patch doesn't apply
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407
--- Comment #13 from Frédéric Demians ---
I'm interested in this functionality. Without response from Nicholas van
Oudtshoorn, I will refactor his patch.
--
You are receiving this mail because:
You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407
Nicholas van Oudtshoorn changed:
What|Removed |Added
Attachment #40854|0 |1
is obsole
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407
Nicholas van Oudtshoorn changed:
What|Removed |Added
Status|Patch doesn't apply |Needs Signoff
--
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407
Nicholas van Oudtshoorn changed:
What|Removed |Added
Attachment #45894|0 |1
is obsole
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407
Nicholas van Oudtshoorn changed:
What|Removed |Added
Attachment #45898|0 |1
is obsole
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407
Nicholas van Oudtshoorn changed:
What|Removed |Added
Summary|Basic access restrictions |Limit web-based
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407
--- Comment #2 from Indranil Das Gupta ---
Comment on attachment 40612
--> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40612
Allow web-based self-checkout to be limited to only certain IPs or IP ranges
Review of atta
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407
Indranil Das Gupta changed:
What|Removed |Added
CC||indr...@gmail.com
--
Y
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407
Nicholas van Oudtshoorn changed:
What|Removed |Added
Attachment #40612|0 |1
is obsole
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407
Indranil Das Gupta changed:
What|Removed |Added
CC||ro...@catalyst.net.nz
-
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407
--- Comment #4 from Robin Sheat ---
The only way we do this currently (AFAIK) is by regex style matching, see how
OpacSuppressionByIPRange is used in opac-search.pl.
A proper matching, like done in this bug, is probably a better way
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407
Nick Clemens changed:
What|Removed |Added
Status|Needs Signoff |ASSIGNED
CC|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407
Nicholas van Oudtshoorn changed:
What|Removed |Added
Attachment #40613|0 |1
is obsole
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407
--- Comment #7 from Robin Sheat ---
(In reply to Nicholas van Oudtshoorn from comment #6)
> As per Robin's suggestion in Comment 4, it no longer uses an XS module. I
> have, however, gone for Net::CIDR instead of Net::IP::Match. For o
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407
Nicholas van Oudtshoorn changed:
What|Removed |Added
Attachment #40852|0 |1
is obsole
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407
--- Comment #9 from Robin Sheat ---
As far as I can tell, this patch is looking good to me from a packaging-related
POV.
(In reply to Nicholas van Oudtshoorn from comment #8)
> Agreed it would need a new bug. Have had a quick squiz,
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407
Nicholas van Oudtshoorn changed:
What|Removed |Added
Status|ASSIGNED|Needs Signoff
---
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407
Marc Véron changed:
What|Removed |Added
Status|Needs Signoff |Patch doesn't apply
--- Commen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407
Nicholas van Oudtshoorn changed:
What|Removed |Added
Attachment #45899|0 |1
is obsol
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407
Nicholas van Oudtshoorn changed:
What|Removed |Added
Status|Patch doesn't apply |Needs Signoff
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407
Nicholas van Oudtshoorn changed:
What|Removed |Added
Attachment #51812|0 |1
is obsol
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407
--- Comment #20 from Nicholas van Oudtshoorn ---
Pinging anyone interested in looking at gettting this signed off! :-)
--
You are receiving this mail because:
You are watching all bug changes.
__
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407
Marc Véron changed:
What|Removed |Added
Depends on||16920
--- Comment #21 from Mar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407
Marc Véron changed:
What|Removed |Added
Status|Needs Signoff |Failed QA
--- Comment #22 from
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407
Nicholas van Oudtshoorn changed:
What|Removed |Added
Attachment #51813|0 |1
is obsol
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407
--- Comment #24 from Marc Véron ---
Quick test:
SQL error is gone.
However, I get an 'Internal Server Error'
plack-error.log says:
Could not compile (...)/opac/sco/sco-main.pl: "in_ipset" is not exported by the
C4::Auth module
Can
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407
Nicholas van Oudtshoorn changed:
What|Removed |Added
Status|Failed QA |Needs Signoff
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407
Nicholas van Oudtshoorn changed:
What|Removed |Added
Attachment #53760|0 |1
is obsol
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407
--- Comment #26 from Marc Véron ---
Hi Nicholas,
I tested and acces was restricted as expected (except printslip.pl, see below)
QA-Tools complain:
FAIL opac/sco/help.pl
FAIL forbidden patterns
forbidden pat
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407
Nicholas van Oudtshoorn changed:
What|Removed |Added
Attachment #54560|0 |1
is obsol
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407
--- Comment #28 from Marc Véron ---
Hi Nicholas
The qa tool no longer complains.
I re-tested with following scenario (restart plack after each change to
syspref):
- Client's IP is 192.168.1.32
- SelfCheckAllowByIPRanges is empty
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407
--- Comment #29 from Nicholas van Oudtshoorn ---
Hmmm - I don't see SelfCheckAllowByIPRanges preferencing suggesting one use
/36. The library I've used should support something like /24, which is what the
preference gives as a sugges
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407
--- Comment #30 from Marc Véron ---
(In reply to Nicholas van Oudtshoorn from comment #29)
> Hmmm - I don't see SelfCheckAllowByIPRanges preferencing suggesting one use
> /36. The library I've used should support something like /24,
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407
--- Comment #31 from Marc Véron ---
Created attachment 56064
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56064&action=edit
Bug 14407 - Allow restricting SCO to IP or IP range Fix presence of tabs in
files, and p
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407
Marc Véron changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--
You are receivi
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407
Marc Véron changed:
What|Removed |Added
Attachment #56064|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407
Marc Véron changed:
What|Removed |Added
Status|Signed Off |Needs Signoff
--
You are rece
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407
--- Comment #32 from Marc Véron ---
Created attachment 56065
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56065&action=edit
Bug 14407 - Allow restricting SCO to IP or IP range Fix presence of tabs in
files, and p
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407
Marc Véron changed:
What|Removed |Added
Attachment #56065|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407
Marc Véron changed:
What|Removed |Added
Attachment #55746|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407
Marc Véron changed:
What|Removed |Added
Attachment #56065|1 |0
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407
Marc Véron changed:
What|Removed |Added
Attachment #56065|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407
Marc Véron changed:
What|Removed |Added
Attachment #55746|1 |0
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407
Marc Véron changed:
What|Removed |Added
Attachment #55746|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407
--- Comment #34 from Marc Véron ---
Created attachment 56066
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56066&action=edit
Bug 14407 - Allow restricting SCO to IP or IP range Fix presence of tabs in
files, and p
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407
Marc Véron changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--
You are receivi
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407
Marcel de Rooy changed:
What|Removed |Added
Status|Signed Off |Failed QA
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407
Hayley Mapley changed:
What|Removed |Added
CC||hayleymap...@catalyst.net.n
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407
Hayley Mapley changed:
What|Removed |Added
Attachment #80738|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407
Marcel de Rooy changed:
What|Removed |Added
QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407
Marcel de Rooy changed:
What|Removed |Added
Status|BLOCKED |Passed QA
--
You are rece
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407
Marcel de Rooy changed:
What|Removed |Added
Attachment #80736|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407
Marcel de Rooy changed:
What|Removed |Added
Attachment #80737|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407
Marcel de Rooy changed:
What|Removed |Added
Attachment #80735|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407
Marcel de Rooy changed:
What|Removed |Added
Attachment #86123|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407
--- Comment #66 from Marcel de Rooy ---
@RM: Do we still have a keyword for packaging? dependency? Net::CIDR is added,
but it seems to be installed already with koha-common and friends.
The pref allows both start-finish and CIDR IP
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407
Katrin Fischer changed:
What|Removed |Added
CC||mi...@abunchofthings.net
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407
Nick Clemens changed:
What|Removed |Added
See Also||https://bugs.koha-community
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407
--- Comment #68 from Mirko Tietgen ---
libnet-server-perl depends on libnet-cidr-perl so we already have it. But it
should be declarded as dependency for koha-common for this bug.
--
You are receiving this mail because:
You are wat
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407
--- Comment #69 from Mirko Tietgen ---
(Please declare the dependency in PerlDependencies, I'll do the rest.)
--
You are receiving this mail because:
You are watching all bug changes.
___
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407
--- Comment #70 from Nick Clemens ---
Created attachment 89114
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89114&action=edit
Bug 14407: (RM follow-up) Add dependency for Net::CIDR
--
You are receiving this mai
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407
--- Comment #71 from Nick Clemens ---
Can I just get a thumbs up on adding the dep before pushing, I tried to get the
version number in Jessie and use that for the minimum
--
You are receiving this mail because:
You are watching al
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407
Martin Renvoize changed:
What|Removed |Added
CC||martin.renvoize@ptfs-europ
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407
Nick Clemens changed:
What|Removed |Added
Attachment #89114|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407
Nick Clemens changed:
What|Removed |Added
Status|Passed QA |Pushed to Master
--- Comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407
Martin Renvoize changed:
What|Removed |Added
Severity|enhancement |new feature
--
You are r
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407
Martin Renvoize changed:
What|Removed |Added
Version(s)||19.05.00
released
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407
Martin Renvoize changed:
What|Removed |Added
Text to go in the|To increase the security of |This new feature allows yo
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407
Martin Renvoize changed:
What|Removed |Added
Keywords|dependency |
--
You are receiving th
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407
David Cook changed:
What|Removed |Added
CC||dc...@prosentient.com.au
--- C
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407
--- Comment #76 from Martin Renvoize ---
We've not released yet.. perhaps we could change it to in_iprange quickly
before it's set in stone forever more.
What do you think David, does that sound more appropriate?
--
You are receiv
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407
Martin Renvoize changed:
What|Removed |Added
Blocks||22943
Referenced Bugs:
1 - 100 of 102 matches
Mail list logo