[Koha-bugs] [Bug 14457] Integrate LIBRIS spellchecking

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14457 --- Comment #42 from Katrin Fischer --- Are there any terms for use for this service? Who is allowed to use it and under which conditions? -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 14457] Integrate LIBRIS spellchecking

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14457 Martin Renvoize changed: What|Removed |Added CC|

[Koha-bugs] [Bug 14457] Integrate LIBRIS spellchecking

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14457 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master

[Koha-bugs] [Bug 14457] Integrate LIBRIS spellchecking

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14457 --- Comment #39 from Katrin Fischer --- I really like to see more use of the 'did you mean' structure! -- You are receiving this mail because: You are watching all bug changes. ___

[Koha-bugs] [Bug 14457] Integrate LIBRIS spellchecking

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14457 --- Comment #37 from Katrin Fischer --- Created attachment 87376 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87376=edit Bug 14457: (QA follow-up) Fix QA script complaints and amend system preference text Pod

[Koha-bugs] [Bug 14457] Integrate LIBRIS spellchecking

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14457 --- Comment #38 from Katrin Fischer --- Created attachment 87377 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87377=edit Bug 14457: (QA follow-up) Fix POD -- You are receiving this mail because: You are

[Koha-bugs] [Bug 14457] Integrate LIBRIS spellchecking

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14457 Katrin Fischer changed: What|Removed |Added Attachment #45967|0 |1 is obsolete|

[Koha-bugs] [Bug 14457] Integrate LIBRIS spellchecking

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14457 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are

[Koha-bugs] [Bug 14457] Integrate LIBRIS spellchecking

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14457 --- Comment #36 from Katrin Fischer --- Created attachment 87375 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87375=edit Bug 14457: (follow-up) Add syspref for Libris API URL Added another syspref for the url

[Koha-bugs] [Bug 14457] Integrate LIBRIS spellchecking

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14457 Katrin Fischer changed: What|Removed |Added Status|Failed QA |Signed Off --- Comment

[Koha-bugs] [Bug 14457] Integrate LIBRIS spellchecking

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14457 Björn Nylén changed: What|Removed |Added CC||bjorn.ny...@ub.lu.se ---

[Koha-bugs] [Bug 14457] Integrate LIBRIS spellchecking

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14457 --- Comment #32 from Björn Nylén --- Created attachment 86569 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86569=edit Bug 14457 - QA follow up Pod coverage for 'NAME'. Moved sysprefs in order and moved

[Koha-bugs] [Bug 14457] Integrate LIBRIS spellchecking

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14457 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff

[Koha-bugs] [Bug 14457] Integrate LIBRIS spellchecking

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14457 Chris Cormack changed: What|Removed |Added Status|ASSIGNED

[Koha-bugs] [Bug 14457] Integrate LIBRIS spellchecking

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14457 Chris Cormack changed: What|Removed |Added Attachment #55948|0 |1

[Koha-bugs] [Bug 14457] Integrate LIBRIS spellchecking

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14457 --- Comment #29 from Chris Cormack --- (In reply to Katrin Fischer from comment #27) > I tried fixing the typo, but now I get: > File does not exist: 400 URL must be absolute > at

[Koha-bugs] [Bug 14457] Integrate LIBRIS spellchecking

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14457 Chris Cormack changed: What|Removed |Added Status|Failed QA

[Koha-bugs] [Bug 14457] Integrate LIBRIS spellchecking

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14457 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff

[Koha-bugs] [Bug 14457] Integrate LIBRIS spellchecking

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14457 lesteretsel changed: What|Removed |Added CC|

[Koha-bugs] [Bug 14457] Integrate LIBRIS spellchecking

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14457 --- Comment #25 from Chris Cormack --- Created attachment 55948 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55948=edit Bug 14457 - Follow up Added another syspref for the url of the

[Koha-bugs] [Bug 14457] Integrate LIBRIS spellchecking

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14457 Chris Cormack changed: What|Removed |Added Status|ASSIGNED

[Koha-bugs] [Bug 14457] Integrate LIBRIS spellchecking

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14457 Chris Cormack changed: What|Removed |Added CC|

[Koha-bugs] [Bug 14457] Integrate LIBRIS spellchecking

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14457 --- Comment #23 from Katrin Fischer --- I think if a pref - better have a proper one so we know what's going on there :) The Did-you-mean-feature already has a very modulized structure, so I think adding to

[Koha-bugs] [Bug 14457] Integrate LIBRIS spellchecking

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14457 --- Comment #22 from Marcel de Rooy --- (In reply to Katrin Fischer from comment #20) > Looking at the code this seems a very specific feature, like Amazon-Covers, > Syndectics, etc. > >

[Koha-bugs] [Bug 14457] Integrate LIBRIS spellchecking

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14457 --- Comment #21 from Eivin Giske Skaaren --- Hi, It seems like they have changed the url to http://api.libris.kb.se/bibspell/ so perhaps some way of changing it without committing code would be good. Please

[Koha-bugs] [Bug 14457] Integrate LIBRIS spellchecking

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14457 --- Comment #20 from Katrin Fischer --- Looking at the code this seems a very specific feature, like Amazon-Covers, Syndectics, etc. Koha::SuggestionEngine::Plugin::LibrisSpellcheck; So if the URL is

[Koha-bugs] [Bug 14457] Integrate LIBRIS spellchecking

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14457 --- Comment #19 from Marcel de Rooy --- (In reply to Katrin Fischer from comment #18) > I am not sure about a preference here as it's a plugin for a specific API > (LibrisSpellcheck.pm). Please explain

[Koha-bugs] [Bug 14457] Integrate LIBRIS spellchecking

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14457 --- Comment #18 from Katrin Fischer --- I am not sure about a preference here as it's a plugin for a specific API (LibrisSpellcheck.pm). -- You are receiving this mail because: You are watching all bug

[Koha-bugs] [Bug 14457] Integrate LIBRIS spellchecking

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14457 Marcel de Rooy changed: What|Removed |Added Status|Signed Off

[Koha-bugs] [Bug 14457] Integrate LIBRIS spellchecking

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14457 Marcel de Rooy changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit

[Koha-bugs] [Bug 14457] Integrate LIBRIS spellchecking

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14457 Marcel de Rooy changed: What|Removed |Added CC|

[Koha-bugs] [Bug 14457] Integrate LIBRIS spellchecking

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14457 --- Comment #15 from David Cook --- Comment on attachment 45967 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45967 Bug 14457: Integrate LIBRIS spellchecking Review of attachment 45967:

[Koha-bugs] [Bug 14457] Integrate LIBRIS spellchecking

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14457 Chris Cormack changed: What|Removed |Added Attachment #40827|0 |1

[Koha-bugs] [Bug 14457] Integrate LIBRIS spellchecking

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14457 Chris Cormack changed: What|Removed |Added Status|Needs Signoff

[Koha-bugs] [Bug 14457] Integrate LIBRIS spellchecking

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14457 Zeno Tajoli changed: What|Removed |Added Status|Failed QA |Needs

[Koha-bugs] [Bug 14457] Integrate LIBRIS spellchecking

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14457 Zeno Tajoli changed: What|Removed |Added CC|

[Koha-bugs] [Bug 14457] Integrate LIBRIS spellchecking

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14457 Zeno Tajoli changed: What|Removed |Added Patch complexity|--- |Small

[Koha-bugs] [Bug 14457] Integrate LIBRIS spellchecking

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14457 --- Comment #12 from Katrin Fischer --- Hm does it need to? It uses the "did you mean" plugin structure. did you test? -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 14457] Integrate LIBRIS spellchecking

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14457 --- Comment #13 from Zeno Tajoli --- I do a an error on reading the code. I reset 'Needs Signoff'. -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 14457] Integrate LIBRIS spellchecking

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14457 --- Comment #9 from Eivin Giske Skaaren ei...@sysmystic.com --- It was indeed the rebase. I have reviewed my original commit and those 2 changes was not part of it. -- You are receiving this mail because: You are watching all bug

[Koha-bugs] [Bug 14457] Integrate LIBRIS spellchecking

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14457 Eivin Giske Skaaren ei...@sysmystic.com changed: What|Removed |Added Attachment #40816|0 |1

[Koha-bugs] [Bug 14457] Integrate LIBRIS spellchecking

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14457 --- Comment #7 from Eivin Giske Skaaren ei...@sysmystic.com --- Hi David, I actually did most of the work several weeks ago but regarding the two issues I think that I just followed the example/plugin that was there. I will take a

[Koha-bugs] [Bug 14457] Integrate LIBRIS spellchecking

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14457 --- Comment #8 from Katrin Fischer katrin.fisc...@bsz-bw.de --- The problem is that given-when is experimental and will spam the logs. It really needs to be rewritten to be an if-else-construct instead. And if there are more we should

[Koha-bugs] [Bug 14457] Integrate LIBRIS spellchecking

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14457 --- Comment #4 from Eivin Giske Skaaren ei...@sysmystic.com --- Created attachment 40816 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40816action=edit Bug 14457: Integrate LIBRIS spellchecking This patch makes it

[Koha-bugs] [Bug 14457] Integrate LIBRIS spellchecking

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14457 Eivin Giske Skaaren ei...@sysmystic.com changed: What|Removed |Added Status|ASSIGNED

[Koha-bugs] [Bug 14457] Integrate LIBRIS spellchecking

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14457 --- Comment #3 from Eivin Giske Skaaren ei...@sysmystic.com --- Before I post the patch let me address the question about a general spellchecking/did you mean. There is already did you mean facilities to plug into and I also used

[Koha-bugs] [Bug 14457] Integrate LIBRIS spellchecking

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14457 David Cook dc...@prosentient.com.au changed: What|Removed |Added CC|

[Koha-bugs] [Bug 14457] Integrate LIBRIS spellchecking

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14457 --- Comment #6 from David Cook dc...@prosentient.com.au --- Comment on attachment 40816 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40816 Bug 14457: Integrate LIBRIS spellchecking Review of attachment 40816: --

[Koha-bugs] [Bug 14457] Integrate LIBRIS spellchecking

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14457 Eivin Giske Skaaren ei...@sysmystic.com changed: What|Removed |Added Status|NEW

[Koha-bugs] [Bug 14457] Integrate LIBRIS spellchecking

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14457 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added CC|