https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576
--- Comment #98 from Nick Clemens ---
Created attachment 83698
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83698=edit
Bug 14576: Update to use get_yaml_pref_hash
--
You are receiving this mail because:
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576
--- Comment #97 from Nick Clemens ---
Created attachment 83697
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83697=edit
Bug 14576: Unit tests
To test:
1 - prove -v t/db_dependent/Circulation/Returns.t
2 - prove
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576
Nick Clemens changed:
What|Removed |Added
Attachment #83113|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576
--- Comment #95 from Nick Clemens ---
(In reply to Josef Moravec from comment #89)
> Nick, why do you prefer to _ALL_ rule override everything? Shouldn't the
> most specific rule be the first taken into account and _ALL_ rule used
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576
--- Comment #94 from Nick Clemens ---
Created attachment 83115
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83115=edit
Bug 14576: Update to use get_yaml_pref_hash and perl update statement
--
You are receiving
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576
--- Comment #93 from Nick Clemens ---
Created attachment 83114
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83114=edit
Bug 14576: Unit tests
To test:
1 - prove -v t/db_dependent/Circulation/Returns.t
2 - prove
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576
Nick Clemens changed:
What|Removed |Added
Attachment #79995|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576
Nick Clemens changed:
What|Removed |Added
Status|Patch doesn't apply |Signed Off
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576
Alex Buckley changed:
What|Removed |Added
Status|Signed Off |Patch doesn't apply
---
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576
--- Comment #90 from Alex Buckley ---
Hi Nick
Can you please rebase? The conflict against master to be resolved is only small
but git-bz fails to merge it automatically.
Cheers,
Alex
--
You are receiving this mail because:
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576
Martin Renvoize changed:
What|Removed |Added
Patch complexity|Small patch |Medium patch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576
Josef Moravec changed:
What|Removed |Added
Blocks||21502
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576
Josef Moravec changed:
What|Removed |Added
CC||josef.mora...@gmail.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576
--- Comment #88 from Michal Denar ---
Created attachment 79996
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79996=edit
Bug 14576: Unit tests
To test:
1 - prove -v t/db_dependent/Circulation/Returns.t
2 - prove
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576
Michal Denar changed:
What|Removed |Added
Attachment #79245|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576
Michal Denar changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576
--- Comment #86 from Nick Clemens ---
Created attachment 79246
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79246=edit
Bug 14576: Unit tests
To test:
1 - prove -v t/db_dependent/Circulation/Returns.t
2 - prove
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576
Nick Clemens changed:
What|Removed |Added
Attachment #75661|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576
Nick Clemens changed:
What|Removed |Added
Status|Patch doesn't apply |Needs Signoff
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576
Claire Gravely changed:
What|Removed |Added
CC||claire_grav...@hotmail.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576
Alex Buckley changed:
What|Removed |Added
Blocks||21159
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576
Katrin Fischer changed:
What|Removed |Added
See Also|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576
--- Comment #83 from Nick Clemens ---
Created attachment 75663
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75663=edit
Bug 14576: (follow-up)
Fix (remove) extra call for item
Fix rebase error code duplication
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576
--- Comment #82 from Nick Clemens ---
Created attachment 75662
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75662=edit
Bug 14576: Unit tests
--
You are receiving this mail because:
You are watching all bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576
Nick Clemens changed:
What|Removed |Added
Attachment #72032|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576
Nick Clemens changed:
What|Removed |Added
Attachment #70795|0 |1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576
--- Comment #79 from Nick Clemens ---
Created attachment 72033
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72033=edit
Bug 14576: Unit tests
--
You are receiving this mail because:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576
--- Comment #80 from Nick Clemens ---
Created attachment 72034
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72034=edit
Bug 14576: Followup
Fix (remove) extra call for item
Fix rebase
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576
--- Comment #76 from Nick Clemens ---
Created attachment 70796
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70796=edit
Bug 14576: Unit tests
--
You are receiving this mail because:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576
--- Comment #77 from Nick Clemens ---
Created attachment 70797
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70797=edit
Bug 14576: Followup
Fix (remove) extra call for item
Fix rebase
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576
Nick Clemens changed:
What|Removed |Added
Attachment #67610|0 |1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576
Nick Clemens changed:
What|Removed |Added
Status|Patch doesn't apply
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576
Katrin Fischer changed:
What|Removed |Added
Status|Needs Signoff
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576
--- Comment #73 from Nick Clemens ---
(In reply to Katrin Fischer from comment #71)
> With the patch applied the message "Not checked out." appears twice when
> returning an item that has not been checked
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576
Nick Clemens changed:
What|Removed |Added
Status|Failed QA
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576
--- Comment #72 from Nick Clemens ---
Created attachment 68297
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68297=edit
Bug 14576: Followup
Fix (remove) extra call for item
Fix rebase
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576
Katrin Fischer changed:
What|Removed |Added
Status|Needs Signoff
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576
Nick Clemens changed:
What|Removed |Added
Status|In Discussion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576
Alex Buckley changed:
What|Removed |Added
Status|Needs Signoff
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576
Marjorie Barry-Vila changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576
--- Comment #68 from Nick Clemens ---
Created attachment 67611
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67611=edit
Bug 14576: Unit tests
--
You are receiving this mail because:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576
Nick Clemens changed:
What|Removed |Added
Status|Signed Off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576
Nick Clemens changed:
What|Removed |Added
Attachment #64656|0 |1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576
Lisa changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576
--- Comment #66 from Nick Clemens ---
Created attachment 64658
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64658=edit
Bug 14576 - (QA followups squashed)
Fix message for use of value
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576
Nick Clemens changed:
What|Removed |Added
Attachment #61940|0 |1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576
Nick Clemens changed:
What|Removed |Added
Status|Patch doesn't apply
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576
--- Comment #65 from Nick Clemens ---
Created attachment 64657
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64657=edit
Bug 14576 - Unit tests
Signed-off-by: Cathi Wiggins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576
Marcel de Rooy changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576
Nick Clemens changed:
What|Removed |Added
Attachment #60748|0 |1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576
--- Comment #62 from Nick Clemens ---
Created attachment 61950
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61950=edit
Bug 14576 (QA Followup) Fix warnings in tests
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576
Nick Clemens changed:
What|Removed |Added
Attachment #60747|0 |1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576
Nick Clemens changed:
What|Removed |Added
Attachment #60751|0 |1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576
Nick Clemens changed:
What|Removed |Added
Attachment #60663|0 |1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576
Nick Clemens changed:
What|Removed |Added
Attachment #60658|0 |1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576
Nick Clemens changed:
What|Removed |Added
Attachment #60659|0 |1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576
Nick Clemens changed:
What|Removed |Added
Attachment #60662|0 |1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576
Nick Clemens changed:
What|Removed |Added
Attachment #60661|0 |1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576
Nick Clemens changed:
What|Removed |Added
Attachment #60660|0 |1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576
Nick Clemens changed:
What|Removed |Added
Status|Failed QA
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576
Jonathan Druart changed:
What|Removed |Added
Status|Signed Off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576
Nick Clemens changed:
What|Removed |Added
Status|Failed QA
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576
--- Comment #51 from Nick Clemens ---
Created attachment 60751
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60751=edit
Bug 14576 - (QA Followup) Fix Returns.t
Two warnings, not one
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576
--- Comment #50 from Nick Clemens ---
(In reply to Jonathan Druart from comment #47)
> C4::Items::ShelfToCart is no longer in used.
Removed
> Tests do not pass.
Indeed, Returns.t is failing, but I have no
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576
--- Comment #48 from Nick Clemens ---
Created attachment 60747
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60747=edit
Bug 14576 (QA Followup) Remove C4:::Items::ShelfToCart
--
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576
--- Comment #49 from Nick Clemens ---
Created attachment 60748
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60748=edit
Bug 14576 (QA Followup) Fix issue.t
--
You are receiving this
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576
Jonathan Druart changed:
What|Removed |Added
Status|Signed Off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576
--- Comment #42 from Nick Clemens ---
Created attachment 60659
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60659=edit
Bug 14576 - Unit tests
Signed-off-by: Cathi Wiggins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576
--- Comment #46 from Nick Clemens ---
Created attachment 60663
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60663=edit
Bug 14576 (QA Followup) Fix undelcared use of $item Move strings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576
--- Comment #45 from Nick Clemens ---
Created attachment 60662
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60662=edit
Bug 14576 - (QA Followup) Remove other instances of
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576
--- Comment #43 from Nick Clemens ---
Created attachment 60660
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60660=edit
Bug 14576 - (QA followup) Fix message for use of value not in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576
--- Comment #44 from Nick Clemens ---
Created attachment 60661
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60661=edit
Bug 14576 (QA Folllowup) Address issues
use mock for tests
use a
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576
Nick Clemens changed:
What|Removed |Added
Attachment #54644|0 |1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576
Nick Clemens changed:
What|Removed |Added
Status|Patch doesn't apply
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576
Nicole C. Engard changed:
What|Removed |Added
CC|neng...@gmail.com |
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576
Owen Leonard changed:
What|Removed |Added
Status|Signed Off |Patch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576
--- Comment #39 from Nick Clemens ---
(In reply to Katrin Fischer from comment #37)
> starting with a first code review here:
> 1) There seem to be a few lines doubled up in AddIssue now:
Fixed
> 2)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576
--- Comment #38 from Nick Clemens ---
Created attachment 55587
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55587=edit
Bug 14576 (QA Followup) Fix undelcared use of $item Move
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576
Nick Clemens changed:
What|Removed |Added
Status|Failed QA
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576
Katrin Fischer changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576
Nick Clemens changed:
What|Removed |Added
Attachment #54648|0 |1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576
--- Comment #35 from Nick Clemens ---
(In reply to Jonathan Druart from comment #29)
> (In reply to Nick Clemens from comment #28)
> > Adds the UpdateItemLocationOnCheckin to svc/checkin
>
> Why is it
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576
Nick Clemens changed:
What|Removed |Added
Attachment #54281|0 |1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576
Nick Clemens changed:
What|Removed |Added
Attachment #53115|0 |1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576
Nick Clemens changed:
What|Removed |Added
Attachment #53114|0 |1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576
Nick Clemens changed:
What|Removed |Added
Attachment #53113|0 |1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576
Nick Clemens changed:
What|Removed |Added
Attachment #53112|0 |1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576
--- Comment #29 from Jonathan Druart
---
(In reply to Nick Clemens from comment #28)
> Adds the UpdateItemLocationOnCheckin to svc/checkin
Why is it needed?
svc/checkin calls AddReturn
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576
Nick Clemens changed:
What|Removed |Added
See Also|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576
--- Comment #28 from Nick Clemens ---
Created attachment 54281
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54281=edit
Bug 14576 - (QA Followup) Remove other instances of
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576
Nick Clemens changed:
What|Removed |Added
Status|Failed QA
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576
rkui...@roundrocktexas.gov changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576
Jonathan Druart changed:
What|Removed |Added
Status|Signed Off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576
Nicole C. Engard changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576
--- Comment #26 from Nick Clemens ---
(In reply to Owen Leonard from comment #7)
> I think that should be "Item shelving location" (since "location" could be
> confused with "library").
Changed
> I
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576
Nick Clemens changed:
What|Removed |Added
Attachment #5|0 |1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576
Nick Clemens changed:
What|Removed |Added
Attachment #52224|0 |1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576
Nick Clemens changed:
What|Removed |Added
Attachment #52365|0 |1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576
Nick Clemens changed:
What|Removed |Added
Attachment #52223|0 |1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576
Nick Clemens changed:
What|Removed |Added
Status|Patch doesn't apply
1 - 100 of 131 matches
Mail list logo