[Koha-bugs] [Bug 14641] Warns in subscription-add.pl

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14641 Frédéric Demians changed: What|Removed |Added CC||frede...@tamil.fr --- Co

[Koha-bugs] [Bug 14641] Warns in subscription-add.pl

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14641 Julian Maurice changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable

[Koha-bugs] [Bug 14641] Warns in subscription-add.pl

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14641 Brendan Gallagher changed: What|Removed |Added CC||bren...@bywatersolutions

[Koha-bugs] [Bug 14641] Warns in subscription-add.pl

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14641 Jonathan Druart changed: What|Removed |Added Attachment #46560|0 |1 is obsolete|

[Koha-bugs] [Bug 14641] Warns in subscription-add.pl

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14641 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are rece

[Koha-bugs] [Bug 14641] Warns in subscription-add.pl

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14641 Magnus Enger changed: What|Removed |Added Status|Needs Signoff |Signed Off Patch complexity

[Koha-bugs] [Bug 14641] Warns in subscription-add.pl

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14641 Magnus Enger changed: What|Removed |Added Attachment #46500|0 |1 is obsolete|

[Koha-bugs] [Bug 14641] Warns in subscription-add.pl

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14641 Aleisha Amohia changed: What|Removed |Added Attachment #45623|0 |1 is obsolete|

[Koha-bugs] [Bug 14641] Warns in subscription-add.pl

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14641 Aleisha Amohia changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are r

[Koha-bugs] [Bug 14641] Warns in subscription-add.pl

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14641 --- Comment #7 from Jonathan Druart --- The verbose way to do it is: my ($selected_lettercode) = @_; if ( not defined $selected_lettercode ) { $selected_lettercode = ''; } A better way, IMO is to use `unless` in

[Koha-bugs] [Bug 14641] Warns in subscription-add.pl

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14641 --- Comment #6 from Aleisha Amohia --- (In reply to Joonas Kylmälä from comment #2) > The warning is triggered when get_letter_loop() is called without an > argument. We should maybe check if @_ is true, and if it's not then use $_ >

[Koha-bugs] [Bug 14641] Warns in subscription-add.pl

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14641 Jonathan Druart changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #5 f

[Koha-bugs] [Bug 14641] Warns in subscription-add.pl

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14641 Aleisha Amohia changed: What|Removed |Added Attachment #41325|0 |1 is obsolete|

[Koha-bugs] [Bug 14641] Warns in subscription-add.pl

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14641 Aleisha Amohia changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are r

[Koha-bugs] [Bug 14641] Warns in subscription-add.pl

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14641 Jonathan Druart changed: What|Removed |Added Severity|enhancement |minor Status|N

[Koha-bugs] [Bug 14641] Warns in subscription-add.pl

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14641 Joonas Kylmälä changed: What|Removed |Added CC||j.kylm...@gmail.com --- Com

[Koha-bugs] [Bug 14641] Warns in subscription-add.pl

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14641 Aleisha Amohia changed: What|Removed |Added Status|NEW |Needs Signoff -- You are r

[Koha-bugs] [Bug 14641] Warns in subscription-add.pl

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14641 --- Comment #1 from Aleisha Amohia --- Created attachment 41325 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41325&action=edit Bug 14641: Warns in subscription-add.pl I think the warns are being triggered because