[Koha-bugs] [Bug 14694] Make decreaseloanHighHolds more flexible

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14694 --- Comment #45 from Kyle M Hall --- Created attachment 48804 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48804=edit Bug 14694 [QA Followup] - Update Koha::Borrower references to

[Koha-bugs] [Bug 14694] Make decreaseloanHighHolds more flexible

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14694 Brendan Gallagher changed: What|Removed |Added Status|Passed QA

[Koha-bugs] [Bug 14694] Make decreaseloanHighHolds more flexible

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14694 Kyle M Hall changed: What|Removed |Added Attachment #48580|0 |1

[Koha-bugs] [Bug 14694] Make decreaseloanHighHolds more flexible

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14694 Kyle M Hall changed: What|Removed |Added Status|Signed Off

[Koha-bugs] [Bug 14694] Make decreaseloanHighHolds more flexible

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14694 M. Tompsett changed: What|Removed |Added Status|Patch doesn't apply |Signed

[Koha-bugs] [Bug 14694] Make decreaseloanHighHolds more flexible

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14694 M. Tompsett changed: What|Removed |Added Attachment #46866|0 |1

[Koha-bugs] [Bug 14694] Make decreaseloanHighHolds more flexible

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14694 M. Tompsett changed: What|Removed |Added Attachment #46867|0 |1

[Koha-bugs] [Bug 14694] Make decreaseloanHighHolds more flexible

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14694 M. Tompsett changed: What|Removed |Added Attachment #46865|0 |1

[Koha-bugs] [Bug 14694] Make decreaseloanHighHolds more flexible

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14694 M. Tompsett changed: What|Removed |Added Attachment #46868|0 |1

[Koha-bugs] [Bug 14694] Make decreaseloanHighHolds more flexible

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14694 M. Tompsett changed: What|Removed |Added Attachment #46864|0 |1

[Koha-bugs] [Bug 14694] Make decreaseloanHighHolds more flexible

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14694 Brendan Gallagher changed: What|Removed |Added CC|

[Koha-bugs] [Bug 14694] Make decreaseloanHighHolds more flexible

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14694 --- Comment #35 from Christopher Brannon --- Awesome! Thank you! Christopher -- You are receiving this mail because: You are watching all bug changes. ___

[Koha-bugs] [Bug 14694] Make decreaseloanHighHolds more flexible

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14694 --- Comment #34 from Jonathan Druart --- Created attachment 46868 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46868=edit Bug 14694: Create data the tests need

[Koha-bugs] [Bug 14694] Make decreaseloanHighHolds more flexible

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14694 --- Comment #31 from Jonathan Druart --- Created attachment 46865 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46865=edit Bug 14694 [QA Followup] - Fix unit tests

[Koha-bugs] [Bug 14694] Make decreaseloanHighHolds more flexible

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14694 --- Comment #33 from Jonathan Druart --- Created attachment 46867 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46867=edit Bug 14694 [QA Followup] - Fix syspref order

[Koha-bugs] [Bug 14694] Make decreaseloanHighHolds more flexible

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14694 --- Comment #32 from Jonathan Druart --- Created attachment 46866 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46866=edit Bug 14694 [QA Followup] - Fix typos

[Koha-bugs] [Bug 14694] Make decreaseloanHighHolds more flexible

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14694 Jonathan Druart changed: What|Removed |Added Attachment #46532|0

[Koha-bugs] [Bug 14694] Make decreaseloanHighHolds more flexible

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14694 Jonathan Druart changed: What|Removed |Added Status|Signed Off

[Koha-bugs] [Bug 14694] Make decreaseloanHighHolds more flexible

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14694 --- Comment #24 from Jonathan Druart --- I would love to get an answer when I ask for a question. -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 14694] Make decreaseloanHighHolds more flexible

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14694 --- Comment #25 from Kyle M Hall --- (In reply to Jonathan Druart from comment #22) > (In reply to Kyle M Hall from comment #20) > > > > ::: Koha/Biblio.pm > > > > @@ +41,5 @@ > > > > > +or list of

[Koha-bugs] [Bug 14694] Make decreaseloanHighHolds more flexible

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14694 --- Comment #27 from Kyle M Hall --- Created attachment 46533 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46533=edit Bug 14694 [QA Followup] - Fix unit tests -- You are receiving this

[Koha-bugs] [Bug 14694] Make decreaseloanHighHolds more flexible

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14694 --- Comment #28 from Kyle M Hall --- Created attachment 46534 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46534=edit Bug 14694 [QA Followup] - Fix typos -- You are receiving this mail

[Koha-bugs] [Bug 14694] Make decreaseloanHighHolds more flexible

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14694 Kyle M Hall changed: What|Removed |Added Attachment #43598|0 |1

[Koha-bugs] [Bug 14694] Make decreaseloanHighHolds more flexible

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14694 --- Comment #29 from Kyle M Hall --- Created attachment 46535 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46535=edit Bug 14694 [QA Followup] - Fix syspref order -- You are receiving

[Koha-bugs] [Bug 14694] Make decreaseloanHighHolds more flexible

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14694 --- Comment #23 from Christopher Brannon --- Would LOVE it if this could get a QA. :) Christopher -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 14694] Make decreaseloanHighHolds more flexible

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14694 Kyle M Hall changed: What|Removed |Added CC|

[Koha-bugs] [Bug 14694] Make decreaseloanHighHolds more flexible

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14694 --- Comment #22 from Jonathan Druart --- (In reply to Kyle M Hall from comment #20) > > > ::: Koha/Biblio.pm > > > @@ +41,5 @@ > > > > +or list of Koha::Item objects in list context. > > > >

[Koha-bugs] [Bug 14694] Make decreaseloanHighHolds more flexible

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14694 --- Comment #20 from Kyle M Hall --- (In reply to Jonathan Druart from comment #18) > (In reply to Kyle M Hall from comment #17) > > > 6 vs 5 > > > > That is a purposeful change. The issue was that the logic

[Koha-bugs] [Bug 14694] Make decreaseloanHighHolds more flexible

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14694 Kyle M Hall changed: What|Removed |Added Status|Failed QA |Signed

[Koha-bugs] [Bug 14694] Make decreaseloanHighHolds more flexible

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14694 --- Comment #21 from Kyle M Hall --- Created attachment 43952 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43952=edit Bug 14694 [QA Followup] - Fix syspref order -- You are receiving

[Koha-bugs] [Bug 14694] Make decreaseloanHighHolds more flexible

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14694 Katrin Fischer changed: What|Removed |Added CC|

[Koha-bugs] [Bug 14694] Make decreaseloanHighHolds more flexible

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14694 --- Comment #18 from Jonathan Druart --- (In reply to Kyle M Hall from comment #17) > > 6 vs 5 > > That is a purposeful change. The issue was that the logic of the unit test > was off by

[Koha-bugs] [Bug 14694] Make decreaseloanHighHolds more flexible

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14694 Jonathan Druart changed: What|Removed |Added Status|Signed Off

[Koha-bugs] [Bug 14694] Make decreaseloanHighHolds more flexible

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14694 --- Comment #13 from Kyle M Hall --- Created attachment 43752 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43752=edit Bug 14694 [QA Followup] - Fix unit tests -- You are receiving this

[Koha-bugs] [Bug 14694] Make decreaseloanHighHolds more flexible

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14694 --- Comment #15 from Jonathan Druart --- Comment on attachment 43752 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43752 Bug 14694 [QA Followup] - Fix unit tests Review of

[Koha-bugs] [Bug 14694] Make decreaseloanHighHolds more flexible

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14694 Jonathan Druart changed: What|Removed |Added Status|Signed Off

[Koha-bugs] [Bug 14694] Make decreaseloanHighHolds more flexible

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14694 --- Comment #14 from Jonathan Druart --- Comment on attachment 43598 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43598 [SIGNED-OFF] Bug 14694 - Make decreaseloanHighHolds

[Koha-bugs] [Bug 14694] Make decreaseloanHighHolds more flexible

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14694 --- Comment #17 from Kyle M Hall --- > ::: t/db_dependent/DecreaseLoanHighHolds.t > @@ +92,5 @@ > > my $patron_hr = { borrower => $patron->id, branchcode => 'MPL' }; > > > > my $data =

[Koha-bugs] [Bug 14694] Make decreaseloanHighHolds more flexible

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14694 Kyle M Hall changed: What|Removed |Added Status|Failed QA |Signed

[Koha-bugs] [Bug 14694] Make decreaseloanHighHolds more flexible

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14694 Kyle M Hall changed: What|Removed |Added Status|Failed QA |Signed

[Koha-bugs] [Bug 14694] Make decreaseloanHighHolds more flexible

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14694 --- Comment #16 from Kyle M Hall --- Created attachment 43768 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43768=edit Bug 14694 [QA Followup] - Fix typos -- You are receiving this mail

[Koha-bugs] [Bug 14694] Make decreaseloanHighHolds more flexible

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14694 Christopher Brannon changed: What|Removed |Added CC|

[Koha-bugs] [Bug 14694] Make decreaseloanHighHolds more flexible

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14694 Kyle M Hall changed: What|Removed |Added Attachment #43513|0 |1

[Koha-bugs] [Bug 14694] Make decreaseloanHighHolds more flexible

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14694 Kyle M Hall changed: What|Removed |Added Attachment #43589|0 |1

[Koha-bugs] [Bug 14694] Make decreaseloanHighHolds more flexible

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14694 Kyle M Hall changed: What|Removed |Added Status|Needs Signoff

[Koha-bugs] [Bug 14694] Make decreaseloanHighHolds more flexible

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14694 --- Comment #8 from Marc Véron --- The feature works, but the tests still fail, same results as in comment #5: 1..12 ok 1 - userenv set not ok 2 - Should exceed threshold # Failed test 'Should exceed threshold' #

[Koha-bugs] [Bug 14694] Make decreaseloanHighHolds more flexible

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14694 Kyle M Hall changed: What|Removed |Added Status|Failed QA

[Koha-bugs] [Bug 14694] Make decreaseloanHighHolds more flexible

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14694 Kyle M Hall changed: What|Removed |Added Attachment #43153|0 |1

[Koha-bugs] [Bug 14694] Make decreaseloanHighHolds more flexible

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14694 Marc Véron changed: What|Removed |Added CC||ve...@veron.ch

[Koha-bugs] [Bug 14694] Make decreaseloanHighHolds more flexible

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14694 Kyle M Hall changed: What|Removed |Added Attachment #42970|0 |1

[Koha-bugs] [Bug 14694] Make decreaseloanHighHolds more flexible

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14694 Kyle M Hall changed: What|Removed |Added Attachment #42958|0 |1

[Koha-bugs] [Bug 14694] Make decreaseloanHighHolds more flexible

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14694 Kyle M Hall changed: What|Removed |Added Blocks||11565

[Koha-bugs] [Bug 14694] Make decreaseloanHighHolds more flexible

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14694 --- Comment #1 from Kyle M Hall --- Created attachment 42957 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42957=edit Bug 14694 - Make decreaseloanHighHolds more flexible This patch

[Koha-bugs] [Bug 14694] Make decreaseloanHighHolds more flexible

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14694 Kyle M Hall changed: What|Removed |Added Attachment #42957|0 |1

[Koha-bugs] [Bug 14694] Make decreaseloanHighHolds more flexible

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14694 Kyle M Hall changed: What|Removed |Added Status|NEW

[Koha-bugs] [Bug 14694] Make decreaseloanHighHolds more flexible

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14694 Nicole Engard (ByWater) nic...@bywatersolutions.com changed: What|Removed |Added CC|

[Koha-bugs] [Bug 14694] Make decreaseloanHighHolds more flexible

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14694 Kyle M Hall kyle.m.h...@gmail.com changed: What|Removed |Added Change sponsored?|--- |Sponsored