https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708
Jonathan Druart changed:
What|Removed |Added
Blocks||27145
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708
Victor Grousset/tuxayo changed:
What|Removed |Added
Resolution|--- |FIXED
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708
Victor Grousset/tuxayo changed:
What|Removed |Added
CC||vic...@tuxayo.net
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708
Andrew Fuerste-Henry changed:
What|Removed |Added
Version(s)|20.11.00|20.11.00, 20.05.07
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708
Andrew Fuerste-Henry changed:
What|Removed |Added
Status|Pushed to master|Pushed to stable
---
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708
Kyle M Hall changed:
What|Removed |Added
Blocks|27145 |
Referenced Bugs:
https://b
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708
Joonas Kylmälä changed:
What|Removed |Added
Blocks||27145
Referenced Bugs:
h
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708
Joonas Kylmälä changed:
What|Removed |Added
Blocks||27144
Referenced Bugs:
h
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708
Lucas Gass changed:
What|Removed |Added
CC||lu...@bywatersolutions.com
---
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708
Jonathan Druart changed:
What|Removed |Added
Blocks||26984
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708
--- Comment #48 from Jonathan Druart
---
This patchset causes bug 26984 (tests are failing if anonymous patron is
configured).
We must fix that before the 20.11 release!
--
You are receiving this mail because:
You are watching all
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708
--- Comment #47 from Jonathan Druart
---
Pushed to master for 20.11, thanks to everybody involved!
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708
Jonathan Druart changed:
What|Removed |Added
Version(s)||20.11.00
released
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708
Tomás Cohen Arazi changed:
What|Removed |Added
Status|Failed QA |Passed QA
--
You are r
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708
--- Comment #46 from Tomás Cohen Arazi ---
Created attachment 113121
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113121&action=edit
Bug 14708: (QA follow-up) Add tests
This patch adds tests for the change. It a
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708
--- Comment #45 from Tomás Cohen Arazi ---
(In reply to Jonathan Druart from comment #43)
> There is a test failing however:
>
> # Failed test 'Patron not found'
> # at t/db_dependent/api/v1/patrons.t line 423.
>
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708
--- Comment #44 from Tomás Cohen Arazi ---
(In reply to Jonathan Druart from comment #42)
> Having this code into master won't help anything: it will have to be rebuilt
> as it cannot be used as a good base.
>
> I am willing to push
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708
Jonathan Druart changed:
What|Removed |Added
Status|Passed QA |Failed QA
--- Comment #43
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708
--- Comment #42 from Jonathan Druart
---
Having this code into master won't help anything: it will have to be rebuilt as
it cannot be used as a good base.
I am willing to push this patchset as it, given the low bug number (but not
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708
--- Comment #41 from David Cook ---
(In reply to Kyle M Hall from comment #40)
> I was actually discussing that as the 'next step' after this development. We
> could easily add a 'read-only' flag to a given account and move the
> Ano
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708
--- Comment #40 from Kyle M Hall ---
(In reply to David Cook from comment #39)
> (In reply to David Cook from comment #38)
> > I like the idea that the Anonymous Patron cannot be deleted, but I think
> > that this implementation is t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708
--- Comment #39 from David Cook ---
(In reply to David Cook from comment #38)
> I like the idea that the Anonymous Patron cannot be deleted, but I think
> that this implementation is too narrowly cast.
>
> I think that we should co
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708
David Cook changed:
What|Removed |Added
CC||dc...@prosentient.com.au
--- C
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708
--- Comment #37 from Kyle M Hall ---
Created attachment 112922
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112922&action=edit
Bug 14708: (QA follow-up) Use try/catch blocks when calling delete() on a
patron
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708
Tomás Cohen Arazi changed:
What|Removed |Added
Version|unspecified |master
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708
Kyle M Hall changed:
What|Removed |Added
Attachment #112830|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708
Kyle M Hall changed:
What|Removed |Added
Status|In Discussion |Passed QA
--- Comment #35 fro
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708
--- Comment #34 from Kyle M Hall ---
Created attachment 112830
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112830&action=edit
Bug 14708: (QA follow-up) Throw exception when deleting anonymous borrower
--
You a
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708
Jonathan Druart changed:
What|Removed |Added
Status|Passed QA |In Discussion
--- Comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708
--- Comment #31 from Jonathan Druart
---
hum, cannot recreate either now.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@l
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708
--- Comment #32 from Jonathan Druart
---
sub delete {
my ($self) = @_;
+my $anonymous_patron = C4::Context->preference("AnonymousPatron");
+return $self if $anonymous_patron && $self->id eq $anonymous_patron;
Should
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708
Nick Clemens changed:
What|Removed |Added
CC||n...@bywatersolutions.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708
Katrin Fischer changed:
What|Removed |Added
See Also||https://bugs.koha-community
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708
--- Comment #29 from Katrin Fischer ---
Hm, I think we always set the anonymous patron as staff user, that prevents
that.
--
You are receiving this mail because:
You are watching all bug changes.
___
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708
Jonathan Druart changed:
What|Removed |Added
Status|Passed QA |Failed QA
--- Comment #28
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708
Katrin Fischer changed:
What|Removed |Added
Attachment #105029|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708
--- Comment #27 from Katrin Fischer ---
Has strings!
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.or
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708
Katrin Fischer changed:
What|Removed |Added
Attachment #105028|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708
Katrin Fischer changed:
What|Removed |Added
Attachment #105027|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708
Katrin Fischer changed:
What|Removed |Added
Attachment #105024|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708
Katrin Fischer changed:
What|Removed |Added
Patch complexity|--- |Small patch
St
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708
Katrin Fischer changed:
What|Removed |Added
Attachment #105026|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708
Katrin Fischer changed:
What|Removed |Added
Attachment #105025|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708
Katrin Fischer changed:
What|Removed |Added
Summary|The patron set as the |The patron set as the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708
Andrew Fuerste-Henry changed:
What|Removed |Added
Attachment #103028|0 |1
is obsolete
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708
Andrew Fuerste-Henry changed:
What|Removed |Added
Attachment #103922|0 |1
is obsolete
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708
Andrew Fuerste-Henry changed:
What|Removed |Added
Attachment #85789|0 |1
is obsolete
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708
Andrew Fuerste-Henry changed:
What|Removed |Added
Attachment #103027|0 |1
is obsolete
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708
Andrew Fuerste-Henry changed:
What|Removed |Added
Attachment #103026|0 |1
is obsolete
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708
Andrew Fuerste-Henry changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--
You a
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708
Andrew Fuerste-Henry changed:
What|Removed |Added
Attachment #85770|0 |1
is obsolete
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708
didier changed:
What|Removed |Added
CC||didier.gautheron@biblibre.c
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708
Kyle M Hall changed:
What|Removed |Added
Blocks||24483
Referenced Bugs:
http
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708
--- Comment #13 from Kyle M Hall ---
(In reply to Andrew Fuerste-Henry from comment #11)
> This technically works, but:
> - When merging patrons, I am able to merge another patron into my anonymous
> patron. Is this what we want? Cou
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708
--- Comment #12 from Kyle M Hall ---
Created attachment 103922
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103922&action=edit
Bug 14708: Don't allow merging of other patron records into Anonymous Patron
--
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708
--- Comment #11 from Andrew Fuerste-Henry ---
This technically works, but:
- When merging patrons, I am able to merge another patron into my anonymous
patron. Is this what we want? Could be, just wanted to make sure it'd been
conside
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708
Andrew Fuerste-Henry changed:
What|Removed |Added
CC||and...@bywatersolutio
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708
--- Comment #9 from Kyle M Hall ---
Created attachment 103028
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103028&action=edit
Bug 14708: Don't allow merging of Anonymous Patron into other patron records
--
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708
--- Comment #8 from Kyle M Hall ---
Created attachment 103027
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103027&action=edit
Bug 14708: Skip AnonymousPatron in GetBorrowersToExpunge
--
You are receiving this m
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708
--- Comment #7 from Kyle M Hall ---
Created attachment 103026
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103026&action=edit
Bug 14708: Prevent deletion of Anonymous Patron at Koha::Patron::delete
--
You are r
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708
Kyle M Hall changed:
What|Removed |Added
Status|Failed QA |Needs Signoff
--
You are rec
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708
Josef Moravec changed:
What|Removed |Added
Status|Signed Off |Failed QA
C
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708
Jonathan Druart changed:
What|Removed |Added
CC||jonathan.dru...@bugs.koha-
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708
--- Comment #4 from Kyle M Hall ---
Created attachment 85789
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85789&action=edit
Bug 14708: Enforce restriction in delete_patrons.pl
--
You are receiving this mail bec
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708
Kyle M Hall changed:
What|Removed |Added
Attachment #85770|1 |0
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708
Kyle M Hall changed:
What|Removed |Added
CC||k...@bywatersolutions.com
At
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708
Kyle M Hall changed:
What|Removed |Added
Attachment #85770|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708
Devinim changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--
You are receiving
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708
Devinim changed:
What|Removed |Added
Attachment #85766|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708
Kyle M Hall changed:
What|Removed |Added
Status|NEW |Needs Signoff
--
You are rec
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708
--- Comment #1 from Kyle M Hall ---
Created attachment 85766
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85766&action=edit
Bug 14708: The patron set as the anonymous patron should not be deletable.
Right now it
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708
Nicole C. Engard changed:
What|Removed |Added
CC|neng...@gmail.com |
--
You are receiving t
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708
Kyle M Hall changed:
What|Removed |Added
Assignee|koha-b...@lists.koha-commun |kyle.m.h...@gmail.com
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708
Nicole C. Engard changed:
What|Removed |Added
CC||neng...@gmail.com
--
You
74 matches
Mail list logo