[Koha-bugs] [Bug 14716] Correctly URI-encode URLs in XSLT result lists and detail pages

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716 Nick Clemens changed: What|Removed |Added Blocks||24654 Referenced Bugs:

[Koha-bugs] [Bug 14716] Correctly URI-encode URLs in XSLT result lists and detail pages

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716 Nick Clemens changed: What|Removed |Added Blocks||24605 Referenced Bugs:

[Koha-bugs] [Bug 14716] Correctly URI-encode URLs in XSLT result lists and detail pages

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716 Katrin Fischer changed: What|Removed |Added CC||k...@bywatersolutions.com

[Koha-bugs] [Bug 14716] Correctly URI-encode URLs in XSLT result lists and detail pages

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716 Fridolin SOMERS changed: What|Removed |Added Blocks||22085 Referenced Bugs:

[Koha-bugs] [Bug 14716] Correctly URI-encode URLs in XSLT result lists and detail pages

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716 Fridolin SOMERS changed: What|Removed |Added Status|Pushed to Stable|RESOLVED

[Koha-bugs] [Bug 14716] Correctly URI-encode URLs in XSLT result lists and detail pages

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716 Martin Renvoize changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable ---

[Koha-bugs] [Bug 14716] Correctly URI-encode URLs in XSLT result lists and detail pages

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com

[Koha-bugs] [Bug 14716] Correctly URI-encode URLs in XSLT result lists and detail pages

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716 --- Comment #72 from David Cook --- Cheers for working on this Ere! I was going to suggest using XML::LibXSLT::register_function() to solve this problem, which I've done locally for years, but your comment reminded me of EXSLT!

[Koha-bugs] [Bug 14716] Correctly URI-encode URLs in XSLT result lists and detail pages

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment

[Koha-bugs] [Bug 14716] Correctly URI-encode URLs in XSLT result lists and detail pages

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716 Martin Renvoize changed: What|Removed |Added Attachment #81054|0 |1 is obsolete|

[Koha-bugs] [Bug 14716] Correctly URI-encode URLs in XSLT result lists and detail pages

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716 Martin Renvoize changed: What|Removed |Added Attachment #81305|0 |1 is obsolete|

[Koha-bugs] [Bug 14716] Correctly URI-encode URLs in XSLT result lists and detail pages

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716 Martin Renvoize changed: What|Removed |Added Attachment #81053|0 |1 is obsolete|

[Koha-bugs] [Bug 14716] Correctly URI-encode URLs in XSLT result lists and detail pages

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716 Martin Renvoize changed: What|Removed |Added Attachment #81052|0 |1 is obsolete|

[Koha-bugs] [Bug 14716] Correctly URI-encode URLs in XSLT result lists and detail pages

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --

[Koha-bugs] [Bug 14716] Correctly URI-encode URLs in XSLT result lists and detail pages

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716 --- Comment #66 from Ere Maijala --- I hope I managed to fix all the remaining issues. I left the removal of extra characters in the extractControlNumber template since just encoding them is not the same as getting rid of them, but

[Koha-bugs] [Bug 14716] Correctly URI-encode URLs in XSLT result lists and detail pages

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716 --- Comment #65 from Ere Maijala --- Created attachment 81305 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81305=edit Bug 14716: Fix more unencoded url parameters. Fixes issues found during QA and unifies the

[Koha-bugs] [Bug 14716] Correctly URI-encode URLs in XSLT result lists and detail pages

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716 --- Comment #64 from Martin Renvoize --- Great work.. as commented on irc earlier.. I found a few cases where we could be escaping but we're not yet: 1) Where we're searching the `an:` index. Unfortunately, we can't guarantee the

[Koha-bugs] [Bug 14716] Correctly URI-encode URLs in XSLT result lists and detail pages

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716 Martin Renvoize changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit

[Koha-bugs] [Bug 14716] Correctly URI-encode URLs in XSLT result lists and detail pages

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716 Ere Maijala changed: What|Removed |Added Attachment #76425|0 |1 is obsolete|

[Koha-bugs] [Bug 14716] Correctly URI-encode URLs in XSLT result lists and detail pages

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716 Ere Maijala changed: What|Removed |Added Attachment #80701|0 |1 is obsolete|

[Koha-bugs] [Bug 14716] Correctly URI-encode URLs in XSLT result lists and detail pages

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716 --- Comment #63 from Ere Maijala --- Now rebased. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org

[Koha-bugs] [Bug 14716] Correctly URI-encode URLs in XSLT result lists and detail pages

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716 Ere Maijala changed: What|Removed |Added Attachment #77471|0 |1 is obsolete|

[Koha-bugs] [Bug 14716] Correctly URI-encode URLs in XSLT result lists and detail pages

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716 Ere Maijala changed: What|Removed |Added Status|Patch doesn't apply |Signed Off -- You are

[Koha-bugs] [Bug 14716] Correctly URI-encode URLs in XSLT result lists and detail pages

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Patch doesn't apply ---

[Koha-bugs] [Bug 14716] Correctly URI-encode URLs in XSLT result lists and detail pages

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716 Magnus Enger changed: What|Removed |Added Attachment #78809|0 |1 is obsolete|

[Koha-bugs] [Bug 14716] Correctly URI-encode URLs in XSLT result lists and detail pages

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716 Magnus Enger changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are

[Koha-bugs] [Bug 14716] Correctly URI-encode URLs in XSLT result lists and detail pages

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716 --- Comment #57 from Katrin Fischer --- Magnus, can you please test the NORMARC patch? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing

[Koha-bugs] [Bug 14716] Correctly URI-encode URLs in XSLT result lists and detail pages

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716 Ere Maijala changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are

[Koha-bugs] [Bug 14716] Correctly URI-encode URLs in XSLT result lists and detail pages

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716 --- Comment #56 from Ere Maijala --- Created attachment 78809 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78809=edit Bug 14716: URI-encode URLs in NORMARC xsl templates.

[Koha-bugs] [Bug 14716] Correctly URI-encode URLs in XSLT result lists and detail pages

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment

[Koha-bugs] [Bug 14716] Correctly URI-encode URLs in XSLT result lists and detail pages

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716 --- Comment #54 from Magnus Enger --- (In reply to Martin Renvoize from comment #53) > QA Comment: Does this also need corresponding NORMARC changes? If this is fixing a problem in XSLT today it would be nice to fix it for NORMARC

[Koha-bugs] [Bug 14716] Correctly URI-encode URLs in XSLT result lists and detail pages

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716 --- Comment #53 from Martin Renvoize --- QA Comment: Does this also need corresponding NORMARC changes? -- You are receiving this mail because: You are watching all bug changes. ___

[Koha-bugs] [Bug 14716] Correctly URI-encode URLs in XSLT result lists and detail pages

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716 Martin Renvoize changed: What|Removed |Added CC||mag...@libriotech.no,

[Koha-bugs] [Bug 14716] Correctly URI-encode URLs in XSLT result lists and detail pages

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716 Julian Maurice changed: What|Removed |Added Attachment #74228|0 |1 is obsolete|

[Koha-bugs] [Bug 14716] Correctly URI-encode URLs in XSLT result lists and detail pages

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716 Julian Maurice changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are

[Koha-bugs] [Bug 14716] Correctly URI-encode URLs in XSLT result lists and detail pages

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716 --- Comment #51 from Julian Maurice --- (In reply to Katrin Fischer from comment #49) > Signing off for MARC21 - maybe someone else could take a look for UNIMARC? > Also tested that this fixes bug 16804. I prefer this solution. I

[Koha-bugs] [Bug 14716] Correctly URI-encode URLs in XSLT result lists and detail pages

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716 Julian Maurice changed: What|Removed |Added CC|

[Koha-bugs] [Bug 14716] Correctly URI-encode URLs in XSLT result lists and detail pages

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716 Katrin Fischer changed: What|Removed |Added Attachment #74804|0 |1 is obsolete|

[Koha-bugs] [Bug 14716] Correctly URI-encode URLs in XSLT result lists and detail pages

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716 Katrin Fischer changed: What|Removed |Added Patch complexity|--- |Medium patch -- You are

[Koha-bugs] [Bug 14716] Correctly URI-encode URLs in XSLT result lists and detail pages

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716 --- Comment #49 from Katrin Fischer --- Signing off for MARC21 - maybe someone else could take a look for UNIMARC? Also tested that this fixes bug 16804. I prefer this solution. -- You are receiving this mail because: You are

[Koha-bugs] [Bug 14716] Correctly URI-encode URLs in XSLT result lists and detail pages

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716 --- Comment #48 from Katrin Fischer --- Back on testing this - continueing later. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list

[Koha-bugs] [Bug 14716] Correctly URI-encode URLs in XSLT result lists and detail pages

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716 Katrin Fischer changed: What|Removed |Added See Also|

[Koha-bugs] [Bug 14716] Correctly URI-encode URLs in XSLT result lists and detail pages

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716 Fridolin SOMERS changed: What|Removed |Added CC|

[Koha-bugs] [Bug 14716] Correctly URI-encode URLs in XSLT result lists and detail pages

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716 --- Comment #47 from Ere Maijala --- Oops, now fixed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list

[Koha-bugs] [Bug 14716] Correctly URI-encode URLs in XSLT result lists and detail pages

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716 Ere Maijala changed: What|Removed |Added Status|Failed QA

[Koha-bugs] [Bug 14716] Correctly URI-encode URLs in XSLT result lists and detail pages

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716 Ere Maijala changed: What|Removed |Added Attachment #74227|0 |1

[Koha-bugs] [Bug 14716] Correctly URI-encode URLs in XSLT result lists and detail pages

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff

[Koha-bugs] [Bug 14716] Correctly URI-encode URLs in XSLT result lists and detail pages

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716 --- Comment #44 from Barton Chittenden --- ... and Chrome will automagically URL encode at least *some* URLs (I'm reminded as I accidentally paste a '?' from an actual question into a bugzilla url, then

[Koha-bugs] [Bug 14716] Correctly URI-encode URLs in XSLT result lists and detail pages

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716 --- Comment #43 from Katrin Fischer --- Maybe too late yesterday, thx for the hint. -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 14716] Correctly URI-encode URLs in XSLT result lists and detail pages

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716 --- Comment #42 from Ere Maijala --- Katrin, Firefox tends to display things in clear even if they're sent properly encoded. You can use e.g. the network tab in the developer tools to see what's actually

[Koha-bugs] [Bug 14716] Correctly URI-encode URLs in XSLT result lists and detail pages

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716 --- Comment #41 from Katrin Fischer --- Hi Ere, this is really strange: I am looking at http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=43 from the sample data. Which is a record with

[Koha-bugs] [Bug 14716] Correctly URI-encode URLs in XSLT result lists and detail pages

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716 Ere Maijala changed: What|Removed |Added Status|Failed QA

[Koha-bugs] [Bug 14716] Correctly URI-encode URLs in XSLT result lists and detail pages

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716 --- Comment #39 from Ere Maijala --- Created attachment 74228 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74228=edit Bug 14716: URI-encode URLs in UNIMARC xsl templates.

[Koha-bugs] [Bug 14716] Correctly URI-encode URLs in XSLT result lists and detail pages

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716 --- Comment #38 from Ere Maijala --- Created attachment 74227 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74227=edit Bug 14716: URI-encode URLs in MARC21 xsl templates.

[Koha-bugs] [Bug 14716] Correctly URI-encode URLs in XSLT result lists and detail pages

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716 Ere Maijala changed: What|Removed |Added Attachment #74226|0 |1

[Koha-bugs] [Bug 14716] Correctly URI-encode URLs in XSLT result lists and detail pages

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716 Ere Maijala changed: What|Removed |Added Attachment #73605|0 |1

[Koha-bugs] [Bug 14716] Correctly URI-encode URLs in XSLT result lists and detail pages

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716 Katrin Fischer changed: What|Removed |Added Summary|opac-detail.pl -- Series