[Koha-bugs] [Bug 14752] Add multiple copies to a basket at once

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14752 Jonathan Druart changed: What|Removed |Added See Also|

[Koha-bugs] [Bug 14752] Add multiple copies to a basket at once

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14752 Zeno Tajoli changed: What|Removed |Added Text to go in the||This

[Koha-bugs] [Bug 14752] Add multiple copies to a basket at once

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14752 Zeno Tajoli changed: What|Removed |Added CC|z.taj...@cineca.it | -- You

[Koha-bugs] [Bug 14752] Add multiple copies to a basket at once

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14752 --- Comment #40 from Jonathan Druart --- (In reply to Nick Clemens from comment #37) > Created attachment 56649 [details] [review] > Bug 14752 - Followup to fix error if barcode fields

[Koha-bugs] [Bug 14752] Add multiple copies to a basket at once

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14752 Jonathan Druart changed: What|Removed |Added Attachment #56649|0

[Koha-bugs] [Bug 14752] Add multiple copies to a basket at once

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14752 --- Comment #38 from Nick Clemens --- Jonathan, can you try the added patch to see if that fixes your error? It works for me and was the only way I triggered the error -- You are receiving this mail

[Koha-bugs] [Bug 14752] Add multiple copies to a basket at once

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14752 --- Comment #37 from Nick Clemens --- Created attachment 56649 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56649=edit Bug 14752 - Followup to fix error if barcode fields undefined --

[Koha-bugs] [Bug 14752] Add multiple copies to a basket at once

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14752 --- Comment #36 from Jonathan Druart --- Nick, if the barcode is not mandatory and you don't fill it, you will get: Can't call method "delete_subfield" on an undefined value at

[Koha-bugs] [Bug 14752] Add multiple copies to a basket at once

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14752 Kyle M Hall changed: What|Removed |Added CC|

[Koha-bugs] [Bug 14752] Add multiple copies to a basket at once

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14752 --- Comment #34 from Jonathan Druart --- Created attachment 55528 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55528=edit Bug 14752 - (QA followup) Remove annoying

[Koha-bugs] [Bug 14752] Add multiple copies to a basket at once

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14752 Jonathan Druart changed: What|Removed |Added Status|Signed Off

[Koha-bugs] [Bug 14752] Add multiple copies to a basket at once

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14752 Jonathan Druart changed: What|Removed |Added Attachment #52605|0

[Koha-bugs] [Bug 14752] Add multiple copies to a basket at once

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14752 Nicole C. Engard changed: What|Removed |Added CC|

[Koha-bugs] [Bug 14752] Add multiple copies to a basket at once

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14752 sandbo...@biblibre.com changed: What|Removed |Added Attachment #52587|0

[Koha-bugs] [Bug 14752] Add multiple copies to a basket at once

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14752 --- Comment #31 from sandbo...@biblibre.com --- Created attachment 52605 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52605=edit Bug 14752 - Add multiple copies to a basket at once This

[Koha-bugs] [Bug 14752] Add multiple copies to a basket at once

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14752 --- Comment #32 from sandbo...@biblibre.com --- Created attachment 52606 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52606=edit Bug 14752 - (QA followup) Remove annoying modal, use

[Koha-bugs] [Bug 14752] Add multiple copies to a basket at once

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14752 sandbo...@biblibre.com changed: What|Removed |Added Attachment #52588|0

[Koha-bugs] [Bug 14752] Add multiple copies to a basket at once

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14752 sandbo...@biblibre.com changed: What|Removed |Added Status|Needs Signoff

[Koha-bugs] [Bug 14752] Add multiple copies to a basket at once

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14752 --- Comment #29 from Koha Team Lyon 3 --- > Agreed, I even found the modal annoying so have removed it in favor of a > dialog when adding multiple. Please test and let me know if this seems better. Thank you

[Koha-bugs] [Bug 14752] Add multiple copies to a basket at once

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14752 Nick Clemens changed: What|Removed |Added Attachment #51481|0 |1

[Koha-bugs] [Bug 14752] Add multiple copies to a basket at once

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14752 Nick Clemens changed: What|Removed |Added Attachment #52083|0 |1

[Koha-bugs] [Bug 14752] Add multiple copies to a basket at once

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14752 Nick Clemens changed: What|Removed |Added Status|Patch doesn't apply

[Koha-bugs] [Bug 14752] Add multiple copies to a basket at once

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14752 Koha Team Lyon 3 changed: What|Removed |Added Status|Needs Signoff

[Koha-bugs] [Bug 14752] Add multiple copies to a basket at once

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14752 Katrin Fischer changed: What|Removed |Added See Also|

[Koha-bugs] [Bug 14752] Add multiple copies to a basket at once

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14752 --- Comment #25 from Nick Clemens --- (In reply to Koha Team Lyon 3 from comment #23) > This enhancement will be very usefull :) > It's just that I'm wondering if there's not a easier way that can suit

[Koha-bugs] [Bug 14752] Add multiple copies to a basket at once

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14752 --- Comment #24 from Nick Clemens --- Created attachment 52083 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52083=edit Bug 14752 - (QA followup) Remove annoying modal, use dialog box

[Koha-bugs] [Bug 14752] Add multiple copies to a basket at once

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14752 --- Comment #23 from Koha Team Lyon 3 --- I have tested it again today. It's ok, I haven't the same issue when emptying "UniqueItemFields". There's problem on sandboxes yesterday, so it can come from that. >The

[Koha-bugs] [Bug 14752] Add multiple copies to a basket at once

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14752 Nick Clemens changed: What|Removed |Added Status|Failed QA

[Koha-bugs] [Bug 14752] Add multiple copies to a basket at once

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14752 Koha Team Lyon 3 changed: What|Removed |Added CC|

[Koha-bugs] [Bug 14752] Add multiple copies to a basket at once

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14752 --- Comment #20 from Nick Clemens --- Patches rebased and squashed, added dependency -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 14752] Add multiple copies to a basket at once

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14752 Nick Clemens changed: What|Removed |Added Attachment #46832|0 |1

[Koha-bugs] [Bug 14752] Add multiple copies to a basket at once

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14752 Nick Clemens changed: What|Removed |Added Depends on|

[Koha-bugs] [Bug 14752] Add multiple copies to a basket at once

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14752 Nick Clemens changed: What|Removed |Added Depends on|

[Koha-bugs] [Bug 14752] Add multiple copies to a basket at once

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14752 --- Comment #18 from Nick Clemens --- Okay, I attached a patch that 'works' I used C4::Barcodes for generating the next barcode, however, this is apparently broken for annual and hbyymmdd and the latter

[Koha-bugs] [Bug 14752] Add multiple copies to a basket at once

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14752 --- Comment #17 from Nick Clemens --- Created attachment 48254 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48254=edit Bug 14752 - [QA followup] Auto-Generate barcode if left blank and

[Koha-bugs] [Bug 14752] Add multiple copies to a basket at once

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14752 Nick Clemens changed: What|Removed |Added Status|ASSIGNED

[Koha-bugs] [Bug 14752] Add multiple copies to a basket at once

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14752 Nick Clemens changed: What|Removed |Added Attachment #47477|0 |1

[Koha-bugs] [Bug 14752] Add multiple copies to a basket at once

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14752 Jonathan Druart changed: What|Removed |Added Status|Signed Off

[Koha-bugs] [Bug 14752] Add multiple copies to a basket at once

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14752 --- Comment #16 from Katrin Fischer --- Auto-generating on saving sounds good to me - showing a note if AutoBarcode is active? The other alternative would probably be to add the item immediately in the

[Koha-bugs] [Bug 14752] Add multiple copies to a basket at once

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14752 Jonathan Druart changed: What|Removed |Added CC|

[Koha-bugs] [Bug 14752] Add multiple copies to a basket at once

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14752 --- Comment #14 from Jonathan Druart --- Hi Nick, I am sorry but I don't understand your last patch. I was referring to this code from additem.pl: 455 # if autoBarcode is set to

[Koha-bugs] [Bug 14752] Add multiple copies to a basket at once

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14752 Nick Clemens changed: What|Removed |Added Status|Needs Signoff

[Koha-bugs] [Bug 14752] Add multiple copies to a basket at once

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14752 Marjorie Barry-Vila changed: What|Removed |Added CC|

[Koha-bugs] [Bug 14752] Add multiple copies to a basket at once

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14752 --- Comment #12 from Jonathan Druart --- Nick, I am sorry but I don't understand why 1/ the barcode is not kept (and auto generated) 2/ you are not using the same method as in additem.tt

[Koha-bugs] [Bug 14752] Add multiple copies to a basket at once

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14752 --- Comment #13 from Nick Clemens --- Created attachment 47477 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47477=edit Bug 14752 - increment barcodes when adding multiples if present

[Koha-bugs] [Bug 14752] Add multiple copies to a basket at once

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14752 Nick Clemens changed: What|Removed |Added Status|Signed Off

[Koha-bugs] [Bug 14752] Add multiple copies to a basket at once

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14752 --- Comment #10 from Nick Clemens --- Created attachment 47252 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47252=edit Bug 14752 - [QA Followup] Correct error message Message changed

[Koha-bugs] [Bug 14752] Add multiple copies to a basket at once

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14752 Nick Clemens changed: What|Removed |Added Status|Failed QA

[Koha-bugs] [Bug 14752] Add multiple copies to a basket at once

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14752 --- Comment #11 from Nick Clemens --- (In reply to Jonathan Druart from comment #9) > I am able to enter 1, without a warning message. I think that is the correct behaviour, I altered the error acordingly

[Koha-bugs] [Bug 14752] Add multiple copies to a basket at once

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14752 --- Comment #9 from Jonathan Druart --- Nick, could you double check, I don't get the modal. +Please enter a number, greater than 1 I am able to enter 1, without a warning message. --

[Koha-bugs] [Bug 14752] Add multiple copies to a basket at once

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14752 --- Comment #7 from Nick Clemens --- Created attachment 47223 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47223=edit Bug 14752 [QA followup] Remove reference to document.f Remove

[Koha-bugs] [Bug 14752] Add multiple copies to a basket at once

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14752 --- Comment #8 from Nick Clemens --- (In reply to Jonathan Druart from comment #6) > QA comments: > 1/ (window.MSG_ADDITEM_JS_UPDATEITEM || "Update item") > If the string is not defined, there is

[Koha-bugs] [Bug 14752] Add multiple copies to a basket at once

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14752 Jonathan Druart changed: What|Removed |Added Status|Signed Off

[Koha-bugs] [Bug 14752] Add multiple copies to a basket at once

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14752 Briana Greally changed: What|Removed |Added Attachment #46093|0 |1

[Koha-bugs] [Bug 14752] Add multiple copies to a basket at once

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14752 Briana Greally changed: What|Removed |Added Status|Needs Signoff

[Koha-bugs] [Bug 14752] Add multiple copies to a basket at once

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14752 Briana Greally changed: What|Removed |Added Attachment #46439|0 |1

[Koha-bugs] [Bug 14752] Add multiple copies to a basket at once

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14752 --- Comment #3 from Nick Clemens --- Created attachment 46439 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46439=edit Bug 14752 - (QA Followup) Use input type="number" and small update

[Koha-bugs] [Bug 14752] Add multiple copies to a basket at once

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14752 --- Comment #2 from Jesse Weaver --- I'd suggest using (like http://www.wufoo.com/html5/types/7-number.html) for the number-of-copies control. It'll add useful UI and make validation easier. I'd also

[Koha-bugs] [Bug 14752] Add multiple copies to a basket at once

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14752 Nick Clemens changed: What|Removed |Added Status|ASSIGNED

[Koha-bugs] [Bug 14752] Add multiple copies to a basket at once

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14752 --- Comment #1 from Nick Clemens --- Created attachment 46093 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46093=edit Bug 14752 - Add multiple copies to a basket at once This patch add

[Koha-bugs] [Bug 14752] Add multiple copies to a basket at once

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14752 Nick Clemens changed: What|Removed |Added Assignee|jwea...@bywatersolutions.co