https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784
--- Comment #83 from Matt Blenkinsop ---
Nice work everyone!
Pushed to stable for 22.11.x
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784
Matt Blenkinsop changed:
What|Removed |Added
Version(s)|23.05.00|23.05.00,22.11.02
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784
--- Comment #82 from Martin Renvoize ---
Nice work everyone!
Pushed to 23.05.x for the next release
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784
Martin Renvoize changed:
What|Removed |Added
Status|Passed QA |Pushed to master
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784
--- Comment #81 from Kyle M Hall ---
Created attachment 145321
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145321&action=edit
Bug 14784: (follow-up) Unit tests
Signed-off-by: Kyle M Hall
--
You are receiving
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784
Kyle M Hall changed:
What|Removed |Added
Attachment #137727|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784
Kyle M Hall changed:
What|Removed |Added
Status|Signed Off |Passed QA
--
You are receivi
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784
--- Comment #79 from Kyle M Hall ---
(In reply to Katrin Fischer from comment #78)
> @Kyle: could you maybe weigh in here? IIRC you were the one to write a part
> of this code at least?
Yes, considering Koha::Paron::is_debarred chec
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784
--- Comment #78 from Katrin Fischer ---
@Kyle: could you maybe weigh in here? IIRC you were the one to write a part of
this code at least?
--
You are receiving this mail because:
You are watching all bug changes.
__
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784
Katrin Fischer changed:
What|Removed |Added
Status|Failed QA |Signed Off
--- Comment #77
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784
--- Comment #76 from Blou ---
So, Signed Off or Failed QA ?
Seems the is still a valid test, per Cate.
--
You are receiving this mail because:
You are watching all bug changes.
___
K
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784
--- Comment #75 from Katrin Fischer ---
Not sure about the date, actually:
If you create an unrestricted debarment you get:
borrowers_debarments.expiration = NULL
borrowers.debarred = -12-31
--
You are receiving this mail bec
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784
Martin Renvoize changed:
What|Removed |Added
Status|Signed Off |Failed QA
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784
--- Comment #74 from Martin Renvoize ---
Comment on attachment 137727
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137727
Bug 14784: Fix checkin message for restricted patrons
Review of attachment 137727:
-->
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784
Shi Yao Wang changed:
What|Removed |Added
Status|Failed QA |Signed Off
--- Comment #73 f
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784
--- Comment #72 from Shi Yao Wang ---
Created attachment 137728
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137728&action=edit
Bug 14784: (follow-up) Unit tests
--
You are receiving this mail because:
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784
Shi Yao Wang changed:
What|Removed |Added
Attachment #136327|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784
Victor Grousset/tuxayo changed:
What|Removed |Added
Status|Signed Off |Failed QA
--- Comm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784
--- Comment #69 from Shi Yao Wang ---
The current patch is quite different than the previous one so I marked the
previous tests as obsolete.
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784
--- Comment #68 from Jonathan Druart ---
Did we lose the tests?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-c
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784
--- Comment #67 from David Nind ---
My testing notes (using koha-testing-docker)
Step 1: To add a restriction:
. Select and edit a patron
. Scroll down to the 'Patron restrictions' section
. Add a manual res
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784
David Nind changed:
What|Removed |Added
Attachment #136040|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784
David Nind changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--
You are receivi
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784
Katrin Fischer changed:
What|Removed |Added
Status|REOPENED|Needs Signoff
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784
Shi Yao Wang changed:
What|Removed |Added
Resolution|WORKSFORME |---
Status|RESOL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784
Shi Yao Wang changed:
What|Removed |Added
Attachment #112724|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784
Shi Yao Wang changed:
What|Removed |Added
CC||shi-yao.w...@inlibro.com
Att
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784
--- Comment #64 from Shi Yao Wang ---
Created attachment 136040
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136040&action=edit
Bug 14784: Fix checkin message for restricted patrons
Test plan:
Before
1) Select
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784
--- Comment #63 from Katrin Fischer ---
Changing status to indicate more clearly that these patches haven't been
pushed.
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784
Katrin Fischer changed:
What|Removed |Added
Resolution|FIXED |WORKSFORME
--
You are rec
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784
Florian changed:
What|Removed |Added
CC||florian.bontemps@biblibre.c
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784
The Minh Luong changed:
What|Removed |Added
Status|Failed QA |RESOLVED
Resolutio
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784
The Minh Luong changed:
What|Removed |Added
CC||the-minh.lu...@inlibro.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784
David Nind changed:
What|Removed |Added
Status|Needs Signoff |Failed QA
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784
Blou changed:
What|Removed |Added
Assignee|charles.far...@inlibro.com |alexis.ripe...@inlibro.com
--
You a
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784
--- Comment #59 from Arthur Suzuki ---
Hi Sonia,
Just managed to get my Koha testing environment up again.
Unfortunately, after applying both tests patch and fix patchs, some tests are
still failing.
Still a bit of work needed on tha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784
Koha Team University Lyon 3 changed:
What|Removed |Added
CC||k...@univ-lyon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784
Alexis Ripetti changed:
What|Removed |Added
Status|Failed QA |Needs Signoff
--- Comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784
Alexis Ripetti changed:
What|Removed |Added
Attachment #110763|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784
Alexis Ripetti changed:
What|Removed |Added
Attachment #110764|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784
--- Comment #54 from Arthur Suzuki ---
Hi Alexis,
Sorry for the late reply...
After applying both patches I still get a failed tests:
root@kohadevbox:koha(master)$ prove t/db_dependent/Circulation.t
t/db_dependent/Circulation.t ..
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784
--- Comment #53 from Alexis Ripetti ---
(In reply to Jonathan Druart from comment #52)
> 1. The second patch "Add tests" adds a change to the module, is that
> expected?
>
> 2. You are modifying a test that is not (at first glance)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784
Jonathan Druart changed:
What|Removed |Added
Status|Passed QA |Failed QA
--- Comment #52
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784
Kyle M Hall changed:
What|Removed |Added
Attachment #106808|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784
Kyle M Hall changed:
What|Removed |Added
Status|Signed Off |Passed QA
--
You are receivi
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784
--- Comment #51 from Kyle M Hall ---
Created attachment 110764
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110764&action=edit
Bug 14784: Add tests
This patch adds tests for PrevDebarred message of AddReturn whe
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784
Kyle M Hall changed:
What|Removed |Added
CC||k...@bywatersolutions.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784
--- Comment #49 from Alexis Ripetti ---
(In reply to Arthur Suzuki from comment #48)
> Test patch works as expected (there is one test which doesn't pass when test
> patch is applied alone).
> However the test patch seems to change t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784
--- Comment #48 from Arthur Suzuki ---
Test patch works as expected (there is one test which doesn't pass when test
patch is applied alone).
However the test patch seems to change things in C4/Circulation as well,
is this due to a ch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784
Arthur Suzuki changed:
What|Removed |Added
Attachment #110485|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784
Arthur Suzuki changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--
You are rece
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784
Alexis Ripetti changed:
What|Removed |Added
Status|Signed Off |Needs Signoff
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784
Alexis Ripetti changed:
What|Removed |Added
Status|Failed QA |Signed Off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784
Alexis Ripetti changed:
What|Removed |Added
Attachment #106809|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784
Kelly McElligott changed:
What|Removed |Added
CC||ke...@bywatersolutions.co
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784
Katrin Fischer changed:
What|Removed |Added
Status|Signed Off |Failed QA
--- Comment #43
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784
Maryse Simard changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--- Comment #42
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784
--- Comment #41 from Katrin Fischer ---
(In reply to Maryse Simard from comment #40)
> Rebased the patch and added a commit for unit tests.
>
> I was unsure which status to set this to, so I've set it back to needs
> signoff.
If th
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784
Katrin Fischer changed:
What|Removed |Added
Attachment #79826|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784
--- Comment #39 from Maryse Simard ---
Created attachment 106809
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106809&action=edit
Bug 14784: Add tests
This patch adds tests for PrevDebarred message of AddReturn w
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784
Maryse Simard changed:
What|Removed |Added
CC||maryse.sim...@inlibro.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784
--- Comment #38 from Maryse Simard ---
Created attachment 106808
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106808&action=edit
Bug 14784: Fix checkin message for debarred patrons
After thinking about it I chan
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784
Arthur Suzuki changed:
What|Removed |Added
CC||arthur.suz...@biblibre.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784
--- Comment #37 from Katrin Fischer ---
This makes changes to a core routine - AddReturn - so asking for tests is
normal and they should be provided by the patch author ideally - anyone can,
but it's not QA's job.
--
You are receiv
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784
--- Comment #36 from Fridolin SOMERS ---
> Tests are missing anyhow
This is a very important code, if anyone is willing to provide tests, you are
welcome :)
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784
Niamh changed:
What|Removed |Added
CC||niamh.walker-headon@it-tall
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784
Jonathan Druart changed:
What|Removed |Added
Status|Signed Off |Failed QA
--- Comment #35
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784
Victor Grousset/tuxayo changed:
What|Removed |Added
CC||victor.grous...@bib
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784
Victor Grousset/tuxayo changed:
What|Removed |Added
Attachment #77683|0 |1
is obsole
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784
Charles Farmer changed:
What|Removed |Added
Attachment #69296|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784
Charles Farmer changed:
What|Removed |Added
Assignee|david.bourga...@inlibro.com |charles.far...@inlibro.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784
Amit Gupta changed:
What|Removed |Added
CC||amitddng...@gmail.com
--
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784
--- Comment #31 from Katrin Fischer ---
Hi Frido, maybe you can sign-off again? I think David made changes after my
initial sign-off (would have been better in a little follow-up patch)
--
You are receiving this mail because:
You a
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784
--- Comment #30 from Fridolin SOMERS ---
It also corrects a small bug, when restriction is infinite, the date
"31/12/" was displayed in return page.
This is because new code always checks for this infinite date and returns
messag
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784
--- Comment #29 from Fridolin SOMERS ---
(In reply to David Bourgault from comment #28)
> Signed-off-by: Katrin Fischer
Is this patch signed off ?
Or does it need a second signing ?
--
You are receiving this mail because:
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784
Fridolin SOMERS changed:
What|Removed |Added
Version|unspecified |master
--
You are receiv
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784
Fridolin SOMERS changed:
What|Removed |Added
Patch complexity|--- |Small patch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784
David Bourgault changed:
What|Removed |Added
Assignee|bouzid.ferg...@inlibro.com |david.bourga...@inlibro.co
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784
David Bourgault changed:
What|Removed |Added
Status|Failed QA |Needs Signoff
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784
David Bourgault changed:
What|Removed |Added
Attachment #69295|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784
David Bourgault changed:
What|Removed |Added
Attachment #68132|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784
Marcel de Rooy changed:
What|Removed |Added
Status|BLOCKED |Failed QA
--- Comment #26
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784
Marcel de Rooy changed:
What|Removed |Added
Status|Signed Off |BLOCKED
--- Comment #25 fr
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784
Marcel de Rooy changed:
What|Removed |Added
CC||m.de.r...@rijksmuseum.nl
-
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784
--- Comment #23 from Katrin Fischer ---
Hi David, thx for the updated test plan. I reset my system since and I could
see the bug and confirm the fix now.
--
You are receiving this mail because:
You are watching all bug changes.
___
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784
Katrin Fischer changed:
What|Removed |Added
Attachment #67102|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784
Katrin Fischer changed:
What|Removed |Added
Status|In Discussion |Signed Off
--
You are rec
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784
David Bourgault changed:
What|Removed |Added
Status|Failed QA |In Discussion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784
Katrin Fischer changed:
What|Removed |Added
Status|Needs Signoff |Failed QA
--- Comment #20
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784
David Bourgault changed:
What|Removed |Added
Attachment #58227|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784
Jonathan Druart changed:
What|Removed |Added
Status|Signed Off |Needs Signoff
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784
Philippe Audet-Fortin changed:
What|Removed |Added
CC||philippe.audet-forti
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784
Owen Leonard changed:
What|Removed |Added
Status|Needs Signoff |Failed QA
--- Comment #17 fr
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784
--- Comment #16 from Owen Leonard ---
I don't think I am able to reproduce this bug. Either that or I misunderstand
what the bug is. As far as I can tell I'm getting the correct checkin messages
for restricted patrons.
--
You are r
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784
Baptiste changed:
What|Removed |Added
CC||baptiste.wojtkowski@biblibr
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784
Bouzid changed:
What|Removed |Added
Assignee|remi.mayrand-provencher@inL |bouzid.ferg...@inlibro.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784
Bouzid changed:
What|Removed |Added
Status|REOPENED|Needs Signoff
--
You are receivin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784
Bouzid changed:
What|Removed |Added
Status|CLOSED |REOPENED
Resolution|WORKSF
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784
Bouzid changed:
What|Removed |Added
CC||bouzid.ferg...@inlibro.com
--
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784
Bouzid changed:
What|Removed |Added
Attachment #49377|0 |1
is obsolete|
1 - 100 of 119 matches
Mail list logo
