https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
--- Comment #376 from David Gustafsson ---
Appears to be some failing tests. I think I know why as encountered the same
issue with another patch. Part of the leader field is now modified in Koha in
ModBiblio, which was not the case
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
David Gustafsson changed:
What|Removed |Added
Status|ASSIGNED|Needs Signoff
---
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
--- Comment #374 from David Gustafsson ---
Created attachment 125633
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125633=edit
Bug 14957: Fix imports in marc-overlay-rules.pl
--
You are receiving this mail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
--- Comment #373 from David Gustafsson ---
Created attachment 125632
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125632=edit
Bug 14957: Fix regression, rules must be refetched on add/edit/deletion
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
--- Comment #372 from David Gustafsson ---
(In reply to Jonathan Druart from comment #369)
> I've spent a lost of time on this patch set to make it part of 21.05. Added
> follow-ups and written test.
>
> Then I had some questions,
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
--- Comment #371 from David Gustafsson ---
(In reply to Martin Renvoize from comment #370)
> > I did forget about one thing though, that actually is a show-stopper, and
> > that is if this bug is merged without the fix in bug 25539,
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
--- Comment #370 from Martin Renvoize ---
> I did forget about one thing though, that actually is a show-stopper, and
> that is if this bug is merged without the fix in bug 25539, this will
> trigger a bug with this current patch. I
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
--- Comment #369 from Jonathan Druart ---
I've spent a lost of time on this patch set to make it part of 21.05. Added
follow-ups and written test.
Then I had some questions, and didn't get the answers I needed to write the
missing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
--- Comment #368 from David Gustafsson ---
(In reply to Jonathan Druart from comment #339)
> There are several questions waiting for answers, see comments 321-333.
I read through those comments again, and the questions where not
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
David Gustafsson changed:
What|Removed |Added
Blocks|25539 |
Depends on|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
--- Comment #367 from Martin Renvoize ---
Another rebase.. another follow-up to fix things that have moved on.
I'm not sure what more I can do... 6 years is too long for an important feature
like this to languish.
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
--- Comment #366 from Martin Renvoize ---
Created attachment 125540
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125540=edit
Bug 14957: Fix imports in tests
--
You are receiving this mail because:
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
Martin Renvoize changed:
What|Removed |Added
Attachment #120705|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
Martin Renvoize changed:
What|Removed |Added
Attachment #120671|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
Martin Renvoize changed:
What|Removed |Added
Attachment #120605|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
Martin Renvoize changed:
What|Removed |Added
Attachment #120604|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
Martin Renvoize changed:
What|Removed |Added
Attachment #120603|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
Martin Renvoize changed:
What|Removed |Added
Attachment #120602|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
Martin Renvoize changed:
What|Removed |Added
Attachment #120601|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
Martin Renvoize changed:
What|Removed |Added
Attachment #120600|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
Martin Renvoize changed:
What|Removed |Added
Attachment #120599|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
Martin Renvoize changed:
What|Removed |Added
Attachment #120598|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
Martin Renvoize changed:
What|Removed |Added
Attachment #120597|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
Martin Renvoize changed:
What|Removed |Added
Attachment #120596|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
Martin Renvoize changed:
What|Removed |Added
Attachment #120595|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
Martin Renvoize changed:
What|Removed |Added
Attachment #120594|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
Martin Renvoize changed:
What|Removed |Added
Attachment #120593|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
Martin Renvoize changed:
What|Removed |Added
Attachment #120592|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
Martin Renvoize changed:
What|Removed |Added
Attachment #120591|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
Martin Renvoize changed:
What|Removed |Added
Attachment #120590|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
Martin Renvoize changed:
What|Removed |Added
Attachment #120589|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
Martin Renvoize changed:
What|Removed |Added
Attachment #120588|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
Martin Renvoize changed:
What|Removed |Added
Attachment #120587|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
Martin Renvoize changed:
What|Removed |Added
Attachment #120586|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
Martin Renvoize changed:
What|Removed |Added
Attachment #120585|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
Martin Renvoize changed:
What|Removed |Added
Attachment #120584|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
Martin Renvoize changed:
What|Removed |Added
Attachment #120583|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
Martin Renvoize changed:
What|Removed |Added
Attachment #120582|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
--- Comment #339 from Jonathan Druart ---
There are several questions waiting for answers, see comments 321-333.
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
--- Comment #338 from David Gustafsson ---
Regarding the level of confidence in this patch regarding stability we have
been running this for a pretty large University Library (Gothenburg University
Library) in production for a
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
--- Comment #337 from Martin Renvoize ---
Still interested but just haven't been able to commit any more time to it.
Honestly it's a complicated enough patch that I get lost in it for days every
time I start to look at it.
--
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
mathieu saby changed:
What|Removed |Added
CC||mathsaby...@gmail.com
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
Marci changed:
What|Removed |Added
CC||mc...@mckinneytexas.org
--
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
Alexander Borkowski changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
--- Comment #336 from Katrin Fischer ---
(In reply to Jonathan Druart from comment #335)
> Nobody interested in getting this done?
Martin and I are, but more hands would be useful.
--
You are receiving this mail because:
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
--- Comment #335 from Jonathan Druart ---
Nobody interested in getting this done?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
Jonathan Druart changed:
What|Removed |Added
Status|Passed QA |ASSIGNED
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
Jonathan Druart changed:
What|Removed |Added
Keywords|rel_21_05_candidate |additional_work_needed,
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
--- Comment #333 from Jonathan Druart ---
(In reply to Jonathan Druart from comment #331)
> I know librarians can have weird needs but, should we really offer the
> "custom" preset? I am reading the tests right now and some
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
--- Comment #332 from Jonathan Druart ---
Created attachment 120705
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120705=edit
Bug 14957: Improve readbility of tests
Not saying that they were not readable before,
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
--- Comment #331 from Jonathan Druart ---
I know librarians can have weird needs but, should we really offer the "custom"
preset? I am reading the tests right now and some combinations are doing funky
stuffs. Maybe we could simplify
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
--- Comment #330 from Jonathan Druart ---
(In reply to Martin Renvoize from comment #327)
> (In reply to Jonathan Druart from comment #324)
> > 5. Can you explain me what this rule means?
> >
> > | id | tag | module | filter |
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
--- Comment #329 from Jonathan Druart ---
(In reply to Martin Renvoize from comment #327)
> (In reply to Jonathan Druart from comment #324)
> > 2. We don't hide the admin page if the pref is off, is that expected?
> so they wanted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
--- Comment #328 from Martin Renvoize ---
OK, I did test this actually..
The modification templates are applied prior to save.. so the changes are then
blocked by the rules here.
The main thing I don't like about this bug is
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
--- Comment #327 from Martin Renvoize ---
(In reply to Jonathan Druart from comment #324)
> 1. See comment 321
Replied above
> 2. We don't hide the admin page if the pref is off, is that expected?
Whilst I agree with what you're
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
--- Comment #326 from Martin Renvoize ---
(In reply to Jonathan Druart from comment #321)
> Running `dbic` generates a change to Koha/Schema/Result/MarcOverlayRule.pm.
> It removes a FK to
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
--- Comment #325 from Jonathan Druart ---
7.
(In reply to Andrew Fuerste-Henry from comment #226)
> I made this rule:
> Module: source
> Filter: *
> Tag: 500
> Preset: Protect
>
> When I go to edit a record, there's nothing in the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
--- Comment #324 from Jonathan Druart ---
1. See comment 321
2. We don't hide the admin page if the pref is off, is that expected?
3. Should we link the pref to the admin page?
4. We need a wiki page, or at least more
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
Jonathan Druart changed:
What|Removed |Added
Attachment #120670|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
--- Comment #322 from Jonathan Druart ---
Created attachment 120670
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120670=edit
Bug 14957: Clean controller
Too many imports and unecessary complicated init of
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
--- Comment #321 from Jonathan Druart ---
Running `dbic` generates a change to Koha/Schema/Result/MarcOverlayRule.pm. It
removes a FK to Koha::Schema::Result::MarcOverlayRulesModule.
However this table does not exist. Should I drop
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
Jonathan Druart changed:
What|Removed |Added
Keywords||rel_21_05_candidate
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
Martin Renvoize changed:
What|Removed |Added
Text to go in the|This enhancement enables|This enhancement enables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
Martin Renvoize changed:
What|Removed |Added
Text to go in the|This enhancement enables|This enhancement enables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
--- Comment #320 from Martin Renvoize ---
(In reply to Katrin Fischer from comment #294)
> Seeing the last status change - what happened?
I broke it with the moving the JS to the bottom of the page.. so whilst I was
working to fix
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
--- Comment #319 from Martin Renvoize ---
Created attachment 120605
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120605=edit
Bug 14957: (QA follow-up) Fix for jQuery undefined
--
You are receiving this mail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
--- Comment #318 from Martin Renvoize ---
Created attachment 120604
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120604=edit
Bug 14957: (QA follow-up) Fix script name
--
You are receiving this mail because:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
Martin Renvoize changed:
What|Removed |Added
Attachment #120581|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
Martin Renvoize changed:
What|Removed |Added
Attachment #120557|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
Martin Renvoize changed:
What|Removed |Added
Attachment #120555|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
Martin Renvoize changed:
What|Removed |Added
Attachment #120554|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
Martin Renvoize changed:
What|Removed |Added
Attachment #120553|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
Martin Renvoize changed:
What|Removed |Added
Attachment #120550|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
Martin Renvoize changed:
What|Removed |Added
Attachment #120548|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
Martin Renvoize changed:
What|Removed |Added
Attachment #120547|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
Martin Renvoize changed:
What|Removed |Added
Attachment #120546|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
Martin Renvoize changed:
What|Removed |Added
Attachment #120545|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
Martin Renvoize changed:
What|Removed |Added
Attachment #120544|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
Martin Renvoize changed:
What|Removed |Added
Attachment #120543|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
Martin Renvoize changed:
What|Removed |Added
Attachment #120542|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
Martin Renvoize changed:
What|Removed |Added
Attachment #120541|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
Martin Renvoize changed:
What|Removed |Added
Attachment #120540|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
Martin Renvoize changed:
What|Removed |Added
Attachment #120539|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
Martin Renvoize changed:
What|Removed |Added
Attachment #120538|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
Martin Renvoize changed:
What|Removed |Added
Attachment #120537|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
Martin Renvoize changed:
What|Removed |Added
Attachment #120536|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
Martin Renvoize changed:
What|Removed |Added
Attachment #120535|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
Martin Renvoize changed:
What|Removed |Added
Attachment #120534|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
Martin Renvoize changed:
What|Removed |Added
Attachment #120533|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
Martin Renvoize changed:
What|Removed |Added
Status|Failed QA |Passed QA
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
--- Comment #295 from Martin Renvoize ---
Created attachment 120581
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120581=edit
Bug 14957: (QA follow-up) Update for bug 23271
--
You are receiving this mail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
--- Comment #294 from Katrin Fischer ---
Seeing the last status change - what happened?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
Martin Renvoize changed:
What|Removed |Added
Status|Passed QA |Failed QA
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
Martin Renvoize changed:
What|Removed |Added
Attachment #120556|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
--- Comment #292 from Martin Renvoize ---
Created attachment 120556
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120556=edit
Bug 14957: (QA follow-up) Fix template indentation
--
You are receiving this mail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
--- Comment #291 from Martin Renvoize ---
Created attachment 120555
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120555=edit
Bug 14957: (QA follow-up) Update for bug 27846
--
You are receiving this mail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
Martin Renvoize changed:
What|Removed |Added
Status|Failed QA |Passed QA
--- Comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
--- Comment #289 from Martin Renvoize ---
Created attachment 120554
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120554=edit
Bug 14957: (QA follow-up) Update for bug 17858
--
You are receiving this mail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
--- Comment #288 from Martin Renvoize ---
Created attachment 120553
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120553=edit
Bug 14957: (QA follow-up) Update for bug 20053
--
You are receiving this mail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
--- Comment #287 from Martin Renvoize ---
Created attachment 120550
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120550=edit
Bug 14957: (QA follow-up) Update for bug 20054
--
You are receiving this mail
101 - 200 of 538 matches
Mail list logo
