[Koha-bugs] [Bug 15006] Need to distinguish client timeout from login timeout

2016-08-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006 Julian Maurice changed: What|Removed |Added CC||julian.maur...@biblibre.com

[Koha-bugs] [Bug 15006] Need to distinguish client timeout from login timeout

2016-08-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006 Frédéric Demians changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable --- Com

[Koha-bugs] [Bug 15006] Need to distinguish client timeout from login timeout

2016-08-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006 --- Comment #85 from Marcel de Rooy --- (In reply to Frédéric Demians from comment #84) > I'm about to push this patch on 16.05 branch (with 13807). But what about > 'client_timeout' SIPconfig.xml new parameter. Isn't it necessary to

[Koha-bugs] [Bug 15006] Need to distinguish client timeout from login timeout

2016-08-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006 --- Comment #84 from Frédéric Demians --- I'm about to push this patch on 16.05 branch (with 13807). But what about 'client_timeout' SIPconfig.xml new parameter. Isn't it necessary to display a warning to admin upgrading the stable b

[Koha-bugs] [Bug 15006] Need to distinguish client timeout from login timeout

2016-07-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006 Kyle M Hall changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment

[Koha-bugs] [Bug 15006] Need to distinguish client timeout from login timeout

2016-07-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006 Marcel de Rooy changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl

[Koha-bugs] [Bug 15006] Need to distinguish client timeout from login timeout

2016-07-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #82

[Koha-bugs] [Bug 15006] Need to distinguish client timeout from login timeout

2016-07-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006 Marcel de Rooy changed: What|Removed |Added Attachment #53358|0 |1 is obsolete|

[Koha-bugs] [Bug 15006] Need to distinguish client timeout from login timeout

2016-07-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006 Marcel de Rooy changed: What|Removed |Added Attachment #53360|0 |1 is obsolete|

[Koha-bugs] [Bug 15006] Need to distinguish client timeout from login timeout

2016-07-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006 Marcel de Rooy changed: What|Removed |Added Attachment #53356|0 |1 is obsolete|

[Koha-bugs] [Bug 15006] Need to distinguish client timeout from login timeout

2016-07-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006 Marcel de Rooy changed: What|Removed |Added Attachment #53357|0 |1 is obsolete|

[Koha-bugs] [Bug 15006] Need to distinguish client timeout from login timeout

2016-07-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006 Marcel de Rooy changed: What|Removed |Added Attachment #53359|0 |1 is obsolete|

[Koha-bugs] [Bug 15006] Need to distinguish client timeout from login timeout

2016-07-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006 --- Comment #78 from Marcel de Rooy --- Created attachment 53366 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53366&action=edit Bug 15006: Centralize timeout logic and allow zero client timeout Moving timeout lo

[Koha-bugs] [Bug 15006] Need to distinguish client timeout from login timeout

2016-07-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006 Marcel de Rooy changed: What|Removed |Added Attachment #53355|0 |1 is obsolete|

[Koha-bugs] [Bug 15006] Need to distinguish client timeout from login timeout

2016-07-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006 --- Comment #80 from Marcel de Rooy --- Created attachment 53368 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53368&action=edit Bug 15006: [QA Follow-up] Satisfy qa tools with one tab less Signed-off-by: Marcel

[Koha-bugs] [Bug 15006] Need to distinguish client timeout from login timeout

2016-07-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006 --- Comment #79 from Marcel de Rooy --- Created attachment 53367 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53367&action=edit Bug 15006 Correct indentation of EXPORTs in Sip.pm Removed tabs and used spaces con

[Koha-bugs] [Bug 15006] Need to distinguish client timeout from login timeout

2016-07-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006 --- Comment #77 from Marcel de Rooy --- Created attachment 53365 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53365&action=edit Bug 15006: Introduce client_timeout in SIPconfig.xml Most selfchecks have persisten

[Koha-bugs] [Bug 15006] Need to distinguish client timeout from login timeout

2016-07-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006 --- Comment #81 from Marcel de Rooy --- Created attachment 53369 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53369&action=edit Bug 15006: [QA Follow-up] Only handle login requests in raw_transport Although main

[Koha-bugs] [Bug 15006] Need to distinguish client timeout from login timeout

2016-07-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006 --- Comment #76 from Marcel de Rooy --- Created attachment 53364 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53364&action=edit Bug 15006 Remove tabs from sip_protocol_loop Remove the tabs causing inconsistent i

[Koha-bugs] [Bug 15006] Need to distinguish client timeout from login timeout

2016-07-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006 --- Comment #75 from Marcel de Rooy --- Created attachment 53363 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53363&action=edit Bug 15006 Drop raw connection if login fails raw_connection was not behaving correc

[Koha-bugs] [Bug 15006] Need to distinguish client timeout from login timeout

2016-07-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006 --- Comment #74 from Marcel de Rooy --- (In reply to Srdjan Jankovic from comment #73) > I still think that > > $server->get_timeout({}) > $self->get_timeout({}) > > beats > > C4::SIP::Sip::get_timeout($server, {}) > C4::SIP::Sip:

[Koha-bugs] [Bug 15006] Need to distinguish client timeout from login timeout

2016-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006 --- Comment #73 from Srdjan Jankovic --- I still think that $server->get_timeout({}) $self->get_timeout({}) beats C4::SIP::Sip::get_timeout($server, {}) C4::SIP::Sip::get_timeout($self, {}) -- You are receiving this mail because

[Koha-bugs] [Bug 15006] Need to distinguish client timeout from login timeout

2016-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006 Srdjan Jankovic changed: What|Removed |Added Attachment #53312|0 |1 is obsolete|

[Koha-bugs] [Bug 15006] Need to distinguish client timeout from login timeout

2016-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006 Srdjan Jankovic changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are re

[Koha-bugs] [Bug 15006] Need to distinguish client timeout from login timeout

2016-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006 Srdjan Jankovic changed: What|Removed |Added Attachment #53311|0 |1 is obsolete|

[Koha-bugs] [Bug 15006] Need to distinguish client timeout from login timeout

2016-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006 Srdjan Jankovic changed: What|Removed |Added Attachment #53310|0 |1 is obsolete|

[Koha-bugs] [Bug 15006] Need to distinguish client timeout from login timeout

2016-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006 Srdjan Jankovic changed: What|Removed |Added Attachment #53309|0 |1 is obsolete|

[Koha-bugs] [Bug 15006] Need to distinguish client timeout from login timeout

2016-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006 Srdjan Jankovic changed: What|Removed |Added Attachment #53133|0 |1 is obsolete|

[Koha-bugs] [Bug 15006] Need to distinguish client timeout from login timeout

2016-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006 Srdjan Jankovic changed: What|Removed |Added Attachment #53132|0 |1 is obsolete|

[Koha-bugs] [Bug 15006] Need to distinguish client timeout from login timeout

2016-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006 --- Comment #66 from Marcel de Rooy --- Hmm Colin: Raw_transport only may still respond to a 97 request. But is that response always correct, or from an older session or so? -- You are receiving this mail because: You are watching

[Koha-bugs] [Bug 15006] Need to distinguish client timeout from login timeout

2016-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006 --- Comment #65 from Marcel de Rooy --- Srdjan: If you could add a signoff, this would probably allow me to pass qa on this patch set. -- You are receiving this mail because: You are watching all bug changes. __

[Koha-bugs] [Bug 15006] Need to distinguish client timeout from login timeout

2016-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006 Marcel de Rooy changed: What|Removed |Added Attachment #53134|0 |1 is obsolete|

[Koha-bugs] [Bug 15006] Need to distinguish client timeout from login timeout

2016-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006 Marcel de Rooy changed: What|Removed |Added Patch complexity|--- |Small patch -- You are re

[Koha-bugs] [Bug 15006] Need to distinguish client timeout from login timeout

2016-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006 --- Comment #63 from Marcel de Rooy --- Created attachment 53311 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53311&action=edit Bug 15006 Correct indentation of EXPORTs in Sip.pm Removed tabs and used spaces con

[Koha-bugs] [Bug 15006] Need to distinguish client timeout from login timeout

2016-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006 --- Comment #64 from Marcel de Rooy --- Created attachment 53312 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53312&action=edit Bug 15006: [QA Follow-up] Satisfy qa tools with one tab less Signed-off-by: Marcel

[Koha-bugs] [Bug 15006] Need to distinguish client timeout from login timeout

2016-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006 --- Comment #62 from Marcel de Rooy --- Created attachment 53310 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53310&action=edit Bug 15006: Centralize timeout logic and allow zero client timeout Moving timeout lo

[Koha-bugs] [Bug 15006] Need to distinguish client timeout from login timeout

2016-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006 --- Comment #60 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #59) > (In reply to Srdjan Jankovic from comment #58) > > If get_timeout() works on SIPServer object, why is it not a SIPServer > > method? > > I woul

[Koha-bugs] [Bug 15006] Need to distinguish client timeout from login timeout

2016-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006 --- Comment #59 from Marcel de Rooy --- (In reply to Srdjan Jankovic from comment #58) > If get_timeout() works on SIPServer object, why is it not a SIPServer method? I wouldn't mind moving it there. But since it is more a utility t

[Koha-bugs] [Bug 15006] Need to distinguish client timeout from login timeout

2016-07-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006 Srdjan Jankovic changed: What|Removed |Added CC||srd...@catalyst.net.nz --

[Koha-bugs] [Bug 15006] Need to distinguish client timeout from login timeout

2016-07-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006 jdem...@roseville.ca.us changed: What|Removed |Added CC||jdem...@roseville.

[Koha-bugs] [Bug 15006] Need to distinguish client timeout from login timeout

2016-07-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006 Colin Campbell changed: What|Removed |Added Status|In Discussion |Needs Signoff --- Comment

[Koha-bugs] [Bug 15006] Need to distinguish client timeout from login timeout

2016-07-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006 --- Comment #56 from Colin Campbell --- Created attachment 53135 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53135&action=edit Proposed patch As the preceding patch touched Sip.pm's EXPORTS it maybe time to tid

[Koha-bugs] [Bug 15006] Need to distinguish client timeout from login timeout

2016-07-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006 Colin Campbell changed: What|Removed |Added Attachment #53009|0 |1 is obsolete|

[Koha-bugs] [Bug 15006] Need to distinguish client timeout from login timeout

2016-07-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006 Colin Campbell changed: What|Removed |Added Attachment #53014|0 |1 is obsolete|

[Koha-bugs] [Bug 15006] Need to distinguish client timeout from login timeout

2016-07-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006 Colin Campbell changed: What|Removed |Added Attachment #53010|0 |1 is obsolete|

[Koha-bugs] [Bug 15006] Need to distinguish client timeout from login timeout

2016-07-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006 --- Comment #52 from Colin Campbell --- (In reply to Marcel de Rooy from comment #51) > (In reply to Colin Campbell from comment #49) > > Comment on attachment 53013 [details] [review] [review] > > Bug 15006: Add timeout and strikes

[Koha-bugs] [Bug 15006] Need to distinguish client timeout from login timeout

2016-07-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006 --- Comment #51 from Marcel de Rooy --- (In reply to Colin Campbell from comment #49) > Comment on attachment 53013 [details] [review] > Bug 15006: Add timeout and strikes to raw_transport > > This is unnecessary - The bogus 3 strik

[Koha-bugs] [Bug 15006] Need to distinguish client timeout from login timeout

2016-07-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006 Colin Campbell changed: What|Removed |Added Status|Signed Off |In Discussion --- Comment

[Koha-bugs] [Bug 15006] Need to distinguish client timeout from login timeout

2016-07-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006 --- Comment #49 from Colin Campbell --- Comment on attachment 53013 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53013 Bug 15006: Add timeout and strikes to raw_transport This is unnecessary - The bogus 3 strike

[Koha-bugs] [Bug 15006] Need to distinguish client timeout from login timeout

2016-07-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006 Marcel de Rooy changed: What|Removed |Added Attachment #53012|0 |1 is obsolete|

[Koha-bugs] [Bug 15006] Need to distinguish client timeout from login timeout

2016-07-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006 Marcel de Rooy changed: What|Removed |Added Attachment #53011|0 |1 is obsolete|

[Koha-bugs] [Bug 15006] Need to distinguish client timeout from login timeout

2016-07-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006 --- Comment #48 from Marcel de Rooy --- Kyle: Please verify your signoff. Thanks. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha

[Koha-bugs] [Bug 15006] Need to distinguish client timeout from login timeout

2016-07-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006 --- Comment #46 from Marcel de Rooy --- Created attachment 53013 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53013&action=edit Bug 15006: Add timeout and strikes to raw_transport The code in raw_transport inclu

[Koha-bugs] [Bug 15006] Need to distinguish client timeout from login timeout

2016-07-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006 --- Comment #47 from Marcel de Rooy --- Created attachment 53014 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53014&action=edit Bug 15006: Centralize timeout logic and allow zero client timeout Moving timeout lo

[Koha-bugs] [Bug 15006] Need to distinguish client timeout from login timeout

2016-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006 --- Comment #45 from Marcel de Rooy --- (In reply to Kyle M Hall from comment #35) > Marcel, would you be able to rebase these patches on top of bug 13807? I did now. But in view of Colin's comments I will still have a look on the l

[Koha-bugs] [Bug 15006] Need to distinguish client timeout from login timeout

2016-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006 --- Comment #43 from Marcel de Rooy --- Created attachment 53011 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53011&action=edit Bug 15006: [COUNTERPATCH] Add timeout and strikes to raw_transport The code in raw_

[Koha-bugs] [Bug 15006] Need to distinguish client timeout from login timeout

2016-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006 --- Comment #44 from Marcel de Rooy --- Created attachment 53012 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53012&action=edit Bug 15006: [COUNTERPATCH] Timeout logic in sip_protocol_loop Instead of adding yet

[Koha-bugs] [Bug 15006] Need to distinguish client timeout from login timeout

2016-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006 Marcel de Rooy changed: What|Removed |Added Attachment #52850|0 |1 is obsolete|

[Koha-bugs] [Bug 15006] Need to distinguish client timeout from login timeout

2016-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006 --- Comment #42 from Marcel de Rooy --- Created attachment 53010 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53010&action=edit Bug 15006 Sip separate global from login timeouts Timeout logic has been added to t

[Koha-bugs] [Bug 15006] Need to distinguish client timeout from login timeout

2016-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006 --- Comment #40 from Marcel de Rooy --- (In reply to Colin Campbell from comment #39) > A problem is the timeout send back in acs_status is a transaction timeout. > Strictly when that timeout elapses the client sould revert the curre

[Koha-bugs] [Bug 15006] Need to distinguish client timeout from login timeout

2016-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006 --- Comment #39 from Colin Campbell --- (In reply to Marcel de Rooy from comment #22) > Created attachment 52480 [details] [review] > Bug 15006: [COUNTERPATCH] Timeout logic in sip_protocol_loop > > Instead of adding yet another cli

[Koha-bugs] [Bug 15006] Need to distinguish client timeout from login timeout

2016-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006 --- Comment #38 from Marcel de Rooy --- (In reply to Colin Campbell from comment #37) > (In reply to Kyle M Hall from comment #34) > > I like this proposal, but I think we should get Colin's testing and input > > before setting it to

[Koha-bugs] [Bug 15006] Need to distinguish client timeout from login timeout

2016-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006 --- Comment #37 from Colin Campbell --- (In reply to Kyle M Hall from comment #34) > I like this proposal, but I think we should get Colin's testing and input > before setting it to Passed QA. It was me saying I'll test --- I was ma

[Koha-bugs] [Bug 15006] Need to distinguish client timeout from login timeout

2016-06-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europ

[Koha-bugs] [Bug 15006] Need to distinguish client timeout from login timeout

2016-06-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006 --- Comment #35 from Kyle M Hall --- Marcell, would you be able to rebase these patches on top of bug 13807? -- You are receiving this mail because: You are watching all bug changes. ___

[Koha-bugs] [Bug 15006] Need to distinguish client timeout from login timeout

2016-06-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006 Kyle M Hall changed: What|Removed |Added Depends on||13807 Referenced Bugs: http

[Koha-bugs] [Bug 15006] Need to distinguish client timeout from login timeout

2016-06-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006 --- Comment #34 from Kyle M Hall --- I like this proposal, but I think we should get Colin's testing and input before setting it to Passed QA. -- You are receiving this mail because: You are watching all bug changes. __

[Koha-bugs] [Bug 15006] Need to distinguish client timeout from login timeout

2016-06-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006 --- Comment #33 from Kyle M Hall --- Created attachment 52853 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52853&action=edit Bug 15006: [COUNTERPATCH] Timeout logic in sip_protocol_loop Instead of adding yet ano

[Koha-bugs] [Bug 15006] Need to distinguish client timeout from login timeout

2016-06-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006 Kyle M Hall changed: What|Removed |Added Attachment #52477|0 |1 is obsolete|

[Koha-bugs] [Bug 15006] Need to distinguish client timeout from login timeout

2016-06-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006 --- Comment #32 from Kyle M Hall --- Created attachment 52852 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52852&action=edit Bug 15006: [COUNTERPATCH] Add timeout and strikes to raw_transport The code in raw_tra

[Koha-bugs] [Bug 15006] Need to distinguish client timeout from login timeout

2016-06-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006 Kyle M Hall changed: What|Removed |Added Attachment #52849|0 |1 is obsolete|

[Koha-bugs] [Bug 15006] Need to distinguish client timeout from login timeout

2016-06-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006 --- Comment #31 from Kyle M Hall --- Created attachment 52851 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52851&action=edit Bug 15006 Sip separate global from login timeouts Timeout logic has been added to the

[Koha-bugs] [Bug 15006] Need to distinguish client timeout from login timeout

2016-06-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006 Marcel de Rooy changed: What|Removed |Added Attachment #52785|0 |1 is obsolete|

[Koha-bugs] [Bug 15006] Need to distinguish client timeout from login timeout

2016-06-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006 Marcel de Rooy changed: What|Removed |Added Attachment #52784|0 |1 is obsolete|

[Koha-bugs] [Bug 15006] Need to distinguish client timeout from login timeout

2016-06-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006 --- Comment #26 from Marcel de Rooy --- Decided to relax the restricted handling in the third patch here. Could be done on another report if we wish to. Still want some feedback on using $server->{policy}->{timeout} in the fourth pa

[Koha-bugs] [Bug 15006] Need to distinguish client timeout from login timeout

2016-06-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006 Marcel de Rooy changed: What|Removed |Added Attachment #52479|0 |1 is obsolete|

[Koha-bugs] [Bug 15006] Need to distinguish client timeout from login timeout

2016-06-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006 Marcel de Rooy changed: What|Removed |Added Attachment #52480|0 |1 is obsolete|

[Koha-bugs] [Bug 15006] Need to distinguish client timeout from login timeout

2016-06-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006 --- Comment #23 from Marcel de Rooy --- I would appreciate feedback on the questions raised earlier. The counterpatches can be applied on top of the first two. See the restricted handling in the third patch of only logins. And the po

[Koha-bugs] [Bug 15006] Need to distinguish client timeout from login timeout

2016-06-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006 --- Comment #22 from Marcel de Rooy --- Created attachment 52480 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52480&action=edit Bug 15006: [COUNTERPATCH] Timeout logic in sip_protocol_loop Instead of adding yet

[Koha-bugs] [Bug 15006] Need to distinguish client timeout from login timeout

2016-06-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006 --- Comment #21 from Marcel de Rooy --- Created attachment 52479 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52479&action=edit Bug 15006: [COUNTERPATCH] Add timeout and strikes to raw_transport The code in raw_

[Koha-bugs] [Bug 15006] Need to distinguish client timeout from login timeout

2016-06-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006 --- Comment #20 from Marcel de Rooy --- Please do not change status yet. Not finished.. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing lis

[Koha-bugs] [Bug 15006] Need to distinguish client timeout from login timeout

2016-06-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006 Marcel de Rooy changed: What|Removed |Added Attachment #45594|0 |1 is obsolete|

[Koha-bugs] [Bug 15006] Need to distinguish client timeout from login timeout

2016-06-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006 --- Comment #18 from Marcel de Rooy --- Created attachment 52477 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52477&action=edit Bug 15006: [QA Follow-up] Indentation for two subroutines Remove tabs from telnet_t

[Koha-bugs] [Bug 15006] Need to distinguish client timeout from login timeout

2016-06-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006 --- Comment #17 from Marcel de Rooy --- Colin or Kyle: Well, I have some improvements coming hopefully :) Already wrote some patches. Few questions are: Is my impression correct that $config->{timeout} normally does not exist? We d

[Koha-bugs] [Bug 15006] Need to distinguish client timeout from login timeout

2016-06-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl -

[Koha-bugs] [Bug 15006] Need to distinguish client timeout from login timeout

2016-04-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006 --- Comment #15 from Colin Campbell --- (In reply to Kyle M Hall from comment #13) > I will try to find some time to run some tests. Here is what I will do: > > 1) Revert 13432 on master > 2) Set up a script that continuously makes

[Koha-bugs] [Bug 15006] Need to distinguish client timeout from login timeout

2016-03-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006 --- Comment #14 from Jonathan Druart --- ping Colin -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.or

[Koha-bugs] [Bug 15006] Need to distinguish client timeout from login timeout

2015-12-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --

[Koha-bugs] [Bug 15006] Need to distinguish client timeout from login timeout

2015-12-23 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006 --- Comment #11 from Larry Baerveldt --- We haven't seen the problem (of outrageous growth in number of SIP processes) since Bug 13432 was applied, so there's no way to see if 15418 helps any with that or not. As noted, Bug 13432 solv

[Koha-bugs] [Bug 15006] Need to distinguish client timeout from login timeout

2015-12-23 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006 --- Comment #10 from Colin Campbell --- (In reply to Larry Baerveldt from comment #9) > Like Kyle, I am concerned about regression. The issue addressed by Bug 13432 > was a very serious one for us, and affected virtually every site us

[Koha-bugs] [Bug 15006] Need to distinguish client timeout from login timeout

2015-12-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006 Larry Baerveldt changed: What|Removed |Added CC||la...@bywatersolutions.com

[Koha-bugs] [Bug 15006] Need to distinguish client timeout from login timeout

2015-12-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006 --- Comment #8 from Kyle M Hall --- Thanks for the explanation! I'm going to ask Larry to lend some eyes to this. I'm just want to make sure we don't introduce a regression. I think another alternative would be to set the client_timeo

[Koha-bugs] [Bug 15006] Need to distinguish client timeout from login timeout

2015-12-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006 Colin Campbell changed: What|Removed |Added Status|Failed QA |Signed Off --- Comment #7 f

[Koha-bugs] [Bug 15006] Need to distinguish client timeout from login timeout

2015-12-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006 Kyle M Hall changed: What|Removed |Added CC||k...@bywatersolutions.com

[Koha-bugs] [Bug 15006] Need to distinguish client timeout from login timeout

2015-12-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006 Jonathan Druart changed: What|Removed |Added Attachment #45583|0 |1 is obsolete|

[Koha-bugs] [Bug 15006] Need to distinguish client timeout from login timeout

2015-12-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006 Jonathan Druart changed: What|Removed |Added Depends on||13432 CC|

[Koha-bugs] [Bug 15006] Need to distinguish client timeout from login timeout

2015-12-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are rece

[Koha-bugs] [Bug 15006] Need to distinguish client timeout from login timeout

2015-12-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006 Frédéric Demians changed: What|Removed |Added Attachment #45039|0 |1 is obsolete|

[Koha-bugs] [Bug 15006] Need to distinguish client timeout from login timeout

2015-12-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006 Frédéric Demians changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are re

[Koha-bugs] [Bug 15006] Need to distinguish client timeout from login timeout

2015-12-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006 --- Comment #3 from Colin Campbell --- (In reply to Frédéric Demians from comment #2) > With this: > > my $timeout = $self->{service}->{client_timeout} || > $config->{client_timeout}; > > what will happen after Koha upgrade if a lib

  1   2   >