https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503
Koha Team Lyon 3 changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503
Nick Clemens changed:
What|Removed |Added
Blocks|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503
Katrin Fischer changed:
What|Removed |Added
Blocks|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503
Zeno Tajoli changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503
Jonathan Druart changed:
What|Removed |Added
Blocks|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503
--- Comment #93 from Kyle M Hall ---
(In reply to Katrin Fischer from comment #92)
> Revert?
I believe Nick is working on followups to remedy those issuses. I might take a
crack at it too. In any case, we
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503
Katrin Fischer changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503
Nick Clemens changed:
What|Removed |Added
Blocks|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503
--- Comment #91 from Jonathan Druart
---
Additionally there are too much code duplicated (rrp and ecost calculation),
and new subs are added to pl files.
--
You are receiving this mail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503
--- Comment #90 from Jonathan Druart
---
There are obvious errors in this patch set:
$bookseller is a Koha object and is used as a hashref, several times
=> Wrong rebase
For sure this will
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503
--- Comment #89 from Jonathan Druart
---
Seems like an independent pair of eyes was missing here...
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503
Kyle M Hall changed:
What|Removed |Added
Status|Passed QA
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503
--- Comment #86 from Nick Clemens ---
Created attachment 60210
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60210=edit
Bug 15503 - Populate the order prices
Signed-off-by: Benjamin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503
--- Comment #84 from Nick Clemens ---
Created attachment 60208
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60208=edit
Bug 15503 [QA Followup] - Set itype and ccode properly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503
--- Comment #87 from Nick Clemens ---
Created attachment 60211
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60211=edit
Bug 15503 (QA Followup)
Fix tabs
Dereference hash for each
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503
--- Comment #85 from Nick Clemens ---
Created attachment 60209
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60209=edit
Bug 15503 [QA Followup] - Use Koha::AuthorisedValues and fetch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503
--- Comment #83 from Nick Clemens ---
Created attachment 60207
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60207=edit
Bug 15503 [QA Followup] - Display "uneven number of fields" error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503
--- Comment #80 from Nick Clemens ---
Created attachment 60204
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60204=edit
Bug 15503 - Fix adding multiple items in multiple biblios.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503
--- Comment #82 from Nick Clemens ---
Created attachment 60206
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60206=edit
Bug 15503 [Followup] - Add replacementprice and itemcallnumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503
--- Comment #81 from Nick Clemens ---
Created attachment 60205
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60205=edit
Bug 15503 [QA Followup] - Remove the use of GetBranchesLoop
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503
Nick Clemens changed:
What|Removed |Added
Attachment #60025|0 |1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503
Nick Clemens changed:
What|Removed |Added
Status|Signed Off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503
--- Comment #78 from Kyle M Hall ---
Created attachment 60032
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60032=edit
[SIGNED-OFF] Bug 15503 - Populate the order prices
Signed-off-by:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503
--- Comment #74 from Kyle M Hall ---
Created attachment 60028
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60028=edit
[SIGNED-OFF] Bug 15503 [Followup] - Add replacementprice and
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503
--- Comment #75 from Kyle M Hall ---
Created attachment 60029
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60029=edit
[SIGNED-OFF] Bug 15503 [QA Followup] - Display "uneven number of
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503
--- Comment #77 from Kyle M Hall ---
Created attachment 60031
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60031=edit
[SIGNED-OFF] Bug 15503 [QA Followup] - Use Koha::AuthorisedValues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503
--- Comment #76 from Kyle M Hall ---
Created attachment 60030
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60030=edit
[SIGNED-OFF] Bug 15503 [QA Followup] - Set itype and ccode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503
--- Comment #73 from Kyle M Hall ---
Created attachment 60027
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60027=edit
[SIGNED-OFF] Bug 15503 [QA Followup] - Remove the use of
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503
Kyle M Hall changed:
What|Removed |Added
Attachment #59415|0 |1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503
--- Comment #72 from Kyle M Hall ---
Created attachment 60026
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60026=edit
[SIGNED-OFF] Bug 15503 - Fix adding multiple items in multiple
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503
Kyle M Hall changed:
What|Removed |Added
Status|Failed QA
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503
--- Comment #69 from Kyle M Hall ---
(In reply to Benjamin Daeuber from comment #68)
> 2. The source of acquisitions is blank. I'm fairly sure that was populating
> before the latest patch.
I've been
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503
Jesse Maseto changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503
--- Comment #68 from Benjamin Daeuber ---
After doing this again with a few records, most fields appear to be mapping
correctly now. The two issues are:
1. For items that have been imported, the non-public
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503
--- Comment #67 from Kyle M Hall ---
Created attachment 59515
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59515=edit
Bug 15503 - Populate the order prices
--
You are receiving this
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503
--- Comment #64 from Kyle M Hall ---
Created attachment 59419
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59419=edit
Bug 15503 [QA Followup] - Display "uneven number of fields" error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503
--- Comment #63 from Kyle M Hall ---
Created attachment 59418
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59418=edit
Bug 15503 [Followup] - Add replacementprice and itemcallnumber
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503
--- Comment #65 from Kyle M Hall ---
Created attachment 59420
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59420=edit
Bug 15503 [QA Followup] - Set itype and ccode properly
--
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503
--- Comment #66 from Kyle M Hall ---
Created attachment 59421
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59421=edit
Bug 15503 [QA Followup] - Use Koha::AuthorisedValues and fetch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503
--- Comment #62 from Kyle M Hall ---
Created attachment 59417
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59417=edit
Bug 15503 [QA Followup] - Remove the use of GetBranchesLoop
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503
--- Comment #61 from Kyle M Hall ---
Created attachment 59416
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59416=edit
Bug 15503 - Fix adding multiple items in multiple biblios.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503
Kyle M Hall changed:
What|Removed |Added
Attachment #55928|0 |1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503
Kyle M Hall changed:
What|Removed |Added
Attachment #58377|0 |1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503
Kyle M Hall changed:
What|Removed |Added
Attachment #58166|0 |1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503
Kyle M Hall changed:
What|Removed |Added
Attachment #58376|0 |1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503
Kyle M Hall changed:
What|Removed |Added
Attachment #58164|0 |1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503
Kyle M Hall changed:
What|Removed |Added
Attachment #58165|0 |1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503
Kyle M Hall changed:
What|Removed |Added
Attachment #54660|0 |1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503
Kyle M Hall changed:
What|Removed |Added
Attachment #57715|0 |1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503
Kyle M Hall changed:
What|Removed |Added
Attachment #54480|0 |1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503
Matthias Meusburger changed:
What|Removed |Added
Status|Patch doesn't
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503
--- Comment #59 from Jonathan Druart
---
(In reply to Matthias Meusburger from comment #58)
> Patches rebased, but git bz apply wants to apply the patches in the wrong
> order (59093 and
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503
--- Comment #58 from Matthias Meusburger ---
Patches rebased, but git bz apply wants to apply the patches in the wrong order
(59093 and 59097 are supposed to be first and second, but they are last).
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503
Matthias Meusburger changed:
What|Removed |Added
Attachment #55927|0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503
Matthias Meusburger changed:
What|Removed |Added
Attachment #58103|0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503
Kyle M Hall changed:
What|Removed |Added
Status|Failed QA
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503
--- Comment #54 from Matthias Meusburger ---
Benjamin, about the problems you had, as I used a fresh koha install database
and faced no problem at all, do you think maybe it could have something to
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503
--- Comment #53 from Kyle M Hall ---
(In reply to Matthias Meusburger from comment #50)
> Hi,
>
> I couldn't reproduce any of the problems you mentioned on my Unimarc
> instance, so I ended up setting up
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503
--- Comment #52 from Matthias Meusburger ---
Created attachment 58377
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58377=edit
Items
--
You are receiving this mail because:
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503
--- Comment #51 from Matthias Meusburger ---
Created attachment 58376
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58376=edit
Import screen
--
You are receiving this mail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503
--- Comment #50 from Matthias Meusburger ---
Hi,
I couldn't reproduce any of the problems you mentioned on my Unimarc instance,
so I ended up setting up a MARC21 instance using your values for the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503
--- Comment #49 from Benjamin Daeuber ---
(In reply to Benjamin Daeuber from comment #46)
> Created attachment 58164 [details]
> Import screen
>
> I've attached a screenshot of the import screen, where
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503
--- Comment #48 from Benjamin Daeuber ---
Created attachment 58166
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58166=edit
Item information after import 2
--
You are receiving this
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503
--- Comment #47 from Benjamin Daeuber ---
Created attachment 58165
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58165=edit
Item information after import 1
--
You are receiving this
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503
--- Comment #46 from Benjamin Daeuber ---
Created attachment 58164
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58164=edit
Import screen
I've attached a screenshot of the import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503
--- Comment #45 from Matthias Meusburger ---
Benjamin,
I can successfully map ccodes and item types.
Can you explain this sentence : "Even on initial import (i.e the order edit
screen when adding
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503
--- Comment #44 from Matthias Meusburger ---
Created attachment 58132
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58132=edit
Bug 15503 [QA Followup] - Use
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503
--- Comment #43 from Matthias Meusburger ---
(Rebased patch)
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503
Matthias Meusburger changed:
What|Removed |Added
Attachment #55926|0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503
Benjamin Daeuber changed:
What|Removed |Added
Status|Patch doesn't apply
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503
--- Comment #40 from Benjamin Daeuber ---
Created attachment 57715
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57715=edit
Test order record with 2 items and all fields mapped
I want
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503
Kyle M Hall changed:
What|Removed |Added
See Also|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503
--- Comment #39 from Kyle M Hall ---
Just a note, we need to make sure the aqorders_items rows are being correctly
created depending on the AcqCreateItem settings ( see Bug 15531 ).
--
You are receiving
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503
Kyle M Hall changed:
What|Removed |Added
Attachment #57124|0 |1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503
Kyle M Hall changed:
What|Removed |Added
Attachment #57123|0 |1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503
--- Comment #36 from Kyle M Hall ---
Created attachment 57123
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57123=edit
Bug 15503 [QA Followup] - Incoming itype doesn't set pulldown
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503
--- Comment #35 from Kyle M Hall ---
In addition, shouldn't the notforloan field be a pulldown based on the
authorised value, rather than a free text field?
--
You are receiving this mail because:
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503
--- Comment #34 from Kyle M Hall ---
I think I may have discovered an issue that will need resolution. Consider
this:
* Most sites have a default setting for notforloan of -1 ( ordered ) in the ACQ
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503
Kyle M Hall changed:
What|Removed |Added
Status|Needs Signoff
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503
Matthias Meusburger changed:
What|Removed |Added
Status|Failed QA
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503
--- Comment #33 from Matthias Meusburger ---
Created attachment 56852
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56852=edit
Bug 15503 [QA Followup] - Display "uneven number of
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503
--- Comment #32 from Matthias Meusburger ---
Created attachment 56851
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56851=edit
Bug 15503 [Followup] - Add replacementprice and
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503
--- Comment #31 from Kyle M Hall ---
I hereby withdraw my 'loc' and 'itemprice' comments! I should have read the
code more closely. It would be better if all the terms matched up, but they
*do* work.
I
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503
--- Comment #30 from Kyle M Hall ---
Maybe this is asking too much, but why use a hard coded list of item fields
instead of abstracting it so that any set of arbitrary item fields could be
given in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503
--- Comment #29 from Benjamin Daeuber ---
(In reply to Kyle M Hall from comment #28)
> I see the same issue with 'itemprice'. There is no itemprice column in the
> db, it would support the price and
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503
Kyle M Hall changed:
What|Removed |Added
Status|Signed Off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503
--- Comment #27 from Kyle M Hall ---
Matthias, I notice this patch acts on a field 'loc' that doesn't exist. I think
it was supposed to be "location", should be a trivial fix.
Also, it would be nice to
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503
Jonathan Druart changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503
--- Comment #25 from Nick Clemens ---
Things worked well in my testing
QA concerns:
QA tool complains on valid tt
"Item fields are uneven" error is odd in that it shows on all bibs even if only
one is
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503
Nick Clemens changed:
What|Removed |Added
Status|Needs Signoff
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503
Nick Clemens changed:
What|Removed |Added
Attachment #55617|0 |1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503
Nick Clemens changed:
What|Removed |Added
Attachment #55057|0 |1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503
Nick Clemens changed:
What|Removed |Added
Attachment #53493|0 |1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503
--- Comment #21 from Kyle M Hall ---
(In reply to Kyle M Hall from comment #20)
> Created attachment 55617 [details] [review]
> Bug 15503 [QA Followup] - Remove the use of GetBranchesLoop
Nick can you
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503
Christopher Davis changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503
Kyle M Hall changed:
What|Removed |Added
Attachment #55616|0 |1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503
Kyle M Hall changed:
What|Removed |Added
Status|Failed QA
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503
--- Comment #19 from Kyle M Hall ---
Created attachment 55616
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55616=edit
Bug 15503 [QA Followup] - Remove the use of GetBranchesLoop
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503
J Schmidt changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503
--- Comment #18 from Nick Clemens ---
This patchset uses GetBranchesLoop which has been removed.
Please provide followup to use Koha::Libraries
--
You are receiving this mail because:
You are watching
1 - 100 of 123 matches
Mail list logo