https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15747
M. Tompsett changed:
What|Removed |Added
Assignee|gmcha...@gmail.com |mtomp...@hotmail.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15747
--- Comment #1 from M. Tompsett ---
Created attachment 47901
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47901&action=edit
Bug 15747 Auth.pm flooding error log with "CGI::param called in list context"
TEST PLAN
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15747
M. Tompsett changed:
What|Removed |Added
Status|ASSIGNED|Needs Signoff
--
You are rec
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15747
M. Tompsett changed:
What|Removed |Added
Attachment #47901|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15747
Marcel de Rooy changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
Patch complex
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15747
Marcel de Rooy changed:
What|Removed |Added
Attachment #47903|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15747
Jonathan Druart changed:
What|Removed |Added
Depends on||15809
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15747
Jonathan Druart changed:
What|Removed |Added
Assignee|mtomp...@hotmail.com|jonathan.dru...@bugs.koha-
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15747
Jonathan Druart changed:
What|Removed |Added
Depends on||11559
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15747
Jonathan Druart changed:
What|Removed |Added
Attachment #47960|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15747
--- Comment #6 from Jonathan Druart
---
(In reply to Jonathan Druart from comment #5)
> Created attachment 47966 [details] [review]
> Bug 15747: Do not use CGI->param in list context - Auth.pm
Theoretically, this patch should be th
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15747
Marcel de Rooy changed:
What|Removed |Added
CC||m.de.r...@rijksmuseum.nl
-
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15747
--- Comment #8 from Marcel de Rooy ---
The change you make is trivial and is no reason to obsolete what was before.
--
You are receiving this mail because:
You are watching all bug changes.
_
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15747
--- Comment #9 from Jonathan Druart
---
I was working on bug 14075 and bug 15809 at the same time (same issue).
I am trying to find a global solution to fix them.
The previous patch uses an unneeded var. To remove the warnings all a
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15747
--- Comment #10 from Marcel de Rooy ---
(In reply to Jonathan Druart from comment #9)
> I was working on bug 14075 and bug 15809 at the same time (same issue).
> I am trying to find a global solution to fix them.
> The previous patch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15747
--- Comment #11 from M. Tompsett ---
(In reply to Jonathan Druart from comment #9)
> I was working on bug 14075 and bug 15809 at the same time (same issue).
> I am trying to find a global solution to fix them.
Oooo... bug 15809 look
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15747
--- Comment #13 from M. Tompsett ---
(In reply to Marcel de Rooy from comment #12)
> That is fine. Well, Jonathan, go for it. Can we close this one?
I don't think so, because this doesn't use the 15809 patch.
If it did, then it woul
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15747
--- Comment #12 from Marcel de Rooy ---
(In reply to M. Tompsett from comment #11)
> (In reply to Jonathan Druart from comment #9)
> > I was working on bug 14075 and bug 15809 at the same time (same issue).
> > I am trying to find a
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15747
--- Comment #14 from Jesse Weaver ---
(In reply to Jonathan Druart from comment #4)
> Jesse, could you explain what you are doing with document.location.hash?
>
> I do not understand the following line in includes/cateditor-ui.inc:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15747
--- Comment #15 from Jesse Weaver ---
(In reply to Jesse Weaver from comment #14)
> (In reply to Jonathan Druart from comment #4)
> > Jesse, could you explain what you are doing with document.location.hash?
> >
> > I do not understa
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15747
Jonathan Druart changed:
What|Removed |Added
Status|ASSIGNED|Needs Signoff
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15747
Jonathan Druart changed:
What|Removed |Added
Attachment #47966|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15747
--- Comment #17 from Jonathan Druart
---
(In reply to Jesse Weaver from comment #14)
> (In reply to Jonathan Druart from comment #4)
> > Jesse, could you explain what you are doing with document.location.hash?
> >
> > I do not unde
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15747
David Cook changed:
What|Removed |Added
CC||dc...@prosentient.com.au
--- C
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15747
--- Comment #19 from David Cook ---
So yeah, even if you use the [] to create an arrayref, you'll still get the CGI
warning, because CGI just knows you're asking for a single named parameter in
list context; it doesn't know that you'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15747
--- Comment #20 from Jonathan Druart
---
(In reply to David Cook from comment #18)
> I'm using "my @param_names = CGI->param()" elsewhere and it doesn't generate
> warnings.
Yes it does.
--
You are receiving this mail because:
Y
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15747
--- Comment #21 from David Cook ---
(In reply to Jonathan Druart from comment #20)
> (In reply to David Cook from comment #18)
> > I'm using "my @param_names = CGI->param()" elsewhere and it doesn't
> > generate warnings.
>
> Yes i
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15747
--- Comment #22 from David Cook ---
P.S. That is CGI.pm version 4.13.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15747
--- Comment #23 from Jonathan Druart
---
(In reply to David Cook from comment #21)
> As you can observe in the warning itself, the warning is for "Fetching the
> value or values of a single named parameter". In the case of
> '$query
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15747
--- Comment #24 from Marcel de Rooy ---
(In reply to Jonathan Druart from comment #23)
> (In reply to David Cook from comment #21)
> > As you can observe in the warning itself, the warning is for "Fetching the
> > value or values of
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15747
--- Comment #25 from David Cook ---
(In reply to Marcel de Rooy from comment #24)
> Misunderstanding? He talks about calling it without arguments (and without
> warning). You mean calls with an argument (and warnings dependent on
> c
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15747
Jonathan Druart changed:
What|Removed |Added
Depends on|15809 |
See Also|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15747
--- Comment #27 from Marcel de Rooy ---
(In reply to Jonathan Druart from comment #26)
> Yes sorry, didn't read carefully enough.
> What's missing to get a signoff?
I signed off Mark's patch. Your patch is more or less identical..
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15747
Marcel de Rooy changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--
You are rec
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15747
Marcel de Rooy changed:
What|Removed |Added
Attachment #48067|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15747
Marcel de Rooy changed:
What|Removed |Added
Status|Signed Off |Passed QA
QA Conta
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15747
Brendan Gallagher changed:
What|Removed |Added
CC||bren...@bywatersolutions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15747
Julian Maurice changed:
What|Removed |Added
CC||julian.maur...@biblibre.com
38 matches
Mail list logo