[Koha-bugs] [Bug 15812] Checkout search with too many results (single character search) causes poor performance or timeout

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15812 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- C

[Koha-bugs] [Bug 15812] Checkout search with too many results (single character search) causes poor performance or timeout

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15812 Katrin Fischer changed: What|Removed |Added Blocks||30230 Referenced Bugs: h

[Koha-bugs] [Bug 15812] Checkout search with too many results (single character search) causes poor performance or timeout

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15812 Joonas Kylmälä changed: What|Removed |Added Blocks||29463 Referenced Bugs: h

[Koha-bugs] [Bug 15812] Checkout search with too many results (single character search) causes poor performance or timeout

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15812 Owen Leonard changed: What|Removed |Added Blocks||29430 Referenced Bugs: htt

[Koha-bugs] [Bug 15812] Checkout search with too many results (single character search) causes poor performance or timeout

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15812 Nick Clemens changed: What|Removed |Added Blocks||29411 Referenced Bugs: htt

[Koha-bugs] [Bug 15812] Checkout search with too many results (single character search) causes poor performance or timeout

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15812 --- Comment #47 from Martin Renvoize --- It's for screen readers I believe... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bug

[Koha-bugs] [Bug 15812] Checkout search with too many results (single character search) causes poor performance or timeout

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15812 --- Comment #46 from Jonathan Druart --- Comment on attachment 125960 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125960 Bug 15812: (follow-up) Enable click cell to select Review of attachment 125960: --> (ht

[Koha-bugs] [Bug 15812] Checkout search with too many results (single character search) causes poor performance or timeout

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15812 Kyle M Hall changed: What|Removed |Added Resolution|--- |FIXED Status|Push

[Koha-bugs] [Bug 15812] Checkout search with too many results (single character search) causes poor performance or timeout

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15812 --- Comment #45 from Jonathan Druart --- (In reply to Jonathan Druart from comment #39) > In members/tables/members_results.tt: > > title='View' > > This is bad, it breaks translated template. Strings must be surrounded by > double

[Koha-bugs] [Bug 15812] Checkout search with too many results (single character search) causes poor performance or timeout

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15812 --- Comment #44 from Martin Renvoize --- circ-patron-search-results.inc is now only used in one last place and I think it could be deprecated in favour of the approach here.. I'll post a bug for that. -- You are receiving this mail

[Koha-bugs] [Bug 15812] Checkout search with too many results (single character search) causes poor performance or timeout

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15812 --- Comment #43 from Nick Clemens --- (In reply to Jonathan Druart from comment #42) > (In reply to Jonathan Druart from comment #37) > > I won't block it more, but I don't think it's the best implementation. > > I do like the "Check

[Koha-bugs] [Bug 15812] Checkout search with too many results (single character search) causes poor performance or timeout

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15812 Jonathan Druart changed: What|Removed |Added See Also||https://bugs.koha-communit

[Koha-bugs] [Bug 15812] Checkout search with too many results (single character search) causes poor performance or timeout

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15812 --- Comment #42 from Jonathan Druart --- (In reply to Jonathan Druart from comment #37) > I won't block it more, but I don't think it's the best implementation. > I do like the "Check out" on the patron list. However I don't understa

[Koha-bugs] [Bug 15812] Checkout search with too many results (single character search) causes poor performance or timeout

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15812 --- Comment #41 from Jonathan Druart --- (In reply to Jonathan Druart from comment #39) > However here we will have to escape it with \ and the string won't be picked > by the translate script. This is not correct, it actually work

[Koha-bugs] [Bug 15812] Checkout search with too many results (single character search) causes poor performance or timeout

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15812 --- Comment #40 from Martin Renvoize --- (In reply to Jonathan Druart from comment #39) > In members/tables/members_results.tt: > > title='View' > > This is bad, it breaks translated template. Strings must be surrounded by > double

[Koha-bugs] [Bug 15812] Checkout search with too many results (single character search) causes poor performance or timeout

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15812 Jonathan Druart changed: What|Removed |Added Blocks||29261 --- Comment #39 fro

[Koha-bugs] [Bug 15812] Checkout search with too many results (single character search) causes poor performance or timeout

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15812 --- Comment #38 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs

[Koha-bugs] [Bug 15812] Checkout search with too many results (single character search) causes poor performance or timeout

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15812 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to master

[Koha-bugs] [Bug 15812] Checkout search with too many results (single character search) causes poor performance or timeout

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15812 --- Comment #37 from Jonathan Druart --- I won't block it more, but I don't think it's the best implementation. I do like the "Check out" on the patron list. However I don't understand why you didn't go the usual way, which is using

[Koha-bugs] [Bug 15812] Checkout search with too many results (single character search) causes poor performance or timeout

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15812 Nick Clemens changed: What|Removed |Added Status|In Discussion |Passed QA --- Comment #36 fr

[Koha-bugs] [Bug 15812] Checkout search with too many results (single character search) causes poor performance or timeout

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15812 Jonathan Druart changed: What|Removed |Added Status|Passed QA |In Discussion -- You are

[Koha-bugs] [Bug 15812] Checkout search with too many results (single character search) causes poor performance or timeout

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15812 --- Comment #35 from Jonathan Druart --- Is there a good reason (apart from laziness) to redirect to member.pl from circulation.pl? 229 print $query->redirect( "/cgi-bin/koha/members/member.pl?quicksearch=1&circsearch=1&sear

[Koha-bugs] [Bug 15812] Checkout search with too many results (single character search) causes poor performance or timeout

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15812 Nick Clemens changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |martin.renvoize@ptfs-europe

[Koha-bugs] [Bug 15812] Checkout search with too many results (single character search) causes poor performance or timeout

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15812 --- Comment #34 from Nick Clemens --- (In reply to Joonas Kylmälä from comment #29) > (In reply to Martin Renvoize from comment #26) > > OK, I think we're all done now. > > > > I restored the label, but made it a visually hidden one

[Koha-bugs] [Bug 15812] Checkout search with too many results (single character search) causes poor performance or timeout

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15812 --- Comment #33 from Nick Clemens --- Created attachment 125960 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125960&action=edit Bug 15812: (follow-up) Enable click cell to select This patch adds handling to allo

[Koha-bugs] [Bug 15812] Checkout search with too many results (single character search) causes poor performance or timeout

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15812 --- Comment #32 from Nick Clemens --- Created attachment 125959 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125959&action=edit Bug 15812: (follow-up) Tweaks to patron results display Move the button into the ac

[Koha-bugs] [Bug 15812] Checkout search with too many results (single character search) causes poor performance or timeout

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15812 --- Comment #31 from Nick Clemens --- Created attachment 125958 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125958&action=edit Bug 15812: (follow-up) Add permission check for 'Check out' button Signed-off-by: M

[Koha-bugs] [Bug 15812] Checkout search with too many results (single character search) causes poor performance or timeout

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15812 Nick Clemens changed: What|Removed |Added Attachment #125580|0 |1 is obsolete|

[Koha-bugs] [Bug 15812] Checkout search with too many results (single character search) causes poor performance or timeout

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15812 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiv

[Koha-bugs] [Bug 15812] Checkout search with too many results (single character search) causes poor performance or timeout

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15812 Nick Clemens changed: What|Removed |Added See Also||https://bugs.koha-community

[Koha-bugs] [Bug 15812] Checkout search with too many results (single character search) causes poor performance or timeout

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15812 Joonas Kylmälä changed: What|Removed |Added Patch complexity|Trivial patch |Medium patch -- You are r

[Koha-bugs] [Bug 15812] Checkout search with too many results (single character search) causes poor performance or timeout

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15812 Joonas Kylmälä changed: What|Removed |Added CC||joonas.kylm...@iki.fi ---

[Koha-bugs] [Bug 15812] Checkout search with too many results (single character search) causes poor performance or timeout

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15812 Owen Leonard changed: What|Removed |Added Attachment #125623|0 |1 is obsolete|

[Koha-bugs] [Bug 15812] Checkout search with too many results (single character search) causes poor performance or timeout

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15812 Martin Renvoize changed: What|Removed |Added Attachment #125622|0 |1 is obsolete|

[Koha-bugs] [Bug 15812] Checkout search with too many results (single character search) causes poor performance or timeout

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15812 --- Comment #26 from Martin Renvoize --- OK, I think we're all done now. I restored the label, but made it a visually hidden one inside the check column for accessibility and I made the whole table cell clickable for the checkbox to

[Koha-bugs] [Bug 15812] Checkout search with too many results (single character search) causes poor performance or timeout

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15812 Martin Renvoize changed: What|Removed |Added Attachment #125604|0 |1 is obsolete|

[Koha-bugs] [Bug 15812] Checkout search with too many results (single character search) causes poor performance or timeout

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15812 Martin Renvoize changed: What|Removed |Added Attachment #125621|0 |1 is obsolete|

[Koha-bugs] [Bug 15812] Checkout search with too many results (single character search) causes poor performance or timeout

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15812 --- Comment #24 from Martin Renvoize --- Created attachment 125621 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125621&action=edit Bug 15812: (follow-up) Enable click cell to select This patch adds handling to a

[Koha-bugs] [Bug 15812] Checkout search with too many results (single character search) causes poor performance or timeout

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15812 Martin Renvoize changed: What|Removed |Added Text to go in the||This patch replaces the

[Koha-bugs] [Bug 15812] Checkout search with too many results (single character search) causes poor performance or timeout

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15812 --- Comment #23 from Martin Renvoize --- Created attachment 125604 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125604&action=edit Bug 15812: (follow-up) Enable click row to select This patch adds handling to al

[Koha-bugs] [Bug 15812] Checkout search with too many results (single character search) causes poor performance or timeout

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15812 --- Comment #22 from Martin Renvoize --- Good catch Owen.. I wasn't aware of the label stuff.. I thought it had been added here. -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 15812] Checkout search with too many results (single character search) causes poor performance or timeout

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15812 Martin Renvoize changed: What|Removed |Added Status|Passed QA |Signed Off -- You are re

[Koha-bugs] [Bug 15812] Checkout search with too many results (single character search) causes poor performance or timeout

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15812 --- Comment #21 from Owen Leonard --- I like the change to the buttons but I'm sorry to see Bug 28081 undone. I'd like to argue that the link is redundant since the button has been added. -- You are receiving this mail because: You

[Koha-bugs] [Bug 15812] Checkout search with too many results (single character search) causes poor performance or timeout

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15812 --- Comment #20 from Martin Renvoize --- Last little tweak made the action button prettier ;) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs maili

[Koha-bugs] [Bug 15812] Checkout search with too many results (single character search) causes poor performance or timeout

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15812 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA -- You are rec

[Koha-bugs] [Bug 15812] Checkout search with too many results (single character search) causes poor performance or timeout

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15812 Martin Renvoize changed: What|Removed |Added Attachment #125583|0 |1 is obsolete|

[Koha-bugs] [Bug 15812] Checkout search with too many results (single character search) causes poor performance or timeout

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15812 --- Comment #18 from Fridolin Somers --- Whaou for me it is awesome. Thanks a lot Martin ;) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing

[Koha-bugs] [Bug 15812] Checkout search with too many results (single character search) causes poor performance or timeout

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15812 --- Comment #17 from Martin Renvoize --- Code speaks.. let me know what you think of that final followup. Otherwise, I'm happy to PQA :) -- You are receiving this mail because: You are watching all bug changes. ___

[Koha-bugs] [Bug 15812] Checkout search with too many results (single character search) causes poor performance or timeout

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15812 --- Comment #16 from Martin Renvoize --- Created attachment 125583 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125583&action=edit Bug 15812: (follow-up) Tweaks to patron results display Move the button into the

[Koha-bugs] [Bug 15812] Checkout search with too many results (single character search) causes poor performance or timeout

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15812 Martin Renvoize changed: What|Removed |Added Attachment #125490|0 |1 is obsolete|

[Koha-bugs] [Bug 15812] Checkout search with too many results (single character search) causes poor performance or timeout

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15812 Martin Renvoize changed: What|Removed |Added Attachment #125489|0 |1 is obsolete|

[Koha-bugs] [Bug 15812] Checkout search with too many results (single character search) causes poor performance or timeout

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15812 --- Comment #13 from Martin Renvoize --- This is a lovely improvement... it simplifies and reduces code and adds direct access to checkouts from patron results page. I'd love to see a follow-on bug to do the same for holds searching

[Koha-bugs] [Bug 15812] Checkout search with too many results (single character search) causes poor performance or timeout

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15812 --- Comment #12 from Fridolin Somers --- Super, permission is OK now. (In reply to Fridolin Somers from comment #6) > Note than cardnumber column may be hidden. > Isn't that a problem ? Also for consistency, everywhere in tables b

[Koha-bugs] [Bug 15812] Checkout search with too many results (single character search) causes poor performance or timeout

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15812 --- Comment #11 from Nick Clemens --- Created attachment 125490 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125490&action=edit Bug 15812: (follow-up) Add permission check for 'Check out' button -- You are rece

[Koha-bugs] [Bug 15812] Checkout search with too many results (single character search) causes poor performance or timeout

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15812 Nick Clemens changed: What|Removed |Added Attachment #125413|0 |1 is obsolete|

[Koha-bugs] [Bug 15812] Checkout search with too many results (single character search) causes poor performance or timeout

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15812 Nick Clemens changed: What|Removed |Added Status|Patch doesn't apply |Signed Off -- You are recei

[Koha-bugs] [Bug 15812] Checkout search with too many results (single character search) causes poor performance or timeout

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15812 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europ

[Koha-bugs] [Bug 15812] Checkout search with too many results (single character search) causes poor performance or timeout

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15812 Nick Clemens changed: What|Removed |Added See Also||https://bugs.koha-community

[Koha-bugs] [Bug 15812] Checkout search with too many results (single character search) causes poor performance or timeout

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15812 George Williams (NEKLS) changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Co

[Koha-bugs] [Bug 15812] Checkout search with too many results (single character search) causes poor performance or timeout

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15812 sandbo...@biblibre.com changed: What|Removed |Added Attachment #125234|0 |1 is obsole

[Koha-bugs] [Bug 15812] Checkout search with too many results (single character search) causes poor performance or timeout

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15812 --- Comment #6 from Fridolin Somers --- Nice change, I test it. > For a search with many results, you are redirected to the patron search > results and there is a 'Checkout' button under the cardnumber I see this also when searchin

[Koha-bugs] [Bug 15812] Checkout search with too many results (single character search) causes poor performance or timeout

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15812 Fridolin Somers changed: What|Removed |Added CC||fridolin.som...@biblibre.c

[Koha-bugs] [Bug 15812] Checkout search with too many results (single character search) causes poor performance or timeout

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15812 Fridolin Somers changed: What|Removed |Added See Also||https://bugs.koha-communit

[Koha-bugs] [Bug 15812] Checkout search with too many results (single character search) causes poor performance or timeout

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15812 Kyle M Hall changed: What|Removed |Added Attachment #125224|0 |1 is obsolete|

[Koha-bugs] [Bug 15812] Checkout search with too many results (single character search) causes poor performance or timeout

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15812 Nick Clemens changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com

[Koha-bugs] [Bug 15812] Checkout search with too many results (single character search) causes poor performance or timeout

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15812 --- Comment #3 from Nick Clemens --- Created attachment 125224 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125224&action=edit Bug 15812: Use patron search in place of circ search The 'Checkout' search hijacks s

[Koha-bugs] [Bug 15812] Checkout search with too many results (single character search) causes poor performance or timeout

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15812 Nick Clemens changed: What|Removed |Added Status|NEW |Needs Signoff Patch comple

[Koha-bugs] [Bug 15812] Checkout search with too many results (single character search ) causes poor performance or timeout

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15812 George Williams (NEKLS) changed: What|Removed |Added CC|gwilli...@nekls.org | -- You are rece

[Koha-bugs] [Bug 15812] Checkout search with too many results (single character search ) causes poor performance or timeout

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15812 George Williams (NEKLS) changed: What|Removed |Added CC||geo...@nekls.org

[Koha-bugs] [Bug 15812] Checkout search with too many results (single character search) causes poor performance or timeout

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15812 Jesse Weaver changed: What|Removed |Added CC||jwea...@bywatersolutions.co

[Koha-bugs] [Bug 15812] Checkout search with too many results (single character search) causes poor performance or timeout

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15812 Jonathan Druart changed: What|Removed |Added Severity|normal |enhancement Ve

[Koha-bugs] [Bug 15812] Checkout search with too many results (single character search) causes poor performance or timeout

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15812 Jacek Ablewicz changed: What|Removed |Added CC||a...@biblos.pk.edu.pl --

[Koha-bugs] [Bug 15812] Checkout search with too many results (single character search) causes poor performance or timeout

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15812 Heather Braum changed: What|Removed |Added CC||hbr...@nekls.org -- You ar

[Koha-bugs] [Bug 15812] Checkout search with too many results (single character search) causes poor performance or timeout

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15812 Nick Clemens changed: What|Removed |Added Severity|enhancement |normal Priority|P5