https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223
Caroline Cyr La Rose changed:
What|Removed |Added
Resolution|--- |FIXED
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223
Katrin Fischer changed:
What|Removed |Added
Status|Pushed to master|Needs documenting
--
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223
Fridolin Somers changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223
--- Comment #119 from Tomás Cohen Arazi ---
Pushed to master for 23.11.
Nice work everyone, thanks!
--
You are receiving this mail because:
You are watching all bug changes.
___
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223
Tomás Cohen Arazi changed:
What|Removed |Added
Status|Passed QA |Pushed to master
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223
--- Comment #118 from Tomás Cohen Arazi ---
Created attachment 156850
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156850=edit
Bug 16223: Tidy
--
You are receiving this mail because:
You are watching all bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223
--- Comment #117 from Tomás Cohen Arazi ---
Created attachment 156849
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156849=edit
Bug 16223: Mark lift_after_payment as boolean in schema
--
You are receiving this
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223
--- Comment #116 from Tomás Cohen Arazi ---
Created attachment 156848
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156848=edit
Bug 16223: DBIC schema
Signed-off-by: Tomas Cohen Arazi
--
You are receiving
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223
--- Comment #115 from Tomás Cohen Arazi ---
Created attachment 156847
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156847=edit
Bug 16223: (QA follow-up) Adjust DB changes
Signed-off-by: Tomas Cohen Arazi
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223
--- Comment #114 from Tomás Cohen Arazi ---
Created attachment 156846
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156846=edit
Bug 16223: (QA follow-up) Add filter, remove superfluous condition
Signed-off-by:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223
--- Comment #113 from Tomás Cohen Arazi ---
Created attachment 156845
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156845=edit
Bug 16223: Require fee limit only if "Lift after payment" is set as "Yes"
Fee limit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223
--- Comment #112 from Tomás Cohen Arazi ---
Created attachment 156844
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156844=edit
Bug 16223: (QA follow-up) Move trigger to apply
This patch moves the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223
--- Comment #111 from Tomás Cohen Arazi ---
Created attachment 156843
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156843=edit
Bug 16223: (QA follow-up) Remove GetDebarments
We remove the GetDebarments routine
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223
--- Comment #110 from Tomás Cohen Arazi ---
Created attachment 156842
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156842=edit
Bug 16223: Add ability to define liftable restrictions
Some libraries debar Patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #155644|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223
--- Comment #108 from Marcel de Rooy ---
Note for RM:
Please watch for conflicts:
Bug 29145 - Allow patrons to have overdue items that would not result in
debarment when removing overdue debarments
--
You are receiving this mail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223
--- Comment #107 from Marcel de Rooy ---
Looks good to me.
FAIL koha-tmpl/intranet-tmpl/prog/en/modules/admin/restrictions.tt
FAIL filters
missing_filter at line 217 ([%
IF
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223
--- Comment #106 from Marcel de Rooy ---
Created attachment 155650
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155650=edit
Bug 16223: (QA follow-up) Add filter, remove superfluous condition
Signed-off-by:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223
Marcel de Rooy changed:
What|Removed |Added
Attachment #153029|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223
Marcel de Rooy changed:
What|Removed |Added
Attachment #153028|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223
Marcel de Rooy changed:
What|Removed |Added
Attachment #153027|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223
Marcel de Rooy changed:
What|Removed |Added
Attachment #153026|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223
Marcel de Rooy changed:
What|Removed |Added
Attachment #153025|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223
Marcel de Rooy changed:
What|Removed |Added
Attachment #153024|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223
Marcel de Rooy changed:
What|Removed |Added
Patch complexity|--- |Small patch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223
Marcel de Rooy changed:
What|Removed |Added
Status|Signed Off |BLOCKED
QA
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223
Emmi Takkinen changed:
What|Removed |Added
Status|Patch doesn't apply |Signed Off
--- Comment #98
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223
Emmi Takkinen changed:
What|Removed |Added
Attachment #150029|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223
Emmi Takkinen changed:
What|Removed |Added
Attachment #153028|Bug 16223: Require fee |Bug 16223: (QA follow-up)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223
Emmi Takkinen changed:
What|Removed |Added
Attachment #150028|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223
Emmi Takkinen changed:
What|Removed |Added
Attachment #150027|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223
Emmi Takkinen changed:
What|Removed |Added
Attachment #150026|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223
Emmi Takkinen changed:
What|Removed |Added
Attachment #150025|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223
Emmi Takkinen changed:
What|Removed |Added
Attachment #148312|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223
--- Comment #90 from Emmi Takkinen ---
First patch has been resolved in bug 33574.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223
Marcel de Rooy changed:
What|Removed |Added
Status|Signed Off |Patch doesn't apply
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223
Bug 16223 depends on bug 33574, which changed state.
Bug 33574 Summary: Restriction type is not stored, all restrictions fall back
to MANUAL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33574
What
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223
Martin Renvoize changed:
What|Removed |Added
QA Contact|martin.renvoize@ptfs-europe
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223
Martin Renvoize changed:
What|Removed |Added
Attachment #148313|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223
Martin Renvoize changed:
What|Removed |Added
Attachment #148311|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223
Martin Renvoize changed:
What|Removed |Added
Attachment #148310|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223
Martin Renvoize changed:
What|Removed |Added
Attachment #148309|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223
Martin Renvoize changed:
What|Removed |Added
Attachment #148308|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223
Martin Renvoize changed:
What|Removed |Added
Attachment #148307|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223
Martin Renvoize changed:
What|Removed |Added
Depends on|31095 |33574
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223
--- Comment #83 from Emmi Takkinen ---
Created attachment 148313
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148313=edit
Bug 16223: Require fee limit only if "Lift after payment" is set as "Yes"
Fee limit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223
Emmi Takkinen changed:
What|Removed |Added
Attachment #146057|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223
Emmi Takkinen changed:
What|Removed |Added
Attachment #146055|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223
Emmi Takkinen changed:
What|Removed |Added
Attachment #146054|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223
Emmi Takkinen changed:
What|Removed |Added
Attachment #146053|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223
Emmi Takkinen changed:
What|Removed |Added
Attachment #146052|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223
Emmi Takkinen changed:
What|Removed |Added
Attachment #146051|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223
--- Comment #76 from Emmi Takkinen ---
I got a comment that "Fee limit" should probably not be always required. Which
got me thinking that maybe it should be required only if "Lift after payment"
is set to "Yes". Or then it should
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223
Bug 16223 depends on bug 31095, which changed state.
Bug 31095 Summary: Remove Koha::Patron::Debarment::GetDebarments and use
$patron->restrictions in preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31095
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223
Emmi Takkinen changed:
What|Removed |Added
Attachment #143936|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223
Emmi Takkinen changed:
What|Removed |Added
Attachment #143770|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223
Emmi Takkinen changed:
What|Removed |Added
Attachment #143769|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223
Emmi Takkinen changed:
What|Removed |Added
Attachment #143768|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223
Emmi Takkinen changed:
What|Removed |Added
Attachment #143767|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223
Emmi Takkinen changed:
What|Removed |Added
Attachment #143766|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223
Emmi Takkinen changed:
What|Removed |Added
Attachment #143765|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223
Emmi Takkinen changed:
What|Removed |Added
Status|Failed QA |Needs Signoff
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223
--- Comment #68 from Emmi Takkinen ---
Created attachment 143936
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143936=edit
Bug 16223: Add correct value attributes to restriction options in select
element
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223
--- Comment #67 from Emmi Takkinen ---
Hmm, it seems code returns only "MANUAL" restriction. Tests however return
correct type. So for some reason Koha saves restrictions incorrectly from UI.
--
You are receiving this mail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223
--- Comment #66 from Emmi Takkinen ---
Thank you Martin and Andrew for looking into this. I'll try to work on this
again tomorrow.
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223
Andrew Fuerste-Henry changed:
What|Removed |Added
Status|Needs Signoff |Failed QA
---
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223
--- Comment #64 from Martin Renvoize ---
I've rebased this and taken bug 31095 into account too..
I'd love to get an independent sign-off on this if your still interested in
testing it Andrew Fuerste-Henry ?
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223
Martin Renvoize changed:
What|Removed |Added
Status|Signed Off |Needs Signoff
--
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223
Martin Renvoize changed:
What|Removed |Added
Depends on||31095
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223
--- Comment #63 from Martin Renvoize ---
Created attachment 143770
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143770=edit
Bug 16223: (QA follow-up) Move trigger to apply
This patch moves the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223
--- Comment #62 from Martin Renvoize ---
Created attachment 143769
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143769=edit
Bug 16223: (QA follow-up) Remove GetDebarments
We remove the GetDebarments routine in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223
--- Comment #61 from Martin Renvoize ---
Created attachment 143768
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143768=edit
Bug 16223: (QA follow-up) Fix kohastructure bug
--
You are receiving this mail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223
Martin Renvoize changed:
What|Removed |Added
Attachment #143690|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223
Martin Renvoize changed:
What|Removed |Added
Attachment #143689|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223
Martin Renvoize changed:
What|Removed |Added
Attachment #143688|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223
Martin Renvoize changed:
What|Removed |Added
Attachment #143672|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223
Martin Renvoize changed:
What|Removed |Added
Attachment #143671|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223
Martin Renvoize changed:
What|Removed |Added
Attachment #143670|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223
--- Comment #54 from Martin Renvoize ---
Hmm... I've not actually tested this yet.. just applied it and done a minor
rebase.. reading the code it look like it won't work quite yet and it also
looks like the follow-up to move from
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223
--- Comment #53 from Martin Renvoize ---
Oh wow, Emmi, you star!
Thanks for the full rework here.. my apologies I missed the action had taken
place.. the code it looking great..
I'm going to work through it now.. I'm afraid it's
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223
Andrew Fuerste-Henry changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223
PTFS Europe Sandboxes changed:
What|Removed |Added
Attachment #143462|0 |1
is
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223
PTFS Europe Sandboxes changed:
What|Removed |Added
Attachment #143389|0 |1
is
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223
PTFS Europe Sandboxes changed:
What|Removed |Added
Attachment #143388|0 |1
is
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223
--- Comment #49 from Andrew Fuerste-Henry ---
I got the same error on the BibLibre sandboxes for some reason. Spinning one up
on PTFS-Europe's site now.
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223
Emmi Takkinen changed:
What|Removed |Added
Status|Patch doesn't apply |Needs Signoff
--- Comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223
Emmi Takkinen changed:
What|Removed |Added
Attachment #143390|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223
--- Comment #46 from Emmi Takkinen ---
(In reply to Andrew Fuerste-Henry from comment #45)
> The third patch here just failed to apply for me on a sandbox. Not sure what
> might have changed, given how recently you posted it.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223
Andrew Fuerste-Henry changed:
What|Removed |Added
Status|Needs Signoff |Patch doesn't apply
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223
Emmi Takkinen changed:
What|Removed |Added
Status|ASSIGNED|Needs Signoff
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223
--- Comment #44 from Emmi Takkinen ---
Created attachment 143390
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143390=edit
Bug 16223: Add ability to define liftable restrictions
Some libraries debar Patrons at
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223
--- Comment #43 from Emmi Takkinen ---
Created attachment 143389
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143389=edit
Bug 16223: DO NOT PUSH! Schema changes
Sponsored-by: Koha-Suomi Oy
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223
Emmi Takkinen changed:
What|Removed |Added
Attachment #132284|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223
Emmi Takkinen changed:
What|Removed |Added
Status|Failed QA |ASSIGNED
--- Comment #41
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223
Katrin Fischer changed:
What|Removed |Added
Status|Signed Off |Failed QA
--- Comment #40
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223
Katrin Fischer changed:
What|Removed |Added
See Also|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223
Emmi Takkinen changed:
What|Removed |Added
Status|Patch doesn't apply |Signed Off
--- Comment #38
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223
Emmi Takkinen changed:
What|Removed |Added
Attachment #128005|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223
Emmi Takkinen changed:
What|Removed |Added
Attachment #127252|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223
Emmi Takkinen changed:
What|Removed |Added
Attachment #122769|0 |1
is obsolete|
1 - 100 of 149 matches
Mail list logo