https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229
Caroline Cyr La Rose changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229
Andrew Fuerste-Henry changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229
Fridolin Somers changed:
What|Removed |Added
Version(s)|21.05.00|21.05.00,20.11.03
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229
--- Comment #66 from Jonathan Druart
---
Last patch pushed to master for 21.05.00.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229
--- Comment #65 from Jonathan Druart
---
Created attachment 115435
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115435=edit
Bug 17229: Fix perlcritic on ILSDI_Services.t
Subroutine "new" called using indirect
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229
--- Comment #64 from Jonathan Druart
---
Last patch pushed to master for 21.05.00, thanks Frido!
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229
--- Comment #63 from Fridolin Somers ---
Created attachment 115411
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115411=edit
Bug 17229: Fix unit test warning
Remove warning :
t/db_dependent/ILSDI_Services.t ..
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229
--- Comment #62 from Jonathan Druart
---
Pushed to master for 21.05, thanks to everybody involved!
--
You are receiving this mail because:
You are watching all bug changes.
___
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229
Jonathan Druart changed:
What|Removed |Added
Version(s)||21.05.00
released
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229
--- Comment #61 from Jonathan Druart
---
Will push as it, but I don't think we are going in the right direction.
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229
--- Comment #60 from Nick Clemens ---
(In reply to Jonathan Druart from comment #59)
> Here the behaviours are expected to be the same (between ILSDI and REST
> API), the existence of bug 24841 is proving it.
Unless that bug is
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229
--- Comment #59 from Jonathan Druart
---
Here the behaviours are expected to be the same (between ILSDI and REST API),
the existence of bug 24841 is proving it.
If we go with this patch we will have to fix bug 24841 anyway, and
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229
Nick Clemens changed:
What|Removed |Added
CC||n...@bywatersolutions.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229
Jonathan Druart changed:
What|Removed |Added
Status|Passed QA |Signed Off
--- Comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229
Martin Renvoize changed:
What|Removed |Added
Status|Signed Off |Passed QA
--- Comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229
Martin Renvoize changed:
What|Removed |Added
Attachment #113743|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229
Martin Renvoize changed:
What|Removed |Added
Attachment #113742|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229
Martin Renvoize changed:
What|Removed |Added
Attachment #113741|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229
--- Comment #52 from Jonathan Druart
---
(In reply to Arthur Suzuki from comment #48)
> Implementation here is the same as in BZ 17247 which is refered to by
> 24841...
> I've rebased the patch on current master, hopping it may
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229
--- Comment #51 from Arthur Suzuki ---
Created attachment 113743
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113743=edit
Bug 17229: moved UnitTest to t/db_dependant/ILSDI_Service.t
Signed-off-by: David Nind
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229
--- Comment #50 from Arthur Suzuki ---
Created attachment 113742
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113742=edit
Bug 17229: Check if patron is expired in CanItemBeReserved
This way, calls to ILS-DI
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229
Arthur Suzuki changed:
What|Removed |Added
Attachment #99817|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229
Arthur Suzuki changed:
What|Removed |Added
Status|BLOCKED |Signed Off
--- Comment #48
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229
Nick Clemens changed:
What|Removed |Added
See Also||https://bugs.koha-community
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229
Jonathan Druart changed:
What|Removed |Added
Status|Signed Off |BLOCKED
--- Comment #47
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229
--- Comment #46 from David Nind ---
Hi Arthur.
Just confirming this works.
I have created bug 24769 for the DataTables error on the patron's hold page:
- this does not occur in 19.11.x; and
- this error occurs before applying your
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229
David Nind changed:
What|Removed |Added
Attachment #99703|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229
David Nind changed:
What|Removed |Added
Attachment #99701|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229
David Nind changed:
What|Removed |Added
Attachment #99702|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229
Arthur Suzuki changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--- Comment #42
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229
Arthur Suzuki changed:
What|Removed |Added
Attachment #89760|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229
Arthur Suzuki changed:
What|Removed |Added
Status|Patch doesn't apply |Needs Signoff
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229
Arthur Suzuki changed:
What|Removed |Added
Attachment #85883|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229
Arthur Suzuki changed:
What|Removed |Added
Attachment #85071|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229
--- Comment #38 from David Nind ---
You get an error on the patron's page when following the test plan, but before
trying to apply the patch - the URL is entered:
1) For the patron, the holds tab heading shows that there is a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229
David Nind changed:
What|Removed |Added
Status|Needs Signoff |Patch doesn't apply
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229
--- Comment #36 from Arthur Suzuki ---
(In reply to Magnus Enger from comment #35)
> This can not really be tested before this bug is fixed:
> Bug 23710 - Holds broken, displays a JSON page with an error
this bug has been resolved
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229
Bug 17229 depends on bug 23710, which changed state.
Bug 23710 Summary: Holds broken on intranet, displays a JSON page with an error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23710
What|Removed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229
Martin Renvoize changed:
What|Removed |Added
Status|BLOCKED |Needs Signoff
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229
Magnus Enger changed:
What|Removed |Added
Status|Needs Signoff |BLOCKED
Depends on|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229
Arthur Suzuki changed:
What|Removed |Added
Status|Failed QA |Needs Signoff
--- Comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229
--- Comment #33 from Arthur Suzuki ---
Created attachment 89760
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89760=edit
Bug 17229: moved UnitTest to t/db_dependant/ILSDI_Service.t
This reverts commit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229
--- Comment #32 from Fridolin SOMERS ---
You need to reconsider the unit test patch.
Move to t/db_dependent/ILSDI_Services.t maybe.
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229
--- Comment #31 from Victor Grousset/tuxayo ---
Hi :)
To preserve the validity of the sign off (and other reasons which I don't
remember ^^"), it's usual to do followup patches instead of amending the signed
one.
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229
Arthur Suzuki changed:
What|Removed |Added
Attachment #85118|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229
--- Comment #29 from Arthur Suzuki ---
Patch also impacts holds submitted through Intranet, need reworks...
Maybe doing the check in ILSDI/Services.pm instead of Reserves.pm would do the
job.
--
You are receiving this mail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229
--- Comment #28 from Katrin Fischer ---
Tiny issue:
FAIL t/db_dependent/Holds.t
OK critic
FAIL forbidden patterns
forbidden pattern: tab char (line 142)
OK git manipulation
OK pod
OK
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229
Katrin Fischer changed:
What|Removed |Added
Status|Signed Off |Failed QA
--- Comment #27
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229
Jonathan Druart changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229
Arthur Suzuki changed:
What|Removed |Added
Attachment #85072|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229
Fridolin SOMERS changed:
What|Removed |Added
See Also|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229
Arthur Suzuki changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229
Arthur Suzuki changed:
What|Removed |Added
Status|ASSIGNED|Needs Signoff
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229
Arthur Suzuki changed:
What|Removed |Added
Status|Pushed for QA |ASSIGNED
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229
Arthur Suzuki changed:
What|Removed |Added
Attachment #85064|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229
Arthur Suzuki changed:
What|Removed |Added
Attachment #85066|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229
Arthur Suzuki changed:
What|Removed |Added
Attachment #85070|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229
Arthur Suzuki changed:
What|Removed |Added
Attachment #85065|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229
Arthur Suzuki changed:
What|Removed |Added
Attachment #72971|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229
--- Comment #19 from Arthur Suzuki ---
Not sure what I did is right but rebased this patch so that it applies to
branch master.
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229
Arthur Suzuki changed:
What|Removed |Added
Attachment #72970|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229
Arthur Suzuki changed:
What|Removed |Added
Status|Failed QA |Pushed for QA
--- Comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229
Arthur Suzuki changed:
What|Removed |Added
CC||arthur.suz...@biblibre.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229
Katrin Fischer changed:
What|Removed |Added
QA Contact|katrin.fisc...@bsz-bw.de|
--
You are receiving
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229
Victor Grousset/tuxayo changed:
What|Removed |Added
See Also|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229
Victor Grousset/tuxayo changed:
What|Removed |Added
Severity|minor |normal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229
Katrin Fischer changed:
What|Removed |Added
Status|Signed Off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229
Brendan Gallagher changed:
What|Removed |Added
Attachment #70683|0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229
Brendan Gallagher changed:
What|Removed |Added
Attachment #70682|0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229
Brendan Gallagher changed:
What|Removed |Added
Status|Needs Signoff
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229
Julian Maurice changed:
What|Removed |Added
Attachment #62036|0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229
Julian Maurice changed:
What|Removed |Added
Attachment #62037|0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229
Julian Maurice changed:
What|Removed |Added
Status|Patch doesn't apply
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229
Katrin Fischer changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229
Dominic Pichette changed:
What|Removed |Added
Attachment #67324|0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229
Dominic Pichette changed:
What|Removed |Added
Attachment #67325|0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229
Dominic Pichette changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229
--- Comment #9 from Dominic Pichette ---
Created attachment 67325
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67325=edit
screenshot with the number removed
--
You are receiving
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229
--- Comment #7 from Julian Maurice ---
(In reply to Héctor Eduardo Castro Avalos from comment #3)
> You should do this one dependent of bug 16246
Why ? They seem to be independent
--
You are receiving
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229
Julian Maurice changed:
What|Removed |Added
Status|Patch doesn't apply
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229
Julian Maurice changed:
What|Removed |Added
Attachment #55059|0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229
Julian Maurice changed:
What|Removed |Added
Attachment #55060|0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229
Héctor Eduardo Castro Avalos changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229
--- Comment #2 from Julian Maurice ---
Created attachment 55060
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55060=edit
Bug 17229: Add unit test for BlockExpiredPatronOpacActions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229
Julian Maurice changed:
What|Removed |Added
Status|ASSIGNED
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229
--- Comment #1 from Julian Maurice ---
Created attachment 55059
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55059=edit
Bug 17229: Check if patron is expired in CanItemBeReserved
86 matches
Mail list logo