https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314
--- Comment #92 from Tomás Cohen Arazi ---
I added a missing dependency, bug 26636. Patches for both this bug and its
dependency have been adapted/rebased to 20.11.x.
Bug 26636 itself is pretty self-contained and I confider it
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314
--- Comment #91 from Tomás Cohen Arazi ---
Created attachment 127536
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127536=edit
Bug 17314: Implement /suggestions routes [20.11.x]
This patch introduces routes to
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314
--- Comment #90 from Tomás Cohen Arazi ---
Created attachment 127535
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127535=edit
Bug 17314: OpenAPI spec [20.11.x]
Signed-off-by: Tomas Cohen Arazi
Signed-off-by:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314
--- Comment #89 from Tomás Cohen Arazi ---
Created attachment 127534
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127534=edit
Bug 17314: Unit tests [20.11.x]
Signed-off-by: Martin Renvoize
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314
--- Comment #88 from Tomás Cohen Arazi ---
Created attachment 127533
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127533=edit
Bug 17314: Make TestBuilder set good defaults for Suggestions [20.11.x]
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314
Tomás Cohen Arazi changed:
What|Removed |Added
Depends on||26636
Referenced
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314
Fridolin Somers changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314
--- Comment #86 from Arthur Suzuki ---
I just checked by git logging into C4/Auth.pm, and reading commits messages, I
don't see significant changes nor breaking changes about how permissions works
since 20.11.
--
You are receiving
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314
--- Comment #85 from Victor Grousset/tuxayo ---
(In reply to Jonathan Druart from comment #83)
> "Just add routes" is not as trivial as it sounds. We could introduce
> permission issues.
Indeed! I just checked and the tests check
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314
Kyle M Hall changed:
What|Removed |Added
Status|Passed QA |Pushed to stable
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314
Kyle M Hall changed:
What|Removed |Added
Status|Signed Off |Passed QA
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314
Kyle M Hall changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314
Kyle M Hall changed:
What|Removed |Added
Status|REOPENED|Needs Signoff
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314
Kyle M Hall changed:
What|Removed |Added
Status|RESOLVED|REOPENED
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314
Kyle M Hall changed:
What|Removed |Added
Version(s)|21.11.00|21.11.00,21.05.05
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314
--- Comment #83 from Jonathan Druart ---
"Just add routes" is not as trivial as it sounds. We could introduce permission
issues.
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314
--- Comment #82 from Arthur Suzuki ---
(In reply to Victor Grousset/tuxayo from comment #81)
> > Hope this one can go to stable and old-stable as well :)
>
> Do you confirm that it's not changing any behavior somewhere else? Like
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314
--- Comment #81 from Victor Grousset/tuxayo ---
> Hope this one can go to stable and old-stable as well :)
Do you confirm that it's not changing any behavior somewhere else? Like it's
just adding routes, right?
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314
Kyle M Hall changed:
What|Removed |Added
Status|Pushed to master|RESOLVED
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314
--- Comment #80 from Arthur Suzuki ---
Great \o/ thanks everyone!
Hope this one can go to stable and old-stable as well :)
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314
--- Comment #79 from Jonathan Druart ---
Pushed to master for 21.11, thanks to everybody involved!
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314
Jonathan Druart changed:
What|Removed |Added
Version(s)||21.11.00
released
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314
--- Comment #78 from Jonathan Druart ---
suggestions.suggestedby - Koha is setting it to the logged in user.
Shouldn't we do the same here?
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314
--- Comment #77 from Jonathan Druart ---
+# FIXME: This should be handled in Koha::Suggestion->store
+$body->{'status'} = 'ASKED'
+unless defined $body->{'status'};
Please open a separate bug report for that.
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314
jmbroust changed:
What|Removed |Added
CC||jean-manuel.broust@univ-lyo
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314
Martin Renvoize changed:
What|Removed |Added
Status|Signed Off |Passed QA
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314
Martin Renvoize changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--- Comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314
Martin Renvoize changed:
What|Removed |Added
Attachment #125100|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314
Martin Renvoize changed:
What|Removed |Added
Attachment #125099|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314
Martin Renvoize changed:
What|Removed |Added
Attachment #125098|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314
Martin Renvoize changed:
What|Removed |Added
Attachment #125097|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314
Tomás Cohen Arazi changed:
What|Removed |Added
QA Contact|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314
--- Comment #71 from Tomás Cohen Arazi ---
Created attachment 125100
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125100=edit
Bug 17314: Implement /suggestions routes
This patch introduces routes to handle
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314
--- Comment #70 from Tomás Cohen Arazi ---
Created attachment 125099
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125099=edit
Bug 17314: OpenAPI spec
Signed-off-by: Tomas Cohen Arazi
--
You are receiving
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314
--- Comment #69 from Tomás Cohen Arazi ---
Created attachment 125098
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125098=edit
Bug 17314: Unit tests
--
You are receiving this mail because:
You are watching all
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314
--- Comment #68 from Tomás Cohen Arazi ---
Created attachment 125097
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125097=edit
Bug 17314: Make TestBuilder set good defaults for Suggestions
Signed-off-by: Tomas
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #120135|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #120134|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #120133|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #120136|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314
Tomás Cohen Arazi changed:
What|Removed |Added
Status|Failed QA |Needs Signoff
--
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314
Katrin Fischer changed:
What|Removed |Added
Status|Needs Signoff |Failed QA
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314
--- Comment #67 from Arthur Suzuki ---
Hi Thomas,
Tests are failing!
I also tried in "real" with rester, although I get error 500, status property
in the reply is 201 and the suggestion is created in Koha :
{
"errors": [
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314
--- Comment #66 from Tomás Cohen Arazi ---
Created attachment 120136
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120136=edit
Bug 17314: Implement /suggestions routes
This patch introduces routes to handle
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314
--- Comment #65 from Tomás Cohen Arazi ---
Created attachment 120135
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120135=edit
Bug 17314: OpenAPI spec
Signed-off-by: Tomas Cohen Arazi
--
You are receiving
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314
--- Comment #64 from Tomás Cohen Arazi ---
Created attachment 120134
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120134=edit
Bug 17314: Unit tests
--
You are receiving this mail because:
You are watching all
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314
--- Comment #63 from Tomás Cohen Arazi ---
Created attachment 120133
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120133=edit
Bug 17314: Make TestBuilder set good defaults for Suggestions
Signed-off-by: Tomas
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314
Tomás Cohen Arazi changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #120111|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314
--- Comment #62 from Tomás Cohen Arazi ---
Created attachment 120111
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120111=edit
Bug 17314: Add routes for purchase suggestions
This patch adds routes for handling
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314
--- Comment #61 from Tomás Cohen Arazi ---
This is a hard move, but in my effort on making this more in line with how we
do it, I found myself removing things and rewriting most of it. And it didn't
contain tests.
So I decided we
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #114118|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #114117|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #114116|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #114115|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #114114|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #114113|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314
David Nind changed:
What|Removed |Added
CC||da...@davidnind.com
---
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314
--- Comment #59 from Arthur Suzuki ---
does patch still apply? anyone willing to test?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314
--- Comment #58 from Arthur Suzuki ---
Created attachment 114118
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114118=edit
Bug 17314: (QA follow-up)
--
You are receiving this mail because:
You are watching all
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314
--- Comment #57 from Arthur Suzuki ---
Created attachment 114117
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114117=edit
Bug 17314: (QA follow-up) Adjust spec
This patch makes the exposed attribute names match
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314
--- Comment #56 from Arthur Suzuki ---
Created attachment 114116
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114116=edit
Bug 17314: Added _to_model and _to_api methods and changed attirbutes naming
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314
--- Comment #55 from Arthur Suzuki ---
Created attachment 114115
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114115=edit
Bug 17314: (QA follow-up)
Test plan unchanged
--
You are receiving this mail because:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314
--- Comment #54 from Arthur Suzuki ---
Created attachment 114114
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114114=edit
Bug 17314: Migration from Swagger2 to OpenApi
This patch migrates the original
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314
Arthur Suzuki changed:
What|Removed |Added
Attachment #109972|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314
Arthur Suzuki changed:
What|Removed |Added
Status|Patch doesn't apply |Needs Signoff
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314
Victor Grousset/tuxayo changed:
What|Removed |Added
CC||vic...@tuxayo.net
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314
--- Comment #51 from Arthur Suzuki ---
up? This one need QA :)
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314
Julian Maurice changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314
Arthur Suzuki changed:
What|Removed |Added
Status|Failed QA |Needs Signoff
--- Comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314
--- Comment #47 from Arthur Suzuki ---
Created attachment 109975
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109975=edit
Bug 17314: Added _to_model and _to_api methods and changed attirbutes naming
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314
--- Comment #49 from Arthur Suzuki ---
Created attachment 109977
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109977=edit
Bug 17314: (QA follow-up)
--
You are receiving this mail because:
You are watching all
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314
--- Comment #48 from Arthur Suzuki ---
Created attachment 109976
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109976=edit
Bug 17314: (QA follow-up) Adjust spec
This patch makes the exposed attribute names match
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314
--- Comment #46 from Arthur Suzuki ---
Created attachment 109974
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109974=edit
Bug 17314: (QA follow-up)
Test plan unchanged
--
You are receiving this mail because:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314
Arthur Suzuki changed:
What|Removed |Added
Attachment #93762|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314
--- Comment #45 from Arthur Suzuki ---
Created attachment 109973
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109973=edit
Bug 17314: Migration from Swagger2 to OpenApi
This patch migrates the original
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314
--- Comment #43 from Arthur Suzuki ---
fixed conflicts but i get errors, also qa-tools are not happy.
Http response from api:
{
"errors": [
{
"message": "Properties not allowed: suggestionid, rejecteddate,
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314
Arthur Suzuki changed:
What|Removed |Added
Attachment #93761|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314
--- Comment #41 from Arthur Suzuki ---
Hi Tomas,
Since you've been doing most of the rework on this patch i thought maybe it
would be best to have you as assignee.
I've just tried to test it and maybe signoff (also a good reason for
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314
Arthur Suzuki changed:
What|Removed |Added
Assignee|arthur.suz...@biblibre.com |tomasco...@gmail.com
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314
--- Comment #40 from Tomás Cohen Arazi ---
Created attachment 93765
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93765=edit
Bug 17314: (QA follow-up) Adjust spec
This patch makes the exposed attribute names
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314
--- Comment #39 from Tomás Cohen Arazi ---
Rebased it on top of current master.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314
Tomás Cohen Arazi changed:
What|Removed |Added
Summary|REST API: Add API route to |Routes to create, list
83 matches
Mail list logo