[Koha-bugs] [Bug 17835] Move C4::Koha::GetItemTypes to Koha::ItemTypes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17835 Martin Renvoize changed: What|Removed |Added Blocks||22883 Referenced Bugs:

[Koha-bugs] [Bug 17835] Move C4::Koha::GetItemTypes to Koha::ItemTypes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17835 Martin Renvoize changed: What|Removed |Added Blocks||22882 Referenced Bugs:

[Koha-bugs] [Bug 17835] Move C4::Koha::GetItemTypes to Koha::ItemTypes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17835 Nick Clemens changed: What|Removed |Added Blocks|

[Koha-bugs] [Bug 17835] Move C4::Koha::GetItemTypes to Koha::ItemTypes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17835 Nick Clemens changed: What|Removed |Added CC|

[Koha-bugs] [Bug 17835] Move C4::Koha::GetItemTypes to Koha::ItemTypes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17835 --- Comment #57 from Jonathan Druart --- (In reply to Jonathan Druart from comment #56) > Created attachment 62470 [details] [review] > Bug 17835: Re-add the use Koha in orderreceive > > It

[Koha-bugs] [Bug 17835] Move C4::Koha::GetItemTypes to Koha::ItemTypes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17835 --- Comment #56 from Jonathan Druart --- Created attachment 62470 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62470=edit Bug 17835: Re-add the use Koha in orderreceive

[Koha-bugs] [Bug 17835] Move C4::Koha::GetItemTypes to Koha::ItemTypes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17835 --- Comment #55 from Jonathan Druart --- (In reply to Tomás Cohen Arazi from comment #54) > Created attachment 62370 [details] [review] > Bug 17835: (followup) Make TestBuilder skip views >

[Koha-bugs] [Bug 17835] Move C4::Koha::GetItemTypes to Koha::ItemTypes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17835 --- Comment #54 from Tomás Cohen Arazi --- Created attachment 62370 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62370=edit Bug 17835: (followup) Make TestBuilder skip views Signed-off-by:

[Koha-bugs] [Bug 17835] Move C4::Koha::GetItemTypes to Koha::ItemTypes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17835 Katrin Fischer changed: What|Removed |Added Resolution|---

[Koha-bugs] [Bug 17835] Move C4::Koha::GetItemTypes to Koha::ItemTypes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17835 Kyle M Hall changed: What|Removed |Added CC|

[Koha-bugs] [Bug 17835] Move C4::Koha::GetItemTypes to Koha::ItemTypes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17835 Marcel de Rooy changed: What|Removed |Added Status|Signed Off

[Koha-bugs] [Bug 17835] Move C4::Koha::GetItemTypes to Koha::ItemTypes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17835 --- Comment #50 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #49) > Another observation: we should also translate the item type description in > the items table of additem.pl. > Now you

[Koha-bugs] [Bug 17835] Move C4::Koha::GetItemTypes to Koha::ItemTypes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17835 --- Comment #49 from Marcel de Rooy --- Another observation: we should also translate the item type description in the items table of additem.pl. Now you have an English description in the items table and a

[Koha-bugs] [Bug 17835] Move C4::Koha::GetItemTypes to Koha::ItemTypes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17835 --- Comment #48 from Marcel de Rooy --- I am not really impressed by the DBIx constructs here. Still trying if we could simplify a bit here.. -- You are receiving this mail because: You are watching all

[Koha-bugs] [Bug 17835] Move C4::Koha::GetItemTypes to Koha::ItemTypes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17835 Marcel de Rooy changed: What|Removed |Added Attachment #61969|0

[Koha-bugs] [Bug 17835] Move C4::Koha::GetItemTypes to Koha::ItemTypes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17835 Marcel de Rooy changed: What|Removed |Added Attachment #61971|0

[Koha-bugs] [Bug 17835] Move C4::Koha::GetItemTypes to Koha::ItemTypes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17835 --- Comment #47 from Marcel de Rooy --- Created attachment 62162 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62162=edit Bug 17835: [QA Follow-up] Fix opac-search.pl Resolves: Global

[Koha-bugs] [Bug 17835] Move C4::Koha::GetItemTypes to Koha::ItemTypes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17835 Marcel de Rooy changed: What|Removed |Added Attachment #61970|0

[Koha-bugs] [Bug 17835] Move C4::Koha::GetItemTypes to Koha::ItemTypes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17835 Marcel de Rooy changed: What|Removed |Added Attachment #61968|0

[Koha-bugs] [Bug 17835] Move C4::Koha::GetItemTypes to Koha::ItemTypes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17835 Marcel de Rooy changed: What|Removed |Added Attachment #61967|0

[Koha-bugs] [Bug 17835] Move C4::Koha::GetItemTypes to Koha::ItemTypes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17835 Marcel de Rooy changed: What|Removed |Added Attachment #61966|0

[Koha-bugs] [Bug 17835] Move C4::Koha::GetItemTypes to Koha::ItemTypes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17835 Marcel de Rooy changed: What|Removed |Added Patch complexity|---

[Koha-bugs] [Bug 17835] Move C4::Koha::GetItemTypes to Koha::ItemTypes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17835 --- Comment #40 from Marcel de Rooy --- QA: Working on this one now. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs

[Koha-bugs] [Bug 17835] Move C4::Koha::GetItemTypes to Koha::ItemTypes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17835 Lari Taskula changed: What|Removed |Added Attachment #61700|0 |1

[Koha-bugs] [Bug 17835] Move C4::Koha::GetItemTypes to Koha::ItemTypes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17835 Lari Taskula changed: What|Removed |Added CC|

[Koha-bugs] [Bug 17835] Move C4::Koha::GetItemTypes to Koha::ItemTypes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17835 Lari Taskula changed: What|Removed |Added Attachment #61699|0 |1

[Koha-bugs] [Bug 17835] Move C4::Koha::GetItemTypes to Koha::ItemTypes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17835 Lari Taskula changed: What|Removed |Added Attachment #61698|0 |1

[Koha-bugs] [Bug 17835] Move C4::Koha::GetItemTypes to Koha::ItemTypes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17835 Lari Taskula changed: What|Removed |Added Attachment #61696|0 |1

[Koha-bugs] [Bug 17835] Move C4::Koha::GetItemTypes to Koha::ItemTypes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17835 Lari Taskula changed: What|Removed |Added Attachment #61697|0 |1

[Koha-bugs] [Bug 17835] Move C4::Koha::GetItemTypes to Koha::ItemTypes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17835 Lari Taskula changed: What|Removed |Added Attachment #61695|0 |1

[Koha-bugs] [Bug 17835] Move C4::Koha::GetItemTypes to Koha::ItemTypes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17835 Marcel de Rooy changed: What|Removed |Added Status|Signed Off

[Koha-bugs] [Bug 17835] Move C4::Koha::GetItemTypes to Koha::ItemTypes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17835 --- Comment #29 from Jonathan Druart --- Created attachment 61698 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61698=edit Bug 17835: Remove the subroutine GetItemTypes

[Koha-bugs] [Bug 17835] Move C4::Koha::GetItemTypes to Koha::ItemTypes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17835 Jonathan Druart changed: What|Removed |Added Attachment #60048|0

[Koha-bugs] [Bug 17835] Move C4::Koha::GetItemTypes to Koha::ItemTypes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17835 --- Comment #30 from Jonathan Druart --- Created attachment 61699 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61699=edit Bug 17835: Add an additional LEFT JOIN

[Koha-bugs] [Bug 17835] Move C4::Koha::GetItemTypes to Koha::ItemTypes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17835 --- Comment #28 from Jonathan Druart --- Created attachment 61697 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61697=edit Bug 17835: Replace GetItemTypes with

[Koha-bugs] [Bug 17835] Move C4::Koha::GetItemTypes to Koha::ItemTypes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17835 --- Comment #31 from Jonathan Druart --- Created attachment 61700 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61700=edit Bug 17835: Mock language pref value That way

[Koha-bugs] [Bug 17835] Move C4::Koha::GetItemTypes to Koha::ItemTypes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17835 --- Comment #27 from Jonathan Druart --- Created attachment 61696 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61696=edit Bug 17835: Do not reselect

[Koha-bugs] [Bug 17835] Move C4::Koha::GetItemTypes to Koha::ItemTypes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17835 Jonathan Druart changed: What|Removed |Added Status|Patch doesn't

[Koha-bugs] [Bug 17835] Move C4::Koha::GetItemTypes to Koha::ItemTypes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17835 Tomás Cohen Arazi changed: What|Removed |Added CC|

[Koha-bugs] [Bug 17835] Move C4::Koha::GetItemTypes to Koha::ItemTypes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17835 Jonathan Druart changed: What|Removed |Added Attachment #60051|0

[Koha-bugs] [Bug 17835] Move C4::Koha::GetItemTypes to Koha::ItemTypes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17835 Jonathan Druart changed: What|Removed |Added Attachment #60052|0

[Koha-bugs] [Bug 17835] Move C4::Koha::GetItemTypes to Koha::ItemTypes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17835 Jonathan Druart changed: What|Removed |Added Attachment #60053|0

[Koha-bugs] [Bug 17835] Move C4::Koha::GetItemTypes to Koha::ItemTypes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17835 Jonathan Druart changed: What|Removed |Added Attachment #60050|0

[Koha-bugs] [Bug 17835] Move C4::Koha::GetItemTypes to Koha::ItemTypes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17835 Bug 17835 depends on bug 17627, which changed state. Bug 17627 Summary: Move C4::Koha::GetItemTypesByCategory to Koha::ItemTypes https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17627 What|Removed

[Koha-bugs] [Bug 17835] Move C4::Koha::GetItemTypes to Koha::ItemTypes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17835 Josef Moravec changed: What|Removed |Added Attachment #60046|0 |1

[Koha-bugs] [Bug 17835] Move C4::Koha::GetItemTypes to Koha::ItemTypes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17835 Josef Moravec changed: What|Removed |Added Attachment #58563|0 |1

[Koha-bugs] [Bug 17835] Move C4::Koha::GetItemTypes to Koha::ItemTypes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17835 Josef Moravec changed: What|Removed |Added Attachment #58564|0 |1

[Koha-bugs] [Bug 17835] Move C4::Koha::GetItemTypes to Koha::ItemTypes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17835 Josef Moravec changed: What|Removed |Added Attachment #58562|0 |1

[Koha-bugs] [Bug 17835] Move C4::Koha::GetItemTypes to Koha::ItemTypes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17835 Josef Moravec changed: What|Removed |Added Attachment #60033|0 |1

[Koha-bugs] [Bug 17835] Move C4::Koha::GetItemTypes to Koha::ItemTypes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17835 Josef Moravec changed: What|Removed |Added Status|Needs Signoff

[Koha-bugs] [Bug 17835] Move C4::Koha::GetItemTypes to Koha::ItemTypes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17835 Josef Moravec changed: What|Removed |Added Attachment #58561|0 |1

[Koha-bugs] [Bug 17835] Move C4::Koha::GetItemTypes to Koha::ItemTypes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17835 --- Comment #14 from Jonathan Druart --- It failed if opaclanguages contained something else than just 'en'. -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 17835] Move C4::Koha::GetItemTypes to Koha::ItemTypes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17835 --- Comment #13 from Jonathan Druart --- Created attachment 60046 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60046=edit Bug 17835: Mock language pref value That way

[Koha-bugs] [Bug 17835] Move C4::Koha::GetItemTypes to Koha::ItemTypes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17835 --- Comment #12 from Josef Moravec --- (In reply to Jonathan Druart from comment #11) > (In reply to Josef Moravec from comment #8) > > test t/db_dependent/Koha/ItemTypes.t is failing: > > # Failed test

[Koha-bugs] [Bug 17835] Move C4::Koha::GetItemTypes to Koha::ItemTypes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17835 --- Comment #11 from Jonathan Druart --- (In reply to Josef Moravec from comment #8) > test t/db_dependent/Koha/ItemTypes.t is failing: > # Failed test 'item types should be sorted by

[Koha-bugs] [Bug 17835] Move C4::Koha::GetItemTypes to Koha::ItemTypes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17835 Jonathan Druart changed: What|Removed |Added Attachment #58565|0

[Koha-bugs] [Bug 17835] Move C4::Koha::GetItemTypes to Koha::ItemTypes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17835 --- Comment #9 from Josef Moravec --- but otherwise looks good for me ;) good job -- You are receiving this mail because: You are watching all bug changes. ___

[Koha-bugs] [Bug 17835] Move C4::Koha::GetItemTypes to Koha::ItemTypes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17835 Josef Moravec changed: What|Removed |Added CC|

[Koha-bugs] [Bug 17835] Move C4::Koha::GetItemTypes to Koha::ItemTypes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17835 --- Comment #7 from Jonathan Druart --- Created attachment 58600 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58600=edit Bug 17835: follow-up -- You are receiving this

[Koha-bugs] [Bug 17835] Move C4::Koha::GetItemTypes to Koha::ItemTypes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17835 Jonathan Druart changed: What|Removed |Added Status|Failed QA

[Koha-bugs] [Bug 17835] Move C4::Koha::GetItemTypes to Koha::ItemTypes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17835 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Failed

[Koha-bugs] [Bug 17835] Move C4::Koha::GetItemTypes to Koha::ItemTypes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17835 Jonathan Druart changed: What|Removed |Added Blocks|

[Koha-bugs] [Bug 17835] Move C4::Koha::GetItemTypes to Koha::ItemTypes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17835 --- Comment #2 from Jonathan Druart --- Created attachment 58562 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58562=edit Bug 17835: Do not reselect

[Koha-bugs] [Bug 17835] Move C4::Koha::GetItemTypes to Koha::ItemTypes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17835 --- Comment #5 from Jonathan Druart --- Created attachment 58565 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58565=edit Bug 17835: Add an additional LEFT JOIN condition

[Koha-bugs] [Bug 17835] Move C4::Koha::GetItemTypes to Koha::ItemTypes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17835 --- Comment #4 from Jonathan Druart --- Created attachment 58564 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58564=edit Bug 17835: Remove the subroutine GetItemTypes

[Koha-bugs] [Bug 17835] Move C4::Koha::GetItemTypes to Koha::ItemTypes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17835 --- Comment #3 from Jonathan Druart --- Created attachment 58563 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58563=edit Bug 17835: Replace GetItemTypes with

[Koha-bugs] [Bug 17835] Move C4::Koha::GetItemTypes to Koha::ItemTypes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17835 --- Comment #1 from Jonathan Druart --- Created attachment 58561 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58561=edit Bug 17835: Create a ItemtypeLocalization view

[Koha-bugs] [Bug 17835] Move C4::Koha::GetItemTypes to Koha::ItemTypes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17835 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED

[Koha-bugs] [Bug 17835] Move C4::Koha::GetItemTypes to Koha::ItemTypes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17835 Jonathan Druart changed: What|Removed |Added Depends on|

[Koha-bugs] [Bug 17835] Move C4::Koha::GetItemTypes to Koha::ItemTypes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17835 Jonathan Druart changed: What|Removed |Added Blocks|