[Koha-bugs] [Bug 17979] Fatal error when searching from addbooks.pl due to ISBN flaw

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17979 --- Comment #20 from Jonathan Druart --- I've applied the test from the second patch and it's failing. See bug 27008. -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 17979] Fatal error when searching from addbooks.pl due to ISBN flaw

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17979 --- Comment #19 from Nick Clemens --- (In reply to Jonathan Druart from comment #18) > (In reply to Nick Clemens from comment #17) > > I believe the patches on bug 29437 resolve the issue here (if a slightly > > different

[Koha-bugs] [Bug 17979] Fatal error when searching from addbooks.pl due to ISBN flaw

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17979 --- Comment #18 from Jonathan Druart --- (In reply to Nick Clemens from comment #17) > I believe the patches on bug 29437 resolve the issue here (if a slightly > different implementation) > > *** This bug has been marked as a

[Koha-bugs] [Bug 17979] Fatal error when searching from addbooks.pl due to ISBN flaw

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17979 Nick Clemens changed: What|Removed |Added Resolution|--- |DUPLICATE

[Koha-bugs] [Bug 17979] Fatal error when searching from addbooks.pl due to ISBN flaw

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17979 Joonas Kylmälä changed: What|Removed |Added See Also|

[Koha-bugs] [Bug 17979] Fatal error when searching from addbooks.pl due to ISBN flaw

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17979 --- Comment #16 from David Cook --- (In reply to Joonas Kylmälä from comment #14) > It would probably make sense to split this to two functions: one for title > search and another for isbn? Makes also unit tests easier, less cases

[Koha-bugs] [Bug 17979] Fatal error when searching from addbooks.pl due to ISBN flaw

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17979 --- Comment #15 from Joonas Kylmälä --- (In reply to Joonas Kylmälä from comment #14) > It would probably make sense to split this to two functions: one for title > search and another for isbn? Makes also unit tests easier, less

[Koha-bugs] [Bug 17979] Fatal error when searching from addbooks.pl due to ISBN flaw

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17979 --- Comment #14 from Joonas Kylmälä --- It would probably make sense to split this to two functions: one for title search and another for isbn? Makes also unit tests easier, less cases to iterate. -- You are receiving this mail

[Koha-bugs] [Bug 17979] Fatal error when searching from addbooks.pl due to ISBN flaw

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17979 --- Comment #13 from Joonas Kylmälä --- (In reply to Nick Clemens from comment #12) > This certainly improves things, however, the initial problem reported still > exists - a search for '1st to die' searches the isbn field The

[Koha-bugs] [Bug 17979] Fatal error when searching from addbooks.pl due to ISBN flaw

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17979 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com

[Koha-bugs] [Bug 17979] Fatal error when searching from addbooks.pl due to ISBN flaw

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17979 --- Comment #11 from Jonathan Druart --- Created attachment 119448 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119448=edit Bug 17979: Improve SQL query build Take also into account an hypotetical call to

[Koha-bugs] [Bug 17979] Fatal error when searching from addbooks.pl due to ISBN flaw

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17979 --- Comment #10 from Joonas Kylmälä --- Would be good if the function didn't error on invalid isbn or title at all, the reproducer from bug 27008 still gives the error with this patch applied: > perl -e 'use C4::Context; use

[Koha-bugs] [Bug 17979] Fatal error when searching from addbooks.pl due to ISBN flaw

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17979 Owen Leonard changed: What|Removed |Added Attachment #119373|0 |1 is obsolete|

[Koha-bugs] [Bug 17979] Fatal error when searching from addbooks.pl due to ISBN flaw

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17979 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are

[Koha-bugs] [Bug 17979] Fatal error when searching from addbooks.pl due to ISBN flaw

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17979 Jonathan Druart changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun

[Koha-bugs] [Bug 17979] Fatal error when searching from addbooks.pl due to ISBN flaw

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17979 --- Comment #7 from Jonathan Druart --- Created attachment 119373 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119373=edit Bug 17979: Fix cataloguing search if ISBN 13 is passed This patch fixes the following

[Koha-bugs] [Bug 17979] Fatal error when searching from addbooks.pl due to ISBN flaw

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17979 Jonathan Druart changed: What|Removed |Added CC|

[Koha-bugs] [Bug 17979] Fatal error when searching from addbooks.pl due to ISBN flaw

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17979 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|NEW -- You are receiving

[Koha-bugs] [Bug 17979] Fatal error when searching from addbooks.pl due to ISBN flaw

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17979 Owen Leonard changed: What|Removed |Added Assignee|oleon...@myacpl.org |koha-b...@lists.koha-commun

[Koha-bugs] [Bug 17979] Fatal error when searching from addbooks.pl due to ISBN flaw

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17979 Owen Leonard changed: What|Removed |Added Attachment #95673|0 |1 is obsolete|

[Koha-bugs] [Bug 17979] Fatal error when searching from addbooks.pl due to ISBN flaw

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17979 --- Comment #5 from Owen Leonard --- I was going off existing code, so perhaps I misunderstood that other instance. -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 17979] Fatal error when searching from addbooks.pl due to ISBN flaw

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17979 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de

[Koha-bugs] [Bug 17979] Fatal error when searching from addbooks.pl due to ISBN flaw

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17979 Owen Leonard changed: What|Removed |Added Assignee|gmcha...@gmail.com |oleon...@myacpl.org -- You

[Koha-bugs] [Bug 17979] Fatal error when searching from addbooks.pl due to ISBN flaw

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17979 --- Comment #3 from Owen Leonard --- Created attachment 95673 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95673=edit Bug 17979: Fatal error when searching from addbooks.pl due to ISBN flaw This patch adds true

[Koha-bugs] [Bug 17979] Fatal error when searching from addbooks.pl due to ISBN flaw

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17979 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Trivial patch

[Koha-bugs] [Bug 17979] Fatal error when searching from addbooks.pl due to ISBN flaw

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17979 --- Comment #2 from David Cook --- (In reply to Jonathan Druart from comment #1) > I guess the regex should be m|^[\d-]*$|; > Instead of just /\d/ That doesn't account for ISBN-10 where the check digit can

[Koha-bugs] [Bug 17979] Fatal error when searching from addbooks.pl due to ISBN flaw

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17979 Jonathan Druart changed: What|Removed |Added CC|