[Koha-bugs] [Bug 18355] Permanent location should show with cart location

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 Marcel de Rooy changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl

[Koha-bugs] [Bug 18355] Permanent location should show with cart location

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 --- Comment #45 from Marcel de Rooy --- Created attachment 95880 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95880&action=edit Bug 18355: (QA follow-up) Rearrange comments, improve code Comments were hard to re

[Koha-bugs] [Bug 18355] Permanent location should show with cart location

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 Marcel de Rooy changed: What|Removed |Added Attachment #95775|0 |1 is obsolete|

[Koha-bugs] [Bug 18355] Permanent location should show with cart location

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexi

[Koha-bugs] [Bug 18355] Permanent location should show with cart location

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 Martin Renvoize changed: What|Removed |Added Keywords||rel_20_05_target -- You

[Koha-bugs] [Bug 18355] Permanent location should show with cart location

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 Martin Renvoize changed: What|Removed |Added Attachment #79717|0 |1 is obsolete|

[Koha-bugs] [Bug 18355] Permanent location should show with cart location

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 --- Comment #43 from Martin Renvoize --- Created attachment 95775 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95775&action=edit Bug 18355: Display permanent location with cart location Signed-off-by: Martin Ren

[Koha-bugs] [Bug 18355] Permanent location should show with cart location

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 Martin Renvoize changed: What|Removed |Added Depends on||21466 Referenced Bugs:

[Koha-bugs] [Bug 18355] Permanent location should show with cart location

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 Martin Renvoize changed: What|Removed |Added Status|Failed QA |Signed Off -- You are re

[Koha-bugs] [Bug 18355] Permanent location should show with cart location

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 Martin Renvoize changed: What|Removed |Added Attachment #83665|0 |1 is obsolete|

[Koha-bugs] [Bug 18355] Permanent location should show with cart location

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europ

[Koha-bugs] [Bug 18355] Permanent location should show with cart location

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Failed QA

[Koha-bugs] [Bug 18355] Permanent location should show with cart location

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 José-Mario Monteiro-Santos changed: What|Removed |Added Status|Needs Signoff |Signed Off --

[Koha-bugs] [Bug 18355] Permanent location should show with cart location

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 José-Mario Monteiro-Santos changed: What|Removed |Added Attachment #80153|0 |1 is ob

[Koha-bugs] [Bug 18355] Permanent location should show with cart location

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 Christopher Brannon changed: What|Removed |Added See Also||https://bugs.koha-comm

[Koha-bugs] [Bug 18355] Permanent location should show with cart location

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 Christopher Brannon changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You

[Koha-bugs] [Bug 18355] Permanent location should show with cart location

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 --- Comment #40 from Christopher Brannon --- Created attachment 80153 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80153&action=edit Bug 18355: Update opac-detail.pl/tt to show both Adding dependancy of bug 2150

[Koha-bugs] [Bug 18355] Permanent location should show with cart location

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 --- Comment #39 from Christopher Brannon --- While this works properly, it will work better once 21503 is applied. As is, AuthoriseValues.pm (plugin) will not fail to code. 21503 will fix that issue. -- You are receiving this mai

[Koha-bugs] [Bug 18355] Permanent location should show with cart location

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 --- Comment #38 from Christopher Brannon --- I've accepted the alternative patch as the better way to go. This patch will depend on fixing AuthorisedValues.pm, per our discussion, to display the code if a description doesn't exist.

[Koha-bugs] [Bug 18355] Permanent location should show with cart location

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 Christopher Brannon changed: What|Removed |Added Attachment #79684|0 |1 is obsolete|

[Koha-bugs] [Bug 18355] Permanent location should show with cart location

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 --- Comment #37 from Christopher Brannon --- Created attachment 79786 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79786&action=edit Bug 18355: Remove obsolete code from pl -- You are receiving this mail becaus

[Koha-bugs] [Bug 18355] Permanent location should show with cart location

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 --- Comment #36 from Christopher Brannon --- I also did a restart just to be sure. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koh

[Koha-bugs] [Bug 18355] Permanent location should show with cart location

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 --- Comment #35 from Christopher Brannon --- Yes. I checked for my mods and they are not there. Just yours. -- You are receiving this mail because: You are watching all bug changes. ___

[Koha-bugs] [Bug 18355] Permanent location should show with cart location

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 --- Comment #34 from Jonathan Druart --- (In reply to Christopher Brannon from comment #33) > (In reply to Jonathan Druart from comment #31) > > Hi Christopher, > > I would suggest to move the display logic to the template for sever

[Koha-bugs] [Bug 18355] Permanent location should show with cart location

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 --- Comment #33 from Christopher Brannon --- (In reply to Jonathan Druart from comment #31) > Hi Christopher, > I would suggest to move the display logic to the template for several > reasons: > - the pl logic from the first patch is

[Koha-bugs] [Bug 18355] Permanent location should show with cart location

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 Christopher Brannon changed: What|Removed |Added Status|In Discussion |Failed QA --- Comment

[Koha-bugs] [Bug 18355] Permanent location should show with cart location

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 Jonathan Druart changed: What|Removed |Added Status|Signed Off |In Discussion --- Comment

[Koha-bugs] [Bug 18355] Permanent location should show with cart location

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 --- Comment #30 from Jonathan Druart --- Created attachment 79717 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79717&action=edit [ALTERNATIVE-PATCH %] Bug 18355: Display permanent location with cart location --

[Koha-bugs] [Bug 18355] Permanent location should show with cart location

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 --- Comment #29 from Christopher Brannon --- (In reply to Jonathan Druart from comment #27) > Please resubmit without the indentation changes. Sorry. Didn't understand this was an issue. Please look and see if this is okay now. -

[Koha-bugs] [Bug 18355] Permanent location should show with cart location

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 Christopher Brannon changed: What|Removed |Added Attachment #78913|0 |1 is obsolete|

[Koha-bugs] [Bug 18355] Permanent location should show with cart location

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-

[Koha-bugs] [Bug 18355] Permanent location should show with cart location

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 Christopher Brannon changed: What|Removed |Added See Also||https://bugs.koha-comm

[Koha-bugs] [Bug 18355] Permanent location should show with cart location

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 Christopher Brannon changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You ar

[Koha-bugs] [Bug 18355] Permanent location should show with cart location

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 Christopher Brannon changed: What|Removed |Added Status|ASSIGNED|Needs Signoff --- Com

[Koha-bugs] [Bug 18355] Permanent location should show with cart location

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 Christopher Brannon changed: What|Removed |Added Status|Signed Off |ASSIGNED Ke

[Koha-bugs] [Bug 18355] Permanent location should show with cart location

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 Lisette Scheer changed: What|Removed |Added CC||lisettesla...@gmail.com

[Koha-bugs] [Bug 18355] Permanent location should show with cart location

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 Lisette Scheer changed: What|Removed |Added Attachment #78908|0 |1 is obsolete|

[Koha-bugs] [Bug 18355] Permanent location should show with cart location

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 ByWater Sandboxes changed: What|Removed |Added Attachment #78584|0 |1 is obsolete|

[Koha-bugs] [Bug 18355] Permanent location should show with cart location

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 --- Comment #22 from Christopher Brannon --- UPDATED TEST PLAN 1) Make sure ReturnToShelvingCart is set to Move. 2) Check in an item. 3) View the item in detail.pl and opac-detail.pl and see that only the cart location shows. 4) Appl

[Koha-bugs] [Bug 18355] Permanent location should show with cart location

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 rkui...@roundrocktexas.gov changed: What|Removed |Added CC||rkui...@roundroc

[Koha-bugs] [Bug 18355] Permanent location should show with cart location

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 M. Tompsett changed: What|Removed |Added Keywords||Academy -- You are receiving

[Koha-bugs] [Bug 18355] Permanent location should show with cart location

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 Christopher Brannon changed: What|Removed |Added Keywords|Academy | Status|F

[Koha-bugs] [Bug 18355] Permanent location should show with cart location

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 Christopher Brannon changed: What|Removed |Added Attachment #66514|0 |1 is obsolete|

[Koha-bugs] [Bug 18355] Permanent location should show with cart location

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 Nick Clemens changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #19 fr

[Koha-bugs] [Bug 18355] Permanent location should show with cart location

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 --- Comment #18 from Christopher Brannon --- (In reply to Alex Buckley from comment #17) > Hi Christopher > > Your patch works as described and I have signed off on it, I have added your > test plan from comment 2 onto the patch as

[Koha-bugs] [Bug 18355] Permanent location should show with cart location

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 --- Comment #17 from Alex Buckley --- Hi Christopher Your patch works as described and I have signed off on it, I have added your test plan from comment 2 onto the patch as I know it makes it easier for the Release Manager -- You

[Koha-bugs] [Bug 18355] Permanent location should show with cart location

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 Alex Buckley changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are recei

[Koha-bugs] [Bug 18355] Permanent location should show with cart location

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 Alex Buckley changed: What|Removed |Added Attachment #66432|0 |1 is obsolete|

[Koha-bugs] [Bug 18355] Permanent location should show with cart location

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 --- Comment #15 from Christopher Brannon --- (In reply to M. Tompsett from comment #13) > (In reply to Alex Buckley from comment #12) > > Can you please merge your patches with the up to date master branch? > > Git properly merged t

[Koha-bugs] [Bug 18355] Permanent location should show with cart location

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 M. Tompsett changed: What|Removed |Added CC||mtomp...@hotmail.com --- Comm

[Koha-bugs] [Bug 18355] Permanent location should show with cart location

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 M. Tompsett changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are rec

[Koha-bugs] [Bug 18355] Permanent location should show with cart location

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 M. Tompsett changed: What|Removed |Added Attachment #62999|0 |1 is obsolete|

[Koha-bugs] [Bug 18355] Permanent location should show with cart location

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 --- Comment #12 from Alex Buckley --- Hi Christopher Can you please merge your patches with the up to date master branch? Cheers Alex -- You are receiving this mail because: You are watching all bug changes. _

[Koha-bugs] [Bug 18355] Permanent location should show with cart location

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 Alex Buckley changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply

[Koha-bugs] [Bug 18355] Permanent location should show with cart location

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 Paul Poulain changed: What|Removed |Added Keywords||Academy CC|

[Koha-bugs] [Bug 18355] Permanent location should show with cart location

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 --- Comment #10 from Christopher Brannon --- (In reply to Nick Clemens from comment #8) > I like the idea, two strange display issues: > > 1 - Items with no location before cart display as "CART (Book Cart)", I > would expect just t

[Koha-bugs] [Bug 18355] Permanent location should show with cart location

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 Christopher Brannon changed: What|Removed |Added Attachment #61984|0 |1 is obsolete|

[Koha-bugs] [Bug 18355] Permanent location should show with cart location

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 Christopher Brannon changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You

[Koha-bugs] [Bug 18355] Permanent location should show with cart location

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com

[Koha-bugs] [Bug 18355] Permanent location should show with cart location

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 Marc Véron changed: What|Removed |Added Status|Needs Signoff |Signed Off Version|

[Koha-bugs] [Bug 18355] Permanent location should show with cart location

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 Marc Véron changed: What|Removed |Added CC||ve...@veron.ch Attachment #61

[Koha-bugs] [Bug 18355] Permanent location should show with cart location

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 --- Comment #6 from Marc Véron --- Created attachment 61984 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61984&action=edit Bug 18355: Permanent location should show with cart location Followed test plan from Com

[Koha-bugs] [Bug 18355] Permanent location should show with cart location

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 Christopher Brannon changed: What|Removed |Added Attachment #61978|0 |1 is obsolete|

[Koha-bugs] [Bug 18355] Permanent location should show with cart location

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 --- Comment #4 from Christopher Brannon --- Never mind. I fixed it. :) I am only addressing the detail pages in the patch. I looked over the search results, and the item information is being pulled in differently, so I am not sur

[Koha-bugs] [Bug 18355] Permanent location should show with cart location

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 Christopher Brannon changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |cbran...@cdalibrary.or

[Koha-bugs] [Bug 18355] Permanent location should show with cart location

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 Christopher Brannon changed: What|Removed |Added Status|NEW |Needs Signoff Patch

[Koha-bugs] [Bug 18355] Permanent location should show with cart location

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 Christopher Brannon changed: What|Removed |Added Attachment #61978|Bug 18355: Modifies |Bug 18355: Modifies

[Koha-bugs] [Bug 18355] Permanent location should show with cart location

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 --- Comment #3 from Christopher Brannon --- I'm not sure how to fix the subject in the attachment. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

[Koha-bugs] [Bug 18355] Permanent location should show with cart location

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 --- Comment #2 from Christopher Brannon --- Sorry, the attach turned out wonky. TEST PLAN 1) Make sure ReturnToShelvingCart is set to Move. 2) Check in an item. 3) View the item in detail.pl and opac-detail.pl and see that only t

[Koha-bugs] [Bug 18355] Permanent location should show with cart location

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 --- Comment #1 from Christopher Brannon --- Created attachment 61978 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61978&action=edit Bug 18355: Modifies location on detail pages. TEST PLAN 1) Make sure ReturnToShe