[Koha-bugs] [Bug 18928] Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules

2019-10-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 Martin Renvoize changed: What|Removed |Added Text to go in the|Reports Note: This changes |Reports Note: This

[Koha-bugs] [Bug 18928] Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules

2019-10-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 Martin Renvoize changed: What|Removed |Added Text to go in the|Reports Note: This changes |Reports Note: This

[Koha-bugs] [Bug 18928] Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules

2019-10-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 Martin Renvoize changed: What|Removed |Added Text to go in the|Reports Note: This changes |Reports Note: This

[Koha-bugs] [Bug 18928] Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules

2019-10-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 Martin Renvoize changed: What|Removed |Added CC|

[Koha-bugs] [Bug 18928] Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules

2019-08-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 Nick Clemens changed: What|Removed |Added Blocks||23484 Referenced Bugs:

[Koha-bugs] [Bug 18928] Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules

2019-07-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 Fridolin SOMERS changed: What|Removed |Added Status|Pushed to master|RESOLVED

[Koha-bugs] [Bug 18928] Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules

2019-07-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 --- Comment #117 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list

[Koha-bugs] [Bug 18928] Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules

2019-07-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 Martin Renvoize changed: What|Removed |Added Version(s)||19.11.00 released

[Koha-bugs] [Bug 18928] Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules

2019-06-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 Nick Clemens changed: What|Removed |Added Attachment #89638|0 |1 is obsolete|

[Koha-bugs] [Bug 18928] Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules

2019-06-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 Nick Clemens changed: What|Removed |Added Attachment #89637|0 |1 is obsolete|

[Koha-bugs] [Bug 18928] Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules

2019-06-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 Nick Clemens changed: What|Removed |Added Attachment #89635|0 |1 is obsolete|

[Koha-bugs] [Bug 18928] Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules

2019-06-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 --- Comment #116 from Nick Clemens --- Created attachment 91094 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91094=edit Bug 18928: (QA follow-up) Remove DBIC files and reference to DefaultCircRule

[Koha-bugs] [Bug 18928] Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules

2019-06-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are

[Koha-bugs] [Bug 18928] Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules

2019-06-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 Nick Clemens changed: What|Removed |Added Attachment #89634|0 |1 is obsolete|

[Koha-bugs] [Bug 18928] Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules

2019-06-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 Nick Clemens changed: What|Removed |Added Attachment #90501|0 |1 is obsolete|

[Koha-bugs] [Bug 18928] Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules

2019-06-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 Nick Clemens changed: What|Removed |Added Attachment #89633|0 |1 is obsolete|

[Koha-bugs] [Bug 18928] Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules

2019-06-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 Nick Clemens changed: What|Removed |Added Attachment #89636|0 |1 is obsolete|

[Koha-bugs] [Bug 18928] Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules

2019-06-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 Nick Clemens changed: What|Removed |Added Attachment #89628|0 |1 is obsolete|

[Koha-bugs] [Bug 18928] Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules

2019-06-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 Nick Clemens changed: What|Removed |Added Attachment #89632|0 |1 is obsolete|

[Koha-bugs] [Bug 18928] Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules

2019-06-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 Nick Clemens changed: What|Removed |Added Attachment #89631|0 |1 is obsolete|

[Koha-bugs] [Bug 18928] Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules

2019-06-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 Nick Clemens changed: What|Removed |Added Attachment #89629|0 |1 is obsolete|

[Koha-bugs] [Bug 18928] Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules

2019-06-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 Nick Clemens changed: What|Removed |Added Attachment #89630|0 |1 is obsolete|

[Koha-bugs] [Bug 18928] Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules

2019-06-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 Bug 18928 depends on bug 18925, which changed state. Bug 18925 Summary: Move maxissueqty and maxonsiteissueqty to circulation_rules https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 What|Removed

[Koha-bugs] [Bug 18928] Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules

2019-06-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 Bug 18928 depends on bug 18925, which changed state. Bug 18925 Summary: Move maxissueqty and maxonsiteissueqty to circulation_rules https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 What|Removed

[Koha-bugs] [Bug 18928] Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules

2019-06-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 Jonathan Druart changed: What|Removed |Added See Also|

[Koha-bugs] [Bug 18928] Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules

2019-06-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 --- Comment #102 from Jonathan Druart --- Created attachment 90501 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90501=edit Bug 18928: (bug 22847 follow-up 2) Display correctly the values (not the propagated

[Koha-bugs] [Bug 18928] Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules

2019-06-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 --- Comment #101 from Jonathan Druart --- (In reply to Nick Clemens from comment #100) > Some feedback: > t/db_dependent/TestBuilder.t - occurrence of default_circ_rules Sure? I do not have it :) > Set rule: > All-libraries >

[Koha-bugs] [Bug 18928] Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules

2019-06-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com

[Koha-bugs] [Bug 18928] Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules

2019-05-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 --- Comment #99 from Jonathan Druart --- Created attachment 89638 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89638=edit Bug 18928: Remove '(not set)' The "(not set)" part must be removed IMO, I am not sure I

[Koha-bugs] [Bug 18928] Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules

2019-05-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 --- Comment #92 from Jonathan Druart --- Created attachment 89631 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89631=edit Bug 18928: Update new occurrences Signed-off-by: Tomas Cohen Arazi Signed-off-by:

[Koha-bugs] [Bug 18928] Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules

2019-05-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 --- Comment #94 from Jonathan Druart --- Created attachment 89633 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89633=edit Bug 18928: (follow-up) Unset max_holds rule if needed Test plan: 1) Set all values in

[Koha-bugs] [Bug 18928] Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules

2019-05-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 --- Comment #93 from Jonathan Druart --- Created attachment 89632 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89632=edit Bug 18928: (follow-up) Make DB update idempotent Signed-off-by: Tomas Cohen Arazi

[Koha-bugs] [Bug 18928] Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules

2019-05-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 --- Comment #91 from Jonathan Druart --- Created attachment 89630 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89630=edit Bug 18928: Add missing filters Signed-off-by: Tomas Cohen Arazi Signed-off-by: Agustin

[Koha-bugs] [Bug 18928] Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules

2019-05-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 --- Comment #90 from Jonathan Druart --- Created attachment 89629 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89629=edit Bug 18928: Add DB structure changes Signed-off-by: Tomas Cohen Arazi Signed-off-by:

[Koha-bugs] [Bug 18928] Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules

2019-05-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 Jonathan Druart changed: What|Removed |Added Attachment #89441|0 |1 is obsolete|

[Koha-bugs] [Bug 18928] Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules

2019-05-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 --- Comment #96 from Jonathan Druart --- Created attachment 89635 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89635=edit Bug 18928: Use get_effective_rule in GetBranchItemRule Signed-off-by: Agustin Moyano

[Koha-bugs] [Bug 18928] Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules

2019-05-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 --- Comment #97 from Jonathan Druart --- Created attachment 89636 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89636=edit Bug 18928: (bug 22679 follow-up) Do not remove all rules along with the issuing rule We

[Koha-bugs] [Bug 18928] Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules

2019-05-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 --- Comment #95 from Jonathan Druart --- Created attachment 89634 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89634=edit Bug 18928: DBIC schema update Signed-off-by: Agustin Moyano Signed-off-by: Liz Rea

[Koha-bugs] [Bug 18928] Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules

2019-05-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 --- Comment #98 from Jonathan Druart --- Created attachment 89637 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89637=edit Bug 18928: (bug 22847 follow-up) Display correctly the values (not the propagated ones)

[Koha-bugs] [Bug 18928] Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules

2019-05-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 Jonathan Druart changed: What|Removed |Added Status|Patch doesn't apply |Signed Off -- You are

[Koha-bugs] [Bug 18928] Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules

2019-05-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de

[Koha-bugs] [Bug 18928] Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules

2019-05-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 Liz Rea changed: What|Removed |Added Attachment #89440|0 |1 is obsolete|

[Koha-bugs] [Bug 18928] Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules

2019-05-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 --- Comment #81 from Liz Rea --- Created attachment 89445 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89445=edit Bug 18928: (follow-up) Make DB update idempotent Signed-off-by: Tomas Cohen Arazi

[Koha-bugs] [Bug 18928] Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules

2019-05-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 --- Comment #79 from Liz Rea --- Created attachment 89443 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89443=edit Bug 18928: Add missing filters Signed-off-by: Tomas Cohen Arazi Signed-off-by: Agustin Moyano

[Koha-bugs] [Bug 18928] Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules

2019-05-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 --- Comment #84 from Liz Rea --- Created attachment 89448 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89448=edit Bug 18928: Use get_effective_rule in GetBranchItemRule Signed-off-by: Agustin Moyano

[Koha-bugs] [Bug 18928] Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules

2019-05-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 --- Comment #80 from Liz Rea --- Created attachment 89444 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89444=edit Bug 18928: Update new occurrences Signed-off-by: Tomas Cohen Arazi Signed-off-by: Agustin

[Koha-bugs] [Bug 18928] Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules

2019-05-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 --- Comment #87 from Liz Rea --- Created attachment 89451 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89451=edit Bug 18928: Remove '(not set)' The "(not set)" part must be removed IMO, I am not sure I

[Koha-bugs] [Bug 18928] Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules

2019-05-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 --- Comment #82 from Liz Rea --- Created attachment 89446 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89446=edit Bug 18928: (follow-up) Unset max_holds rule if needed Test plan: 1) Set all values in Default

[Koha-bugs] [Bug 18928] Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules

2019-05-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 --- Comment #78 from Liz Rea --- Created attachment 89442 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89442=edit Bug 18928: Add DB structure changes Signed-off-by: Tomas Cohen Arazi Signed-off-by: Agustin

[Koha-bugs] [Bug 18928] Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules

2019-05-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 --- Comment #86 from Liz Rea --- Created attachment 89450 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89450=edit Bug 18928: (bug 22847 follow-up) Display correctly the values (not the propagated ones)

[Koha-bugs] [Bug 18928] Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules

2019-05-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 --- Comment #85 from Liz Rea --- Created attachment 89449 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89449=edit Bug 18928: (bug 22679 follow-up) Do not remove all rules along with the issuing rule We actually

[Koha-bugs] [Bug 18928] Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules

2019-05-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 --- Comment #83 from Liz Rea --- Created attachment 89447 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89447=edit Bug 18928: DBIC schema update Signed-off-by: Agustin Moyano Signed-off-by: Liz Rea -- You

[Koha-bugs] [Bug 18928] Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules

2019-05-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 --- Comment #77 from Liz Rea --- Created attachment 89441 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89441=edit Bug 18928: Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules Test

[Koha-bugs] [Bug 18928] Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules

2019-05-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 Liz Rea changed: What|Removed |Added Attachment #89428|0 |1 is obsolete|

[Koha-bugs] [Bug 18928] Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules

2019-05-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 --- Comment #66 from Kyle M Hall --- Created attachment 89429 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89429=edit Bug 18928: Add DB structure changes Signed-off-by: Tomas Cohen Arazi Signed-off-by: Agustin

[Koha-bugs] [Bug 18928] Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules

2019-05-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 --- Comment #67 from Kyle M Hall --- Created attachment 89430 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89430=edit Bug 18928: Add missing filters Signed-off-by: Tomas Cohen Arazi Signed-off-by: Agustin

[Koha-bugs] [Bug 18928] Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules

2019-05-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 --- Comment #68 from Kyle M Hall --- Created attachment 89431 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89431=edit Bug 18928: Update new occurrences Signed-off-by: Tomas Cohen Arazi Signed-off-by: Agustin

[Koha-bugs] [Bug 18928] Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules

2019-05-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 --- Comment #71 from Kyle M Hall --- Created attachment 89434 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89434=edit Bug 18928: DBIC schema update Signed-off-by: Agustin Moyano Signed-off-by: Kyle M Hall

[Koha-bugs] [Bug 18928] Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules

2019-05-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 --- Comment #70 from Kyle M Hall --- Created attachment 89433 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89433=edit Bug 18928: (follow-up) Unset max_holds rule if needed Test plan: 1) Set all values in

[Koha-bugs] [Bug 18928] Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules

2019-05-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 Kyle M Hall changed: What|Removed |Added Attachment #89427|0 |1 is obsolete|

[Koha-bugs] [Bug 18928] Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules

2019-05-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 --- Comment #73 from Kyle M Hall --- Created attachment 89436 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89436=edit Bug 18928: (bug 22679 follow-up) Do not remove all rules along with the issuing rule We

[Koha-bugs] [Bug 18928] Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules

2019-05-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 --- Comment #72 from Kyle M Hall --- Created attachment 89435 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89435=edit Bug 18928: Use get_effective_rule in GetBranchItemRule Signed-off-by: Agustin Moyano

[Koha-bugs] [Bug 18928] Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules

2019-05-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 --- Comment #75 from Kyle M Hall --- Created attachment 89438 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89438=edit Bug 18928: Remove '(not set)' The "(not set)" part must be removed IMO, I am not sure I

[Koha-bugs] [Bug 18928] Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules

2019-05-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 --- Comment #74 from Kyle M Hall --- Created attachment 89437 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89437=edit Bug 18928: (bug 22847 follow-up) Display correctly the values (not the propagated ones)

[Koha-bugs] [Bug 18928] Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules

2019-05-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 --- Comment #69 from Kyle M Hall --- Created attachment 89432 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89432=edit Bug 18928: (follow-up) Make DB update idempotent Signed-off-by: Tomas Cohen Arazi

[Koha-bugs] [Bug 18928] Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules

2019-05-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 Kyle M Hall changed: What|Removed |Added Attachment #89339|0 |1 is obsolete|

[Koha-bugs] [Bug 18928] Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules

2019-05-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 Agustín Moyano changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are

[Koha-bugs] [Bug 18928] Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules

2019-05-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 Agustín Moyano changed: What|Removed |Added Attachment #89377|0 |1 is obsolete|

[Koha-bugs] [Bug 18928] Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules

2019-05-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 --- Comment #62 from Agustín Moyano --- (In reply to Jonathan Druart from comment #61) > Created attachment 89377 [details] [review] > Bug 18928: Remove '(not set)' > > The "(not set)" part must be removed IMO, I am not sure I

[Koha-bugs] [Bug 18928] Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules

2019-05-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 Jonathan Druart changed: What|Removed |Added Status|BLOCKED |Needs Signoff -- You

[Koha-bugs] [Bug 18928] Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules

2019-05-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 --- Comment #61 from Jonathan Druart --- Created attachment 89377 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89377=edit Bug 18928: Remove '(not set)' The "(not set)" part must be removed IMO, I am not sure I

[Koha-bugs] [Bug 18928] Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules

2019-05-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 Jonathan Druart changed: What|Removed |Added Attachment #89349|0 |1 is obsolete|

[Koha-bugs] [Bug 18928] Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules

2019-05-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 --- Comment #60 from Jonathan Druart --- So, if we agree that bug 22847 is valid, last patch must be obsoleted. However the "(not set)" part must be removed IMO, I am not sure I understand its goal. Now that we have 1 entry per

[Koha-bugs] [Bug 18928] Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules

2019-05-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 Jonathan Druart changed: What|Removed |Added Depends on||22847 Referenced Bugs:

[Koha-bugs] [Bug 18928] Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules

2019-05-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 --- Comment #59 from Jonathan Druart --- (In reply to Jonathan Druart from comment #58) > I opened bug 22847 to deal with this behavior, and I thought it was a bug. I > am not sure what we expect actually. I am going to mark this

[Koha-bugs] [Bug 18928] Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules

2019-05-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 Jonathan Druart changed: What|Removed |Added Status|Signed Off |BLOCKED --- Comment #58

[Koha-bugs] [Bug 18928] Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules

2019-05-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 --- Comment #57 from Agustín Moyano --- (In reply to Agustín Moyano from comment #56) > (In reply to Jonathan Druart from comment #55) > > (In reply to Agustín Moyano from comment #54) > > > Created attachment 89349 [details]

[Koha-bugs] [Bug 18928] Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules

2019-05-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 --- Comment #56 from Agustín Moyano --- (In reply to Jonathan Druart from comment #55) > (In reply to Agustín Moyano from comment #54) > > Created attachment 89349 [details] [review] [review] > > Hola Agustín, are you sure this

[Koha-bugs] [Bug 18928] Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules

2019-05-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 Agustín Moyano changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are

[Koha-bugs] [Bug 18928] Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules

2019-05-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 --- Comment #55 from Jonathan Druart --- (In reply to Agustín Moyano from comment #54) > Created attachment 89349 [details] [review] Hola Agustín, are you sure this patch is still needed after the 2 follow-ups I attached

[Koha-bugs] [Bug 18928] Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules

2019-05-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 --- Comment #50 from Agustín Moyano --- Created attachment 89345 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89345=edit Bug 18928: DBIC schema update Signed-off-by: Agustin Moyano -- You are receiving this

[Koha-bugs] [Bug 18928] Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules

2019-05-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 --- Comment #51 from Agustín Moyano --- Created attachment 89346 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89346=edit Bug 18928: Use get_effective_rule in GetBranchItemRule Signed-off-by: Agustin Moyano --

[Koha-bugs] [Bug 18928] Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules

2019-05-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 --- Comment #52 from Agustín Moyano --- Created attachment 89347 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89347=edit Bug 18928: (bug 22679 follow-up) Do not remove all rules along with the issuing rule We

[Koha-bugs] [Bug 18928] Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules

2019-05-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 --- Comment #54 from Agustín Moyano --- Created attachment 89349 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89349=edit Bug 18928: Add Branches.HasCirculationRules and set branchcode in CirculationRules.Search

[Koha-bugs] [Bug 18928] Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules

2019-05-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 --- Comment #53 from Agustín Moyano --- Created attachment 89348 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89348=edit Bug 18928: (bug 22847 follow-up) Display correctly the values (not the propagated ones)

[Koha-bugs] [Bug 18928] Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules

2019-05-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 --- Comment #49 from Agustín Moyano --- Created attachment 89344 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89344=edit Bug 18928: (follow-up) Unset max_holds rule if needed Test plan: 1) Set all values in

[Koha-bugs] [Bug 18928] Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules

2019-05-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 --- Comment #48 from Agustín Moyano --- Created attachment 89343 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89343=edit Bug 18928: (follow-up) Make DB update idempotent Signed-off-by: Tomas Cohen Arazi

[Koha-bugs] [Bug 18928] Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules

2019-05-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 --- Comment #47 from Agustín Moyano --- Created attachment 89342 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89342=edit Bug 18928: Update new occurrences Signed-off-by: Tomas Cohen Arazi Signed-off-by:

[Koha-bugs] [Bug 18928] Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules

2019-05-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 --- Comment #44 from Agustín Moyano --- Created attachment 89339 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89339=edit Bug 18928: Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules

[Koha-bugs] [Bug 18928] Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules

2019-05-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 --- Comment #46 from Agustín Moyano --- Created attachment 89341 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89341=edit Bug 18928: Add missing filters Signed-off-by: Tomas Cohen Arazi Signed-off-by: Agustin

[Koha-bugs] [Bug 18928] Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules

2019-05-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 --- Comment #45 from Agustín Moyano --- Created attachment 89340 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89340=edit Bug 18928: Add DB structure changes Signed-off-by: Tomas Cohen Arazi Signed-off-by:

[Koha-bugs] [Bug 18928] Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules

2019-05-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 Agustín Moyano changed: What|Removed |Added Attachment #89022|0 |1 is obsolete|

[Koha-bugs] [Bug 18928] Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules

2019-05-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 Agustín Moyano changed: What|Removed |Added Attachment #89020|0 |1 is obsolete|

[Koha-bugs] [Bug 18928] Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules

2019-05-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 Agustín Moyano changed: What|Removed |Added Attachment #89023|0 |1 is obsolete|

[Koha-bugs] [Bug 18928] Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules

2019-05-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 Agustín Moyano changed: What|Removed |Added Attachment #89021|0 |1 is obsolete|

[Koha-bugs] [Bug 18928] Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules

2019-05-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 Agustín Moyano changed: What|Removed |Added Attachment #89019|0 |1 is obsolete|

[Koha-bugs] [Bug 18928] Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules

2019-05-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 Agustín Moyano changed: What|Removed |Added Attachment #89017|0 |1 is obsolete|

[Koha-bugs] [Bug 18928] Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules

2019-05-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 Agustín Moyano changed: What|Removed |Added Attachment #89336|0 |1 is obsolete|

[Koha-bugs] [Bug 18928] Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules

2019-05-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 Agustín Moyano changed: What|Removed |Added Attachment #89338|0 |1 is obsolete|

[Koha-bugs] [Bug 18928] Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules

2019-05-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 Agustín Moyano changed: What|Removed |Added Attachment #89018|0 |1 is obsolete|

  1   2   >