https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930
Martin Renvoize changed:
What|Removed |Added
CC||martin.renvoize@ptfs-europ
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930
Fridolin SOMERS changed:
What|Removed |Added
Resolution|--- |FIXED
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930
Bug 18930 depends on bug 18928, which changed state.
Bug 18928 Summary: Move holdallowed, hold_fulfillment_policy, returnbranch to
circulation_rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928
What
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930
Martin Renvoize changed:
What|Removed |Added
Blocks||23323
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930
Martin Renvoize changed:
What|Removed |Added
Version(s)||19.11.00
released
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930
--- Comment #51 from Martin Renvoize ---
Nice work!
Pushed to master for 19.11.00
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koh
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930
Josef Moravec changed:
What|Removed |Added
Attachment #90548|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930
--- Comment #50 from Josef Moravec ---
Created attachment 91260
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91260&action=edit
Bug 18930: (QA follow-up) Remove debug code
Signed-off-by: Josef Moravec
--
You a
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930
Josef Moravec changed:
What|Removed |Added
QA Contact|testo...@bugs.koha-communit |josef.mora...@gmail.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930
Josef Moravec changed:
What|Removed |Added
Attachment #90545|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930
Josef Moravec changed:
What|Removed |Added
Attachment #90549|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930
Josef Moravec changed:
What|Removed |Added
Attachment #90547|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930
Josef Moravec changed:
What|Removed |Added
Attachment #90544|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930
Josef Moravec changed:
What|Removed |Added
Attachment #90546|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930
Agustín Moyano changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--
You are rec
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930
--- Comment #43 from Agustín Moyano ---
Created attachment 90549
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90549&action=edit
Bug 18930: (follow-up) Change variable used in refund select for default
options
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930
--- Comment #42 from Agustín Moyano ---
Created attachment 90548
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90548&action=edit
Bug 18930: (follow-up) Amend search parameter in
Koha::RefundLostItemFeeRules->_defa
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930
--- Comment #41 from Agustín Moyano ---
Created attachment 90547
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90547&action=edit
Bug 18930: (follow-up) Amend Koha::RefundLostItemFeeRules->find
--
You are receivi
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930
--- Comment #39 from Agustín Moyano ---
Created attachment 90545
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90545&action=edit
Bug 18930: Do not insert '*' in circulation_rules
We must insert NULL instead, othe
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930
--- Comment #40 from Agustín Moyano ---
Created attachment 90546
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90546&action=edit
Bug 18930: (follow-up) Make DB update idempotent
Signed-off-by: Tomas Cohen Arazi
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930
--- Comment #38 from Agustín Moyano ---
Created attachment 90544
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90544&action=edit
Bug 18930: Move lost item refund rules to circulation_rules table
This patch will m
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930
Agustín Moyano changed:
What|Removed |Added
Attachment #86169|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930
Agustín Moyano changed:
What|Removed |Added
Attachment #86170|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930
Agustín Moyano changed:
What|Removed |Added
Attachment #86171|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930
Agustín Moyano changed:
What|Removed |Added
Attachment #90542|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930
Agustín Moyano changed:
What|Removed |Added
Attachment #90543|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930
Agustín Moyano changed:
What|Removed |Added
Attachment #90541|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930
--- Comment #37 from Agustín Moyano ---
(In reply to Jonathan Druart from comment #33)
> Agustín, can you provide tests for the changes you made please?
Hi Jonathan, I just provided tests for find function.
Thanks.
--
You are rec
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930
--- Comment #34 from Agustín Moyano ---
Created attachment 90541
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90541&action=edit
Bug 18930: (follow-up) Amend Koha::RefundLostItemFeeRules->find
--
You are receivi
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930
--- Comment #35 from Agustín Moyano ---
Created attachment 90542
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90542&action=edit
Bug 18930: (follow-up) Amend search parameter in
Koha::RefundLostItemFeeRules->_defa
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930
--- Comment #36 from Agustín Moyano ---
Created attachment 90543
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90543&action=edit
Bug 18930: (follow-up) Change variable used in refund select for default
options
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930
Agustín Moyano changed:
What|Removed |Added
Attachment #90283|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930
Agustín Moyano changed:
What|Removed |Added
Attachment #90284|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930
Agustín Moyano changed:
What|Removed |Added
Attachment #90285|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930
--- Comment #33 from Jonathan Druart
---
Agustín, can you provide tests for the changes you made please?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koh
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930
--- Comment #32 from Jonathan Druart
---
Augustin, can you provide tests for the changes you made please?
--
You are receiving this mail because:
You are watching all bug changes.
___
Ko
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930
--- Comment #31 from Agustín Moyano ---
(In reply to Jonathan Druart from comment #24)
> Comment on attachment 89404 [details] [review]
> Bug 18930: (follow-up) Amend Koha::RefundLostItemFeeRules->find parameters
> in smart-rules.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930
--- Comment #30 from Agustín Moyano ---
Created attachment 90285
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90285&action=edit
Bug 18930: (follow-up) Change variable used in refund select for default
options
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930
--- Comment #28 from Agustín Moyano ---
Created attachment 90283
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90283&action=edit
Bug 18930: (follow-up) Amend Koha::RefundLostItemFeeRules->find
--
You are receivi
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930
--- Comment #29 from Agustín Moyano ---
Created attachment 90284
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90284&action=edit
Bug 18930: (follow-up) Amend search parameter in
Koha::RefundLostItemFeeRules->_defa
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930
Agustín Moyano changed:
What|Removed |Added
Attachment #90282|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930
Agustín Moyano changed:
What|Removed |Added
Attachment #90281|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930
Agustín Moyano changed:
What|Removed |Added
Attachment #90280|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930
--- Comment #27 from Agustín Moyano ---
Created attachment 90282
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90282&action=edit
Bug 18930: (follow-up) Change variable used in refund select for default
options
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930
Agustín Moyano changed:
What|Removed |Added
Attachment #89406|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930
--- Comment #25 from Agustín Moyano ---
Created attachment 90280
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90280&action=edit
Bug 18930: (follow-up) Amend Koha::RefundLostItemFeeRules->find
--
You are receivi
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930
--- Comment #26 from Agustín Moyano ---
Created attachment 90281
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90281&action=edit
Bug 18930: (follow-up) Amend search parameter in
Koha::RefundLostItemFeeRules->_defa
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930
Agustín Moyano changed:
What|Removed |Added
Attachment #89404|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930
Agustín Moyano changed:
What|Removed |Added
Attachment #89405|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930
--- Comment #24 from Jonathan Druart
---
Comment on attachment 89404
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89404
Bug 18930: (follow-up) Amend Koha::RefundLostItemFeeRules->find parameters in
smart-rules.p
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930
Jonathan Druart changed:
What|Removed |Added
See Also||https://bugs.koha-communit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930
Victor Grousset/tuxayo changed:
What|Removed |Added
CC||victor.grous...@bib
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930
Agustín Moyano changed:
What|Removed |Added
Status|Signed Off |Needs Signoff
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930
--- Comment #21 from Agustín Moyano ---
(In reply to Agustín Moyano from comment #18)
> Created attachment 89406 [details] [review]
> Bug 18930: (follow-up) Change variable used in refund select for default
> options
This change was
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930
--- Comment #20 from Agustín Moyano ---
(In reply to Agustín Moyano from comment #17)
> Created attachment 89405 [details] [review]
> Bug 18930: (follow-up) Amend search parameter in
> Koha::RefundLostItemFeeRules->_default_rule
Thi
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930
Agustín Moyano changed:
What|Removed |Added
CC||agustinmoy...@theke.io
---
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930
--- Comment #17 from Agustín Moyano ---
Created attachment 89405
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89405&action=edit
Bug 18930: (follow-up) Amend search parameter in
Koha::RefundLostItemFeeRules->_defa
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930
--- Comment #18 from Agustín Moyano ---
Created attachment 89406
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89406&action=edit
Bug 18930: (follow-up) Change variable used in refund select for default
options
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930
--- Comment #16 from Agustín Moyano ---
Created attachment 89404
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89404&action=edit
Bug 18930: (follow-up) Amend Koha::RefundLostItemFeeRules->find parameters in
smart-
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930
Agustín Moyano changed:
What|Removed |Added
Blocks||22284
Referenced Bugs:
h
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930
--- Comment #13 from Tomás Cohen Arazi ---
Created attachment 86169
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86169&action=edit
Bug 18930: Move lost item refund rules to circulation_rules table
This patch wil
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930
--- Comment #14 from Tomás Cohen Arazi ---
Created attachment 86170
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86170&action=edit
Bug 18930: Do not insert '*' in circulation_rules
We must insert NULL instead, o
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930
--- Comment #15 from Tomás Cohen Arazi ---
Created attachment 86171
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86171&action=edit
Bug 18930: (follow-up) Make DB update idempotent
Signed-off-by: Tomas Cohen Araz
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930
Tomás Cohen Arazi changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
Patch comp
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930
Tomás Cohen Arazi changed:
What|Removed |Added
CC||tomasco...@gmail.com
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #85493|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #85492|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930
Jonathan Druart changed:
What|Removed |Added
Attachment #82938|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930
Jonathan Druart changed:
What|Removed |Added
Attachment #82937|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930
--- Comment #10 from Jonathan Druart
---
Created attachment 82938
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82938&action=edit
Bug 18930: Do not insert '*' in circulation_rules
We must insert NULL instead, ot
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930
Jonathan Druart changed:
What|Removed |Added
Attachment #81101|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930
--- Comment #8 from Jonathan Druart
---
Created attachment 81148
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81148&action=edit
Bug 18930: Do not insert '*' in circulation_rules
We must insert NULL instead, oth
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930
Jonathan Druart changed:
What|Removed |Added
Status|Failed QA |Needs Signoff
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930
Alex Buckley changed:
What|Removed |Added
Status|Needs Signoff |Failed QA
--- Comment #7 fro
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930
Jonathan Druart changed:
What|Removed |Added
Status|BLOCKED |Needs Signoff
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930
Jonathan Druart changed:
What|Removed |Added
Attachment #71007|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930
Jonathan Druart changed:
What|Removed |Added
Assignee|koha-b...@lists.koha-commun |jonathan.dru...@bugs.koha-
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930
Jonathan Druart changed:
What|Removed |Added
CC||jonathan.dru...@bugs.koha-
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930
Katrin Fischer changed:
What|Removed |Added
CC||katrin.fisc...@bsz-bw.de
-
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930
Jesse Weaver changed:
What|Removed |Added
Attachment #65243|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930
--- Comment #3 from Alex Buckley ---
Actually one of the dependencies further down the stream (this patch depends on
18928, and that in turn depends on 18925, and that in turn depends on 18887) of
this patch is bug 18887 and when app
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930
Alex Buckley changed:
What|Removed |Added
CC||alexbuck...@catalyst.net.nz
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930
--- Comment #1 from Kyle M Hall ---
Created attachment 65243
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65243&action=edit
Bug 18930 - Move lost item refund rules to circulation_rules table
This patch will move
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930
Kyle M Hall changed:
What|Removed |Added
Status|NEW |Needs Signoff
--
You are rec
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930
Kyle M Hall changed:
What|Removed |Added
Blocks||18936
Referenced Bugs:
http
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930
Kyle M Hall changed:
What|Removed |Added
Depends on||18928
Referenced Bugs:
http
86 matches
Mail list logo