[Koha-bugs] [Bug 19234] Add query parameters handling helpers

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19234 Bug 19234 depends on bug 19196, which changed state. Bug 19196 Summary: Add pagination helpers https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19196 What|Removed |Added

[Koha-bugs] [Bug 19234] Add query parameters handling helpers

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19234 Nick Clemens changed: What|Removed |Added Status|Pushed to Master

[Koha-bugs] [Bug 19234] Add query parameters handling helpers

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19234 Jonathan Druart changed: What|Removed |Added Status|Passed QA

[Koha-bugs] [Bug 19234] Add query parameters handling helpers

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19234 --- Comment #31 from Kyle M Hall --- Created attachment 69362 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69362=edit Bug 19234: (followup) Make Query plugin available to endpoints

[Koha-bugs] [Bug 19234] Add query parameters handling helpers

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19234 --- Comment #30 from Kyle M Hall --- Created attachment 69361 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69361=edit Bug 19234: Add query parameters handling helpers This patch

[Koha-bugs] [Bug 19234] Add query parameters handling helpers

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19234 Kyle M Hall changed: What|Removed |Added Attachment #67785|0 |1

[Koha-bugs] [Bug 19234] Add query parameters handling helpers

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19234 Kyle M Hall changed: What|Removed |Added Status|Signed Off

[Koha-bugs] [Bug 19234] Add query parameters handling helpers

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19234 Jonathan Druart changed: What|Removed |Added

[Koha-bugs] [Bug 19234] Add query parameters handling helpers

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19234 --- Comment #28 from Tomás Cohen Arazi --- (In reply to Julian Maurice from comment #27) > Maybe I'm missing the big picture here, but I don't understand why this > plugin is needed. > All it does is separate

[Koha-bugs] [Bug 19234] Add query parameters handling helpers

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19234 Julian Maurice changed: What|Removed |Added CC|

[Koha-bugs] [Bug 19234] Add query parameters handling helpers

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19234 Jonathan Druart changed: What|Removed |Added Keywords|

[Koha-bugs] [Bug 19234] Add query parameters handling helpers

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19234 Lari Taskula changed: What|Removed |Added Attachment #67377|0 |1

[Koha-bugs] [Bug 19234] Add query parameters handling helpers

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19234 Lari Taskula changed: What|Removed |Added Attachment #67375|0 |1

[Koha-bugs] [Bug 19234] Add query parameters handling helpers

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19234 Lari Taskula changed: What|Removed |Added Attachment #67374|0 |1

[Koha-bugs] [Bug 19234] Add query parameters handling helpers

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19234 Tomás Cohen Arazi changed: What|Removed |Added Blocks|

[Koha-bugs] [Bug 19234] Add query parameters handling helpers

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19234 --- Comment #23 from Kyle M Hall --- Created attachment 67377 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67377=edit Bug 19234: (followup) Make Query plugin available to endpoints

[Koha-bugs] [Bug 19234] Add query parameters handling helpers

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19234 Kyle M Hall changed: What|Removed |Added Attachment #67363|0 |1

[Koha-bugs] [Bug 19234] Add query parameters handling helpers

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19234 --- Comment #22 from Kyle M Hall --- Created attachment 67375 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67375=edit Bug 19234: Add query parameters handling helpers This patch

[Koha-bugs] [Bug 19234] Add query parameters handling helpers

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19234 Kyle M Hall changed: What|Removed |Added Status|Needs Signoff

[Koha-bugs] [Bug 19234] Add query parameters handling helpers

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19234 Tomás Cohen Arazi changed: What|Removed |Added Blocks|

[Koha-bugs] [Bug 19234] Add query parameters handling helpers

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19234 Tomás Cohen Arazi changed: What|Removed |Added Blocks|

[Koha-bugs] [Bug 19234] Add query parameters handling helpers

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19234 Tomás Cohen Arazi changed: What|Removed |Added Attachment #67360|0 |1

[Koha-bugs] [Bug 19234] Add query parameters handling helpers

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19234 Tomás Cohen Arazi changed: What|Removed |Added Attachment #67359|0 |1

[Koha-bugs] [Bug 19234] Add query parameters handling helpers

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19234 Tomás Cohen Arazi changed: What|Removed |Added Attachment #67358|0 |1

[Koha-bugs] [Bug 19234] Add query parameters handling helpers

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19234 --- Comment #17 from Tomás Cohen Arazi --- Kyle, Martin, I have simplified this plugin, making it only extract reserved params from the query, and providing a 'cleaned up' attributes hash. The commit message

[Koha-bugs] [Bug 19234] Add query parameters handling helpers

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19234 Tomás Cohen Arazi changed: What|Removed |Added Patch complexity|---

[Koha-bugs] [Bug 19234] Add query parameters handling helpers

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19234 Tomás Cohen Arazi changed: What|Removed |Added Attachment #66993|0 |1

[Koha-bugs] [Bug 19234] Add query parameters handling helpers

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19234 Tomás Cohen Arazi changed: What|Removed |Added Attachment #66991|0 |1

[Koha-bugs] [Bug 19234] Add query parameters handling helpers

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19234 Tomás Cohen Arazi changed: What|Removed |Added Attachment #66992|0 |1

[Koha-bugs] [Bug 19234] Add query parameters handling helpers

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19234 --- Comment #13 from Tomás Cohen Arazi --- (In reply to Martin Renvoize from comment #8) > This somehow feels like a step too far in trying to generalise a mapping > between api query parameters and database

[Koha-bugs] [Bug 19234] Add query parameters handling helpers

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19234 --- Comment #12 from Tomás Cohen Arazi --- (In reply to Martin Renvoize from comment #7) > Comment on attachment 66991 [details] [review] > Bug 19234: Unit tests for query parameters handling helpers > >

[Koha-bugs] [Bug 19234] Add query parameters handling helpers

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19234 Tomás Cohen Arazi changed: What|Removed |Added Status|Signed Off

[Koha-bugs] [Bug 19234] Add query parameters handling helpers

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19234 --- Comment #10 from Martin Renvoize --- Comment on attachment 66992 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66992 Bug 19234: Add query parameters handling helpers Review

[Koha-bugs] [Bug 19234] Add query parameters handling helpers

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19234 --- Comment #9 from Martin Renvoize --- OR.. perhaps you need some sort of object (be that Koha:: or Schema::Result) introspection to match up fields to query parameters in there? -- You are

[Koha-bugs] [Bug 19234] Add query parameters handling helpers

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19234 Martin Renvoize changed: What|Removed |Added CC|

[Koha-bugs] [Bug 19234] Add query parameters handling helpers

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19234 --- Comment #7 from Martin Renvoize --- Comment on attachment 66991 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66991 Bug 19234: Unit tests for query parameters handling helpers

[Koha-bugs] [Bug 19234] Add query parameters handling helpers

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19234 Tomás Cohen Arazi changed: What|Removed |Added Component|Architecture, internals,

[Koha-bugs] [Bug 19234] Add query parameters handling helpers

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19234 --- Comment #6 from Kyle M Hall --- Created attachment 66993 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66993=edit Bug 19234: (followup) Make Query plugin available to endpoints

[Koha-bugs] [Bug 19234] Add query parameters handling helpers

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19234 --- Comment #5 from Kyle M Hall --- Created attachment 66992 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66992=edit Bug 19234: Add query parameters handling helpers This patch

[Koha-bugs] [Bug 19234] Add query parameters handling helpers

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19234 Kyle M Hall changed: What|Removed |Added Attachment #66752|0 |1

[Koha-bugs] [Bug 19234] Add query parameters handling helpers

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19234 Kyle M Hall changed: What|Removed |Added Status|Needs Signoff

[Koha-bugs] [Bug 19234] Add query parameters handling helpers

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19234 Kyle M Hall changed: What|Removed |Added Depends on|18137 |

[Koha-bugs] [Bug 19234] Add query parameters handling helpers

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19234 Kyle M Hall changed: What|Removed |Added Depends on|

[Koha-bugs] [Bug 19234] Add query parameters handling helpers

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19234 Tomás Cohen Arazi changed: What|Removed |Added Blocks|

[Koha-bugs] [Bug 19234] Add query parameters handling helpers

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19234 --- Comment #2 from Tomás Cohen Arazi --- Created attachment 66753 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66753=edit Bug 19234: Add query parameters handling helpers This patch

[Koha-bugs] [Bug 19234] Add query parameters handling helpers

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19234 Tomás Cohen Arazi changed: What|Removed |Added Status|NEW

[Koha-bugs] [Bug 19234] Add query parameters handling helpers

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19234 --- Comment #3 from Tomás Cohen Arazi --- Created attachment 66754 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66754=edit Bug 19234: (followup) Make Query plugin available to endpoints --

[Koha-bugs] [Bug 19234] Add query parameters handling helpers

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19234 --- Comment #1 from Tomás Cohen Arazi --- Created attachment 66752 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66752=edit Bug 19234: Unit tests for query parameters handling helpers This

[Koha-bugs] [Bug 19234] Add query parameters handling helpers

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19234 Tomás Cohen Arazi changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun