https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
Aleisha Amohia changed:
What|Removed |Added
Keywords||rel_22_05_candidate
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
--- Comment #889 from Aleisha Amohia ---
Today is Pass QA Day! What do I need to do to satisfy the QA team?
--
You are receiving this mail because:
You are watching all bug changes.
___
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
--- Comment #888 from Marcel de Rooy ---
Final comment for now.
Aleisha has done a really amazing job in keeping this development alive from
2017 onwards. It is a very brave effort on itself to insert this feature into
Koha's
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
--- Comment #887 from Marcel de Rooy ---
Still posting two observations from a functional view without any need to
address them here btw.
Functionally, it is a bit confusing that the recall overdue fine amount is so
close in the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
--- Comment #886 from Aleisha Amohia ---
Thanks Marcel, I appreciate you helping me get this over the line. If there are
bits I can look at, let me know, I have a bit of capacity at the moment.
Pass QA on Friday 11 sounds like a
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
--- Comment #885 from Marcel de Rooy ---
I hope to finish up tomorrow which actually does not mean that I could QA this
huge patch set just on my own [impossible; see earlier comments], but I have
spent a considerable amount of time
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
--- Comment #884 from Marcel de Rooy ---
Created attachment 131330
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131330=edit
Bug 19532: (QA follow-up) Add the cron jobs to the cron files
Signed-off-by: Marcel de
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
--- Comment #883 from Aleisha Amohia ---
It's looking good Marcel! Thanks for your help.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
Marcel de Rooy changed:
What|Removed |Added
Attachment #130643|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
Marcel de Rooy changed:
What|Removed |Added
Attachment #130642|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
--- Comment #882 from Marcel de Rooy ---
Aleisha: Note that I added an extra patch in the beginning too to extract DBIx
stuff out of a regular patch.
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
Marcel de Rooy changed:
What|Removed |Added
Attachment #131260|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
Marcel de Rooy changed:
What|Removed |Added
Attachment #131257|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
Marcel de Rooy changed:
What|Removed |Added
Attachment #131193|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
Marcel de Rooy changed:
What|Removed |Added
Attachment #131160|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
Marcel de Rooy changed:
What|Removed |Added
Attachment #131159|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
Marcel de Rooy changed:
What|Removed |Added
Attachment #131158|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
Marcel de Rooy changed:
What|Removed |Added
Attachment #131157|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
Marcel de Rooy changed:
What|Removed |Added
Attachment #131156|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
Marcel de Rooy changed:
What|Removed |Added
Attachment #130653|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
Marcel de Rooy changed:
What|Removed |Added
Attachment #130652|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
Marcel de Rooy changed:
What|Removed |Added
Attachment #130651|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
Marcel de Rooy changed:
What|Removed |Added
Attachment #130650|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
Marcel de Rooy changed:
What|Removed |Added
Attachment #130649|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
Marcel de Rooy changed:
What|Removed |Added
Attachment #130648|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
Marcel de Rooy changed:
What|Removed |Added
Attachment #130647|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
Marcel de Rooy changed:
What|Removed |Added
Attachment #130646|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
Marcel de Rooy changed:
What|Removed |Added
Attachment #130645|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
Marcel de Rooy changed:
What|Removed |Added
Attachment #130644|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
--- Comment #863 from Marcel de Rooy ---
Created attachment 131264
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131264=edit
Bug 19532: [DBIx] Schema change for Recalls
Separated from the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
--- Comment #862 from Marcel de Rooy ---
Created attachment 131263
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131263=edit
Bug 19532: [DBIx] Add boolean flags to recalls.old and
recalls.item_level_recall
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
--- Comment #861 from Marcel de Rooy ---
Created attachment 131262
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131262=edit
Bug 19532: [DBIx] Updated schema files
Signed-off-by: David Nind
Signed-off-by:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
Marcel de Rooy changed:
What|Removed |Added
Attachment #130641|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
--- Comment #859 from Marcel de Rooy ---
Created attachment 131260
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131260=edit
Bug 19532: (QA follow-up) Move as_list to iterator based loop
Adjusting both new cron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
--- Comment #858 from Marcel de Rooy ---
TODO We need to add two new cronjobs to the cron files (debian side and example
file somewhere in etc folder)
misc/cronjobs/recalls/expire_recalls.pl
misc/cronjobs/recalls/overdue_recalls.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
--- Comment #857 from Marcel de Rooy ---
(In reply to Marcel de Rooy from comment #856)
> Created attachment 131257 [details] [review]
> Bug 19532: (QA follow-up) Fix fine calculation by inserting biblionumber
>
> The fines cron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
--- Comment #856 from Marcel de Rooy ---
Created attachment 131257
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131257=edit
Bug 19532: (QA follow-up) Fix fine calculation by inserting biblionumber
The fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
--- Comment #855 from Marcel de Rooy ---
I remember to have posted this before, but these lines show me that Recalls
does not support itemtype notforloan:
+ return 0 if ( $self->notforloan != 0 );
OR +my @items =
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
--- Comment #854 from Marcel de Rooy ---
Same remark for:
FAIL C4/Overdues.pm
FAIL pod coverage
POD is missing for 'GetWdayFromItemnumber'
and
FAIL C4/XSLT.pm
FAIL pod coverage
POD
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
--- Comment #853 from Marcel de Rooy ---
FAIL C4/Circulation.pm
FAIL pod coverage
POD is missing for AddOfflineOperation
POD is missing for CheckValidBarcode
POD is missing for
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
--- Comment #852 from Marcel de Rooy ---
(In reply to Marcel de Rooy from comment #851)
> In conclusion: We dont wanna die here, but as for ReturnClaims we could send
> a code to the template allowing to return something meaningful
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
Marcel de Rooy changed:
What|Removed |Added
Attachment #131213|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
--- Comment #851 from Marcel de Rooy ---
(In reply to Aleisha Amohia from comment #850)
> Not unfinished business, I was just copying the similar code above, but I
> have removed in latest follow-up.
Are you really really sure
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
--- Comment #850 from Aleisha Amohia ---
Cool I will ignore that warning about KohaPlugins then.
(In reply to Marcel de Rooy from comment #848)
> From code glancing:
> Unfinished business?
>
> +} elsif ( $code eq
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
--- Comment #849 from Aleisha Amohia ---
Created attachment 131213
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131213=edit
Bug 19532: (follow-up) Removing unnecessary code
--
You are receiving this mail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
--- Comment #848 from Marcel de Rooy ---
From code glancing:
Unfinished business?
+} elsif ( $code eq 'RecallFound' ) {
+;
+} elsif ( $code eq 'RecallNeedsTransfer' ) {
+;
+} elsif ( $code eq
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
--- Comment #847 from Marcel de Rooy ---
Saw this warning in QA tools:
FAIL koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-recalls.tt
FAIL valid_template
Attempt to reload Koha/Template/Plugin/KohaPlugins.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
--- Comment #846 from Marcel de Rooy ---
Created attachment 131193
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131193=edit
Bug 19532: (QA follow-up) Fix few Koha::Recalls->search occurrences
Due to the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
--- Comment #845 from Marcel de Rooy ---
(In reply to Aleisha Amohia from comment #844)
> (In reply to Marcel de Rooy from comment #835)
> > Still applied on current master (more or less: minor conflicts)
> > commit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
--- Comment #844 from Aleisha Amohia ---
(In reply to Marcel de Rooy from comment #835)
> Still applied on current master (more or less: minor conflicts)
> commit 4cc3c0a760df4ddd96cd7bdadc4a766343f0a103
>
> Will be spending some
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
--- Comment #843 from Aleisha Amohia ---
Created attachment 131160
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131160=edit
Bug 19532: (follow-up) Fix for wantarray change and title-string
--
You are receiving
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
Aleisha Amohia changed:
What|Removed |Added
Attachment #131108|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
Aleisha Amohia changed:
What|Removed |Added
Attachment #130656|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
Aleisha Amohia changed:
What|Removed |Added
Attachment #130655|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
Aleisha Amohia changed:
What|Removed |Added
Attachment #130654|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
--- Comment #838 from Marcel de Rooy ---
Created attachment 131108
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131108=edit
Bug 19532: (QA follow-up) Fixing unit tests
(Trivial:) Number of tests in Koha/Item.t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
--- Comment #837 from Marcel de Rooy ---
QA tools is quite happy, here are two items:
TODO koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-recalls.tt
* forbidden pattern: Don't use the title-string class for sorting (bug 27934)
(line
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
--- Comment #836 from Marcel de Rooy ---
Some intermediate observations. Will continue next week.
TODO FAIL t/db_dependent/Circulation/CalcFine.t
* The method Koha::Recalls->item_level_recall is not covered by tests!
=> Error in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
--- Comment #835 from Marcel de Rooy ---
Still applied on current master (more or less: minor conflicts)
commit 4cc3c0a760df4ddd96cd7bdadc4a766343f0a103
Will be spending some time on it now and next week, and hoping that the other
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
--- Comment #834 from Aleisha Amohia ---
Created attachment 130656
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130656=edit
Bug 19532: (follow-up) Fixes along recall workflow
--
You are receiving this mail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
Aleisha Amohia changed:
What|Removed |Added
Attachment #129319|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
Aleisha Amohia changed:
What|Removed |Added
Attachment #129318|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
Aleisha Amohia changed:
What|Removed |Added
Attachment #129317|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
Aleisha Amohia changed:
What|Removed |Added
Attachment #129316|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
Aleisha Amohia changed:
What|Removed |Added
Attachment #129315|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
Aleisha Amohia changed:
What|Removed |Added
Attachment #129314|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
Aleisha Amohia changed:
What|Removed |Added
Attachment #129313|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
Aleisha Amohia changed:
What|Removed |Added
Attachment #129312|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
Aleisha Amohia changed:
What|Removed |Added
Attachment #129311|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
Aleisha Amohia changed:
What|Removed |Added
Attachment #129310|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
Aleisha Amohia changed:
What|Removed |Added
Attachment #129309|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
Aleisha Amohia changed:
What|Removed |Added
Attachment #129308|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
Aleisha Amohia changed:
What|Removed |Added
Attachment #129307|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
Aleisha Amohia changed:
What|Removed |Added
Attachment #129306|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
Aleisha Amohia changed:
What|Removed |Added
Attachment #129305|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
Aleisha Amohia changed:
What|Removed |Added
Status|ASSIGNED|Needs Signoff
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
Eric Phetteplace changed:
What|Removed |Added
CC||ephettepl...@cca.edu
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
--- Comment #818 from Katrin Fischer ---
I understand the difficulties of splitting it up now, so totally ok working
with the rebased patch set. Thx Marcel and Aleisha for clearing things up!
--
You are receiving this mail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
--- Comment #817 from Marcel de Rooy ---
(In reply to Aleisha Amohia from comment #816)
> I see. In the email chain we had discussed reformatting but clearly there
> was some misunderstanding.
>
> I had started rewriting things
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
--- Comment #816 from Aleisha Amohia ---
I see. In the email chain we had discussed reformatting but clearly there was
some misunderstanding.
I had started rewriting things before Christmas but it was proving to be very
difficult
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
--- Comment #815 from Marcel de Rooy ---
(In reply to Aleisha Amohia from comment #814)
> I am talking about the current patchset. My understanding was that as the
> patches currently are, they are too big and daunting to
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
--- Comment #814 from Aleisha Amohia ---
I am talking about the current patchset. My understanding was that as the
patches currently are, they are too big and daunting to effectively test and
QA.
--
You are receiving this mail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
--- Comment #813 from Marcel de Rooy ---
(In reply to Aleisha Amohia from comment #812)
> I started rewriting before Christmas but couldn't get it sorted in time.
> Will try to pick up again this week or next. Trying to work out the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
--- Comment #812 from Aleisha Amohia ---
I started rewriting before Christmas but couldn't get it sorted in time. Will
try to pick up again this week or next. Trying to work out the best way to
split everything out.
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
--- Comment #811 from Fridolin Somers ---
Sure, I'm in.
At first look code looks pretty mature.
I'll listen to QA team.
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
--- Comment #810 from Marcel de Rooy ---
(In reply to Katrin Fischer from comment #809)
> (In reply to Marcel de Rooy from comment #808)
> > I rebased what we had. Didnt check yet.
> >
> > Katrin, Fridolin, Aleisha, David, Victor:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
--- Comment #809 from Katrin Fischer ---
(In reply to Marcel de Rooy from comment #808)
> I rebased what we had. Didnt check yet.
>
> Katrin, Fridolin, Aleisha, David, Victor: When can we work on this patch set
> this month? Would
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
--- Comment #808 from Marcel de Rooy ---
I rebased what we had. Didnt check yet.
Katrin, Fridolin, Aleisha, David, Victor: When can we work on this patch set
this month? Would be handy to plan our actions now.
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
--- Comment #807 from Marcel de Rooy ---
Created attachment 129319
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129319=edit
Bug 19532: (QA follow-up) Enable XSLT statuses translation
--
You are receiving this
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
Marcel de Rooy changed:
What|Removed |Added
Attachment #126580|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
Marcel de Rooy changed:
What|Removed |Added
Attachment #126579|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
Marcel de Rooy changed:
What|Removed |Added
Attachment #126578|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
Marcel de Rooy changed:
What|Removed |Added
Attachment #126577|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
Marcel de Rooy changed:
What|Removed |Added
Attachment #126576|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
Marcel de Rooy changed:
What|Removed |Added
Attachment #126575|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
Marcel de Rooy changed:
What|Removed |Added
Attachment #126574|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
Marcel de Rooy changed:
What|Removed |Added
Attachment #126573|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
Marcel de Rooy changed:
What|Removed |Added
Attachment #126572|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
Marcel de Rooy changed:
What|Removed |Added
Attachment #126571|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
Marcel de Rooy changed:
What|Removed |Added
Attachment #126570|0 |1
is obsolete|
101 - 200 of 1180 matches
Mail list logo
