https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
--- Comment #815 from Marcel de Rooy ---
(In reply to Aleisha Amohia from comment #814)
> I am talking about the current patchset. My understanding was that as the
> patches currently are, they are too big and daunting to effectively
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
--- Comment #816 from Aleisha Amohia ---
I see. In the email chain we had discussed reformatting but clearly there was
some misunderstanding.
I had started rewriting things before Christmas but it was proving to be very
difficult to
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
--- Comment #817 from Marcel de Rooy ---
(In reply to Aleisha Amohia from comment #816)
> I see. In the email chain we had discussed reformatting but clearly there
> was some misunderstanding.
>
> I had started rewriting things befo
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
--- Comment #818 from Katrin Fischer ---
I understand the difficulties of splitting it up now, so totally ok working
with the rebased patch set. Thx Marcel and Aleisha for clearing things up!
--
You are receiving this mail because:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
Eric Phetteplace changed:
What|Removed |Added
CC||ephettepl...@cca.edu
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
Owen Leonard changed:
What|Removed |Added
Keywords|rel_22_05_candidate |
--
You are receiving this
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
Tomás Cohen Arazi changed:
What|Removed |Added
Blocks||30823
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
Tomás Cohen Arazi changed:
What|Removed |Added
Blocks||30876
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
--- Comment #925 from Jonathan Druart ---
Two critical bugs found in the last day: bug 30876 and bug 30885.
They make the feature unusable. Please provide a patch for bug 30885.
--
You are receiving this mail because:
You are watch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
Jonathan Druart changed:
What|Removed |Added
Blocks||30886
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
Jonathan Druart changed:
What|Removed |Added
Blocks||30885
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
Katrin Fischer changed:
What|Removed |Added
Blocks||30905
Referenced Bugs:
h
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
Katrin Fischer changed:
What|Removed |Added
Blocks||30907
Referenced Bugs:
h
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
Aleisha Amohia changed:
What|Removed |Added
Blocks|30905 |
Referenced Bugs:
https:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
Katrin Fischer changed:
What|Removed |Added
Blocks|30292 |
Referenced Bugs:
https:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
Martin Renvoize changed:
What|Removed |Added
Resolution|FIXED |---
Status|RE
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
Arthur Suzuki changed:
What|Removed |Added
Blocks||30788
Referenced Bugs:
ht
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
David Nind changed:
What|Removed |Added
Documentation||David Nind
contact|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
Tomás Cohen Arazi changed:
What|Removed |Added
Blocks||31368
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
Tomás Cohen Arazi changed:
What|Removed |Added
Blocks||31369
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
Katrin Fischer changed:
What|Removed |Added
Blocks|31368 |
Referenced Bugs:
https:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
Katrin Fischer changed:
What|Removed |Added
Blocks|31369 |
Referenced Bugs:
https:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
Aleisha Amohia changed:
What|Removed |Added
Blocks||31391
Referenced Bugs:
h
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
Aleisha Amohia changed:
What|Removed |Added
Blocks||31415
Referenced Bugs:
h
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
Aleisha Amohia changed:
What|Removed |Added
Blocks|31415 |
Referenced Bugs:
https:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
--- Comment #930 from Jonathan Druart ---
Regarding circulation rules: "Holds allowed (total)" vs "Recalls allowed
(total)"
For holds an empty value means unlimited, for recalls it is "not allowed".
Is that expected to have two dif
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
--- Comment #931 from Katrin Fischer ---
(In reply to Jonathan Druart from comment #930)
> Regarding circulation rules: "Holds allowed (total)" vs "Recalls allowed
> (total)"
>
> For holds an empty value means unlimited, for recalls
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
Aleisha Amohia changed:
What|Removed |Added
Blocks||35967
Referenced Bugs:
h
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
Aleisha Amohia changed:
What|Removed |Added
Blocks||36075
Referenced Bugs:
h
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
Aleisha Amohia changed:
What|Removed |Added
Blocks|36075 |
Referenced Bugs:
https:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
Pedro Amorim changed:
What|Removed |Added
Blocks||36142
Referenced Bugs:
htt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
Aleisha Amohia changed:
What|Removed |Added
Blocks||36209
Referenced Bugs:
h
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
Aleisha Amohia changed:
What|Removed |Added
Blocks||36210
Referenced Bugs:
h
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
Aleisha Amohia changed:
What|Removed |Added
Blocks||33399
Referenced Bugs:
h
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
Aleisha Amohia changed:
What|Removed |Added
Blocks||34016
Referenced Bugs:
h
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
Aleisha Amohia changed:
What|Removed |Added
Blocks||31147
Referenced Bugs:
h
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
Aleisha Amohia changed:
What|Removed |Added
Blocks||34722
Referenced Bugs:
h
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
--- Comment #928 from Jonathan Druart ---
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-course-details.tt
-[% INCLUDE 'item-status.inc'
item=cr.item issue=cr.issue %]
+
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
Jonathan Druart changed:
What|Removed |Added
Blocks||32445
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
--- Comment #929 from Aleisha Amohia ---
(In reply to Jonathan Druart from comment #928)
> koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-course-details.tt
>
> -[% INCLUDE 'item-status.inc'
> i
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
Aleisha Amohia changed:
What|Removed |Added
Blocks||32967
Referenced Bugs:
h
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
Aleisha Amohia changed:
What|Removed |Added
Blocks||33220
Referenced Bugs:
h
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
--- Comment #926 from Jonathan Druart ---
From misc/cronjobs/recalls/expire_recalls.pl and
misc/cronjobs/recalls/overdue_recalls.pl:
+BEGIN {
+# find Koha's Perl modules
+# test carefully before changing this
+use FindBi
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
Aleisha Amohia changed:
What|Removed |Added
Blocks||32129
Referenced Bugs:
h
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
--- Comment #927 from Katrin Fischer ---
(In reply to Jonathan Druart from comment #926)
> From misc/cronjobs/recalls/expire_recalls.pl and
> misc/cronjobs/recalls/overdue_recalls.pl:
>
> +BEGIN {
> +# find Koha's Perl modules
>
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
Jonathan Druart changed:
What|Removed |Added
Blocks||32268
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
Aleisha Amohia changed:
What|Removed |Added
Status|ASSIGNED|Needs Signoff
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
Aleisha Amohia changed:
What|Removed |Added
Attachment #129305|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
Aleisha Amohia changed:
What|Removed |Added
Attachment #129306|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
Aleisha Amohia changed:
What|Removed |Added
Attachment #129307|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
Aleisha Amohia changed:
What|Removed |Added
Attachment #129308|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
Aleisha Amohia changed:
What|Removed |Added
Attachment #129309|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
Aleisha Amohia changed:
What|Removed |Added
Attachment #129310|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
Aleisha Amohia changed:
What|Removed |Added
Attachment #129311|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
Aleisha Amohia changed:
What|Removed |Added
Attachment #129312|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
Aleisha Amohia changed:
What|Removed |Added
Attachment #129313|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
Aleisha Amohia changed:
What|Removed |Added
Attachment #129314|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
Aleisha Amohia changed:
What|Removed |Added
Attachment #129315|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
Aleisha Amohia changed:
What|Removed |Added
Attachment #129316|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
Aleisha Amohia changed:
What|Removed |Added
Attachment #129317|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
Aleisha Amohia changed:
What|Removed |Added
Attachment #129318|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
Aleisha Amohia changed:
What|Removed |Added
Attachment #129319|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
--- Comment #834 from Aleisha Amohia ---
Created attachment 130656
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130656&action=edit
Bug 19532: (follow-up) Fixes along recall workflow
--
You are receiving this ma
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
--- Comment #835 from Marcel de Rooy ---
Still applied on current master (more or less: minor conflicts)
commit 4cc3c0a760df4ddd96cd7bdadc4a766343f0a103
Will be spending some time on it now and next week, and hoping that the other
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
--- Comment #836 from Marcel de Rooy ---
Some intermediate observations. Will continue next week.
TODO FAIL t/db_dependent/Circulation/CalcFine.t
* The method Koha::Recalls->item_level_recall is not covered by tests!
=> Error in sub
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
--- Comment #837 from Marcel de Rooy ---
QA tools is quite happy, here are two items:
TODO koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-recalls.tt
* forbidden pattern: Don't use the title-string class for sorting (bug 27934)
(line
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
--- Comment #838 from Marcel de Rooy ---
Created attachment 131108
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131108&action=edit
Bug 19532: (QA follow-up) Fixing unit tests
(Trivial:) Number of tests in Koha/I
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
Aleisha Amohia changed:
What|Removed |Added
Attachment #130654|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
Aleisha Amohia changed:
What|Removed |Added
Attachment #130655|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
Aleisha Amohia changed:
What|Removed |Added
Attachment #130656|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
Aleisha Amohia changed:
What|Removed |Added
Attachment #131108|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
--- Comment #843 from Aleisha Amohia ---
Created attachment 131160
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131160&action=edit
Bug 19532: (follow-up) Fix for wantarray change and title-string
--
You are rec
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
--- Comment #844 from Aleisha Amohia ---
(In reply to Marcel de Rooy from comment #835)
> Still applied on current master (more or less: minor conflicts)
> commit 4cc3c0a760df4ddd96cd7bdadc4a766343f0a103
>
> Will be spending some t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
--- Comment #845 from Marcel de Rooy ---
(In reply to Aleisha Amohia from comment #844)
> (In reply to Marcel de Rooy from comment #835)
> > Still applied on current master (more or less: minor conflicts)
> > commit 4cc3c0a760df4ddd9
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
--- Comment #846 from Marcel de Rooy ---
Created attachment 131193
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131193&action=edit
Bug 19532: (QA follow-up) Fix few Koha::Recalls->search occurrences
Due to the w
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
--- Comment #847 from Marcel de Rooy ---
Saw this warning in QA tools:
FAIL koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-recalls.tt
FAIL valid_template
Attempt to reload Koha/Template/Plugin/KohaPlugins.pm a
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
--- Comment #848 from Marcel de Rooy ---
From code glancing:
Unfinished business?
+} elsif ( $code eq 'RecallFound' ) {
+;
+} elsif ( $code eq 'RecallNeedsTransfer' ) {
+;
+} elsif ( $code eq 'Transferred
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
--- Comment #849 from Aleisha Amohia ---
Created attachment 131213
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131213&action=edit
Bug 19532: (follow-up) Removing unnecessary code
--
You are receiving this mail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
--- Comment #850 from Aleisha Amohia ---
Cool I will ignore that warning about KohaPlugins then.
(In reply to Marcel de Rooy from comment #848)
> From code glancing:
> Unfinished business?
>
> +} elsif ( $code eq 'RecallFound'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
--- Comment #851 from Marcel de Rooy ---
(In reply to Aleisha Amohia from comment #850)
> Not unfinished business, I was just copying the similar code above, but I
> have removed in latest follow-up.
Are you really really sure abou
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
Marcel de Rooy changed:
What|Removed |Added
Attachment #131213|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
--- Comment #852 from Marcel de Rooy ---
(In reply to Marcel de Rooy from comment #851)
> In conclusion: We dont wanna die here, but as for ReturnClaims we could send
> a code to the template allowing to return something meaningful
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
--- Comment #853 from Marcel de Rooy ---
FAIL C4/Circulation.pm
FAIL pod coverage
POD is missing for AddOfflineOperation
POD is missing for CheckValidBarcode
POD is missing for
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
--- Comment #854 from Marcel de Rooy ---
Same remark for:
FAIL C4/Overdues.pm
FAIL pod coverage
POD is missing for 'GetWdayFromItemnumber'
and
FAIL C4/XSLT.pm
FAIL pod coverage
POD i
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
--- Comment #855 from Marcel de Rooy ---
I remember to have posted this before, but these lines show me that Recalls
does not support itemtype notforloan:
+ return 0 if ( $self->notforloan != 0 );
OR +my @items = Koha::Items->se
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
--- Comment #856 from Marcel de Rooy ---
Created attachment 131257
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131257&action=edit
Bug 19532: (QA follow-up) Fix fine calculation by inserting biblionumber
The fin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
--- Comment #857 from Marcel de Rooy ---
(In reply to Marcel de Rooy from comment #856)
> Created attachment 131257 [details] [review]
> Bug 19532: (QA follow-up) Fix fine calculation by inserting biblionumber
>
> The fines cron job
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
--- Comment #858 from Marcel de Rooy ---
TODO We need to add two new cronjobs to the cron files (debian side and example
file somewhere in etc folder)
misc/cronjobs/recalls/expire_recalls.pl
misc/cronjobs/recalls/overdue_recalls.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
--- Comment #859 from Marcel de Rooy ---
Created attachment 131260
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131260&action=edit
Bug 19532: (QA follow-up) Move as_list to iterator based loop
Adjusting both new
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
Marcel de Rooy changed:
What|Removed |Added
Attachment #130641|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
--- Comment #861 from Marcel de Rooy ---
Created attachment 131262
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131262&action=edit
Bug 19532: [DBIx] Updated schema files
Signed-off-by: David Nind
Signed-off-by
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
--- Comment #862 from Marcel de Rooy ---
Created attachment 131263
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131263&action=edit
Bug 19532: [DBIx] Add boolean flags to recalls.old and
recalls.item_level_recall
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
--- Comment #863 from Marcel de Rooy ---
Created attachment 131264
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131264&action=edit
Bug 19532: [DBIx] Schema change for Recalls
Separated from the "Recalls-objects-
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
Marcel de Rooy changed:
What|Removed |Added
Attachment #130644|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
Marcel de Rooy changed:
What|Removed |Added
Attachment #130645|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
Marcel de Rooy changed:
What|Removed |Added
Attachment #130646|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
Marcel de Rooy changed:
What|Removed |Added
Attachment #130647|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
Marcel de Rooy changed:
What|Removed |Added
Attachment #130648|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
Marcel de Rooy changed:
What|Removed |Added
Attachment #130649|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
Marcel de Rooy changed:
What|Removed |Added
Attachment #130650|0 |1
is obsolete|
1001 - 1100 of 1182 matches
Mail list logo
