[Koha-bugs] [Bug 19564] Fix extraction of sort order from sort condition name

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19564 Fridolin SOMERS changed: What|Removed |Added Resolution|--- |FIXED CC|

[Koha-bugs] [Bug 19564] Fix extraction of sort order from sort condition name

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19564 Nick Clemens changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable --- Comment

[Koha-bugs] [Bug 19564] Fix extraction of sort order from sort condition name

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19564 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comm

[Koha-bugs] [Bug 19564] Fix extraction of sort order from sort condition name

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19564 --- Comment #15 from Nick Clemens --- Created attachment 73386 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73386&action=edit Bug 19564: Add tests for _convert_sort_fields Signed-off-by: Nicolas Legrand Signed

[Koha-bugs] [Bug 19564] Fix extraction of sort order from sort condition name

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19564 --- Comment #16 from Nick Clemens --- Created attachment 73387 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73387&action=edit Bug 19564: (QA follow-up) Make commented out tests pass We likely shoudln't pass thro

[Koha-bugs] [Bug 19564] Fix extraction of sort order from sort condition name

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19564 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiv

[Koha-bugs] [Bug 19564] Fix extraction of sort order from sort condition name

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19564 Nick Clemens changed: What|Removed |Added Attachment #73022|0 |1 is obsolete|

[Koha-bugs] [Bug 19564] Fix extraction of sort order from sort condition name

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19564 Nicolas Legrand changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are re

[Koha-bugs] [Bug 19564] Fix extraction of sort order from sort condition name

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19564 Nicolas Legrand changed: What|Removed |Added Attachment #70137|0 |1 is obsolete|

[Koha-bugs] [Bug 19564] Fix extraction of sort order from sort condition name

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19564 Nicolas Legrand changed: What|Removed |Added Attachment #68998|0 |1 is obsolete|

[Koha-bugs] [Bug 19564] Fix extraction of sort order from sort condition name

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19564 David Gustafsson changed: What|Removed |Added Status|Signed Off |Needs Signoff -- You ar

[Koha-bugs] [Bug 19564] Fix extraction of sort order from sort condition name

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19564 David Gustafsson changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #

[Koha-bugs] [Bug 19564] Fix extraction of sort order from sort condition name

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19564 --- Comment #10 from David Gustafsson --- :) Thanks for the tests! Will apply and test this tomorrow. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bu

[Koha-bugs] [Bug 19564] Fix extraction of sort order from sort condition name

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19564 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-

[Koha-bugs] [Bug 19564] Fix extraction of sort order from sort condition name

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19564 Jonathan Druart changed: What|Removed |Added Status|NEW |Needs Signoff -- You are

[Koha-bugs] [Bug 19564] Fix extraction of sort order from sort condition name

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19564 --- Comment #8 from Jonathan Druart --- Created attachment 70137 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70137&action=edit Bug 19564: Add tests for _convert_sort_fields -- You are receiving this mail beca

[Koha-bugs] [Bug 19564] Fix extraction of sort order from sort condition name

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19564 --- Comment #7 from Nick Clemens --- (In reply to Nick Clemens from comment #5) > This works, I mean we need a callnum index, but it changes form not having a > sort to having a sort on an undefined index :-) let me know what other b

[Koha-bugs] [Bug 19564] Fix extraction of sort order from sort condition name

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19564 --- Comment #6 from David Gustafsson --- Yes, although I think it's a good idea to fix the code even though it does not solve the issue with the current code base, I think that sorting should work with this fix together with https://

[Koha-bugs] [Bug 19564] Fix extraction of sort order from sort condition name

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19564 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com --

[Koha-bugs] [Bug 19564] Fix extraction of sort order from sort condition name

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19564 David Gustafsson changed: What|Removed |Added Attachment #68892|0 |1 is obsolete|

[Koha-bugs] [Bug 19564] Fix extraction of sort order from sort condition name

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19564 --- Comment #3 from David Gustafsson --- Replaced the wrong line in previous patch, will fix. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs maili

[Koha-bugs] [Bug 19564] Fix extraction of sort order from sort condition name

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19564 --- Comment #2 from David Gustafsson --- I did not add a test-case since sorting does currently work anyway because of other unrelated bugs (which I can link to once having created issues and submitted fixes f). But this Perl code ca

[Koha-bugs] [Bug 19564] Fix extraction of sort order from sort condition name

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19564 --- Comment #1 from David Gustafsson --- Created attachment 68892 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68892&action=edit Bug 19564: Fix extraction of sort order from sort condition name Currently sort or

[Koha-bugs] [Bug 19564] Fix extraction of sort order from sort condition name

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19564 David Gustafsson changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |glask...@gmail.com