https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575
--- Comment #67 from Nick Clemens ---
Created attachment 85030
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85030&action=edit
Bug 19575: Rebase and fix tests
This patch lower cases the sort by fields to normaliz
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575
Nick Clemens changed:
What|Removed |Added
Attachment #83710|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575
Nick Clemens changed:
What|Removed |Added
Status|Failed QA |Signed Off
--
You are recei
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575
--- Comment #68 from Nick Clemens ---
Rebased and updated, I think in spirit of original set - set to Signed off,
would like another QA run and Ere's okay
--
You are receiving this mail because:
You are watching all bug changes.
__
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575
--- Comment #69 from Nick Clemens ---
Extra note: I found that indexes like 'se' and 'an' were not searchable - no
results were returned from faceting or searchign like "se:pengiun" changing to
title-series (or even 'ser' in testing)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575
--- Comment #70 from Katrin Fischer ---
(In reply to Nick Clemens from comment #69)
> Extra note: I found that indexes like 'se' and 'an' were not searchable - no
> results were returned from faceting or searchign like "se:pengiun" c
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575
--- Comment #71 from David Gustafsson ---
(In reply to Nick Clemens from comment #67)
> Created attachment 85030 [details] [review]
> Bug 19575: Rebase and fix tests
>
> This patch lower cases the sort by fields to normalize checkin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575
Nick Clemens changed:
What|Removed |Added
Attachment #85030|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575
--- Comment #73 from Nick Clemens ---
(In reply to Katrin Fischer from comment #70)
> (In reply to Nick Clemens from comment #69)
> > Extra note: I found that indexes like 'se' and 'an' were not searchable - no
> > results were retur
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575
--- Comment #74 from Nick Clemens ---
(In reply to David Gustafsson from comment #71)
> (In reply to Nick Clemens from comment #67)
> > Created attachment 85030 [details] [review] [review]
> > Bug 19575: Rebase and fix tests
> >
> >
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575
--- Comment #75 from David Gustafsson ---
(In reply to Nick Clemens from comment #69)
> Extra note: I found that indexes like 'se' and 'an' were not searchable - no
> results were returned from faceting or searchign like "se:pengiun"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575
--- Comment #76 from David Gustafsson ---
Oops, bug 22325 I mean, perhaps you linked to the wrong bug number in the
previous comment?
--
You are receiving this mail because:
You are watching all bug changes.
___
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575
--- Comment #77 from David Gustafsson ---
Could the cause be that the value of an: is unquoted in clause where
UseAuthoritiesForTracings is set in the excerpt below
(koha-tmpl/intranet-tmpl/prog/en/xslt/NORMARCslim2intranetResults.xs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575
--- Comment #78 from David Gustafsson ---
(And in many other places). Should perhaps not matter though if "an" never
contains whitespace.
--
You are receiving this mail because:
You are watching all bug changes.
___
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575
--- Comment #79 from Nick Clemens ---
Created attachment 85105
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85105&action=edit
Bug 19575: Fix an search field
--
You are receiving this mail because:
You are watch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575
--- Comment #80 from Nick Clemens ---
(In reply to David Gustafsson from comment #75)
> (In reply to Nick Clemens from comment #69)
> > Extra note: I found that indexes like 'se' and 'an' were not searchable - no
> > results were ret
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575
--- Comment #81 from David Gustafsson ---
Created attachment 85124
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85124&action=edit
Bug 19575: Keep authority-number as alias and fix query
Keep authority-number as
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575
--- Comment #82 from David Gustafsson ---
Ok! Since it was some time ago I don't really remember how to parse the Zebra
field definitions anymore, but the authority-number entry looked a little bit
strange and I might have made some
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575
Martin Renvoize changed:
What|Removed |Added
Attachment #85029|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575
Martin Renvoize changed:
What|Removed |Added
Attachment #85062|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575
Martin Renvoize changed:
What|Removed |Added
Attachment #85124|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575
Martin Renvoize changed:
What|Removed |Added
Status|Signed Off |Passed QA
--
You are rec
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575
Martin Renvoize changed:
What|Removed |Added
Attachment #85105|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575
--- Comment #87 from Nick Clemens ---
*** Bug 9 has been marked as a duplicate of this bug. ***
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575
David Gustafsson changed:
What|Removed |Added
Attachment #69507|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575
--- Comment #32 from David Gustafsson ---
Case insensitive field names in searches is now fixed. A few changes I made
could use some extra motivation/explanation:
# sub _convert_index_strings_freeform() (line 685):
changed from:
sub
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575
David Gustafsson changed:
What|Removed |Added
Attachment #70494|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575
--- Comment #34 from David Gustafsson ---
Found some more places where hard coded fields needed to be changed to
lower-case.
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575
--- Comment #35 from David Gustafsson ---
Here is a github-diff that might be easier on the eyes:
https://github.com/ub-digit/Koha/commit/8be850d2cdc93e5d121afa19c5eed1e1cc683f1c
--
You are receiving this mail because:
You are watc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575
David Gustafsson changed:
What|Removed |Added
Attachment #70495|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575
--- Comment #37 from David Gustafsson ---
Found one (hopefully) last place that needed case-adjustment. New diff:
https://github.com/ub-digit/Koha/commit/a6fda51b59c65c2459d460fd374377b56b5f10cc
--
You are receiving this mail becau
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575
David Gustafsson changed:
What|Removed |Added
Attachment #70558|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575
--- Comment #39 from David Gustafsson ---
Found one more hard coded field value in authorities search that needed
lower-casing.
--
You are receiving this mail because:
You are watching all bug changes.
_
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575
David Gustafsson changed:
What|Removed |Added
Attachment #71090|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575
--- Comment #41 from David Gustafsson ---
Fixed hard coded field name in Koha/SearchEngine/ElasticSearch/Search.pm ('au'
to 'authority-number')
--
You are receiving this mail because:
You are watching all bug changes.
_
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575
--- Comment #42 from David Gustafsson ---
*('an' to 'authority-number')
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575
David Gustafsson changed:
What|Removed |Added
Attachment #71112|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575
--- Comment #44 from David Gustafsson ---
Removed incorrect alias/field name conversions (ctype => "content-type"), and
some aliases with identical source and target values.
--
You are receiving this mail because:
You are watching
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575
Nick Clemens changed:
What|Removed |Added
Attachment #71966|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575
Nick Clemens changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--
You are recei
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575
Jonathan Druart changed:
What|Removed |Added
Summary|ES: Use canonical field |Use canonical field names
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575
--- Comment #47 from David Gustafsson ---
Rebased against master.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575
David Gustafsson changed:
What|Removed |Added
Attachment #72673|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575
Julian Maurice changed:
What|Removed |Added
CC||julian.maur...@biblibre.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575
--- Comment #1 from David Gustafsson ---
Created attachment 68914
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68914&action=edit
Bug 19575: Use canonical field names and resolve aliased fields
Adjust elastic sea
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575
--- Comment #2 from David Gustafsson ---
The following issue should be resolved with this patch applied:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19485
But in addition to title-series, most of the other broken sear
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575
--- Comment #3 from David Gustafsson ---
Think I have missed a few places (facets for example) where field names are
hard coded and needs to be changes. So no point in trying out patch in it's
current state until these things are fix
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575
David Gustafsson changed:
What|Removed |Added
Attachment #68914|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575
David Gustafsson changed:
What|Removed |Added
Attachment #69140|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575
--- Comment #6 from David Gustafsson ---
Now most (hopefully all) issues (primarily with facets) should be sorted out.
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575
David Gustafsson changed:
What|Removed |Added
Assignee|koha-b...@lists.koha-commun |glask...@gmail.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575
--- Comment #7 from David Gustafsson ---
Think I have been looking at the Zebra-mapping configuration in the wrong place
(this old config, not biblio-koha-indexdefs.xml). I will go through the mapping
changes one more time using this
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575
David Bourgault changed:
What|Removed |Added
CC||david.bourga...@inlibro.co
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575
David Gustafsson changed:
What|Removed |Added
Attachment #69153|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575
--- Comment #10 from David Gustafsson ---
Wrote a script to extract mappings from biblio-koha-indexdefs.xml and convert
to mappings.yaml, left the fields with existing mapping-targets as they are
(even though discovered several discr
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575
David Gustafsson changed:
What|Removed |Added
Attachment #69306|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575
Jonathan Druart changed:
What|Removed |Added
CC||jonathan.dru...@bugs.koha-
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575
--- Comment #13 from David Gustafsson ---
Sorry, should have been more clear about that. Yes, this is ready for signoff.
There is still some stuff I left out of this patch, like:
- New mappings for other marc-flavours than marc21 ex
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575
--- Comment #14 from Jonathan Druart
---
(In reply to David Gustafsson from comment #13)
> But if this get reviewed and committed I can open new bug-reports for those
> once I have time to further polish the extraction-script.
Can
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575
--- Comment #15 from David Gustafsson ---
Yes, I was thinking to do so, though it is only a quick and dirty script in
Ruby (should perhaps be re-written in perl if to be included in Koha-repo), and
though would clean it up just a lit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575
--- Comment #16 from David Gustafsson ---
https://github.com/ub-digit/koha-indexdefs-to-mappings-yaml
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bu
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575
David Bourgault changed:
What|Removed |Added
Status|NEW |Needs Signoff
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575
David Bourgault changed:
What|Removed |Added
Status|Needs Signoff |Patch doesn't apply
--- C
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575
David Gustafsson changed:
What|Removed |Added
Attachment #69314|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575
--- Comment #19 from David Gustafsson ---
Ok! Rebased against master. There was a commit in between setting the "sort"
for serveral fields, those changes should now be merged in.
--
You are receiving this mail because:
You are watc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575
--- Comment #20 from David Gustafsson ---
Reviewing the commit-diff once again, I think I made an error in the merge.
Will upload again.
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575
David Gustafsson changed:
What|Removed |Added
Attachment #69479|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575
--- Comment #22 from David Gustafsson ---
Think git auto-merged some stuff incorrectly, but this should now be sorted
out.
--
You are receiving this mail because:
You are watching all bug changes.
__
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575
David Gustafsson changed:
What|Removed |Added
Attachment #69480|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575
--- Comment #24 from David Gustafsson ---
Field name 'Date/time-last-modified' does not work with elastic since "/" will
create subfields, koha will also not tokanize this correctly, changed this
(back) to 'Date-time-last-modified'.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575
--- Comment #25 from Jonathan Druart
---
(In reply to David Gustafsson from comment #22)
> Think git auto-merged some stuff incorrectly, but this should now be sorted
> out.
So, ready to be signed off?
--
You are receiving this m
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575
--- Comment #26 from David Gustafsson ---
Yes should be ready for sign off, have discovered no more issues since the most
recent patch.
--
You are receiving this mail because:
You are watching all bug changes.
_
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575
--- Comment #27 from Jonathan Druart
---
(In reply to David Gustafsson from comment #26)
> Yes should be ready for sign off, have discovered no more issues since the
> most recent patch.
The good way to tell other people that your
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575
--- Comment #28 from David Gustafsson ---
Aha, I looked for a status drop down but manage to miss it since it wasn't a
drop down. :) Will fix.
--
You are receiving this mail because:
You are watching all bug changes.
__
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575
David Gustafsson changed:
What|Removed |Added
Status|Patch doesn't apply |Needs Signoff
--
You ar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575
--- Comment #29 from David Gustafsson ---
And, now I saw there was a dropdown, but below the comment area.
--
You are receiving this mail because:
You are watching all bug changes.
___
Ko
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575
--- Comment #30 from David Gustafsson ---
Just a caveat, just discovered that some field names hard coded in
xsl-templates have names that differer in case from mappings.yaml.
(control-number for example). Zebra has case-insensitive
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575
--- Comment #49 from David Gustafsson ---
Will fix this. Test plan is a litte bit tricky since this corrects a lot of
small stuff. But will try to backtrack to list most of what is fixed.
--
You are receiving this mail because:
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575
David Gustafsson changed:
What|Removed |Added
Attachment #75115|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575
David Gustafsson changed:
What|Removed |Added
Attachment #81297|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575
David Gustafsson changed:
What|Removed |Added
Attachment #81299|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575
David Gustafsson changed:
What|Removed |Added
Attachment #81303|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575
Katrin Fischer changed:
What|Removed |Added
CC||katrin.fisc...@bsz-bw.de
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575
--- Comment #56 from David Gustafsson ---
Rebase against master.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575
David Gustafsson changed:
What|Removed |Added
Attachment #81304|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575
Martin Renvoize changed:
What|Removed |Added
CC||martin.renvoize@ptfs-europ
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575
Martin Renvoize changed:
What|Removed |Added
CC||ere.maij...@helsinki.fi
-
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575
Ere Maijala changed:
What|Removed |Added
Attachment #82794|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575
--- Comment #59 from Ere Maijala ---
Awesome, thanks David. This was actually on my list of things to work on when
time permits, and it had been bugging me.
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575
Ere Maijala changed:
What|Removed |Added
CC||frank.han...@ub.lu.se
--- Com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575
Martin Renvoize changed:
What|Removed |Added
Attachment #83704|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575
Martin Renvoize changed:
What|Removed |Added
Status|Signed Off |Passed QA
--- Comment #62
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575
Martin Renvoize changed:
What|Removed |Added
QA Contact||ere.maij...@helsinki.fi
-
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575
Nick Clemens changed:
What|Removed |Added
Status|Passed QA |Failed QA
--- Comment #63 fr
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575
--- Comment #64 from Ere Maijala ---
David, will you be able to address the test issues?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing li
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575
Katrin Fischer changed:
What|Removed |Added
See Also||https://bugs.koha-community
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575
--- Comment #65 from David Gustafsson ---
Unfortunately I have have been a little bit too busy lately to have a look at
this, but hope will have the time to do so some time next week.
--
You are receiving this mail because:
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575
--- Comment #88 from Nick Clemens ---
Created attachment 85178
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85178&action=edit
Bug 19575: (RM follow-up) Fix mapping typo
Found with QA tools, simple fix
--
You a
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575
--- Comment #89 from Nick Clemens ---
I looked at this today, but the update statement is a little confusing.
Should we update a library's mappings in updates? or simply require that they
reset mappings when upgrading?
I am okay wi
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575
--- Comment #90 from David Gustafsson ---
Yes, the lowercase update statement is pretty pointless since the mixed case
field names will be restored on reset. Field names are lower-cased in
_foreach_mapping, so the case of field names
1 - 100 of 121 matches
Mail list logo
