https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985
--- Comment #69 from M. Tompsett ---
Created attachment 74761
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74761&action=edit
Bug 1985: Send email alert when comment posted.
In comment #11, it was mentioned that t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985
M. Tompsett changed:
What|Removed |Added
Attachment #63761|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985
M. Tompsett changed:
What|Removed |Added
Attachment #63763|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985
M. Tompsett changed:
What|Removed |Added
Attachment #63762|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985
M. Tompsett changed:
What|Removed |Added
Attachment #74761|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985
M. Tompsett changed:
What|Removed |Added
Attachment #74762|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985
M. Tompsett changed:
What|Removed |Added
Status|Patch doesn't apply |Needs Signoff
--
You are rece
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985
M. Tompsett changed:
What|Removed |Added
Status|Needs Signoff |ASSIGNED
--
You are receiving
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985
M. Tompsett changed:
What|Removed |Added
Attachment #74764|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985
M. Tompsett changed:
What|Removed |Added
Attachment #74763|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985
M. Tompsett changed:
What|Removed |Added
Attachment #74760|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985
M. Tompsett changed:
What|Removed |Added
Status|ASSIGNED|Needs Signoff
--- Comment #76
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985
Olli-Antti Kivilahti changed:
What|Removed |Added
Assignee|olli-antti.kivila...@jns.fi |oleon...@myacpl.org
-
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985
M. Tompsett changed:
What|Removed |Added
Assignee|oleon...@myacpl.org |mtomp...@hotmail.com
--- Comme
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985
--- Comment #49 from M. Tompsett ---
Created attachment 63746
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63746&action=edit
Bug 1985: Fix whitespace in opac/opac-review.pl
$ git diff -w origin/master
-- should h
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985
M. Tompsett changed:
What|Removed |Added
Attachment #38908|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985
--- Comment #52 from M. Tompsett ---
Created attachment 63749
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63749&action=edit
Bug 1985: perlcritic
After the patch is applied:
Code is not tidy at line 1, column 1.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985
--- Comment #53 from M. Tompsett ---
Created attachment 63750
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63750&action=edit
Bug 1985: perltidy opac/opac-review.pl
--
You are receiving this mail because:
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985
M. Tompsett changed:
What|Removed |Added
Attachment #39062|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985
--- Comment #55 from M. Tompsett ---
Created attachment 63752
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63752&action=edit
Bug 1985: perltidy Koha/Review.pm
--
You are receiving this mail because:
You are watc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985
--- Comment #54 from M. Tompsett ---
Created attachment 63751
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63751&action=edit
Bug 1985: perlcritic
--
You are receiving this mail because:
You are watching all bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985
M. Tompsett changed:
What|Removed |Added
Status|Patch doesn't apply |Needs Signoff
--- Comment #56
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985
--- Comment #57 from M. Tompsett ---
(In reply to M. Tompsett from comment #56)
> If you apply everything and run the test plans in comment #50 and comment
> #51, then it should suffice.
Generally running perlcritic -1 {file}, and ig
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985
--- Comment #58 from Jonathan Druart
---
(In reply to M. Tompsett from comment #57)
> (In reply to M. Tompsett from comment #56)
> > If you apply everything and run the test plans in comment #50 and comment
> > #51, then it should su
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985
--- Comment #59 from M. Tompsett ---
(In reply to Jonathan Druart from comment #58)
> We are not following perlcritic -1, this patch is out of the scope of this
> bug report.
While you are correct about scope creep for the last 4 pat
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985
M. Tompsett changed:
What|Removed |Added
Attachment #63750|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985
M. Tompsett changed:
What|Removed |Added
Attachment #63749|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985
M. Tompsett changed:
What|Removed |Added
Attachment #63751|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985
M. Tompsett changed:
What|Removed |Added
Attachment #63752|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985
--- Comment #64 from Marc Véron ---
Tested all patches together, followed test plan from comment #50, works as
expected. Will sign off.
--
You are receiving this mail because:
You are watching all bug changes.
__
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985
Marc Véron changed:
What|Removed |Added
Attachment #63746|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985
Marc Véron changed:
What|Removed |Added
Attachment #63747|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985
Marc Véron changed:
What|Removed |Added
Attachment #63748|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985
Marc Véron changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--
You are receivin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985
Niamh changed:
What|Removed |Added
CC||niamh.walker-headon@it-tall
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985
Marcel de Rooy changed:
What|Removed |Added
CC||m.de.r...@rijksmuseum.nl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985
--- Comment #1 from Olli-Antti Kivilahti ---
Created attachment 33916
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33916&action=edit
Bug 1985 - Email notification of new OPAC comments
This feature adds YAS 'Comment
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985
Olli-Antti Kivilahti changed:
What|Removed |Added
CC||olli-antti.kivila...@jn
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985
Olli-Antti Kivilahti changed:
What|Removed |Added
Status|NEW |Needs Signoff
--- Comm
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985
Olli-Antti Kivilahti changed:
What|Removed |Added
Attachment #33916|0 |1
is obsolete|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985
--- Comment #4 from M. Tompsett ---
Comment on attachment 33918
--> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33918
Bug 1985 - Email notification of new OPAC comments
Review of attachment 33918:
-->
(http://bugs.k
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985
M. Tompsett changed:
What|Removed |Added
Status|Needs Signoff |Failed QA
CC|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985
Katrin Fischer changed:
What|Removed |Added
CC||katrin.fisc...@bsz-bw.de
---
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985
Jonathan Druart changed:
What|Removed |Added
Status|Failed QA |Needs Signoff
--
You are r
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985
Jonathan Druart changed:
What|Removed |Added
Attachment #33918|0 |1
is obsolete|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985
Jonathan Druart changed:
What|Removed |Added
CC||jonathan.dru...@biblibre.co
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985
--- Comment #9 from Jonathan Druart ---
The last patch now passes the qa script.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bu
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985
--- Comment #10 from Jonathan Druart ---
Comment on attachment 36065
--> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36065
Bug 1985 - Email notification of new OPAC comments
Review of attachment 36065:
-->
(http://b
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985
Koha Team Lyon 3 changed:
What|Removed |Added
CC||k...@univ-lyon3.fr
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985
--- Comment #12 from M. Tompsett ---
I think that may be a cronjob configuration problem. I'll recheck this.
--
You are receiving this mail because:
You are watching all bug changes.
___
Ko
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985
--- Comment #13 from M. Tompsett ---
Another reason this is currently failed qa. This modifies C4/Review.pm without
adding any tests. Don't worry, the patch I'm working on for this will handle
comment #11 and add tests.
--
You are re
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985
--- Comment #15 from M. Tompsett ---
Created attachment 36517
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36517&action=edit
Bug 1985 - Add missing table variables, tweak License, and cleanup
In comment #11, it was
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985
M. Tompsett changed:
What|Removed |Added
Attachment #36065|0 |1
is obsolete|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985
M. Tompsett changed:
What|Removed |Added
Status|Failed QA |Needs Signoff
--- Comment #16 f
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985
--- Comment #17 from M. Tompsett ---
And by the way, comment 10 is still a valid issue. I figure it might be useful
to include it in the letter in the future, but no code was added to make that
possible.
--
You are receiving this mai
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985
M. Tompsett changed:
What|Removed |Added
Attachment #36516|0 |1
is obsolete|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985
M. Tompsett changed:
What|Removed |Added
Attachment #36517|0 |1
is obsolete|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985
--- Comment #20 from M. Tompsett ---
Ignore comments #10 and #17. My second commit covers all that. :)
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bug
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985
--- Comment #21 from Koha Team Lyon 3 ---
I have just tested it. Everything is fine except that <>
isn't filled in the email :
...
BEGIN COMMENT --- A lire absolument --- END COMMENT --- To approve:
http:///cgi-bin/koha/review/reviews
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985
--- Comment #22 from M. Tompsett ---
(In reply to Koha Team Lyon 3 from comment #21)
> I have just tested it. Everything is fine except that <>
> isn't filled in the email :
> ...
> BEGIN COMMENT --- A lire absolument --- END COMMENT
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985
M. Tompsett changed:
What|Removed |Added
Attachment #36522|0 |1
is obsolete|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985
M. Tompsett changed:
What|Removed |Added
Attachment #36521|0 |1
is obsolete|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985
--- Comment #25 from Koha Team Lyon 3 ---
Yes, you're right :-) I forgot to set the staffClientBaseURL syspref ...
I'll test one more time
--
You are receiving this mail because:
You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985
--- Comment #26 from Koha Team Lyon 3 ---
Tested on a sandbox :
- go to OPAC to add a comment without filling the syspref
CommentModeratorsEmail : nothing is added in message_queue table : OK
- set syspref CommentModeratorsEmail with
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985
--- Comment #27 from M. Tompsett ---
Created attachment 36628
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36628&action=edit
Bug 1985 - Email notification of new OPAC comments
This feature adds YAS 'CommentModerato
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985
M. Tompsett changed:
What|Removed |Added
Attachment #36614|0 |1
is obsolete|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985
sandbo...@biblibre.com changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985
sandbo...@biblibre.com changed:
What|Removed |Added
Attachment #36613|0 |1
is obsolete
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985
sandbo...@biblibre.com changed:
What|Removed |Added
Attachment #36628|0 |1
is obsolete
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985
--- Comment #30 from sandbo...@biblibre.com ---
Created attachment 36643
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36643&action=edit
Bug 13635: Unimarc - On editing a notice, the title should be displayed
The ti
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985
--- Comment #31 from sandbo...@biblibre.com ---
Created attachment 36644
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36644&action=edit
Bug 1985 - Email notification of new OPAC comments
This feature adds YAS 'Comm
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985
sandbo...@biblibre.com changed:
What|Removed |Added
Attachment #36629|0 |1
is obsolete
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985
--- Comment #32 from sandbo...@biblibre.com ---
Created attachment 36645
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36645&action=edit
Bug 1985 - tweak License and lots of cleanup
In comment #11, it was mentioned
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985
--- Comment #33 from Koha Team Lyon 3 ---
I've done again all the tests (until point 6 but I think point 6 and 7 can be
done at the QA step ?)
Everything works correctly
--
You are receiving this mail because:
You are watching all bu
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985
Jonathan Druart changed:
What|Removed |Added
Attachment #36643|0 |1
is obsolete|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985
Kyle M Hall changed:
What|Removed |Added
Status|Signed Off |Passed QA
--
You are receiving
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985
Kyle M Hall changed:
What|Removed |Added
Attachment #36644|0 |1
is obsolete|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985
--- Comment #35 from Kyle M Hall ---
Created attachment 36678
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36678&action=edit
[PASSED-QA] Bug 1985 - tweak License and lots of cleanup
In comment #11, it was mentioned
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985
Kyle M Hall changed:
What|Removed |Added
CC||k...@bywatersolutions.com
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985
M. Tompsett changed:
What|Removed |Added
See Also||http://bugs.koha-community.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985
M. Tompsett changed:
What|Removed |Added
Assignee|olli-antti.kivila...@jns.fi |mtomp...@hotmail.com
--
You ar
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985
--- Comment #38 from M. Tompsett ---
Created attachment 36720
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36720&action=edit
Bug 1985 - Follow up: Add sample letter to other languages
As per comment #36, the letter
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985
M. Tompsett changed:
What|Removed |Added
Status|Failed QA |Needs Signoff
--
You are recei
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985
M. Tompsett changed:
What|Removed |Added
Status|Failed QA |Patch doesn't apply
--
You are
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985
Marc Véron changed:
What|Removed |Added
CC||ve...@veron.ch
--
You are recei
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985
M. Tompsett changed:
What|Removed |Added
Attachment #36677|0 |1
is obsolete|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985
M. Tompsett changed:
What|Removed |Added
Attachment #36678|0 |1
is obsolete|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985
M. Tompsett changed:
What|Removed |Added
Attachment #36720|0 |1
is obsolete|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985
--- Comment #42 from M. Tompsett ---
This is a rebase. The last patch (Follow up: Add sample letter to other
languages) is what addresses Kyle's comment #36. The first two patches have
passed QA, the last one needs sign off.
prove xt/
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985
Bernardo Gonzalez Kriegel changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--
Yo
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985
Bernardo Gonzalez Kriegel changed:
What|Removed |Added
Attachment #38910|0 |1
is obsol
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985
--- Comment #44 from Jonathan Druart ---
Comment on attachment 38909
--> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38909
Bug 1985 - tweak License and lots of cleanup
Review of attachment 38909:
-->
(http://bugs.ko
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985
--- Comment #45 from Jonathan Druart ---
Comment on attachment 38908
--> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38908
Bug 1985 - Email notification of new OPAC comments
Review of attachment 38908:
-->
(http://b
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985
M. Tompsett changed:
What|Removed |Added
Assignee|mtomp...@hotmail.com|olli-antti.kivila...@jns.fi
---
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985
Jonathan Druart changed:
What|Removed |Added
Status|Signed Off |Failed QA
--
You are recei
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985
joe <15379...@gmail.com> changed:
What|Removed |Added
CC||15379...@gmail.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985
Liz Rea changed:
What|Removed |Added
CC||wizzy...@gmail.com
Sta
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985
M. Tompsett changed:
What|Removed |Added
Status|Patch doesn't apply |Needs Signoff
--
You are rece
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985
--- Comment #79 from M. Tompsett ---
Created attachment 91191
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91191&action=edit
Bug 1985: Send email alert when comment posted.
Many blog systems have a feature where
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985
M. Tompsett changed:
What|Removed |Added
Attachment #74769|0 |1
is obsolete|
1 - 100 of 119 matches
Mail list logo
